<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110731</bug_id>
          
          <creation_ts>2013-02-25 00:50:35 -0800</creation_ts>
          <short_desc>Make ninja the default build system for build-webkit --chromium on windows</short_desc>
          <delta_ts>2013-02-25 19:06:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>110758</dependson>
          <blocked>104434</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nico Weber">thakis</reporter>
          <assigned_to name="Nico Weber">thakis</assigned_to>
          <cc>dpranke</cc>
    
    <cc>jochen</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>840774</commentid>
    <comment_count>0</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-02-25 00:50:35 -0800</bug_when>
    <thetext>Make ninja the default build system for build-webkit --chromium on windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840776</commentid>
    <comment_count>1</comment_count>
      <attachid>190014</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-02-25 00:51:32 -0800</bug_when>
    <thetext>Created attachment 190014
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840778</commentid>
    <comment_count>2</comment_count>
      <attachid>190014</attachid>
    <who name="">jochen</who>
    <bug_when>2013-02-25 00:53:42 -0800</bug_when>
    <thetext>Comment on attachment 190014
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840794</commentid>
    <comment_count>3</comment_count>
      <attachid>190014</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-02-25 01:34:25 -0800</bug_when>
    <thetext>Comment on attachment 190014
Patch

Thanks! Let&apos;s see what breaks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840805</commentid>
    <comment_count>4</comment_count>
      <attachid>190014</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-25 01:50:35 -0800</bug_when>
    <thetext>Comment on attachment 190014
Patch

Clearing flags on attachment: 190014

Committed r143895: &lt;http://trac.webkit.org/changeset/143895&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840806</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-25 01:50:38 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840961</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-25 07:38:13 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 110758</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841326</commentid>
    <comment_count>7</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-02-25 15:07:09 -0800</bug_when>
    <thetext>trying again ... reenabled in http://trac.webkit.org/changeset/143978</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841527</commentid>
    <comment_count>8</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2013-02-25 19:06:24 -0800</bug_when>
    <thetext>seems to be happy so far w/ ~5 runs all greenish.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190014</attachid>
            <date>2013-02-25 00:51:32 -0800</date>
            <delta_ts>2013-02-25 01:50:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-110731-20130225094748.patch</filename>
            <type>text/plain</type>
            <size>1164</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzQ2YTdlNWQ2NTZjYzBiZGM2ZTJkYmQwNmFlNGI2YzQz
YWRkYTQyYi4uOTU3NjYyNmMyMjEyNTk3ZGEwMTRjMTIxMDM3YmE1MzQ0NDhiYmVjNyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDEzLTAyLTI1ICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg
ICAgICBNYWtlIG5pbmphIHRoZSBkZWZhdWx0IGJ1aWxkIHN5c3RlbSBmb3IgYnVpbGQtd2Via2l0
IC0tY2hyb21pdW0gb24gd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTEwNzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgV2l0aCBodHRwOi8vY3JidWcuY29tLzE2OTk0NSBmaXhlZCwgdGhpcyBz
aG91bGQgbm93IHdvcmsuCisKKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21p
dW06CisKIDIwMTMtMDItMTQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBbY2hyb21pdW1dIFJlcXVlc3QgV2ViTGF5ZXJUcmVlVmlldyBmb3IgRHVtcFJl
bmRlclRyZWUgdmlhIGV4cGxpY2l0IHRlc3RpbmcgcGF0aApkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny
aXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0
LWNocm9taXVtCmluZGV4IGNjY2QzN2Q5ZmVhNjFkMjE0NDFiY2EzOWM5MTY4YjM4MGI4YjBhMzAu
LmY5ODQ3M2ZmMjZhYTAxMmNhYTk2ZTNiMzUyNWQ2YTMzMTNkMWJjNmQgMTAwNzU1Ci0tLSBhL1Rv
b2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQorKysgYi9Ub29scy9TY3JpcHRzL3Vw
ZGF0ZS13ZWJraXQtY2hyb21pdW0KQEAgLTY2LDcgKzY2LDcgQEAgaWYgKGlzQ2hyb21pdW1BbmRy
b2lkKCkpIHsKIH0KIAogbXkgJGZvcmNlID0gMDsKLW15ICR1c2VOaW5qYSA9ICReTyBlcSAibGlu
dXgiIHx8ICReTyBlcSAiZGFyd2luIjsKK215ICR1c2VOaW5qYSA9IDE7CiAKIEdldE9wdGlvbnMo
CiAgICdmb3JjZScgPT4gXCRmb3JjZSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>