110714 2013-02-24 11:35:53 -0800 Clarify meaning of default default encoding localizable string 2013-02-24 16:33:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap mitz oldest_to_newest 840633 0 ap 2013-02-24 11:35:53 -0800 /* The default, default character encoding */ "ISO-8859-1" = "ISO-8859-1"; This string only has effect on Windows, but there is nothing telling localizers so, and it's a huge source of confusion. 840634 1 189981 ap 2013-02-24 11:38:24 -0800 Created attachment 189981 proposed patch 840637 2 mitz 2013-02-24 11:54:02 -0800 Does this comment aid localization? Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like /* (Used only on Windows) The IANA name of the default default character encoding */ "DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1"; 840663 3 ap 2013-02-24 16:09:35 -0800 (In reply to comment #2) > Does this comment aid localization? Yes, that's its purpose, and it's certainly visible in relevant tools. >Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like > > /* (Used only on Windows) The IANA name of the default default character encoding */ > > "DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1"; This is only needed when there are multiple localizable strings that are the same in English, but not necessarily the same in other languages. But we only use the "ISO-8859-1" key once. 840665 4 ap 2013-02-24 16:16:31 -0800 Committed <http://trac.webkit.org/changeset/143881>. 840666 5 mitz 2013-02-24 16:18:43 -0800 (In reply to comment #3) > (In reply to comment #2) > > Does this comment aid localization? > > Yes, that's its purpose, and it's certainly visible in relevant tools. I was referring to the particular comment in your patch. > > >Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like > > > > /* (Used only on Windows) The IANA name of the default default character encoding */ > > > > "DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1"; > > This is only needed when there are multiple localizable strings that are the same in English, but not necessarily the same in other languages. I wasn’t suggesting that it was needed, I was suggesting that it would aid in localization. 840670 6 ap 2013-02-24 16:33:45 -0800 > I was referring to the particular comment in your patch. I didn't explain where the confusion was. It's perfectly clear how to localize this string, but testing the localization is a challenge, because people expect to see its effect on Mac. 189981 2013-02-24 11:38:24 -0800 2013-02-24 11:47:24 -0800 proposed patch LocalizableStringsComment.txt text/plain 2974 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Mzg3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTI0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIENsYXJpZnkgbWVhbmluZyBv ZiBkZWZhdWx0IGRlZmF1bHQgZW5jb2RpbmcgbG9jYWxpemFibGUgc3RyaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA3MTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovTG9j YWxpemFibGUuc3RyaW5nczogVGhpcyBzdHJpbmcgaXMgb25seSB1c2VkIG9uIFdpbmRvd3MsIGFu ZCBpdCdzCisgICAgICAgIHZlcnkgY29uZnVzaW5nIHRvIGV2ZXJ5b25lIGludm9sdmVkLgorCiAy MDEzLTAyLTI0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1RLXSBTdG9wIGdlbmVyYXRpbmcgVXNlckFnZW50R3RrLmgKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MJKHJldmlzaW9uIDE0 MzU2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5n cwkod29ya2luZyBjb3B5KQpAQCAtMTc4LDcgKzE3OCw3IEBACiAALwAqACAAbQBlAG4AdQAgAGkA dABlAG0AIAB0AGkAdABsAGUAIAAqAC8ACiAAIgBIAGkAZABlACAAUwB1AGIAcwB0AGkAdAB1AHQA aQBvAG4AcwAiACAAPQAgACIASABpAGQAZQAgAFMAdQBiAHMAdABpAHQAdQB0AGkAbwBuAHMAIgA7 AAogAAotAC8AKgAgAFQAaABlACAAZABlAGYAYQB1AGwAdAAsACAAZABlAGYAYQB1AGwAdAAgAGMA aABhAHIAYQBjAHQAZQByACAAZQBuAGMAbwBkAGkAbgBnACAAKgAvAAorAC8AKgAgAFQAaABlACAA ZABlAGYAYQB1AGwAdAAsACAAZABlAGYAYQB1AGwAdAAgAGMAaABhAHIAYQBjAHQAZQByACAAZQBu AGMAbwBkAGkAbgBnACAAbwBuACAAVwBpAG4AZABvAHcAcwAgACoALwAKIAAiAEkAUwBPAC0AOAA4 ADUAOQAtADEAIgAgAD0AIAAiAEkAUwBPAC0AOAA4ADUAOQAtADEAIgA7AAogAAogAC8AKgAgAEkA ZwBuAG8AcgBlACAARwByAGEAbQBtAGEAcgAgAGMAbwBuAHQAZQB4AHQAIABtAGUAbgB1ACAAaQB0 AGUAbQAgACoALwAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Mzg3NSkKKysrIFNv dXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTAyLTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIENsYXJpZnkgbWVhbmluZyBvZiBkZWZhdWx0IGRlZmF1bHQgZW5jb2RpbmcgbG9jYWxpemFi bGUgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTA3MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlByZWZlcmVuY2VzLmNwcDogVXBkYXRlZCBhIGNvbW1lbnQuCisKIDIwMTMtMDItMjEg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDM1MzYuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9X ZWJQcmVmZXJlbmNlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViUHJl ZmVyZW5jZXMuY3BwCShyZXZpc2lvbiAxNDM1NjUpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQ cmVmZXJlbmNlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NSw3ICsxOTUsNyBAQCB2b2lkIFdl YlByZWZlcmVuY2VzOjppbml0aWFsaXplRGVmYXVsdFNlCiAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFs dWUoZGVmYXVsdHMsIENGU1RSKFdlYktpdERlZmF1bHRGb250U2l6ZVByZWZlcmVuY2VLZXkpLCBD RlNUUigiMTYiKSk7CiAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoZGVmYXVsdHMsIENGU1RSKFdl YktpdERlZmF1bHRGaXhlZEZvbnRTaXplUHJlZmVyZW5jZUtleSksIENGU1RSKCIxMyIpKTsKIAot ICAgIFN0cmluZyBkZWZhdWx0RGVmYXVsdEVuY29kaW5nKFdFQl9VSV9TVFJJTkcoIklTTy04ODU5 LTEiLCAiVGhlIGRlZmF1bHQsIGRlZmF1bHQgY2hhcmFjdGVyIGVuY29kaW5nIikpOworICAgIFN0 cmluZyBkZWZhdWx0RGVmYXVsdEVuY29kaW5nKFdFQl9VSV9TVFJJTkcoIklTTy04ODU5LTEiLCAi VGhlIGRlZmF1bHQsIGRlZmF1bHQgY2hhcmFjdGVyIGVuY29kaW5nIG9uIFdpbmRvd3MiKSk7CiAg ICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoZGVmYXVsdHMsIENGU1RSKFdlYktpdERlZmF1bHRUZXh0 RW5jb2RpbmdOYW1lUHJlZmVyZW5jZUtleSksIGRlZmF1bHREZWZhdWx0RW5jb2RpbmcuY3JlYXRl Q0ZTdHJpbmcoKS5nZXQoKSk7CiAKICAgICBDRkRpY3Rpb25hcnlBZGRWYWx1ZShkZWZhdWx0cywg Q0ZTVFIoV2ViS2l0VXNlclN0eWxlU2hlZXRFbmFibGVkUHJlZmVyZW5jZUtleSksIGtDRkJvb2xl YW5GYWxzZSk7Cg==