110707 2013-02-23 21:03:39 -0800 [Mac] user preference caption style applied incorrectly 2013-02-23 21:33:51 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson dino esprehn+autocc feature-media-reviews jer.noble ojan.autocc webkit-bug-importer webkit.review.bot oldest_to_newest 840527 0 eric.carlson 2013-02-23 21:03:39 -0800 CaptionUserPreferencesMac attaches a user style sheet for the cue text and "window" properties to the a child of the element used for the ::cue pseudo element. This makes it impossible for CSS to override these properties. 840528 1 webkit-bug-importer 2013-02-23 21:04:07 -0800 <rdar://problem/13281096> 840529 2 189956 eric.carlson 2013-02-23 21:12:07 -0800 Created attachment 189956 Proposed patch 840533 3 189956 mjs 2013-02-23 21:26:45 -0800 Comment on attachment 189956 Proposed patch r=me We should find a way to make this code testable in the future. 840534 4 eric.carlson 2013-02-23 21:33:32 -0800 Committed in https://trac.webkit.org/r143857 189956 2013-02-23 21:12:07 -0800 2013-02-23 21:33:51 -0800 Proposed patch patch_1.txt text/plain 5054 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Mzg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHVzZXIgcHJl ZmVyZW5jZSBjYXB0aW9uIHN0eWxlIGFwcGxpZWQgaW5jb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDcwNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250 cm9sRWxlbWVudHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVGV4dFRyYWNr Q29udGFpbmVyRWxlbWVudDo6dGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudFNoYWRvd1BzZXVkb0lk KTogTmV3CisgICAgICAgICAgICBzdGF0aWMgZnVuY3Rpb24gc28gdGhlIHBzZXVkbyBJRCBpcyBh dmFpbGFibGUuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWlu ZXJFbGVtZW50OjpzaGFkb3dQc2V1ZG9JZCk6IENhbGwgdGV4dFRyYWNrQ29udGFpbmVyRWxlbWVu dFNoYWRvd1BzZXVkb0lkLgorICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1l bnRzLmg6CisKKyAgICAgICAgKiBwYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNNYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjpDYXB0aW9uVXNlclByZWZlcmVuY2VzTWFjOjpjYXB0aW9uc1N0eWxl U2hlZXRPdmVycmlkZSk6IFN0eWxlIHRoZSB0ZXh0IHRyYWNrIGNvbnRhaW5lcgorICAgICAgICAg ICAgZWxlbWVudCBmb3IgY3VlIGNvbG9yLCBlZGdlIHN0eWxlLCBhbmQgZm9udCBuYW1lLgorCiAy MDEzLTAyLTIyICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbVjhdIEdlbmVyYXRlIHh4eEF0dHJHZXR0ZXJDYWxsYmFjaygpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCShyZXZp c2lvbiAxNDM4NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xF bGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMDAsMTEgKzEyMDAsMTYgQEAgUmVuZGVy T2JqZWN0KiBNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YQogICAgIHJldHVybiBuZXcgKGFyZW5h KSBSZW5kZXJUZXh0VHJhY2tDb250YWluZXJFbGVtZW50KHRoaXMpOwogfQogCi1jb25zdCBBdG9t aWNTdHJpbmcmIE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnNoYWRvd1Bz ZXVkb0lkKCkgY29uc3QKK2NvbnN0IEF0b21pY1N0cmluZyYgTWVkaWFDb250cm9sVGV4dFRyYWNr Q29udGFpbmVyRWxlbWVudDo6dGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudFNoYWRvd1BzZXVkb0lk KCkKIHsKICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKEF0b21pY1N0cmluZywgaWQsICgiLXdlYmtp dC1tZWRpYS10ZXh0LXRyYWNrLWNvbnRhaW5lciIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJv bUxpdGVyYWwpKTsKICAgICByZXR1cm4gaWQ7CiB9CisgICAgCitjb25zdCBBdG9taWNTdHJpbmcm IE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnNoYWRvd1BzZXVkb0lkKCkg Y29uc3QKK3sKKyAgICByZXR1cm4gdGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudFNoYWRvd1BzZXVk b0lkKCk7Cit9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6 dXBkYXRlRGlzcGxheSgpCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRp YUNvbnRyb2xFbGVtZW50cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmgJKHJldmlzaW9uIDE0Mzg1MSkKKysrIFNvdXJjZS9X ZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmgJKHdvcmtpbmcgY29weSkK QEAgLTQ0MCw2ICs0NDAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVEaXNwbGF5KCk7CiAg ICAgdm9pZCB1cGRhdGVTaXplcyhib29sIGZvcmNlVXBkYXRlID0gZmFsc2UpOwogICAgIHZvaWQg Y3JlYXRlU3VidHJlZXMoRG9jdW1lbnQqKTsKKyAgICBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5n JiB0ZXh0VHJhY2tDb250YWluZXJFbGVtZW50U2hhZG93UHNldWRvSWQoKTsKIAogcHJpdmF0ZToK ICAgICBleHBsaWNpdCBNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50KERvY3Vt ZW50Kik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNN YWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNlclByZWZl cmVuY2VzTWFjLm1tCShyZXZpc2lvbiAxNDM4NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0Nh cHRpb25Vc2VyUHJlZmVyZW5jZXNNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDcg QEAKICNpbXBvcnQgIkxhbmd1YWdlLmgiCiAjaW1wb3J0ICJMb2NhbGl6ZWRTdHJpbmdzLmgiCiAj aW1wb3J0ICJMb2dnaW5nLmgiCisjaW1wb3J0ICJNZWRpYUNvbnRyb2xFbGVtZW50cy5oIgogI2lt cG9ydCAiUGFnZUdyb3VwLmgiCiAjaW1wb3J0ICJTb2Z0TGlua2luZy5oIgogI2ltcG9ydCAiVGV4 dFRyYWNrQ3VlLmgiCkBAIC0zNzYsMTAgKzM3Nyw3IEBAIFN0cmluZyBDYXB0aW9uVXNlclByZWZl cmVuY2VzTWFjOjpjYXB0aW8KIAogICAgIFN0cmluZyB3aW5kb3dDb2xvciA9IGNhcHRpb25zV2lu ZG93Q1NTKCk7CiAgICAgU3RyaW5nIHdpbmRvd0Nvcm5lclJhZGl1cyA9IHdpbmRvd1JvdW5kZWRD b3JuZXJSYWRpdXNDU1MoKTsKLSAgICBTdHJpbmcgY2FwdGlvbnNDb2xvciA9IGNhcHRpb25zVGV4 dENvbG9yQ1NTKCk7Ci0gICAgU3RyaW5nIGVkZ2VTdHlsZSA9IGNhcHRpb25zVGV4dEVkZ2VDU1Mo KTsKLSAgICBTdHJpbmcgZm9udE5hbWUgPSBjYXB0aW9uc0RlZmF1bHRGb250Q1NTKCk7Ci0gICAg aWYgKCFjYXB0aW9uc0NvbG9yLmlzRW1wdHkoKSB8fCAhd2luZG93Q29sb3IuaXNFbXB0eSgpIHx8 ICF3aW5kb3dDb3JuZXJSYWRpdXMuaXNFbXB0eSgpIHx8ICFlZGdlU3R5bGUuaXNFbXB0eSgpIHx8 ICFmb250TmFtZS5pc0VtcHR5KCkpIHsKKyAgICBpZiAoIXdpbmRvd0NvbG9yLmlzRW1wdHkoKSB8 fCAhd2luZG93Q29ybmVyUmFkaXVzLmlzRW1wdHkoKSkgewogICAgICAgICBjYXB0aW9uc092ZXJy aWRlU3R5bGVTaGVldC5hcHBlbmQoIiB2aWRlbzo6Iik7CiAgICAgICAgIGNhcHRpb25zT3ZlcnJp ZGVTdHlsZVNoZWV0LmFwcGVuZChUZXh0VHJhY2tDdWVCb3g6OnRleHRUcmFja0N1ZUJveFNoYWRv d1BzZXVkb0lkKCkpOwogICAgICAgICBjYXB0aW9uc092ZXJyaWRlU3R5bGVTaGVldC5hcHBlbmQo J3snKTsKQEAgLTM4OCw2ICszODYsMTggQEAgU3RyaW5nIENhcHRpb25Vc2VyUHJlZmVyZW5jZXNN YWM6OmNhcHRpbwogICAgICAgICAgICAgY2FwdGlvbnNPdmVycmlkZVN0eWxlU2hlZXQuYXBwZW5k KHdpbmRvd0NvbG9yKTsKICAgICAgICAgaWYgKCF3aW5kb3dDb3JuZXJSYWRpdXMuaXNFbXB0eSgp KQogICAgICAgICAgICAgY2FwdGlvbnNPdmVycmlkZVN0eWxlU2hlZXQuYXBwZW5kKHdpbmRvd0Nv cm5lclJhZGl1cyk7CisKKyAgICAgICAgY2FwdGlvbnNPdmVycmlkZVN0eWxlU2hlZXQuYXBwZW5k KCd9Jyk7CisgICAgfQorICAgIAorICAgIFN0cmluZyBjYXB0aW9uc0NvbG9yID0gY2FwdGlvbnNU ZXh0Q29sb3JDU1MoKTsKKyAgICBTdHJpbmcgZWRnZVN0eWxlID0gY2FwdGlvbnNUZXh0RWRnZUNT UygpOworICAgIFN0cmluZyBmb250TmFtZSA9IGNhcHRpb25zRGVmYXVsdEZvbnRDU1MoKTsKKyAg ICBpZiAoIWNhcHRpb25zQ29sb3IuaXNFbXB0eSgpIHx8ICFlZGdlU3R5bGUuaXNFbXB0eSgpIHx8 ICFmb250TmFtZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgY2FwdGlvbnNPdmVycmlkZVN0eWxlU2hl ZXQuYXBwZW5kKCIgdmlkZW86OiIpOworICAgICAgICBjYXB0aW9uc092ZXJyaWRlU3R5bGVTaGVl dC5hcHBlbmQoTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dGV4dFRyYWNr Q29udGFpbmVyRWxlbWVudFNoYWRvd1BzZXVkb0lkKCkpOworICAgICAgICBjYXB0aW9uc092ZXJy aWRlU3R5bGVTaGVldC5hcHBlbmQoJ3snKTsKKwogICAgICAgICBpZiAoIWNhcHRpb25zQ29sb3Iu aXNFbXB0eSgpKQogICAgICAgICAgICAgY2FwdGlvbnNPdmVycmlkZVN0eWxlU2hlZXQuYXBwZW5k KGNhcHRpb25zQ29sb3IpOwogICAgICAgICBpZiAoIWVkZ2VTdHlsZS5pc0VtcHR5KCkpCkBAIC0z OTcsNyArNDA3LDcgQEAgU3RyaW5nIENhcHRpb25Vc2VyUHJlZmVyZW5jZXNNYWM6OmNhcHRpbwog CiAgICAgICAgIGNhcHRpb25zT3ZlcnJpZGVTdHlsZVNoZWV0LmFwcGVuZCgnfScpOwogICAgIH0K LQorICAgIAogICAgIExPRyhNZWRpYSwgIkNhcHRpb25Vc2VyUHJlZmVyZW5jZXNNYWM6OmNhcHRp b25zU3R5bGVTaGVldE92ZXJyaWRlU2V0dGluZyBzeXRsZSB0bzpcbiVzIiwgY2FwdGlvbnNPdmVy cmlkZVN0eWxlU2hlZXQudG9TdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIHJldHVybiBj YXB0aW9uc092ZXJyaWRlU3R5bGVTaGVldC50b1N0cmluZygpOwo=