110685 2013-02-23 01:26:08 -0800 [Texmap] LayoutTests/compositing/animation/state-at-end-event-transform-layer.html shows a red square where it shouldn't 2013-02-26 04:20:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam alexander.pashenko allan.jensen cmarcelo dongseong.hwang jaepark kbalazs kenneth kvserr luiz mrobinson rafael.lobo webkit.review.bot oldest_to_newest 840329 0 noam 2013-02-23 01:26:08 -0800 I believe this is a regression since r140825. m_shouldUpdateCurrentTransformFromGraphicsLayer is set to false at some point, but never reset to true. We don't treat end of animations correctly! 840337 1 189916 noam 2013-02-23 01:55:32 -0800 Created attachment 189916 Patch 840980 2 189916 mrobinson 2013-02-25 08:08:16 -0800 Comment on attachment 189916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189916&action=review > Source/WebCore/ChangeLog:8 > + Removed m_shouldUpdateTransformm_shouldUpdateCurrentTransformFromGraphicsLayer etc., as they don't do Looks like m_shouldUpdateTransformm_shouldUpdateCurrentTransformFromGraphicsLayer might be missing a space. 840997 3 190069 noam 2013-02-25 08:41:26 -0800 Created attachment 190069 Patch for landing 841100 4 190069 webkit.review.bot 2013-02-25 10:41:04 -0800 Comment on attachment 190069 Patch for landing Clearing flags on attachment: 190069 Committed r143947: <http://trac.webkit.org/changeset/143947> 841101 5 webkit.review.bot 2013-02-25 10:41:08 -0800 All reviewed patches have been landed. Closing bug. 841182 6 allan.jensen 2013-02-25 12:21:22 -0800 Actually the patch you reverted here made a significant impact on Qt WK1. Has the issues been solved in a different way now? 841199 7 noam 2013-02-25 12:40:21 -0800 (In reply to comment #6) > Actually the patch you reverted here made a significant impact on Qt WK1. Has the issues been solved in a different way now? This is not a revert. Can you be more specific than "significant impact", and are there tests that cover this? 841230 8 allan.jensen 2013-02-25 13:08:03 -0800 (In reply to comment #7) > (In reply to comment #6) > > Actually the patch you reverted here made a significant impact on Qt WK1. Has the issues been solved in a different way now? > > This is not a revert. Can you be more specific than "significant impact", and are there tests that cover this? I thought the introduction of these variables was the main part of r140825, so it just look like a revert to me. R140825 solved an annoying flicker issue that was only observable in WK1 and had no tests, I merged it into Qt5.0, so I am trying to understand this patch, to see if merging r140825 was a mistake, or I need this patch too or anything in between. 841231 9 noam 2013-02-25 13:09:53 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Actually the patch you reverted here made a significant impact on Qt WK1. Has the issues been solved in a different way now? > > > > This is not a revert. Can you be more specific than "significant impact", and are there tests that cover this? > > I thought the introduction of these variables was the main part of r140825, so it just look like a revert to me. R140825 solved an annoying flicker issue that was only observable in WK1 and had no tests, I merged it into Qt5.0, so I am trying to understand this patch, to see if merging r140825 was a mistake, or I need this patch too or anything in between. In any case those variables were wrong - they are set to false once and then never reset to true, unless I've missed something. 841834 10 alexander.pashenko 2013-02-26 03:00:47 -0800 > In any case those variables were wrong - they are set to false once and then never reset to true, unless I've missed something. I believe you have because actually they do get set to true inside m_shouldUpdateCurrentTransformFromGraphicsLayer. Please see https://bug-102501-attachments.webkit.org/attachment.cgi?id=184733 it reads, among other things, if (changeMask & TransformChange) m_shouldUpdateCurrentTransformFromGraphicsLayer = true; if (changeMask & OpacityChange) m_shouldUpdateCurrentOpacityFromGraphicsLayer = true; #if ENABLE(CSS_FILTERS) if (changeMask & FilterChange) m_shouldUpdateCurrentFiltersFromGraphicsLayer = true; #endif 841846 11 alexander.pashenko 2013-02-26 03:26:19 -0800 (In reply to comment #10) > they do get set to true inside m_shouldUpdateCurrentTransformFromGraphicsLayer Sorry, I meant that the patch sets these variables to true inside TextureMapperLayer::flushCompositingStateForThisLayerOnly. 841870 12 noam 2013-02-26 04:09:57 -0800 (In reply to comment #11) > (In reply to comment #10) > > they do get set to true inside m_shouldUpdateCurrentTransformFromGraphicsLayer > > Sorry, I meant that the patch sets these variables to true inside TextureMapperLayer::flushCompositingStateForThisLayerOnly. OK, I think it got lost at a later patch then, probably in the GLTM refactoring. 841872 13 noam 2013-02-26 04:20:46 -0800 (In reply to comment #11) > (In reply to comment #10) > > they do get set to true inside m_shouldUpdateCurrentTransformFromGraphicsLayer > > Sorry, I meant that the patch sets these variables to true inside TextureMapperLayer::flushCompositingStateForThisLayerOnly. You're right, but it's still the wrong fix. When an animation doesn't fillForward, it should revert to its original position at end of animation. Your patch makes it so that animations are always considered to have a fillsForward flag. 189916 2013-02-23 01:55:32 -0800 2013-02-25 08:41:20 -0800 Patch bug-110685-20130223105144.patch text/plain 4533 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyYWQ2MDY4OWU0OGEx ZjkyOTg0ZDZlNzAxMzc2YTQ3NDJjOWVjMC4uNTE1ZWMzZGJhZjNlM2YxNTZiMDBlZTQ2MDYxNWUy ZmJkNzczMTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTIzICBObydh bSBSb3NlbnRoYWwgIDxub2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1RleG1hcF0gTGF5b3V0 VGVzdHMvY29tcG9zaXRpbmcvYW5pbWF0aW9uL3N0YXRlLWF0LWVuZC1ldmVudC10cmFuc2Zvcm0t bGF5ZXIuaHRtbCBzaG93cyBhIHJlZCBzcXVhcmUgd2hlcmUgaXQgc2hvdWxkbid0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2ODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIG1fc2hvdWxk VXBkYXRlVHJhbnNmb3JtbV9zaG91bGRVcGRhdGVDdXJyZW50VHJhbnNmb3JtRnJvbUdyYXBoaWNz TGF5ZXIgZXRjLiwgYXMgdGhleSBkb24ndCBkbworICAgICAgICB3aGF0IHRoZXkncmUgc3VwcG9z ZWQgdG8gZG8uIE5vIGZsaWNrZXJzIG9ic2VydmVkLgorCisgICAgICAgIExheW91dFRlc3RzL2Nv bXBvc2l0aW5nL2FuaW1hdGlvbi9zdGF0ZS1hdC1lbmQtZXZlbnQtdHJhbnNmb3JtLWxheWVyLmh0 bWwgbm93IHdvcmtzIGNvcnJlY3RseS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1h cHBlckxheWVyOjpzZXRBbmltYXRlZFRyYW5zZm9ybSk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0 dXJlTWFwcGVyTGF5ZXI6OnNldEFuaW1hdGVkT3BhY2l0eSk6CisgICAgICAgIChXZWJDb3JlOjpU ZXh0dXJlTWFwcGVyTGF5ZXI6OnNldEFuaW1hdGVkRmlsdGVycyk6CisgICAgICAgIChXZWJDb3Jl OjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnN5bmNBbmltYXRpb25zKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmg6CisgICAgICAgIChXZWJDb3Jl OjpUZXh0dXJlTWFwcGVyTGF5ZXI6OlRleHR1cmVNYXBwZXJMYXllcik6CisgICAgICAgIChUZXh0 dXJlTWFwcGVyTGF5ZXIpOgorCiAyMDEzLTAyLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW5hbWUgRGF0YWJhc2VCYWNrZW5kIHRvIERhdGFiYXNlQmFja2Vu ZEJhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDg4ZWIzY2QxZmQ5N2YwZmNm YzExMTc1ZGFmODY3YTUyNThiOTE4ZDMuLjhhMmNjOTkyYjcxMTA2NjYxMDdjMWJlMDMxM2JhNGFm OTZjNmZiYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC0yNzcsMjAgKzI3Nywx NyBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmQW5kQ2hpbGRyZW5XaXRoUmVw bGljYShjb25zdCBUZXh0dXJlTWFwcGVyUGFpbgogCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6 c2V0QW5pbWF0ZWRUcmFuc2Zvcm0oY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIG1hdHJpeCkK IHsKLSAgICBtX3Nob3VsZFVwZGF0ZUN1cnJlbnRUcmFuc2Zvcm1Gcm9tR3JhcGhpY3NMYXllciA9 IGZhbHNlOwogICAgIG1fY3VycmVudFRyYW5zZm9ybS5zZXRMb2NhbFRyYW5zZm9ybShtYXRyaXgp OwogfQogCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6c2V0QW5pbWF0ZWRPcGFjaXR5KGZsb2F0 IG9wYWNpdHkpCiB7Ci0gICAgbV9zaG91bGRVcGRhdGVDdXJyZW50T3BhY2l0eUZyb21HcmFwaGlj c0xheWVyID0gZmFsc2U7CiAgICAgbV9jdXJyZW50T3BhY2l0eSA9IG9wYWNpdHk7CiB9CiAKICNp ZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6c2V0QW5pbWF0 ZWRGaWx0ZXJzKGNvbnN0IEZpbHRlck9wZXJhdGlvbnMmIGZpbHRlcnMpCiB7Ci0gICAgbV9zaG91 bGRVcGRhdGVDdXJyZW50RmlsdGVyc0Zyb21HcmFwaGljc0xheWVyID0gZmFsc2U7CiAgICAgbV9j dXJyZW50RmlsdGVycyA9IGZpbHRlcnM7CiB9CiAKQEAgLTU3NiwxMyArNTczLDEzIEBAIHZvaWQg VGV4dHVyZU1hcHBlckxheWVyOjphcHBseUFuaW1hdGlvbnNSZWN1cnNpdmVseSgpCiB2b2lkIFRl eHR1cmVNYXBwZXJMYXllcjo6c3luY0FuaW1hdGlvbnMoKQogewogICAgIG1fYW5pbWF0aW9ucy5h cHBseSh0aGlzKTsKLSAgICBpZiAoIW1fYW5pbWF0aW9ucy5oYXNBY3RpdmVBbmltYXRpb25zT2ZU eXBlKEFuaW1hdGVkUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0pICYmIG1fc2hvdWxkVXBkYXRlQ3Vy cmVudFRyYW5zZm9ybUZyb21HcmFwaGljc0xheWVyKQorICAgIGlmICghbV9hbmltYXRpb25zLmhh c0FjdGl2ZUFuaW1hdGlvbnNPZlR5cGUoQW5pbWF0ZWRQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSkp CiAgICAgICAgIG1fY3VycmVudFRyYW5zZm9ybS5zZXRMb2NhbFRyYW5zZm9ybShtX3N0YXRlLnRy YW5zZm9ybSk7Ci0gICAgaWYgKCFtX2FuaW1hdGlvbnMuaGFzQWN0aXZlQW5pbWF0aW9uc09mVHlw ZShBbmltYXRlZFByb3BlcnR5T3BhY2l0eSkgJiYgbV9zaG91bGRVcGRhdGVDdXJyZW50T3BhY2l0 eUZyb21HcmFwaGljc0xheWVyKQorICAgIGlmICghbV9hbmltYXRpb25zLmhhc0FjdGl2ZUFuaW1h dGlvbnNPZlR5cGUoQW5pbWF0ZWRQcm9wZXJ0eU9wYWNpdHkpKQogICAgICAgICBtX2N1cnJlbnRP cGFjaXR5ID0gbV9zdGF0ZS5vcGFjaXR5OwogCiAjaWYgRU5BQkxFKENTU19GSUxURVJTKQotICAg IGlmICghbV9hbmltYXRpb25zLmhhc0FjdGl2ZUFuaW1hdGlvbnNPZlR5cGUoQW5pbWF0ZWRQcm9w ZXJ0eVdlYmtpdEZpbHRlcikgJiYgbV9zaG91bGRVcGRhdGVDdXJyZW50RmlsdGVyc0Zyb21HcmFw aGljc0xheWVyKQorICAgIGlmICghbV9hbmltYXRpb25zLmhhc0FjdGl2ZUFuaW1hdGlvbnNPZlR5 cGUoQW5pbWF0ZWRQcm9wZXJ0eVdlYmtpdEZpbHRlcikpCiAgICAgICAgIG1fY3VycmVudEZpbHRl cnMgPSBtX3N0YXRlLmZpbHRlcnM7CiAjZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaApp bmRleCBmNmI3MmEzMjViYjg1YmUwMWY4OTJjMzc5YzJiNzA3NmQxNjYwNGU0Li42MWZiODI3Njcw ODYwM2UxMTBmYWNlZDQxODlkYjdkYTBiYzAzMWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5o CkBAIC00NCwxMSArNDQsNiBAQCBwdWJsaWM6CiAgICAgICAgICwgbV9jb250ZW50c0xheWVyKDAp CiAgICAgICAgICwgbV9jdXJyZW50T3BhY2l0eSgxKQogICAgICAgICAsIG1fY2VudGVyWigwKQot ICAgICAgICAsIG1fc2hvdWxkVXBkYXRlQ3VycmVudFRyYW5zZm9ybUZyb21HcmFwaGljc0xheWVy KHRydWUpCi0gICAgICAgICwgbV9zaG91bGRVcGRhdGVDdXJyZW50T3BhY2l0eUZyb21HcmFwaGlj c0xheWVyKHRydWUpCi0jaWYgRU5BQkxFKENTU19GSUxURVJTKQotICAgICAgICAsIG1fc2hvdWxk VXBkYXRlQ3VycmVudEZpbHRlcnNGcm9tR3JhcGhpY3NMYXllcih0cnVlKQotI2VuZGlmCiAgICAg ICAgICwgbV90ZXh0dXJlTWFwcGVyKDApCiAgICAgICAgICwgbV9maXhlZFRvVmlld3BvcnQoZmFs c2UpCiAgICAgeyB9CkBAIC0xNDksMTIgKzE0NCw2IEBAIHByaXZhdGU6CiAgICAgRmlsdGVyT3Bl cmF0aW9ucyBtX2N1cnJlbnRGaWx0ZXJzOwogI2VuZGlmCiAgICAgZmxvYXQgbV9jZW50ZXJaOwot ICAgIAotICAgIGJvb2wgbV9zaG91bGRVcGRhdGVDdXJyZW50VHJhbnNmb3JtRnJvbUdyYXBoaWNz TGF5ZXI7Ci0gICAgYm9vbCBtX3Nob3VsZFVwZGF0ZUN1cnJlbnRPcGFjaXR5RnJvbUdyYXBoaWNz TGF5ZXI7Ci0jaWYgRU5BQkxFKENTU19GSUxURVJTKQotICAgIGJvb2wgbV9zaG91bGRVcGRhdGVD dXJyZW50RmlsdGVyc0Zyb21HcmFwaGljc0xheWVyOwotI2VuZGlmCiAKICAgICBzdHJ1Y3QgU3Rh dGUgewogICAgICAgICBGbG9hdFBvaW50IHBvczsK 190069 2013-02-25 08:41:26 -0800 2013-02-25 10:41:04 -0800 Patch for landing bug-110685-20130225173741.patch text/plain 4511 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyYWQ2MDY4OWU0OGEx ZjkyOTg0ZDZlNzAxMzc2YTQ3NDJjOWVjMC4uNmYxZjU4ZjQ0NmM5ZWZlZDAwNzZkMzdjZjg0ZTQ3 YzFkYmNlZjc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTIzICBObydh bSBSb3NlbnRoYWwgIDxub2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1RleG1hcF0gTGF5b3V0 VGVzdHMvY29tcG9zaXRpbmcvYW5pbWF0aW9uL3N0YXRlLWF0LWVuZC1ldmVudC10cmFuc2Zvcm0t bGF5ZXIuaHRtbCBzaG93cyBhIHJlZCBzcXVhcmUgd2hlcmUgaXQgc2hvdWxkbid0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2ODUKKworICAgICAg ICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCisKKyAgICAgICAgUmVtb3ZlZCBtX3Nob3Vs ZFVwZGF0ZUN1cnJlbnRUcmFuc2Zvcm1Gcm9tR3JhcGhpY3NMYXllciBldGMuLCBhcyB0aGV5IGRv bid0IGRvCisgICAgICAgIHdoYXQgdGhleSdyZSBzdXBwb3NlZCB0byBkby4gTm8gZmxpY2tlcnMg b2JzZXJ2ZWQuCisKKyAgICAgICAgTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYW5pbWF0aW9uL3N0 YXRlLWF0LWVuZC1ldmVudC10cmFuc2Zvcm0tbGF5ZXIuaHRtbCBub3cgd29ya3MgY29ycmVjdGx5 LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXll ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldEFuaW1hdGVk VHJhbnNmb3JtKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6c2V0QW5p bWF0ZWRPcGFjaXR5KToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6c2V0 QW5pbWF0ZWRGaWx0ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6 c3luY0FuaW1hdGlvbnMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyTGF5ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6 VGV4dHVyZU1hcHBlckxheWVyKToKKyAgICAgICAgKFRleHR1cmVNYXBwZXJMYXllcik6CisKIDIw MTMtMDItMjAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFt ZSBEYXRhYmFzZUJhY2tlbmQgdG8gRGF0YWJhc2VCYWNrZW5kQmFzZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJMYXllci5jcHAKaW5kZXggODhlYjNjZDFmZDk3ZjBmY2ZjMTExNzVkYWY4NjdhNTI1OGI5MThk My4uOGEyY2M5OTJiNzExMDY2NjEwN2MxYmUwMzEzYmE0YWY5NmM2ZmJhZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXll ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1 cmVNYXBwZXJMYXllci5jcHAKQEAgLTI3NywyMCArMjc3LDE3IEBAIHZvaWQgVGV4dHVyZU1hcHBl ckxheWVyOjpwYWludFNlbGZBbmRDaGlsZHJlbldpdGhSZXBsaWNhKGNvbnN0IFRleHR1cmVNYXBw ZXJQYWluCiAKIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpzZXRBbmltYXRlZFRyYW5zZm9ybShj b25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4KQogewotICAgIG1fc2hvdWxkVXBkYXRl Q3VycmVudFRyYW5zZm9ybUZyb21HcmFwaGljc0xheWVyID0gZmFsc2U7CiAgICAgbV9jdXJyZW50 VHJhbnNmb3JtLnNldExvY2FsVHJhbnNmb3JtKG1hdHJpeCk7CiB9CiAKIHZvaWQgVGV4dHVyZU1h cHBlckxheWVyOjpzZXRBbmltYXRlZE9wYWNpdHkoZmxvYXQgb3BhY2l0eSkKIHsKLSAgICBtX3No b3VsZFVwZGF0ZUN1cnJlbnRPcGFjaXR5RnJvbUdyYXBoaWNzTGF5ZXIgPSBmYWxzZTsKICAgICBt X2N1cnJlbnRPcGFjaXR5ID0gb3BhY2l0eTsKIH0KIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykK IHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpzZXRBbmltYXRlZEZpbHRlcnMoY29uc3QgRmlsdGVy T3BlcmF0aW9ucyYgZmlsdGVycykKIHsKLSAgICBtX3Nob3VsZFVwZGF0ZUN1cnJlbnRGaWx0ZXJz RnJvbUdyYXBoaWNzTGF5ZXIgPSBmYWxzZTsKICAgICBtX2N1cnJlbnRGaWx0ZXJzID0gZmlsdGVy czsKIH0KIApAQCAtNTc2LDEzICs1NzMsMTMgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmFw cGx5QW5pbWF0aW9uc1JlY3Vyc2l2ZWx5KCkKIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpzeW5j QW5pbWF0aW9ucygpCiB7CiAgICAgbV9hbmltYXRpb25zLmFwcGx5KHRoaXMpOwotICAgIGlmICgh bV9hbmltYXRpb25zLmhhc0FjdGl2ZUFuaW1hdGlvbnNPZlR5cGUoQW5pbWF0ZWRQcm9wZXJ0eVdl YmtpdFRyYW5zZm9ybSkgJiYgbV9zaG91bGRVcGRhdGVDdXJyZW50VHJhbnNmb3JtRnJvbUdyYXBo aWNzTGF5ZXIpCisgICAgaWYgKCFtX2FuaW1hdGlvbnMuaGFzQWN0aXZlQW5pbWF0aW9uc09mVHlw ZShBbmltYXRlZFByb3BlcnR5V2Via2l0VHJhbnNmb3JtKSkKICAgICAgICAgbV9jdXJyZW50VHJh bnNmb3JtLnNldExvY2FsVHJhbnNmb3JtKG1fc3RhdGUudHJhbnNmb3JtKTsKLSAgICBpZiAoIW1f YW5pbWF0aW9ucy5oYXNBY3RpdmVBbmltYXRpb25zT2ZUeXBlKEFuaW1hdGVkUHJvcGVydHlPcGFj aXR5KSAmJiBtX3Nob3VsZFVwZGF0ZUN1cnJlbnRPcGFjaXR5RnJvbUdyYXBoaWNzTGF5ZXIpCisg ICAgaWYgKCFtX2FuaW1hdGlvbnMuaGFzQWN0aXZlQW5pbWF0aW9uc09mVHlwZShBbmltYXRlZFBy b3BlcnR5T3BhY2l0eSkpCiAgICAgICAgIG1fY3VycmVudE9wYWNpdHkgPSBtX3N0YXRlLm9wYWNp dHk7CiAKICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCi0gICAgaWYgKCFtX2FuaW1hdGlvbnMuaGFz QWN0aXZlQW5pbWF0aW9uc09mVHlwZShBbmltYXRlZFByb3BlcnR5V2Via2l0RmlsdGVyKSAmJiBt X3Nob3VsZFVwZGF0ZUN1cnJlbnRGaWx0ZXJzRnJvbUdyYXBoaWNzTGF5ZXIpCisgICAgaWYgKCFt X2FuaW1hdGlvbnMuaGFzQWN0aXZlQW5pbWF0aW9uc09mVHlwZShBbmltYXRlZFByb3BlcnR5V2Vi a2l0RmlsdGVyKSkKICAgICAgICAgbV9jdXJyZW50RmlsdGVycyA9IG1fc3RhdGUuZmlsdGVyczsK ICNlbmRpZgogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5oCmluZGV4IGY2YjcyYTMyNWJiODViZTAx Zjg5MmMzNzljMmI3MDc2ZDE2NjA0ZTQuLjYxZmI4Mjc2NzA4NjAzZTExMGZhY2VkNDE4OWRiN2Rh MGJjMDMxZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmgKQEAgLTQ0LDExICs0NCw2IEBAIHB1 YmxpYzoKICAgICAgICAgLCBtX2NvbnRlbnRzTGF5ZXIoMCkKICAgICAgICAgLCBtX2N1cnJlbnRP cGFjaXR5KDEpCiAgICAgICAgICwgbV9jZW50ZXJaKDApCi0gICAgICAgICwgbV9zaG91bGRVcGRh dGVDdXJyZW50VHJhbnNmb3JtRnJvbUdyYXBoaWNzTGF5ZXIodHJ1ZSkKLSAgICAgICAgLCBtX3No b3VsZFVwZGF0ZUN1cnJlbnRPcGFjaXR5RnJvbUdyYXBoaWNzTGF5ZXIodHJ1ZSkKLSNpZiBFTkFC TEUoQ1NTX0ZJTFRFUlMpCi0gICAgICAgICwgbV9zaG91bGRVcGRhdGVDdXJyZW50RmlsdGVyc0Zy b21HcmFwaGljc0xheWVyKHRydWUpCi0jZW5kaWYKICAgICAgICAgLCBtX3RleHR1cmVNYXBwZXIo MCkKICAgICAgICAgLCBtX2ZpeGVkVG9WaWV3cG9ydChmYWxzZSkKICAgICB7IH0KQEAgLTE0OSwx MiArMTQ0LDYgQEAgcHJpdmF0ZToKICAgICBGaWx0ZXJPcGVyYXRpb25zIG1fY3VycmVudEZpbHRl cnM7CiAjZW5kaWYKICAgICBmbG9hdCBtX2NlbnRlclo7Ci0gICAgCi0gICAgYm9vbCBtX3Nob3Vs ZFVwZGF0ZUN1cnJlbnRUcmFuc2Zvcm1Gcm9tR3JhcGhpY3NMYXllcjsKLSAgICBib29sIG1fc2hv dWxkVXBkYXRlQ3VycmVudE9wYWNpdHlGcm9tR3JhcGhpY3NMYXllcjsKLSNpZiBFTkFCTEUoQ1NT X0ZJTFRFUlMpCi0gICAgYm9vbCBtX3Nob3VsZFVwZGF0ZUN1cnJlbnRGaWx0ZXJzRnJvbUdyYXBo aWNzTGF5ZXI7Ci0jZW5kaWYKIAogICAgIHN0cnVjdCBTdGF0ZSB7CiAgICAgICAgIEZsb2F0UG9p bnQgcG9zOwo=