110678 2013-02-22 18:28:07 -0800 Correct InspectorInstrumentation for background HTML parser 2013-02-22 20:05:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 tonyg tonyg abarth eric esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 840225 0 tonyg 2013-02-22 18:28:07 -0800 Correct InspectorInstrumentation for background HTML parser 840229 1 189889 tonyg 2013-02-22 18:31:40 -0800 Created attachment 189889 Patch 840255 2 189889 webkit.review.bot 2013-02-22 19:16:25 -0800 Comment on attachment 189889 Patch Clearing flags on attachment: 189889 Committed r143828: <http://trac.webkit.org/changeset/143828> 840256 3 webkit.review.bot 2013-02-22 19:16:28 -0800 All reviewed patches have been landed. Closing bug. 840275 4 189889 eric 2013-02-22 20:05:00 -0800 Comment on attachment 189889 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189889&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:316 > + InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, lineNumber().zeroBasedInt()); This should be trivial to fix, if we add it to the chuck struct passed from the background. :) 840276 5 eric 2013-02-22 20:05:11 -0800 Thanks for doing this. :) 189889 2013-02-22 18:31:40 -0800 2013-02-22 20:05:00 -0800 Patch bug-110678-20130222182759.patch text/plain 4468 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE0OWRkNDEyYmNhMjFm ZDFjM2M4MTA5NTMzMDQ3MjVjY2Y0YzQ5NS4uNzJkMjA0NDljYjlkMGFjZmI5M2I2NmNlODRkMWE3 ZDk0YzZiMDlhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTIyICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ29ycmVjdCBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb24gZm9yIGJhY2tncm91bmQgSFRNTCBwYXJzZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlc3VtZVBhcnNpbmdBZnRl clNjcmlwdEV4ZWN1dGlvbiBwb3RlbnRpYWxseSBjYWxscyBwcm9jZXNzUGFyc2VkQ2h1bmtGcm9t QmFja2dyb3VuZFBhcnNlciBtdWx0aXBsZSB0aW1lcworICAgICAgICB3aXRob3V0IHlpZWxkaW5n LiBTbyBpdCBpcyBub3QgY29ycmVjdCB0byBjb3VudCBlYWNoIG9mIHRob3NlIGFzIGEgc2VwYXJh dGUgUGFyc2VIVE1MIGV2ZW50LgorCisgICAgICAgIFRoaXMgcGF0Y2ggbW92ZXMgdGhlIGluc3Ry dW1lbnRhdGlvbiBvdXRzaWRlIG9mIHRoZSBsb29wLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBi ZWNhdXNlIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRN TERvY3VtZW50UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNl cjo6ZGlkUmVjZWl2ZVBhcnNlZENodW5rRnJvbUJhY2tncm91bmRQYXJzZXIpOgorICAgICAgICAo V2ViQ29yZTo6SFRNTERvY3VtZW50UGFyc2VyOjpwcm9jZXNzUGFyc2VkQ2h1bmtGcm9tQmFja2dy b3VuZFBhcnNlcik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OnJlc3Vt ZVBhcnNpbmdBZnRlclNjcmlwdEV4ZWN1dGlvbik6CisKIDIwMTMtMDItMjIgIERpbWl0cmkgR2xh emtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMzAw ODkpOiBTY3JvbGxiYXIgdGh1bWIgbm8gbG9uZ2VyIHJlLXJlbmRlcmVkIG9uIGhvdmVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcAppbmRl eCBhYmRmZmY0NmFmMzc1ZmY2YmYxN2VkNDA4MTgyNDgwZGI5MmI3NjEzLi5kNmFkZGUwMDNhYTdh Nzc5OThkNTYyYTUxZDAxZDM3Mjk4YTMzMzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHAKQEAgLTMwNyw5ICszMDcsMTkgQEAgdm9p ZCBIVE1MRG9jdW1lbnRQYXJzZXI6OmRpZFJlY2VpdmVQYXJzZWRDaHVua0Zyb21CYWNrZ3JvdW5k UGFyc2VyKFBhc3NPd25QdHI8UGEKICAgICAgICAgbV9zcGVjdWxhdGlvbnMuYXBwZW5kKGNodW5r KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKworICAgIC8vIHByb2Nlc3NQYXJzZWRDaHVua0Zy b21CYWNrZ3JvdW5kUGFyc2VyIGNhbiBjYXVzZSB0aGlzIHBhcnNlciB0byBiZSBkZXRhY2hlZCBm cm9tIHRoZSBEb2N1bWVudCwKKyAgICAvLyBidXQgd2UgbmVlZCB0byBlbnN1cmUgaXQgaXNuJ3Qg ZGVsZXRlZCB5ZXQuCisgICAgUmVmUHRyPEhUTUxEb2N1bWVudFBhcnNlcj4gcHJvdGVjdCh0aGlz KTsKKworICAgIC8vIEZJWE1FOiBQYXNzIGluIGN1cnJlbnQgaW5wdXQgbGVuZ3RoLgorICAgIElu c3BlY3Rvckluc3RydW1lbnRhdGlvbkNvb2tpZSBjb29raWUgPSBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb246OndpbGxXcml0ZUhUTUwoZG9jdW1lbnQoKSwgMCwgbGluZU51bWJlcigpLnplcm9CYXNl ZEludCgpKTsKKwogICAgIEFTU0VSVChtX3NwZWN1bGF0aW9ucy5pc0VtcHR5KCkpOwogICAgIGNo dW5rLT5wcmVsb2Fkcy5jbGVhcigpOyAvLyBXZSBkb24ndCBuZWVkIHRvIHByZWxvYWQgYmVjYXVz ZSB3ZSdyZSBnb2luZyB0byBwYXJzZSBpbW1lZGlhdGVseS4KICAgICBwcm9jZXNzUGFyc2VkQ2h1 bmtGcm9tQmFja2dyb3VuZFBhcnNlcihjaHVuayk7CisKKyAgICBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb246OmRpZFdyaXRlSFRNTChjb29raWUsIGxpbmVOdW1iZXIoKS56ZXJvQmFzZWRJbnQoKSk7 CiB9CiAKIHZvaWQgSFRNTERvY3VtZW50UGFyc2VyOjpjaGVja0ZvclNwZWN1bGF0aW9uRmFpbHVy ZSgpCkBAIC0zNDcsMTggKzM1NywxMSBAQCB2b2lkIEhUTUxEb2N1bWVudFBhcnNlcjo6cHJvY2Vz c1BhcnNlZENodW5rRnJvbUJhY2tncm91bmRQYXJzZXIoUGFzc093blB0cjxQYXJzZQogewogICAg IEFTU0VSVChzaG91bGRVc2VUaHJlYWRpbmcoKSk7CiAKLSAgICAvLyBUaGlzIG1ldGhvZCBjYW4g Y2F1c2UgdGhpcyBwYXJzZXIgdG8gYmUgZGV0YWNoZWQgZnJvbSB0aGUgRG9jdW1lbnQsCi0gICAg Ly8gYnV0IHdlIG5lZWQgdG8gZW5zdXJlIGl0IGlzbid0IGRlbGV0ZWQgeWV0LgotICAgIFJlZlB0 cjxIVE1MRG9jdW1lbnRQYXJzZXI+IHByb3RlY3QodGhpcyk7Ci0KICAgICBBY3RpdmVQYXJzZXJT ZXNzaW9uIHNlc3Npb24oY29udGV4dEZvclBhcnNpbmdTZXNzaW9uKCkpOwogCiAgICAgbV9jdXJy ZW50Q2h1bmsgPSBjaHVuazsKICAgICBPd25QdHI8Q29tcGFjdEhUTUxUb2tlblN0cmVhbT4gdG9r ZW5zID0gbV9jdXJyZW50Q2h1bmstPnRva2Vucy5yZWxlYXNlKCk7CiAKLSAgICAvLyBGSVhNRTog UGFzcyBpbiBjdXJyZW50IGlucHV0IGxlbmd0aC4KLSAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRp b25Db29raWUgY29va2llID0gSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsV3JpdGVIVE1M KGRvY3VtZW50KCksIDAsIGxpbmVOdW1iZXIoKS56ZXJvQmFzZWRJbnQoKSk7Ci0KICAgICBmb3Ig KFZlY3RvcjxDb21wYWN0SFRNTFRva2VuPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSB0b2tlbnMtPmJl Z2luKCk7IGl0ICE9IHRva2Vucy0+ZW5kKCk7ICsraXQpIHsKICAgICAgICAgQVNTRVJUKCFpc1dh aXRpbmdGb3JTY3JpcHRzKCkpOwogCkBAIC0zODksOCArMzkyLDYgQEAgdm9pZCBIVE1MRG9jdW1l bnRQYXJzZXI6OnByb2Nlc3NQYXJzZWRDaHVua0Zyb21CYWNrZ3JvdW5kUGFyc2VyKFBhc3NPd25Q dHI8UGFyc2UKICAgICB9CiAKICAgICBjaGVja0ZvclNwZWN1bGF0aW9uRmFpbHVyZSgpOwotCi0g ICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRXcml0ZUhUTUwoY29va2llLCBsaW5lTnVt YmVyKCkuemVyb0Jhc2VkSW50KCkpOwogfQogCiAjZW5kaWYgLy8gRU5BQkxFKFRIUkVBREVEX0hU TUxfUEFSU0VSKQpAQCAtNzkxLDExICs3OTIsMjEgQEAgdm9pZCBIVE1MRG9jdW1lbnRQYXJzZXI6 OnJlc3VtZVBhcnNpbmdBZnRlclNjcmlwdEV4ZWN1dGlvbigpCiAgICAgaWYgKG1faGF2ZUJhY2tn cm91bmRQYXJzZXIpIHsKICAgICAgICAgY2hlY2tGb3JTcGVjdWxhdGlvbkZhaWx1cmUoKTsKIAor ICAgICAgICAvLyBwcm9jZXNzUGFyc2VkQ2h1bmtGcm9tQmFja2dyb3VuZFBhcnNlciBjYW4gY2F1 c2UgdGhpcyBwYXJzZXIgdG8gYmUgZGV0YWNoZWQgZnJvbSB0aGUgRG9jdW1lbnQsCisgICAgICAg IC8vIGJ1dCB3ZSBuZWVkIHRvIGVuc3VyZSBpdCBpc24ndCBkZWxldGVkIHlldC4KKyAgICAgICAg UmVmUHRyPEhUTUxEb2N1bWVudFBhcnNlcj4gcHJvdGVjdCh0aGlzKTsKKworICAgICAgICAvLyBG SVhNRTogUGFzcyBpbiBjdXJyZW50IGlucHV0IGxlbmd0aC4KKyAgICAgICAgSW5zcGVjdG9ySW5z dHJ1bWVudGF0aW9uQ29va2llIGNvb2tpZSA9IEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6d2ls bFdyaXRlSFRNTChkb2N1bWVudCgpLCAwLCBsaW5lTnVtYmVyKCkuemVyb0Jhc2VkSW50KCkpOwor CiAgICAgICAgIHdoaWxlICghbV9zcGVjdWxhdGlvbnMuaXNFbXB0eSgpKSB7CiAgICAgICAgICAg ICBwcm9jZXNzUGFyc2VkQ2h1bmtGcm9tQmFja2dyb3VuZFBhcnNlcihtX3NwZWN1bGF0aW9ucy50 YWtlRmlyc3QoKSk7CiAgICAgICAgICAgICBpZiAoaXNXYWl0aW5nRm9yU2NyaXB0cygpIHx8IGlz U3RvcHBlZCgpKQotICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgfQorCisgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkV3Jp dGVIVE1MKGNvb2tpZSwgbGluZU51bWJlcigpLnplcm9CYXNlZEludCgpKTsKKwogICAgICAgICBy ZXR1cm47CiAgICAgfQogI2VuZGlmCg==