110677 2013-02-22 18:23:33 -0800 IndexedDB: Histogram all exits from IDBBackingStore::open 2013-02-28 11:06:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110675 110820 1 dgrogan dgrogan alecflett buildbot jsbell rniwa tony webkit.review.bot oldest_to_newest 840224 0 dgrogan 2013-02-22 18:23:33 -0800 IndexedDB: Assert that IDBBackingStore::open's fallthrough path is not entered 840230 1 189890 dgrogan 2013-02-22 18:33:35 -0800 Created attachment 189890 Patch 840238 2 dgrogan 2013-02-22 18:43:09 -0800 Josh or Alec, could you take a look? IO error on schema check and failed openInMemory were the last two situations caught by the fallthrough that is now histogrammed as UnknownErr. 840263 3 189890 jsbell 2013-02-22 19:33:39 -0800 Comment on attachment 189890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189890&action=review lgtm > Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:374 > + if (db) Restructure this as an early exit to reduce the amount of nesting? if (!db) { blah; return; } blah; ... but it's not a huge win here. 840272 4 189890 dgrogan 2013-02-22 19:48:52 -0800 Comment on attachment 189890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189890&action=review >> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:374 >> + if (db) > > Restructure this as an early exit to reduce the amount of nesting? > > if (!db) { > blah; > return; > } > blah; > > ... but it's not a huge win here. Done. 840273 5 189901 dgrogan 2013-02-22 19:49:46 -0800 Created attachment 189901 Patch 840274 6 dgrogan 2013-02-22 19:50:35 -0800 Tony, could you review this? 840301 7 189901 buildbot 2013-02-22 21:56:49 -0800 Comment on attachment 189901 Patch Attachment 189901 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16714498 New failing tests: fast/css/sticky/sticky-both-sides.html fast/css/sticky/inline-sticky.html 841047 8 189901 tony 2013-02-25 09:52:29 -0800 Comment on attachment 189901 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189901&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * Modules/indexeddb/IDBBackingStore.cpp: Nit: You should still have a line here saying why there is no test. E.g., No tests because this only changes logging code. In the long run, we may want to come up with a way to write a test for this in webkit_unit_tests. 844194 9 190751 dgrogan 2013-02-28 10:24:57 -0800 Created attachment 190751 Patch for landing 844196 10 dgrogan 2013-02-28 10:26:05 -0800 (In reply to comment #8) > (From update of attachment 189901 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189901&action=review > > > Source/WebCore/ChangeLog:8 > > + Reviewed by NOBODY (OOPS!). > > + > > + * Modules/indexeddb/IDBBackingStore.cpp: > > Nit: You should still have a line here saying why there is no test. E.g., No tests because this only changes logging code. In the long run, we may want to come up with a way to write a test for this in webkit_unit_tests. Done. 844237 11 190751 webkit.review.bot 2013-02-28 11:06:05 -0800 Comment on attachment 190751 Patch for landing Clearing flags on attachment: 190751 Committed r144330: <http://trac.webkit.org/changeset/144330> 844238 12 webkit.review.bot 2013-02-28 11:06:09 -0800 All reviewed patches have been landed. Closing bug. 189890 2013-02-22 18:33:35 -0800 2013-02-22 19:49:45 -0800 Patch bug-110677-20130222182954.patch text/plain 3251 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZhNDBhNDAyZjNjZjhi ZWZiZDdjYzI2NDJkMDRmNzQ3ODllN2E0OC4uYTIwZDRhNmE4MzdmZGMxMzAwNjg0YzliOGVjYmIz MjZkZjU2NDRkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTIyICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEhp c3RvZ3JhbSBhbGwgZXhpdHMgZnJvbSBJREJCYWNraW5nU3RvcmU6Om9wZW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIv SURCQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6 b3Blbik6CisKIDIwMTMtMDItMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgW1dLMl0gVGhlIHJvb3QgYW5kIHBhZ2Ugb3ZlcmxheSBsYXllcnMgc2hv dWxkIGJlIHRoZSBzaXplIG9mIHRoZSB2aWV3LCBub3QgdGhlIGNvbnRlbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCmluZGV4 IDhjMmQ2MDJjNmY2MjhiMjU3YzI3YmY5NDcxMDlkODZlYTdiNmM3N2QuLjQyY2UwNmY2MTQ4NGNi N2JhNzhhM2M2YjI3MGM0NGY3ZWYzYzRmNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcApAQCAtMzQ4LDcgKzM0OCw3IEBA IElEQkJhY2tpbmdTdG9yZTo6fklEQkJhY2tpbmdTdG9yZSgpCiB9CiAKIGVudW0gSURCTGV2ZWxE QkJhY2tpbmdTdG9yZU9wZW5SZXN1bHQgewotICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVu TWVtb3J5LAorICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5U3VjY2VzcywKICAg ICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlblN1Y2Nlc3MsCiAgICAgSURCTGV2ZWxEQkJhY2tp bmdTdG9yZU9wZW5GYWlsZWREaXJlY3RvcnksCiAgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9w ZW5GYWlsZWRVbmtub3duU2NoZW1hLApAQCAtMzU2LDYgKzM1Niw4IEBAIGVudW0gSURCTGV2ZWxE QkJhY2tpbmdTdG9yZU9wZW5SZXN1bHQgewogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVu Q2xlYW51cFJlb3BlbkZhaWxlZCwKICAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkNsZWFu dXBSZW9wZW5TdWNjZXNzLAogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuRmFpbGVkSU9F cnJDaGVja2luZ1NjaGVtYSwKKyAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkZhaWxlZFVu a25vd25FcnIsCisgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NZW1vcnlGYWlsZWQsCiAg ICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NYXgsCiB9OwogCkBAIC0zNjgsOCArMzcwLDE0 IEBAIFBhc3NSZWZQdHI8SURCQmFja2luZ1N0b3JlPiBJREJCYWNraW5nU3RvcmU6Om9wZW4oU2Vj dXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpZ2luCiAgICAgT3duUHRyPExldmVsREJEYXRhYmFzZT4g ZGI7CiAKICAgICBpZiAocGF0aEJhc2UuaXNFbXB0eSgpKSB7Ci0gICAgICAgIEhpc3RvZ3JhbVN1 cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJXZWJDb3JlLkluZGV4ZWREQi5CYWNraW5nU3Rv cmUuT3BlblN0YXR1cyIsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5LCBJREJMZXZl bERCQmFja2luZ1N0b3JlT3Blbk1heCk7CiAgICAgICAgIGRiID0gTGV2ZWxEQkRhdGFiYXNlOjpv cGVuSW5NZW1vcnkoY29tcGFyYXRvci5nZXQoKSk7CisgICAgICAgIGlmIChkYikKKyAgICAgICAg ICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJXZWJDb3JlLkluZGV4 ZWREQi5CYWNraW5nU3RvcmUuT3BlblN0YXR1cyIsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVu TWVtb3J5U3VjY2VzcywgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NYXgpOworICAgICAgICBl bHNlIHsKKyAgICAgICAgICAgIExPR19FUlJPUigiTGV2ZWxEQkRhdGFiYXNlOjpvcGVuSW5NZW1v cnkgZmFpbGVkLiIpOworICAgICAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51 bWVyYXRpb24oIldlYkNvcmUuSW5kZXhlZERCLkJhY2tpbmdTdG9yZS5PcGVuU3RhdHVzIiwgSURC TGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NZW1vcnlGYWlsZWQsIElEQkxldmVsREJCYWNraW5nU3Rv cmVPcGVuTWF4KTsKKyAgICAgICAgICAgIHJldHVybiBQYXNzUmVmUHRyPElEQkJhY2tpbmdTdG9y ZT4oKTsKKyAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmICghbWFrZUFsbERpcmVj dG9yaWVzKHBhdGhCYXNlKSkgewogICAgICAgICAgICAgTE9HX0VSUk9SKCJVbmFibGUgdG8gY3Jl YXRlIEluZGV4ZWREQiBkYXRhYmFzZSBwYXRoICVzIiwgcGF0aEJhc2UudXRmOCgpLmRhdGEoKSk7 CkBAIC00MTcsOCArNDI1LDExIEBAIFBhc3NSZWZQdHI8SURCQmFja2luZ1N0b3JlPiBJREJCYWNr aW5nU3RvcmU6Om9wZW4oU2VjdXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpZ2luCiAgICAgICAgIH0K ICAgICB9CiAKLSAgICBpZiAoIWRiKQorICAgIGlmICghZGIpIHsKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0 aW9uKCJXZWJDb3JlLkluZGV4ZWREQi5CYWNraW5nU3RvcmUuT3BlblN0YXR1cyIsIElEQkxldmVs REJCYWNraW5nU3RvcmVPcGVuRmFpbGVkVW5rbm93bkVyciwgSURCTGV2ZWxEQkJhY2tpbmdTdG9y ZU9wZW5NYXgpOwogICAgICAgICByZXR1cm4gUGFzc1JlZlB0cjxJREJCYWNraW5nU3RvcmU+KCk7 CisgICAgfQogCiAgICAgLy8gRklYTUU6IEhhbmRsZSBjb21wYXJhdG9yIG5hbWUgY2hhbmdlcy4K IAo= 189901 2013-02-22 19:49:46 -0800 2013-02-28 10:24:55 -0800 Patch bug-110677-20130222194605.patch text/plain 3234 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZhNDBhNDAyZjNjZjhi ZWZiZDdjYzI2NDJkMDRmNzQ3ODllN2E0OC4uYTIwZDRhNmE4MzdmZGMxMzAwNjg0YzliOGVjYmIz MjZkZjU2NDRkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTIyICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEhp c3RvZ3JhbSBhbGwgZXhpdHMgZnJvbSBJREJCYWNraW5nU3RvcmU6Om9wZW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIv SURCQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6 b3Blbik6CisKIDIwMTMtMDItMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgW1dLMl0gVGhlIHJvb3QgYW5kIHBhZ2Ugb3ZlcmxheSBsYXllcnMgc2hv dWxkIGJlIHRoZSBzaXplIG9mIHRoZSB2aWV3LCBub3QgdGhlIGNvbnRlbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCmluZGV4 IDhjMmQ2MDJjNmY2MjhiMjU3YzI3YmY5NDcxMDlkODZlYTdiNmM3N2QuLmI4Y2MwM2YwZjJiZTY1 NGU5ZTI1MTg2OWI4Yzg0ODZkZDcxZjZiNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcApAQCAtMzQ4LDcgKzM0OCw3IEBA IElEQkJhY2tpbmdTdG9yZTo6fklEQkJhY2tpbmdTdG9yZSgpCiB9CiAKIGVudW0gSURCTGV2ZWxE QkJhY2tpbmdTdG9yZU9wZW5SZXN1bHQgewotICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVu TWVtb3J5LAorICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5U3VjY2VzcywKICAg ICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlblN1Y2Nlc3MsCiAgICAgSURCTGV2ZWxEQkJhY2tp bmdTdG9yZU9wZW5GYWlsZWREaXJlY3RvcnksCiAgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9w ZW5GYWlsZWRVbmtub3duU2NoZW1hLApAQCAtMzU2LDYgKzM1Niw4IEBAIGVudW0gSURCTGV2ZWxE QkJhY2tpbmdTdG9yZU9wZW5SZXN1bHQgewogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVu Q2xlYW51cFJlb3BlbkZhaWxlZCwKICAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkNsZWFu dXBSZW9wZW5TdWNjZXNzLAogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuRmFpbGVkSU9F cnJDaGVja2luZ1NjaGVtYSwKKyAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkZhaWxlZFVu a25vd25FcnIsCisgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NZW1vcnlGYWlsZWQsCiAg ICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NYXgsCiB9OwogCkBAIC0zNjgsOCArMzcwLDEz IEBAIFBhc3NSZWZQdHI8SURCQmFja2luZ1N0b3JlPiBJREJCYWNraW5nU3RvcmU6Om9wZW4oU2Vj dXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpZ2luCiAgICAgT3duUHRyPExldmVsREJEYXRhYmFzZT4g ZGI7CiAKICAgICBpZiAocGF0aEJhc2UuaXNFbXB0eSgpKSB7Ci0gICAgICAgIEhpc3RvZ3JhbVN1 cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJXZWJDb3JlLkluZGV4ZWREQi5CYWNraW5nU3Rv cmUuT3BlblN0YXR1cyIsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5LCBJREJMZXZl bERCQmFja2luZ1N0b3JlT3Blbk1heCk7CiAgICAgICAgIGRiID0gTGV2ZWxEQkRhdGFiYXNlOjpv cGVuSW5NZW1vcnkoY29tcGFyYXRvci5nZXQoKSk7CisgICAgICAgIGlmICghZGIpIHsKKyAgICAg ICAgICAgIExPR19FUlJPUigiTGV2ZWxEQkRhdGFiYXNlOjpvcGVuSW5NZW1vcnkgZmFpbGVkLiIp OworICAgICAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIldl YkNvcmUuSW5kZXhlZERCLkJhY2tpbmdTdG9yZS5PcGVuU3RhdHVzIiwgSURCTGV2ZWxEQkJhY2tp bmdTdG9yZU9wZW5NZW1vcnlGYWlsZWQsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsK KyAgICAgICAgICAgIHJldHVybiBQYXNzUmVmUHRyPElEQkJhY2tpbmdTdG9yZT4oKTsKKyAgICAg ICAgfQorICAgICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiV2Vi Q29yZS5JbmRleGVkREIuQmFja2luZ1N0b3JlLk9wZW5TdGF0dXMiLCBJREJMZXZlbERCQmFja2lu Z1N0b3JlT3Blbk1lbW9yeVN1Y2Nlc3MsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsK ICAgICB9IGVsc2UgewogICAgICAgICBpZiAoIW1ha2VBbGxEaXJlY3RvcmllcyhwYXRoQmFzZSkp IHsKICAgICAgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGNyZWF0ZSBJbmRleGVkREIgZGF0 YWJhc2UgcGF0aCAlcyIsIHBhdGhCYXNlLnV0ZjgoKS5kYXRhKCkpOwpAQCAtNDE3LDggKzQyNCwx MSBAQCBQYXNzUmVmUHRyPElEQkJhY2tpbmdTdG9yZT4gSURCQmFja2luZ1N0b3JlOjpvcGVuKFNl Y3VyaXR5T3JpZ2luKiBzZWN1cml0eU9yaWdpbgogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYg KCFkYikKKyAgICBpZiAoIWRiKSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAg ICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiV2ViQ29yZS5JbmRl eGVkREIuQmFja2luZ1N0b3JlLk9wZW5TdGF0dXMiLCBJREJMZXZlbERCQmFja2luZ1N0b3JlT3Bl bkZhaWxlZFVua25vd25FcnIsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsKICAgICAg ICAgcmV0dXJuIFBhc3NSZWZQdHI8SURCQmFja2luZ1N0b3JlPigpOworICAgIH0KIAogICAgIC8v IEZJWE1FOiBIYW5kbGUgY29tcGFyYXRvciBuYW1lIGNoYW5nZXMuCiAK 190751 2013-02-28 10:24:57 -0800 2013-02-28 11:06:05 -0800 Patch for landing bug-110677-20130228102109.patch text/plain 3333 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwMWE4ZTM5ZWQ1NjM5 NTk0YWNiYWM2MzU5Y2VkZTAyZTRlNjU2ZC4uYzE5NGJmMzAyYjc2NTVlZWRjYmVhN2FhMzQ0ZmUy ZDFmODk4MjYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTAyLTI4ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBJbmRleGVkREI6IEhp c3RvZ3JhbSBhbGwgZXhpdHMgZnJvbSBJREJCYWNraW5nU3RvcmU6Om9wZW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3NworCisgICAgICAgIFJl dmlld2VkIGJ5IFRvbnkgQ2hhbmcuCisKKyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB0aGlzIG9u bHkgY2hhbmdlcyBsb2dnaW5nIGNvZGUuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9J REJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCQmFja2luZ1N0b3JlOjpv cGVuKToKKworMjAxMy0wMi0yOCAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgSW5kZXhlZERCOiBJTyBlcnJvciB3aGVuIGNoZWNraW5nIHNjaGVtYSBzaG91 bGQgZGVzdHJveSBMZXZlbERCIGRpcmVjdG9yeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNjc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCmluZGV4IDIyNjQxYjRiNjlhOWY4 MTZjNTQ2NTJmMzBjY2QzNWFmNWRmZTRlYjYuLjkwOWVlYWU2NjdhMGY3NmY0NDk1NmM1ZTIzMzFm OGJiOTFmM2EyMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvSURCQmFja2luZ1N0b3JlLmNwcApAQCAtMzYwLDcgKzM2MCw3IEBAIElEQkJhY2tpbmdTdG9y ZTo6fklEQkJhY2tpbmdTdG9yZSgpCiB9CiAKIGVudW0gSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9w ZW5SZXN1bHQgewotICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5LAorICAgIElE QkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5U3VjY2VzcywKICAgICBJREJMZXZlbERCQmFj a2luZ1N0b3JlT3BlblN1Y2Nlc3MsCiAgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5GYWls ZWREaXJlY3RvcnksCiAgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5GYWlsZWRVbmtub3du U2NoZW1hLApAQCAtMzY4LDYgKzM2OCw4IEBAIGVudW0gSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9w ZW5SZXN1bHQgewogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuQ2xlYW51cFJlb3BlbkZh aWxlZCwKICAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkNsZWFudXBSZW9wZW5TdWNjZXNz LAogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuRmFpbGVkSU9FcnJDaGVja2luZ1NjaGVt YSwKKyAgICBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkZhaWxlZFVua25vd25FcnIsCisgICAg SURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NZW1vcnlGYWlsZWQsCiAgICAgSURCTGV2ZWxEQkJh Y2tpbmdTdG9yZU9wZW5NYXgsCiB9OwogCkBAIC0zODYsOCArMzg4LDEzIEBAIFBhc3NSZWZQdHI8 SURCQmFja2luZ1N0b3JlPiBJREJCYWNraW5nU3RvcmU6Om9wZW4oU2VjdXJpdHlPcmlnaW4qIHNl Y3VyaXR5T3JpZ2luCiAgICAgT3duUHRyPExldmVsREJEYXRhYmFzZT4gZGI7CiAKICAgICBpZiAo cGF0aEJhc2UuaXNFbXB0eSgpKSB7Ci0gICAgICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3Jh bUVudW1lcmF0aW9uKCJXZWJDb3JlLkluZGV4ZWREQi5CYWNraW5nU3RvcmUuT3BlblN0YXR1cyIs IElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWVtb3J5LCBJREJMZXZlbERCQmFja2luZ1N0b3Jl T3Blbk1heCk7CiAgICAgICAgIGRiID0gTGV2ZWxEQkRhdGFiYXNlOjpvcGVuSW5NZW1vcnkoY29t cGFyYXRvci5nZXQoKSk7CisgICAgICAgIGlmICghZGIpIHsKKyAgICAgICAgICAgIExPR19FUlJP UigiTGV2ZWxEQkRhdGFiYXNlOjpvcGVuSW5NZW1vcnkgZmFpbGVkLiIpOworICAgICAgICAgICAg SGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIldlYkNvcmUuSW5kZXhlZERC LkJhY2tpbmdTdG9yZS5PcGVuU3RhdHVzIiwgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZU9wZW5NZW1v cnlGYWlsZWQsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsKKyAgICAgICAgICAgIHJl dHVybiBQYXNzUmVmUHRyPElEQkJhY2tpbmdTdG9yZT4oKTsKKyAgICAgICAgfQorICAgICAgICBI aXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiV2ViQ29yZS5JbmRleGVkREIu QmFja2luZ1N0b3JlLk9wZW5TdGF0dXMiLCBJREJMZXZlbERCQmFja2luZ1N0b3JlT3Blbk1lbW9y eVN1Y2Nlc3MsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsKICAgICB9IGVsc2Ugewog ICAgICAgICBpZiAoIW1ha2VBbGxEaXJlY3RvcmllcyhwYXRoQmFzZSkpIHsKICAgICAgICAgICAg IExPR19FUlJPUigiVW5hYmxlIHRvIGNyZWF0ZSBJbmRleGVkREIgZGF0YWJhc2UgcGF0aCAlcyIs IHBhdGhCYXNlLnV0ZjgoKS5kYXRhKCkpOwpAQCAtNDM0LDggKzQ0MSwxMSBAQCBQYXNzUmVmUHRy PElEQkJhY2tpbmdTdG9yZT4gSURCQmFja2luZ1N0b3JlOjpvcGVuKFNlY3VyaXR5T3JpZ2luKiBz ZWN1cml0eU9yaWdpbgogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCFkYikKKyAgICBpZiAo IWRiKSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBIaXN0b2dyYW1T dXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiV2ViQ29yZS5JbmRleGVkREIuQmFja2luZ1N0 b3JlLk9wZW5TdGF0dXMiLCBJREJMZXZlbERCQmFja2luZ1N0b3JlT3BlbkZhaWxlZFVua25vd25F cnIsIElEQkxldmVsREJCYWNraW5nU3RvcmVPcGVuTWF4KTsKICAgICAgICAgcmV0dXJuIFBhc3NS ZWZQdHI8SURCQmFja2luZ1N0b3JlPigpOworICAgIH0KIAogICAgIC8vIEZJWE1FOiBIYW5kbGUg Y29tcGFyYXRvciBuYW1lIGNoYW5nZXMuCiAK