110673 2013-02-22 18:00:02 -0800 RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset() 2023-07-16 03:45:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=259260 InRadar P2 Normal --- 111278 1 bdakin bdakin abarth bdakin eric esprehn+autocc ojan.autocc sam simon.fraser webkit.review.bot oldest_to_newest 840201 0 bdakin 2013-02-22 18:00:02 -0800 Right now, FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like http://instagram.com/p/UrCCIVBQX3/ because they have overflow on the body. We can easily address this by calling it at the end of RenderLayer::scrollTo(). <rdar://problem/13258596> 840207 1 189884 bdakin 2013-02-22 18:03:46 -0800 Created attachment 189884 Patch 840212 2 189884 bdakin 2013-02-22 18:05:27 -0800 Comment on attachment 189884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189884&action=review > Source/WebCore/ChangeLog:10 > + FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like I have removed the "like" in my local copy. 840218 3 189884 sam 2013-02-22 18:12:22 -0800 Comment on attachment 189884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189884&action=review > Source/WebCore/ChangeLog:6 > + RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset() > + https://bugs.webkit.org/show_bug.cgi?id=110673 > + -and corresponding- > + <rdar://problem/13258596> This is perfect. >> Source/WebCore/ChangeLog:10 >> + FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like > > I have removed the "like" in my local copy. Like totally. 840221 4 bdakin 2013-02-22 18:15:49 -0800 http://trac.webkit.org/changeset/143825 856723 5 abarth 2013-03-17 10:16:00 -0700 This patch might have caused <https://code.google.com/p/chromium/issues/detail?id=193555>. We're investigating. 858004 6 abarth 2013-03-19 00:41:34 -0700 The discussion continues on Bug 111278. The folks there confirm that this patch caused the regression. 858005 7 abarth 2013-03-19 00:43:03 -0700 This patch also lacks a regression test. 858015 8 abarth 2013-03-19 00:59:23 -0700 I rolled out this patch in http://trac.webkit.org/changeset/146185. Please feel free to re-land it once it doesn't cause a regression in the Chromium port. 858719 9 193917 bdakin 2013-03-19 14:14:16 -0700 Created attachment 193917 Patch This patch should not break Chromium. 858743 10 bdakin 2013-03-19 14:33:39 -0700 Thanks, Simon! http://trac.webkit.org/changeset/146260 189884 2013-02-22 18:03:46 -0800 2013-03-19 14:14:16 -0700 Patch for-review.txt text/plain 1836 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzgyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTIyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXJMYXllcjo6c2Nyb2xsVG8o KSBzaG91bGQgY2FsbCBGcmFtZUxvYWRlckNsaWVudDo6ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3Mwor ICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzI1 ODU5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG cmFtZUxvYWRlckNsaWVudDo6ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCkgZG9lc24ndCBnZXQgY2Fs bGVkIGZvciB3ZWIgcGFnZXMgbGlrZSAKKyAgICAgICAgdGhhdCBoYXZlIG92ZXJmbG93IG9uIHRo ZSBib2R5LiBXZSBjYW4gZWFzaWx5IGFkZHJlc3MgdGhpcyBieSBjYWxsaW5nIGl0IGF0IHRoZSAK KyAgICAgICAgZW5kIG9mIFJlbmRlckxheWVyOjpzY3JvbGxUbygpLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpz Y3JvbGxUbyk6CisKIDIwMTMtMDItMjIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgV2ViS2l0IGNhbiBlcnJvbmVvdXNseSBzdHJpcCBmb250LXNpemUgQ1NTIHBy b3BlcnR5IGZyb20gZm9udCBlbGVtZW50IHdpdGggc2l6ZSBhdHRyaWJ1dGUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gMTQzNzUyKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjAsNiArNjAsNyBAQAogI2luY2x1ZGUgIkZsb2F0UmVjdC5oIgogI2luY2x1ZGUgIkZvY3Vz Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCisjaW5jbHVkZSAiRnJhbWVMb2FkZXJD bGllbnQuaCIKICNpbmNsdWRlICJGcmFtZVNlbGVjdGlvbi5oIgogI2luY2x1ZGUgIkZyYW1lVHJl ZS5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgpAQCAtMjEyMyw2ICsyMTI0LDcgQEAgdm9pZCBS ZW5kZXJMYXllcjo6c2Nyb2xsVG8oaW50IHgsIGludCB5KQogICAgICAgICByZW5kZXJlcigpLT5u b2RlKCktPmRvY3VtZW50KCktPmV2ZW50UXVldWUoKS0+ZW5xdWV1ZU9yRGlzcGF0Y2hTY3JvbGxF dmVudChyZW5kZXJlcigpLT5ub2RlKCksIERvY3VtZW50RXZlbnRRdWV1ZTo6U2Nyb2xsRXZlbnRF bGVtZW50VGFyZ2V0KTsKIAogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkU2Nyb2xs TGF5ZXIoZnJhbWUpOworICAgIGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRpZENoYW5nZVNj cm9sbE9mZnNldCgpOwogfQogCiBzdGF0aWMgaW5saW5lIGJvb2wgZnJhbWVFbGVtZW50QW5kVmll d1Blcm1pdFNjcm9sbChIVE1MRnJhbWVFbGVtZW50KiBmcmFtZUVsZW1lbnQsIEZyYW1lVmlldyog ZnJhbWVWaWV3KSAK 193917 2013-03-19 14:14:16 -0700 2013-03-19 14:31:43 -0700 Patch for-review.txt text/plain 1480 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjI1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTE5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXJMYXllcjo6c2Nyb2xsVG8o KSBzaG91bGQgY2FsbCBGcmFtZUxvYWRlckNsaWVudDo6ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY3Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyYW1lTG9h ZGVyQ2xpZW50OjpkaWRDaGFuZ2VTY3JvbGxPZmZzZXQoKSBzaG91bGQgYmUgY2FsbGVkIHdoZW5l dmVyIHNvbWV0aGluZyBpcyAKKyAgICAgICAgYWN0dWFsbHkgYmVpbmcgc2Nyb2xsZWQuIAorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyOjpzY3JvbGxUbyk6CisKIDIwMTMtMDMtMTkgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBHZW5lcmF0ZUhhc2hWYWx1ZSBzaG91bGQgYmUgdXNhYmxl IG91dHNpZGUgQ29kZUdlbmVyYXRvckpTLnBtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDE0NjIzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMTQsNiArMjIxNCw4 IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnNjcm9sbFRvKGludCB4LCBpbnQgeSkKICAgICAgICAgcmVu ZGVyZXIoKS0+bm9kZSgpLT5kb2N1bWVudCgpLT5ldmVudFF1ZXVlKCktPmVucXVldWVPckRpc3Bh dGNoU2Nyb2xsRXZlbnQocmVuZGVyZXIoKS0+bm9kZSgpLCBEb2N1bWVudEV2ZW50UXVldWU6OlNj cm9sbEV2ZW50RWxlbWVudFRhcmdldCk7CiAKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246 OmRpZFNjcm9sbExheWVyKGZyYW1lKTsKKyAgICBpZiAoc2Nyb2xsc092ZXJmbG93KCkpCisgICAg ICAgIGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRpZENoYW5nZVNjcm9sbE9mZnNldCgpOyAK IH0KIAogc3RhdGljIGlubGluZSBib29sIGZyYW1lRWxlbWVudEFuZFZpZXdQZXJtaXRTY3JvbGwo SFRNTEZyYW1lRWxlbWVudCogZnJhbWVFbGVtZW50LCBGcmFtZVZpZXcqIGZyYW1lVmlldykgCg==