110668 2013-02-22 17:31:01 -0800 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached 2013-02-22 18:56:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddorwin ddorwin abarth tkent webkit.review.bot oldest_to_newest 840159 0 ddorwin 2013-02-22 17:31:01 -0800 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached 840163 1 189874 ddorwin 2013-02-22 17:34:04 -0800 Created attachment 189874 Patch 840171 2 ddorwin 2013-02-22 17:35:55 -0800 abarth, as discussed - PTAL. tkent, FYI, WebPagePopupImpl might also need this change, though it just calls to an empty client. 840178 3 189874 abarth 2013-02-22 17:42:15 -0800 Comment on attachment 189874 Patch Ok. For the folks reading along, we talked a bit about this issue in person. Currently our plan is for the helper plugin to participate in as little of the lifecycle as possible. If run into more of these sorts of issues, we should consider changing the design to use the shadow DOM rather than implementing the helper plugin in the WebKit layer. 840249 4 189874 webkit.review.bot 2013-02-22 18:56:29 -0800 Comment on attachment 189874 Patch Clearing flags on attachment: 189874 Committed r143827: <http://trac.webkit.org/changeset/143827> 840250 5 webkit.review.bot 2013-02-22 18:56:32 -0800 All reviewed patches have been landed. Closing bug. 189874 2013-02-22 17:34:04 -0800 2013-02-22 18:56:29 -0800 Patch bug-110668-20130222173023.patch text/plain 1326 ddorwin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGEyMjA1YjZjNDBhZTZmYjA0NGQ4ZWNmYTdiMDE0MTliMzkzZGQ3ZWQuLjI1ZjQ1NTQ3OTA0ODAx ZGZlMTNiMGU3ZjA3ZDlhZDFjYzRkODU2ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDItMjIgIERhdmlkIERvcndpbiAgPGRkb3J3aW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGNhbGwgdG8gZGV0YWNoIFdlYkhl bHBlclBsdWdpbkltcGwncyBmcmFtZSBzaW5jZSBpdCBpcyBuZXZlciBhdHRhY2hlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNjY4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaXhlcyBodHRw Oi8vY3JidWcuY29tLzE3Mjc2NAorCisgICAgICAgICogc3JjL1dlYkhlbHBlclBsdWdpbkltcGwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJIZWxwZXJQbHVnaW5JbXBsOjpkZXN0b3J5UGFnZSk6 CisKIDIwMTMtMDItMjIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDM3MzQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJIZWxwZXJQbHVnaW5JbXBsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkhlbHBlclBsdWdpbkltcGwuY3BwCmluZGV4IGIy NDJmOGZmMTVmODlhYjI4NjU0MzllY2RiODZlY2M2Mjk2YmM2OWQuLjlhZjc5NGM3MDc5YTdjNTk4 ZDkyNmFjMGVjOTk5ZGI4NDRjODhmZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkhlbHBlclBsdWdpbkltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkhlbHBlclBsdWdpbkltcGwuY3BwCkBAIC0yMDksOSArMjA5LDYgQEAgdm9pZCBX ZWJIZWxwZXJQbHVnaW5JbXBsOjpkZXN0b3J5UGFnZSgpCiAgICAgaWYgKCFtX3BhZ2UpCiAgICAg ICAgIHJldHVybjsKIAotICAgIGlmIChtX3BhZ2UtPm1haW5GcmFtZSgpKQotICAgICAgICBtX3Bh Z2UtPm1haW5GcmFtZSgpLT5sb2FkZXIoKS0+ZnJhbWVEZXRhY2hlZCgpOwotCiAgICAgbV9wYWdl LmNsZWFyKCk7CiB9CiAK