110666 2013-02-22 17:15:08 -0800 [V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom() 2013-02-26 21:13:00 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 840147 0 haraken 2013-02-22 17:15:08 -0800 Event::dataTransferAttrGetterCustom() is not used (i.e. the custom method is not registered to V8). Event::valueAttrSetterCustom() is declared but not implemented. We can remove them. 840148 1 189870 haraken 2013-02-22 17:16:33 -0800 Created attachment 189870 Patch 842659 2 189870 abarth 2013-02-26 20:59:17 -0800 Comment on attachment 189870 Patch ok 842666 3 189870 webkit.review.bot 2013-02-26 21:12:57 -0800 Comment on attachment 189870 Patch Clearing flags on attachment: 189870 Committed r144142: <http://trac.webkit.org/changeset/144142> 842667 4 webkit.review.bot 2013-02-26 21:13:00 -0800 All reviewed patches have been landed. Closing bug. 189870 2013-02-22 17:16:33 -0800 2013-02-26 21:12:57 -0800 Patch bug-110666-20130222171252.patch text/plain 3189 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTZhZGY3YjVlZDE1ZDZk MGViN2IyZTEyNTY2OGJlMDZiNjRjMzAzZi4uMmJjMjhlYzkxZDU4Njk1OWMwOWM1ZjJhNjAzMWJh ZmY4YjlmZDY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAyLTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSBF dmVudDo6ZGF0YVRyYW5zZmVyQXR0ckdldHRlckN1c3RvbSgpIGFuZCBFdmVudDo6dmFsdWVBdHRy U2V0dGVyQ3VzdG9tKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMDY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEV2ZW50OjpkYXRhVHJhbnNmZXJBdHRyR2V0dGVyQ3VzdG9tKCkgaXMgbm90IHVzZWQK KyAgICAgICAgKGkuZS4gdGhlIGN1c3RvbSBtZXRob2QgaXMgbm90IHJlZ2lzdGVyZWQgdG8gVjgp LgorICAgICAgICBFdmVudDo6dmFsdWVBdHRyU2V0dGVyQ3VzdG9tKCkgaXMgZGVjbGFyZWQgYnV0 IG5vdAorICAgICAgICBpbXBsZW1lbnRlZC4gV2UgY2FuIHJlbW92ZSB0aGVtLgorCisgICAgICAg IE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlSGVhZGVyQ3VzdG9t Q2FsbCk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRDdXN0b20uY3BwOgor CisyMDEzLTAyLTIyICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwogICAg ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4gQWRkZWQgbWlzc2luZyAjaWYgUExBVEZPUk0oQ0hS T01JVU0pLgogCiAgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggZmJhZGViMGFi ZjNiNTliNGVmODNmYTYzYWQxYTc4NzkwYmYzMDI4YS4uNjY5MDIzNzU2OWJhNzgzMmY0MTU3NDRl NWYyOWFjODI3MTczY2IzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTcyOCwxMCArNzI4LDYgQEAgc3ViIEdlbmVyYXRl SGVhZGVyQ3VzdG9tQ2FsbAogICAgIGlmICgkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMt PnsiQ3VzdG9tQ2FsbCJ9KSB7CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3Rh dGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjYWxsQXNGdW5jdGlvbkNhbGxiYWNrKGNvbnN0IHY4 OjpBcmd1bWVudHMmKTtcbiIpOwogICAgIH0KLSAgICBpZiAoJGludGVyZmFjZS0+bmFtZSBlcSAi RXZlbnQiKSB7Ci0gICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBkYXRhVHJhbnNmZXJBdHRyR2V0dGVyQ3VzdG9tKHY4OjpMb2NhbDx2 ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJik7XG4iKTsKLSAgICAgICAg cHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgdm9pZCB2YWx1ZUF0dHJTZXR0ZXJDdXN0 b20odjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsIHY4OjpMb2NhbDx2ODo6VmFsdWU+LCBjb25z dCB2ODo6QWNjZXNzb3JJbmZvJik7XG4iKTsKLSAgICB9CiAgICAgaWYgKCRpbnRlcmZhY2UtPm5h bWUgZXEgIkxvY2F0aW9uIikgewogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYXNzaWduQXR0ckdldHRlckN1c3RvbSh2ODo6TG9j YWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYpO1xuIik7CiAgICAg ICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVl PiByZWxvYWRBdHRyR2V0dGVyQ3VzdG9tKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25z dCB2ODo6QWNjZXNzb3JJbmZvJik7XG4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOEV2ZW50Q3VzdG9tLmNwcAppbmRleCBiOWUyYzljYjdkMGI3YTcyNjcw ZDZlOWQ1MDMzYTZmOTU5MWYyYWRhLi4yMzc5YWRiNmYwMjM0YTBjMTE5MGI4MDE4Y2JkZDI5MTJl YjNkMTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhF dmVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 RXZlbnRDdXN0b20uY3BwCkBAIC00MiwxNiArNDIsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEV2ZW50OjpkYXRhVHJhbnNmZXJBdHRyR2V0dGVy Q3VzdG9tKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZv JiBpbmZvKQotewotICAgIEV2ZW50KiBldmVudCA9IFY4RXZlbnQ6OnRvTmF0aXZlKGluZm8uSG9s ZGVyKCkpOwotCi0gICAgaWYgKGV2ZW50LT5pc0RyYWdFdmVudCgpKQotICAgICAgICByZXR1cm4g dG9WOEZhc3Qoc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+KGV2ZW50KS0+Y2xpcGJvYXJkKCksIGlu Zm8sIGV2ZW50KTsKLQotICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Ci19Ci0KIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBWOEV2ZW50OjpjbGlwYm9hcmREYXRhQXR0ckdldHRlckN1c3RvbSh2ODo6 TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbykKIHsK ICAgICBFdmVudCogZXZlbnQgPSBWOEV2ZW50Ojp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsK