110665 2013-02-22 17:01:49 -0800 ResourceRequestBase unnecessarily updates when nothing changes 2013-02-23 23:31:04 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap msaboff webkit.review.bot oldest_to_newest 840139 0 ap 2013-02-22 17:01:49 -0800 ResourceRequestBase likes to set m_platformRequestUpdated to false even if nothing changed. Updating is a very expensive operation, and should be avoided as much as possible. 840144 1 189869 ap 2013-02-22 17:05:31 -0800 Created attachment 189869 proposed patch 840550 2 189869 webkit.review.bot 2013-02-23 23:31:01 -0800 Comment on attachment 189869 proposed patch Clearing flags on attachment: 189869 Committed r143861: <http://trac.webkit.org/changeset/143861> 840551 3 webkit.review.bot 2013-02-23 23:31:04 -0800 All reviewed patches have been landed. Closing bug. 189869 2013-02-22 17:05:31 -0800 2013-02-23 23:31:01 -0800 proposed patch DontMarkDirty.txt text/plain 4010 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzgxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTIyICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlUmVxdWVzdEJh c2UgdW5uZWNlc3NhcmlseSB1cGRhdGVzIHdoZW4gbm90aGluZyBjaGFuZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2NjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBtYXJrIHBsYXRmb3Jt IGRhdGEgZm9yIHVwZGF0ZSBpZiBub3RoaW5nIHJlYWxseSBjaGFuZ2VkLiBUaGlzIGF2b2lkcyBl dmVyIGRvaW5nCisgICAgICAgIGRvVXBkYXRlUGxhdGZvcm1SZXF1ZXN0KCkgaW4gTmV0d29ya1By b2Nlc3MgZHVyaW5nIG5vcm1hbCBicm93c2luZyBmb3IgbWUsIHdoaWNoIGlzCisgICAgICAgIGdv b2QgZm9yIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJj ZVJlcXVlc3RCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdEJhc2U6 OnJlbW92ZUNyZWRlbnRpYWxzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdEJh c2U6OnNldENhY2hlUG9saWN5KToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdEJh c2U6OnNldFRpbWVvdXRJbnRlcnZhbCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVl c3RCYXNlOjpzZXRGaXJzdFBhcnR5Rm9yQ29va2llcyk6CisgICAgICAgIChXZWJDb3JlOjpSZXNv dXJjZVJlcXVlc3RCYXNlOjpzZXRIVFRQTWV0aG9kKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291 cmNlUmVxdWVzdEJhc2U6OmNsZWFySFRUUEF1dGhvcml6YXRpb24pOgorICAgICAgICAoV2ViQ29y ZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6c2V0QWxsb3dDb29raWVzKToKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdEJhc2U6OnNldFByaW9yaXR5KToKKwogMjAxMy0wMi0yMiAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBUaGUg cm9vdCBhbmQgcGFnZSBvdmVybGF5IGxheWVycyBzaG91bGQgYmUgdGhlIHNpemUgb2YgdGhlIHZp ZXcsIG5vdCB0aGUgY29udGVudApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9SZXNvdXJjZVJlcXVlc3RCYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCShyZXZpc2lvbiAxNDM3NTcp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsNiArMTM2LDkgQEAgdm9pZCBSZXNvdXJjZVJlcXVl c3RCYXNlOjpyZW1vdmVDcmVkZW50aQogewogICAgIHVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOyAK IAorICAgIGlmIChtX3VybC51c2VyKCkuaXNFbXB0eSgpICYmIG1fdXJsLnBhc3MoKS5pc0VtcHR5 KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fdXJsLnNldFVzZXIoU3RyaW5nKCkpOwogICAg IG1fdXJsLnNldFBhc3MoU3RyaW5nKCkpOwogCkBAIC0xNTIsNiArMTU1LDkgQEAgUmVzb3VyY2VS ZXF1ZXN0Q2FjaGVQb2xpY3kgUmVzb3VyY2VSZXF1ZQogdm9pZCBSZXNvdXJjZVJlcXVlc3RCYXNl OjpzZXRDYWNoZVBvbGljeShSZXNvdXJjZVJlcXVlc3RDYWNoZVBvbGljeSBjYWNoZVBvbGljeSkK IHsKICAgICB1cGRhdGVSZXNvdXJjZVJlcXVlc3QoKTsgCisKKyAgICBpZiAobV9jYWNoZVBvbGlj eSA9PSBjYWNoZVBvbGljeSkKKyAgICAgICAgcmV0dXJuOwogICAgIAogICAgIG1fY2FjaGVQb2xp Y3kgPSBjYWNoZVBvbGljeTsKICAgICAKQEAgLTE3MCw3ICsxNzYsMTAgQEAgdm9pZCBSZXNvdXJj ZVJlcXVlc3RCYXNlOjpzZXRUaW1lb3V0SW50ZQogewogICAgIHVwZGF0ZVJlc291cmNlUmVxdWVz dCgpOyAKICAgICAKLSAgICBtX3RpbWVvdXRJbnRlcnZhbCA9IHRpbWVvdXRJbnRlcnZhbDsgCisg ICAgaWYgKG1fdGltZW91dEludGVydmFsID09IHRpbWVvdXRJbnRlcnZhbCkKKyAgICAgICAgcmV0 dXJuOworCisgICAgbV90aW1lb3V0SW50ZXJ2YWwgPSB0aW1lb3V0SW50ZXJ2YWw7CiAgICAgCiAg ICAgaWYgKHVybCgpLnByb3RvY29sSXNJbkhUVFBGYW1pbHkoKSkKICAgICAgICAgbV9wbGF0Zm9y bVJlcXVlc3RVcGRhdGVkID0gZmFsc2U7CkBAIC0xODYsNyArMTk1LDEwIEBAIGNvbnN0IEtVUkwm IFJlc291cmNlUmVxdWVzdEJhc2U6OmZpcnN0UGEKIHZvaWQgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6 c2V0Rmlyc3RQYXJ0eUZvckNvb2tpZXMoY29uc3QgS1VSTCYgZmlyc3RQYXJ0eUZvckNvb2tpZXMp CiB7IAogICAgIHVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOyAKLSAgICAKKworICAgIGlmIChtX2Zp cnN0UGFydHlGb3JDb29raWVzID09IGZpcnN0UGFydHlGb3JDb29raWVzKQorICAgICAgICByZXR1 cm47CisKICAgICBtX2ZpcnN0UGFydHlGb3JDb29raWVzID0gZmlyc3RQYXJ0eUZvckNvb2tpZXM7 CiAgICAgCiAgICAgbV9wbGF0Zm9ybVJlcXVlc3RVcGRhdGVkID0gZmFsc2U7CkBAIC0yMDMsNiAr MjE1LDkgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRIVFRQTWV0aG9kKAogewogICAg IHVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOyAKIAorICAgIGlmIChtX2h0dHBNZXRob2QgPT0gaHR0 cE1ldGhvZCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgbV9odHRwTWV0aG9kID0gaHR0cE1ldGhv ZDsKICAgICAKICAgICBpZiAodXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKQpAQCAtMjQ5 LDcgKzI2NCwxMSBAQCB2b2lkIFJlc291cmNlUmVxdWVzdEJhc2U6OmNsZWFySFRUUEF1dGhvCiB7 CiAgICAgdXBkYXRlUmVzb3VyY2VSZXF1ZXN0KCk7IAogCi0gICAgbV9odHRwSGVhZGVyRmllbGRz LnJlbW92ZSgiQXV0aG9yaXphdGlvbiIpOworICAgIEhUVFBIZWFkZXJNYXA6Oml0ZXJhdG9yIGl0 ZXIgPSBtX2h0dHBIZWFkZXJGaWVsZHMuZmluZCgiQXV0aG9yaXphdGlvbiIpOworICAgIGlmIChp dGVyID09IG1faHR0cEhlYWRlckZpZWxkcy5lbmQoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAg bV9odHRwSGVhZGVyRmllbGRzLnJlbW92ZShpdGVyKTsKIAogICAgIGlmICh1cmwoKS5wcm90b2Nv bElzSW5IVFRQRmFtaWx5KCkpCiAgICAgICAgIG1fcGxhdGZvcm1SZXF1ZXN0VXBkYXRlZCA9IGZh bHNlOwpAQCAtMzQ5LDcgKzM2OCwxMCBAQCBib29sIFJlc291cmNlUmVxdWVzdEJhc2U6OmFsbG93 Q29va2llcygpCiB2b2lkIFJlc291cmNlUmVxdWVzdEJhc2U6OnNldEFsbG93Q29va2llcyhib29s IGFsbG93Q29va2llcykKIHsKICAgICB1cGRhdGVSZXNvdXJjZVJlcXVlc3QoKTsgCi0gICAgCisK KyAgICBpZiAobV9hbGxvd0Nvb2tpZXMgPT0gYWxsb3dDb29raWVzKQorICAgICAgICByZXR1cm47 CisKICAgICBtX2FsbG93Q29va2llcyA9IGFsbG93Q29va2llczsKICAgICAKICAgICBpZiAodXJs KCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKQpAQCAtMzY3LDYgKzM4OSw5IEBAIHZvaWQgUmVz b3VyY2VSZXF1ZXN0QmFzZTo6c2V0UHJpb3JpdHkoUmUKIHsKICAgICB1cGRhdGVSZXNvdXJjZVJl cXVlc3QoKTsKIAorICAgIGlmIChtX3ByaW9yaXR5ID09IHByaW9yaXR5KQorICAgICAgICByZXR1 cm47CisKICAgICBtX3ByaW9yaXR5ID0gcHJpb3JpdHk7CiAKICAgICBpZiAodXJsKCkucHJvdG9j b2xJc0luSFRUUEZhbWlseSgpKQo=