110661 2013-02-22 16:51:57 -0800 Refactor logic for relaying out children out of RenderBlock::styleDidChange 2013-02-25 11:16:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony eric esprehn+autocc hyatt ojan.autocc webkit.review.bot oldest_to_newest 840126 0 tony 2013-02-22 16:51:57 -0800 Refactor logic for relaying out children out of RenderBlock::styleDidChange 840136 1 189867 tony 2013-02-22 16:59:07 -0800 Created attachment 189867 Patch 841104 2 189867 hyatt 2013-02-25 10:49:40 -0800 Comment on attachment 189867 Patch r=me. Nice change! 841127 3 189867 webkit.review.bot 2013-02-25 11:16:30 -0800 Comment on attachment 189867 Patch Clearing flags on attachment: 189867 Committed r143950: <http://trac.webkit.org/changeset/143950> 841128 4 webkit.review.bot 2013-02-25 11:16:33 -0800 All reviewed patches have been landed. Closing bug. 189867 2013-02-22 16:59:07 -0800 2013-02-25 11:16:30 -0800 Patch bug-110661-20130222165526.patch text/plain 6868 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk1MWM4MzgwNmIwZjZh ZjE0Y2RiNTExMzU3OWIxYjJmNzQ4ODQyOC4uZmNlMTE4Yjg1YmVlZWJkOTQ0YzVhYWExN2UwNjQy YTJjMzY0M2FkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAyLTIyICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVmYWN0b3IgbG9naWMgZm9y IHJlbGF5aW5nIG91dCBjaGlsZHJlbiBvdXQgb2YgUmVuZGVyQmxvY2s6OnN0eWxlRGlkQ2hhbmdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2NjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFk IG9mIGhhdmluZyBzdHlsZURpZENoYW5nZSBuZWVkIHRvIGtub3cgd2hpY2ggY2hpbGRyZW4gdG8g bWFyayBhcyBuZWVkaW5nIGxheW91dCwKKyAgICAgICAgdXNlIGEgYm9vbCB0byBrZWVwIHRyYWNr IG9mIGJvcmRlciBhbmQgcGFkZGluZyB3aWR0aCBjaGFuZ2VzIHNvIGF0IGxheW91dCB0aW1lLCB3 ZSBrbm93CisgICAgICAgIHdlIG5lZWQgdG8gc2V0IHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZS4KKwor ICAgICAgICBXZSBzdGVhbCBhIGJpdCBmcm9tIG1fbGluZUhlaWdodCByZWR1Y2luZyB0aGUgcG9z c2libGUgbGluZSBoZWlnaHQgZnJvbSBhcm91bmQgNTAwIG1pbGxpb24gcGl4ZWxzCisgICAgICAg IHRvIDI1MCBtaWxsaW9uIHBpeGVscy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgc2hv dWxkIGJlIGNvdmVyZWQgYnkgZmFzdC9ibG9jay9wb3NpdGlvbmluZy9ib3JkZXItY2hhbmdlLXJl bGF5b3V0LXRlc3QuaHRtbCBhbmQKKyAgICAgICAgZmFzdC9ibG9jay9keW5hbWljLXBhZGRpbmct Ym9yZGVyLmh0bWwuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OlJlbmRlckJsb2NrKTogRml4IGluZGVudCBhbmQg aW5pdGlhbGl6ZSBtX2hhc0JvcmRlck9yUGFkZGluZ0xvZ2ljYWxXaWR0aENoYW5nZWQuCisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6c3R5bGVEaWRDaGFuZ2UpOiBSZW1vdmUgbG9naWMg Zm9yIHNldHRpbmcgY2hpbGRyZW4gYXMgbmVlZGluZyBsYXlvdXQuCisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJCbG9jazo6dXBkYXRlTG9naWNhbFdpZHRoQW5kQ29sdW1uV2lkdGgpOiBSZXR1cm4g dHJ1ZSBpZiBib3JkZXIgb3IgcGFkZGluZyB3aWR0aCBjaGFuZ2VkLgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9jay5oOgorICAgICAgICAoUmVuZGVyQmxvY2spOiBTdGVhbCBhIGJpdCBm cm9tIG1fbGluZUhlaWdodCBhbmQgZ2l2ZSBpdCB0byBtX2hhc0JvcmRlck9yUGFkZGluZ0xvZ2lj YWxXaWR0aENoYW5nZWQuCisKIDIwMTMtMDItMjIgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBkZXNjcmlwdGl2ZSBuYW1lcyBmb3IgZGlmZmVyZW50 IGFkZE1pZHBvaW50IHVzZSBjYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKaW5kZXggOWIwZGY5NTVlZjE0NjI5NjhkYmFjMDMwYmZhZDRjYTlkYzYxYzg5Yy4uMDUy OWM3YTc3NTRhMDY2OTY4YjFjODMxZjEyZTEyNTRkMjgzZTc4ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0xOTksMTAgKzE5OSwxMSBAQCBSZW5kZXJCbG9j azo6TWFyZ2luSW5mbzo6TWFyZ2luSW5mbyhSZW5kZXJCbG9jayogYmxvY2ssIExheW91dFVuaXQg YmVmb3JlQm9yZGVyUAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogCiBSZW5kZXJCbG9jazo6UmVuZGVyQmxvY2soQ29udGFpbmVyTm9kZSogbm9kZSkK LSAgICAgIDogUmVuZGVyQm94KG5vZGUpCi0gICAgICAsIG1fbGluZUhlaWdodCgtMSkKLSAgICAg ICwgbV9iZWluZ0Rlc3Ryb3llZChmYWxzZSkKLSAgICAgICwgbV9oYXNNYXJrdXBUcnVuY2F0aW9u KGZhbHNlKQorICAgIDogUmVuZGVyQm94KG5vZGUpCisgICAgLCBtX2xpbmVIZWlnaHQoLTEpCisg ICAgLCBtX2JlaW5nRGVzdHJveWVkKGZhbHNlKQorICAgICwgbV9oYXNNYXJrdXBUcnVuY2F0aW9u KGZhbHNlKQorICAgICwgbV9oYXNCb3JkZXJPclBhZGRpbmdMb2dpY2FsV2lkdGhDaGFuZ2VkKGZh bHNlKQogewogICAgIHNldENoaWxkcmVuSW5saW5lKHRydWUpOwogICAgIENPTVBJTEVfQVNTRVJU KHNpemVvZihSZW5kZXJCbG9jazo6RmxvYXRpbmdPYmplY3QpID09IHNpemVvZihTYW1lU2l6ZUFz RmxvYXRpbmdPYmplY3QpLCBGbG9hdGluZ09iamVjdF9zaG91bGRfc3RheV9zbWFsbCk7CkBAIC00 MDgsMzYgKzQwOSw4IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlm ZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5CiAgICAgfQogICAgIAogICAg IC8vIEl0J3MgcG9zc2libGUgZm9yIG91ciBib3JkZXIvcGFkZGluZyB0byBjaGFuZ2UsIGJ1dCBm b3IgdGhlIG92ZXJhbGwgbG9naWNhbCB3aWR0aCBvZiB0aGUgYmxvY2sgdG8KLSAgICAvLyBlbmQg dXAgYmVpbmcgdGhlIHNhbWUuIFdoZW4gdGhpcyBoYXBwZW5zLCB3ZSB3b24ndCB1bmRlcnN0YW5k IHRvIHNldCB8cmVsYXlvdXRDaGlsZHJlbnwgdG8gdHJ1ZQotICAgIC8vIGluIGxheW91dEJsb2Nr LiBMb25nZXItdGVybSwgd2Ugc2hvdWxkIGJlIGZpZ3VyaW5nIHRoaXMgc3R1ZmYgb3V0IG92ZXIg aW4gbGF5b3V0QmxvY2ssIHNpbmNlCi0gICAgLy8gd2UgbmVlZCB0byBiZSBhYmxlIHRvIGhhbmRs ZSB0aGUgc2FtZSBzaXR1YXRpb24gaW4gUmVuZGVyUmVnaW9ucyB3aGVuIHdlIGhhdmUgZGlzdGlu Y3QgYm9yZGVycyBpbgotICAgIC8vIHRob3NlIHJlZ2lvbnMuIEZvciBub3csIHRob3VnaCwgd2Ug anVzdCBtYXJrIHRoZSBjaGlsZHJlbiBmb3IgcmVsYXlvdXQgcmlnaHQgaGVyZS4KLSAgICBpZiAo b2xkU3R5bGUgJiYgZGlmZiA9PSBTdHlsZURpZmZlcmVuY2VMYXlvdXQgJiYgbmVlZHNMYXlvdXQo KSAmJiBib3JkZXJPclBhZGRpbmdMb2dpY2FsV2lkdGhDaGFuZ2VkKG9sZFN0eWxlLCBuZXdTdHls ZSkpIHsKLSAgICAgICAgLy8gRmlyc3Qgd2FsayBvdXIgbm9ybWFsIGZsb3cgb2JqZWN0cyBhbmQg c2VlIGlmIHRoZXJlIGlzIGFueSBjaGFuZ2UuCi0gICAgICAgIGlmICghY2hpbGRyZW5JbmxpbmUo KSkgewotICAgICAgICAgICAgZm9yIChSZW5kZXJCb3gqIGNoaWxkQm94ID0gZmlyc3RDaGlsZEJv eCgpOyBjaGlsZEJveDsgY2hpbGRCb3ggPSBjaGlsZEJveC0+bmV4dFNpYmxpbmdCb3goKSkgewot ICAgICAgICAgICAgICAgIC8vIFBvc2l0aW9uZWQgb2JqZWN0cyBhcmUgY2hlY2tlZCBiZWxvdywg c2luY2Ugd2Ugb25seSBjYXJlIGFib3V0IHRob3NlIG9iamVjdHMgZm9yIHdoaWNoIHdlCi0gICAg ICAgICAgICAgICAgLy8gYXJlIHRoZSBjb250YWluaW5nIGJsb2NrLiBXZSBza2lwIGZsb2F0cyBj b21wbGV0ZWx5LCBzaW5jZSB0aGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yIG9mCi0gICAgICAgICAg ICAgICAgLy8gdGhlIHxyZWxheW91dENoaWxkcmVufCBib29sZWFuIGluIGxheW91dEJsb2NrLiBJ dCBpcyBlbnRpcmVseSBwb3NzaWJsZSB0aGVyZSBhcmUgYnVncwotICAgICAgICAgICAgICAgIC8v IHJlbGF0ZWQgdG8gZmxvYXRzIGhlcmUsIGJ1dCBmb3Igbm93IHdlJ2xsIGJlIGNvbnNpc3RlbnQg d2l0aCBsYXlvdXRCbG9jaywgc2luY2UgdGhvc2UKLSAgICAgICAgICAgICAgICAvLyBidWdzIHdv dWxkIGV4aXN0IGV2ZW4gd2l0aG91dCBib3JkZXIvcGFkZGluZyBjaGFuZ2VzLgotICAgICAgICAg ICAgICAgIGlmIChjaGlsZEJveC0+aXNGbG9hdGluZ09yT3V0T2ZGbG93UG9zaXRpb25lZCgpKQot ICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgICAgICBjaGlsZEJveC0+ c2V0Q2hpbGROZWVkc0xheW91dCh0cnVlLCBNYXJrT25seVRoaXMpOwotICAgICAgICAgICAgfQot ICAgICAgICB9Ci0KLSAgICAgICAgLy8gTm93IHdhbGsgdGhlIHBvc2l0aW9uZWQgb2JqZWN0cyBm b3Igd2hpY2ggd2UgYXJlIHRoZSBjb250YWluaW5nIGJsb2NrLgotICAgICAgICBUcmFja2VkUmVu ZGVyZXJMaXN0SGFzaFNldCogcG9zaXRpb25lZERlc2NlbmRhbnRzID0gcG9zaXRpb25lZE9iamVj dHMoKTsKLSAgICAgICAgaWYgKHBvc2l0aW9uZWREZXNjZW5kYW50cykgewotICAgICAgICAgICAg UmVuZGVyQm94KiBwb3NpdGlvbmVkQm94OwotICAgICAgICAgICAgVHJhY2tlZFJlbmRlcmVyTGlz dEhhc2hTZXQ6Oml0ZXJhdG9yIGVuZCA9IHBvc2l0aW9uZWREZXNjZW5kYW50cy0+ZW5kKCk7Ci0g ICAgICAgICAgICBmb3IgKFRyYWNrZWRSZW5kZXJlckxpc3RIYXNoU2V0OjppdGVyYXRvciBpdCA9 IHBvc2l0aW9uZWREZXNjZW5kYW50cy0+YmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAg ICAgICAgICAgICAgcG9zaXRpb25lZEJveCA9ICppdDsKLSAgICAgICAgICAgICAgICBwb3NpdGlv bmVkQm94LT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUsIE1hcmtDb250YWluaW5nQmxvY2tDaGFp bik7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9CisgICAgLy8gZW5kIHVwIGJlaW5n IHRoZSBzYW1lLiBXZSBrZWVwIHRyYWNrIG9mIHRoaXMgY2hhbmdlIHNvIGluIGxheW91dEJsb2Nr LCB3ZSBjYW4ga25vdyB0byBzZXQgcmVsYXlvdXRDaGlsZHJlbj10cnVlLgorICAgIG1faGFzQm9y ZGVyT3JQYWRkaW5nTG9naWNhbFdpZHRoQ2hhbmdlZCA9IG9sZFN0eWxlICYmIGRpZmYgPT0gU3R5 bGVEaWZmZXJlbmNlTGF5b3V0ICYmIG5lZWRzTGF5b3V0KCkgJiYgYm9yZGVyT3JQYWRkaW5nTG9n aWNhbFdpZHRoQ2hhbmdlZChvbGRTdHlsZSwgbmV3U3R5bGUpOwogfQogCiBSZW5kZXJCbG9jayog UmVuZGVyQmxvY2s6OmNvbnRpbnVhdGlvbkJlZm9yZShSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxk KQpAQCAtMTQ5Myw3ICsxNDY2LDEwIEBAIGJvb2wgUmVuZGVyQmxvY2s6OnVwZGF0ZUxvZ2ljYWxX aWR0aEFuZENvbHVtbldpZHRoKCkKICAgICB1cGRhdGVMb2dpY2FsV2lkdGgoKTsKICAgICBjYWxj Q29sdW1uV2lkdGgoKTsKIAotICAgIHJldHVybiBvbGRXaWR0aCAhPSBsb2dpY2FsV2lkdGgoKSB8 fCBvbGRDb2x1bW5XaWR0aCAhPSBkZXNpcmVkQ29sdW1uV2lkdGgoKTsKKyAgICBib29sIGhhc0Jv cmRlck9yUGFkZGluZ0xvZ2ljYWxXaWR0aENoYW5nZWQgPSBtX2hhc0JvcmRlck9yUGFkZGluZ0xv Z2ljYWxXaWR0aENoYW5nZWQ7CisgICAgbV9oYXNCb3JkZXJPclBhZGRpbmdMb2dpY2FsV2lkdGhD aGFuZ2VkID0gZmFsc2U7CisKKyAgICByZXR1cm4gb2xkV2lkdGggIT0gbG9naWNhbFdpZHRoKCkg fHwgb2xkQ29sdW1uV2lkdGggIT0gZGVzaXJlZENvbHVtbldpZHRoKCkgfHwgaGFzQm9yZGVyT3JQ YWRkaW5nTG9naWNhbFdpZHRoQ2hhbmdlZDsKIH0KIAogdm9pZCBSZW5kZXJCbG9jazo6Y2hlY2tG b3JQYWdpbmF0aW9uTG9naWNhbEhlaWdodENoYW5nZShMYXlvdXRVbml0JiBwYWdlTG9naWNhbEhl aWdodCwgYm9vbCYgcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkLCBib29sJiBoYXNTcGVjaWZpZWRQ YWdlTG9naWNhbEhlaWdodCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKaW5k ZXggNjQ1Y2E5OGJmOGMyOWMyZTI3MzlmMDQ4ODk4OWM4MThiY2I0YjliMC4uYmIyOTAxZTZjNjgz NjE4M2ZlNGFjMDI1MGY2YTBiMDM1M2RlZDE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmgKQEAgLTEyMzUsOSArMTIzNSwxMCBAQCBwcm90ZWN0ZWQ6CiAgICAgUmVuZGVy T2JqZWN0Q2hpbGRMaXN0IG1fY2hpbGRyZW47CiAgICAgUmVuZGVyTGluZUJveExpc3QgbV9saW5l Qm94ZXM7ICAgLy8gQWxsIG9mIHRoZSByb290IGxpbmUgYm94ZXMgY3JlYXRlZCBmb3IgdGhpcyBi bG9jayBmbG93LiAgRm9yIGV4YW1wbGUsIDxkaXY+SGVsbG88YnI+d29ybGQuPC9kaXY+IHdpbGwg aGF2ZSB0d28gdG90YWwgbGluZXMgZm9yIHRoZSA8ZGl2Pi4KIAotICAgIG11dGFibGUgc2lnbmVk IG1fbGluZUhlaWdodCA6IDMwOworICAgIG11dGFibGUgc2lnbmVkIG1fbGluZUhlaWdodCA6IDI5 OwogICAgIHVuc2lnbmVkIG1fYmVpbmdEZXN0cm95ZWQgOiAxOwogICAgIHVuc2lnbmVkIG1faGFz TWFya3VwVHJ1bmNhdGlvbiA6IDE7CisgICAgdW5zaWduZWQgbV9oYXNCb3JkZXJPclBhZGRpbmdM b2dpY2FsV2lkdGhDaGFuZ2VkIDogMTsKIAogICAgIC8vIFJlbmRlclJ1YnlCYXNlIG9iamVjdHMg bmVlZCB0byBiZSBhYmxlIHRvIHNwbGl0IGFuZCBtZXJnZSwgbW92aW5nIHRoZWlyIGNoaWxkcmVu IGFyb3VuZAogICAgIC8vIChjYWxsaW5nIG1vdmVDaGlsZFRvLCBtb3ZlQWxsQ2hpbGRyZW5Ubywg YW5kIG1ha2VDaGlsZHJlbk5vbklubGluZSkuCg==