110640 2013-02-22 14:01:11 -0800 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient 2013-02-25 16:46:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov enne fishd tkent+wkapi vangelis webkit.review.bot oldest_to_newest 839915 0 jamesr 2013-02-22 14:01:11 -0800 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient 839919 1 189820 jamesr 2013-02-22 14:02:22 -0800 Created attachment 189820 Patch 839924 2 189820 jamesr 2013-02-22 14:03:55 -0800 Comment on attachment 189820 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189820&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:-4022 > - IntRect damagedRect(0, 0, m_size.width, m_size.height); > - if (!m_isAcceleratedCompositingActive && !m_suppressInvalidations) > - m_client->didInvalidateRect(damagedRect); This is dead code - m_suppressInvalidations will always be true here since it's set at the top of the function. I'm not sure how we got into this state but everything seems to be working fine. 839942 3 webkit.review.bot 2013-02-22 14:10:57 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 841350 4 189820 enne 2013-02-25 15:27:28 -0800 Comment on attachment 189820 Patch R=me. 841421 5 189820 webkit.review.bot 2013-02-25 16:46:19 -0800 Comment on attachment 189820 Patch Clearing flags on attachment: 189820 Committed r143985: <http://trac.webkit.org/changeset/143985> 841422 6 webkit.review.bot 2013-02-25 16:46:22 -0800 All reviewed patches have been landed. Closing bug. 189820 2013-02-22 14:02:22 -0800 2013-02-25 16:46:19 -0800 Patch bug-110640-20130222135841.patch text/plain 3533 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMWFkOTc1MmJkODk2ZjViMDFkYTIxZThjMjIwNDI4Y2EyYzIwNDcuLmI4YzZkODgzZjAxNDZl M2FhNzM5MmU5YzNjZmNmZGJjMGU0OTdkMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDItMjIgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFBsdW1iIFdlYlZpZXdJbXBsJ3MgY29tcG9z aXRvciBzY2hlZHVsaW5nIHN1cHByZXNzaW9uIG91dCB0byBXZWJXaWRnZXRDbGllbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDY0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGx1bWJzIHRo ZSBXZWJWaWV3SW1wbDo6bV9zdXBwcmVzc0ludmFsaWRhdGlvbnMgbG9naWMgb3V0IHRvIHRoZSBX ZWJXaWRnZXRDbGllbnQgc28KKyAgICAgICAgaXQgY2FuIGJlIGltcGxlbWVudGVkIGJ5IHRoZSBl bWJlZGRlci4gVGhlIGV4aXN0aW5nIGxvZ2ljIGlzIGxlZnQgaW4gcGxhY2UgZm9yIG5vdywKKyAg ICAgICAgb25jZSB0aGUgZW1iZWRkZXIgc2lkZSBoYXMgbGFuZGVkIFdlYlZpZXdJbXBsIHdpbGwg YmUgcHVyZWx5IGEgcGFzcy10aHJvdWdoLgorCisgICAgICAgICogcHVibGljL1dlYldpZGdldENs aWVudC5oOgorICAgICAgICAoV2ViV2lkZ2V0Q2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6V2Vi V2lkZ2V0Q2xpZW50OjpzdXBwcmVzc0NvbXBvc2l0b3JTY2hlZHVsaW5nKToKKyAgICAgICAgKiBz cmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c3VwcHJl c3NJbnZhbGlkYXRpb25zKToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldFJvb3RH cmFwaGljc0xheWVyKToKKwogMjAxMy0wMi0yMSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBHZXQgcmlkIG9mIHBhcnNlZFVS TCBpbiB1aVNvdXJjZUNvZGUsIHVzZSBuYW1lIGFuZCBwYXRoIGZvciBkaXNwbGF5TmFtZSBpbnN0 ZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0 Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXRDbGllbnQu aAppbmRleCBmYTlkM2Q4ZmEzNmJjYjM2Mjg5ZDcwZjI5NDgzZGY3ZDlmNGUzNTIzLi40OGZlNTg4 MzVjNTE5ODU4MTNmODI2YmNjOGIxOTU1ODlmMzA0MjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXRDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRnZXRDbGllbnQuaApAQCAtNzUsNiArNzUsMTIgQEAgcHVi bGljOgogICAgIC8vIFdlYldpZGdldENsaWVudC4KICAgICB2aXJ0dWFsIFdlYkxheWVyVHJlZVZp ZXcqIGxheWVyVHJlZVZpZXcoKSB7IHJldHVybiAwOyB9CiAKKyAgICAvLyBTb21ldGltZXMgdGhl IFdlYldpZGdldCBlbnRlcnMgYSBzdGF0ZSB3aGVyZSBpdCB3aWxsIGdlbmVyYXRlIGEgc2VxdWVu Y2UKKyAgICAvLyBvZiBpbnZhbGlkYXRpb25zIHRoYXQgc2hvdWxkIG5vdCwgYnkgdGhlbXNlbHZl cywgdHJpZ2dlciB0aGUgY29tcG9zaXRvcgorICAgIC8vIHRvIHNjaGVkdWxlIGEgbmV3IGZyYW1l LiBUaGlzIGNhbGwgaW5kaWNhdGVzIHRvIHRoZSBlbWJlZGRlciB0aGF0IGl0CisgICAgLy8gc2hv dWxkIHN1cHByZXNzIGNvbXBvc2l0b3Igc2NoZWR1bGluZyB0ZW1wb3JhcmlseS4KKyAgICB2aXJ0 dWFsIHZvaWQgc3VwcHJlc3NDb21wb3NpdG9yU2NoZWR1bGluZyhib29sIGVuYWJsZSkgeyB9CisK ICAgICAvLyBJbmRpY2F0ZXMgdG8gdGhlIGVtYmVkZGVyIHRoYXQgdGhlIGNvbXBvc2l0b3IgaXMg YWJvdXQgdG8gYmVnaW4gYQogICAgIC8vIGZyYW1lLiBUaGlzIGlzIHByaW1hcmlseSB0byBzaWdu YWwgdG8gZmxvdyBjb250cm9sIG1lY2hhbmlzbXMgdGhhdCBhCiAgICAgLy8gZnJhbWUgaXMgYmVn aW5uaW5nLCBub3QgdG8gcGVyZm9ybSBhY3R1YWwgcGFpbnRpbmcgd29yay4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBhMzcxZGYwZTM1MTU2Njg4M2Mx NzA0ODhkMzE1ZDAxOWYwYjEyMDE5Li4zNWY2MjIyNzM2NTNhN2QzMTg3NzJjOGY3MjUyNWRhODI0 ZTVkNTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBA IC0zOTgzLDYgKzM5ODMsNyBAQCBib29sIFdlYlZpZXdJbXBsOjp0YWJzVG9MaW5rcygpIGNvbnN0 CiB2b2lkIFdlYlZpZXdJbXBsOjpzdXBwcmVzc0ludmFsaWRhdGlvbnMoYm9vbCBlbmFibGUpCiB7 CiAgICAgbV9zdXBwcmVzc0ludmFsaWRhdGlvbnMgPSBlbmFibGU7CisgICAgbV9jbGllbnQtPnN1 cHByZXNzQ29tcG9zaXRvclNjaGVkdWxpbmcoZW5hYmxlKTsKIH0KIAogI2lmIFVTRShBQ0NFTEVS QVRFRF9DT01QT1NJVElORykKQEAgLTM5OTMsNiArMzk5NCw3IEBAIGJvb2wgV2ViVmlld0ltcGw6 OmFsbG93c0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKQogCiB2b2lkIFdlYlZpZXdJbXBsOjpzZXRS b290R3JhcGhpY3NMYXllcihHcmFwaGljc0xheWVyKiBsYXllcikKIHsKKyAgICBtX2NsaWVudC0+ c3VwcHJlc3NDb21wb3NpdG9yU2NoZWR1bGluZyh0cnVlKTsKICAgICBUZW1wb3JhcnlDaGFuZ2U8 Ym9vbD4gY2hhbmdlKG1fc3VwcHJlc3NJbnZhbGlkYXRpb25zLCB0cnVlKTsKIAogICAgIG1fcm9v dEdyYXBoaWNzTGF5ZXIgPSBsYXllcjsKQEAgLTQwMTcsOSArNDAxOSw3IEBAIHZvaWQgV2ViVmll d0ltcGw6OnNldFJvb3RHcmFwaGljc0xheWVyKEdyYXBoaWNzTGF5ZXIqIGxheWVyKQogICAgICAg ICAgICAgbV9sYXllclRyZWVWaWV3LT5jbGVhclJvb3RMYXllcigpOwogICAgIH0KIAotICAgIElu dFJlY3QgZGFtYWdlZFJlY3QoMCwgMCwgbV9zaXplLndpZHRoLCBtX3NpemUuaGVpZ2h0KTsKLSAg ICBpZiAoIW1faXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlICYmICFtX3N1cHByZXNzSW52 YWxpZGF0aW9ucykKLSAgICAgICAgbV9jbGllbnQtPmRpZEludmFsaWRhdGVSZWN0KGRhbWFnZWRS ZWN0KTsKKyAgICBtX2NsaWVudC0+c3VwcHJlc3NDb21wb3NpdG9yU2NoZWR1bGluZyhmYWxzZSk7 CiB9CiAKIHZvaWQgV2ViVmlld0ltcGw6OnNjaGVkdWxlQ29tcG9zaXRpbmdMYXllclN5bmMoKQo=