110630 2013-02-22 11:53:11 -0800 [BlackBerry] Eliminate invalid clipping for content editable selections 2013-02-22 13:43:42 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 839788 0 mifenton 2013-02-22 11:53:11 -0800 SSIA. 839792 1 189804 mifenton 2013-02-22 11:55:12 -0800 Created attachment 189804 Patch 839802 2 189804 rwlbuis 2013-02-22 12:07:03 -0800 Comment on attachment 189804 Patch LGTM. 839888 3 189804 webkit.review.bot 2013-02-22 13:43:39 -0800 Comment on attachment 189804 Patch Clearing flags on attachment: 189804 Committed r143786: <http://trac.webkit.org/changeset/143786> 839889 4 webkit.review.bot 2013-02-22 13:43:42 -0800 All reviewed patches have been landed. Closing bug. 189804 2013-02-22 11:55:12 -0800 2013-02-22 13:43:39 -0800 Patch 0001-2013-02-22-Mike-Fenton-mifenton-rim.com.patch text/plain 4328 mifenton RnJvbSBkN2Q4ZWNhZDE3YzBkYzQ3NjllNmMxZjc4NjJmNjVlMDg0OWFjOWEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog RnJpLCAyMiBGZWIgMjAxMyAxMzoyNjoyMiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMtMDIt MjIgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMjg0NjI5LgoK ICAgICAgICBSZW1vdmUgc2VsZWN0aW9uIGNsaXBwaW5nIGZvciBjb250ZW50IGVkaXRhYmxlCiAg ICAgICAgZmllbGRzIGFzIHRoZSBib3VuZHMgYXJlbid0IHZhbGlkIGFuZCBjYXVzZQogICAgICAg IGNsaXBwaW5nIGJhc2VkIG9uIHN0YXJ0aW5nIG5vZGUgcmF0aGVyIHRoYW4gdGhlCiAgICAgICAg dW5pb24gb2Ygbm9kZXMuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAg ICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmJvdW5kaW5nQm94Rm9ySW5wdXRGaWVsZCk6CiAgICAg ICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgogICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNsaXBwaW5nUmVjdEZvclZpc2libGVDb250 ZW50KToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICB8ICAgMjEgKysrKysrKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCAgICAgIHwgICAxMCArKysrKysrKy0tCiAuLi4vYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwICB8ICAgIDIgKy0KIDMgZmls ZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzYmM1MTdmLi4wYWYyYTY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAogMjAxMy0wMi0yMiAgTWlrZSBGZW50b24g IDxtaWZlbnRvbkByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbGltaW5hdGUgaW52 YWxpZCBjbGlwcGluZyBmb3IgY29udGVudCBlZGl0YWJsZSBzZWxlY3Rpb25zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2MzAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUiAyODQ2MjkuCisKKyAgICAg ICAgUmVtb3ZlIHNlbGVjdGlvbiBjbGlwcGluZyBmb3IgY29udGVudCBlZGl0YWJsZQorICAgICAg ICBmaWVsZHMgYXMgdGhlIGJvdW5kcyBhcmVuJ3QgdmFsaWQgYW5kIGNhdXNlCisgICAgICAgIGNs aXBwaW5nIGJhc2VkIG9uIHN0YXJ0aW5nIG5vZGUgcmF0aGVyIHRoYW4gdGhlCisgICAgICAgIHVu aW9uIG9mIG5vZGVzLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgTmltYSBHaGFu YXZhdGlhbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjp1cGRhdGVGb3JtU3RhdGUp OgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNsaXBwaW5nUmVjdEZvclZp c2libGVDb250ZW50KToKKworMjAxMy0wMi0yMiAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0u Y29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSBGb3JjZSBmb3JtIHN1Ym1pc3Npb24gd2hlbiBp bXBsaWNpdCBzdWJtaXNzaW9uIGZhaWxzLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNjI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDdhYjU1ODcuLjE5 OWZmMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtMTIyMywxMSArMTIyMywxNyBAQCBXZWJDb3JlOjpJ bnRSZWN0IElucHV0SGFuZGxlcjo6Ym91bmRpbmdCb3hGb3JJbnB1dEZpZWxkKCkKICAgICAgICAg cmV0dXJuIFdlYkNvcmU6OkludFJlY3QoKTsKIAogICAgIC8vIHR5cGU9InNlYXJjaCIgY2FuIGhh dmUgYSAnWCcsIHNvIHRha2UgdGhlIGlubmVyIGJsb2NrIGJvdW5kaW5nIGJveCB0byBub3QgaW5j bHVkZSBpdC4KLSAgICBpZiAoSFRNTElucHV0RWxlbWVudCogZWxlbWVudCA9IG1fY3VycmVudEZv Y3VzRWxlbWVudC0+dG9JbnB1dEVsZW1lbnQoKSkKKyAgICBpZiAoSFRNTElucHV0RWxlbWVudCog ZWxlbWVudCA9IG1fY3VycmVudEZvY3VzRWxlbWVudC0+dG9JbnB1dEVsZW1lbnQoKSkgewogICAg ICAgICBpZiAoZWxlbWVudC0+aXNTZWFyY2hGaWVsZCgpKQogICAgICAgICAgICAgcmV0dXJuIGVs ZW1lbnQtPmlubmVyQmxvY2tFbGVtZW50KCktPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRpbmdC b3hSZWN0KCk7CisgICAgICAgIHJldHVybiBtX2N1cnJlbnRGb2N1c0VsZW1lbnQtPnJlbmRlcmVy KCktPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCk7CisgICAgfQorCisgICAgaWYgKG1fY3VycmVu dEZvY3VzRWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnRleHRhcmVhVGFnKSkKKyAgICAg ICAgcmV0dXJuIG1fY3VycmVudEZvY3VzRWxlbWVudC0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3Vu ZGluZ0JveFJlY3QoKTsKIAotICAgIHJldHVybiBtX2N1cnJlbnRGb2N1c0VsZW1lbnQtPnJlbmRl cmVyKCktPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCk7CisgICAgLy8gQ29udGVudCBFZGl0YWJs ZSBjYW4ndCByZWx5IG9uIHRoZSBib3VuZGluZyBib3ggc2luY2UgaXQgaXNuJ3QgZml4ZWQuCisg ICAgcmV0dXJuIFdlYkNvcmU6OkludFJlY3QoKTsKIH0KIAogdm9pZCBJbnB1dEhhbmRsZXI6OmVu c3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlKENhcmV0U2Nyb2xsVHlwZSBzY3JvbGxUeXBlKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0 aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCA1ZTMyY2M4Li4zMTExMzM0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25I YW5kbGVyLmNwcApAQCAtMTA3LDcgKzEwNyw3IEBAIFdlYkNvcmU6OkludFJlY3QgU2VsZWN0aW9u SGFuZGxlcjo6Y2xpcHBpbmdSZWN0Rm9yVmlzaWJsZUNvbnRlbnQoKSBjb25zdAogewogICAgIC8v IEdldCB0aGUgY29udGFpbmluZyBjb250ZW50IHJlY3QgZm9yIHRoZSBmcmFtZS4KICAgICBGcmFt ZSogZnJhbWUgPSBtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpOwotICAgIFdlYkNvcmU6 OkludFJlY3QgY2xpcFJlY3QgPSBXZWJDb3JlOjpJbnRSZWN0KFdlYkNvcmU6OkludFBvaW50KDAs IDApLCBtX3dlYlBhZ2UtPmNvbnRlbnRzU2l6ZSgpKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0IGNs aXBSZWN0ID0gV2ViQ29yZTo6SW50UmVjdChXZWJDb3JlOjpJbnRQb2ludCgwLCAwKSwgZnJhbWUt PnZpZXcoKS0+Y29udGVudHNTaXplKCkpOwogICAgIGlmIChmcmFtZSAhPSBtX3dlYlBhZ2UtPm1h aW5GcmFtZSgpKSB7CiAgICAgICAgIGNsaXBSZWN0ID0gbV93ZWJQYWdlLT5nZXRSZWN1cnNpdmVW aXNpYmxlV2luZG93UmVjdChmcmFtZS0+dmlldygpLCB0cnVlIC8qIG5vIGNsaXAgdG8gbWFpbiBm cmFtZSB3aW5kb3cgKi8pOwogICAgICAgICBjbGlwUmVjdCA9IG1fd2ViUGFnZS0+bV9tYWluRnJh bWUtPnZpZXcoKS0+d2luZG93VG9Db250ZW50cyhjbGlwUmVjdCk7Ci0tIAoxLjcuOS41Cgo=