110618 2013-02-22 09:50:30 -0800 [Chromium] Add expandedToParagraph() method to WebRange 2013-02-25 19:20:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rouslan+webkit webkit-unassigned abarth dglazkov fishd groby jamesr rouslan+webkit tkent+wkapi tony webkit.review.bot oldest_to_newest 839671 0 rouslan+webkit 2013-02-22 09:50:30 -0800 Add paragraphAroundCaret() method to WebFrame 839673 1 189785 rouslan+webkit 2013-02-22 09:55:10 -0800 Created attachment 189785 Patch 839675 2 rouslan+webkit 2013-02-22 09:56:31 -0800 Groby, Tony: PTAL. 839682 3 rouslan+webkit 2013-02-22 09:59:19 -0800 Groby: This method allows to query the spelling context. As you mentioned, we would not want to pass the spelling context up together with context click data. Another possibility would be add expandParagraph() method to WebRange object, but its comment says that WebRange is intended to be read-only. 839845 4 webkit.review.bot 2013-02-22 13:05:13 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 840036 5 tony 2013-02-22 15:05:27 -0800 (In reply to comment #3) > Groby: This method allows to query the spelling context. As you mentioned, we would not want to pass the spelling context up together with context click data. Another possibility would be add expandParagraph() method to WebRange object, but its comment says that WebRange is intended to be read-only. Could you have WebRange::expandParagraph return a new WebRange with the extra text? 840037 6 rouslan+webkit 2013-02-22 15:07:08 -0800 I certainly could! Let me get that done... 840105 7 189859 rouslan+webkit 2013-02-22 16:40:01 -0800 Created attachment 189859 Patch 840107 8 rouslan+webkit 2013-02-22 16:40:32 -0800 Tony: PTAL. 840209 9 189859 tony 2013-02-22 18:04:00 -0800 Comment on attachment 189859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189859&action=review > Source/WebKit/chromium/src/WebRange.cpp:101 > + ExceptionCode ec; > + copy.m_private->expand("block", ec); I think you want to use IGNORE_EXCEPTION here. 840210 10 tony 2013-02-22 18:04:24 -0800 (In reply to comment #9) > (From update of attachment 189859 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189859&action=review > > > Source/WebKit/chromium/src/WebRange.cpp:101 > > + ExceptionCode ec; > > + copy.m_private->expand("block", ec); > > I think you want to use IGNORE_EXCEPTION here. LGTM with that change, but one of the API owners needs to approve. 840390 11 189859 abarth 2013-02-23 09:52:54 -0800 Comment on attachment 189859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189859&action=review > Source/WebKit/chromium/public/WebRange.h:76 > + WEBKIT_EXPORT WebRange expandParagraph() const; It looks like the WebCore version mutates the Rang whereas this one returns a new range that has been expanded. Perhaps we should pick a name like "expandedToParagraph" to make it clear that we're not mutating the object. 841015 12 190073 rouslan+webkit 2013-02-25 09:13:21 -0800 Created attachment 190073 Patch for landing 841016 13 190073 rouslan+webkit 2013-02-25 09:14:10 -0800 Comment on attachment 190073 Patch for landing Adam: PTAL. 841165 14 190073 abarth 2013-02-25 11:51:33 -0800 Comment on attachment 190073 Patch for landing I should ask you for a test. :) 841533 15 190073 webkit.review.bot 2013-02-25 19:20:17 -0800 Comment on attachment 190073 Patch for landing Clearing flags on attachment: 190073 Committed r144002: <http://trac.webkit.org/changeset/144002> 841534 16 webkit.review.bot 2013-02-25 19:20:21 -0800 All reviewed patches have been landed. Closing bug. 189785 2013-02-22 09:55:10 -0800 2013-02-22 16:39:57 -0800 Patch bug-110618-20130222095129.patch text/plain 3534 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU3Y2I2NWVkMjVmYTJkZjM1OTgyZTBmNjIxNzFhMmMyNTkyZmZkMTcuLjgzNjMwODdmZTg1ZTcy MmVjNGU1Nzc0MmE0MzRhNWQ5NzhjYmZkM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTMtMDItMjIgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBwYXJhZ3JhcGhBcm91bmRDYXJldCgpIG1ldGhv ZCB0byBXZWJGcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEwNjE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgbWV0aG9kIHBhcmFncmFwaEFyb3VuZENhcmV0KCkgdG8gV2ViRnJhbWUgdG8g cmV0dXJuIHRoZSBwYXJhZ3JhcGgKKyAgICAgICAgb2YgdGV4dCBhcm91bmQgdGhlIGNhcmV0IHBv c2l0aW9uIHdpdGhvdXQgbW92aW5nIHRoZSBjYXJldCBvciBhbHRlcmluZworICAgICAgICBzZWxl Y3Rpb24uIFRoaXMgbWV0aG9kIGlzIHRvIGJlIHVzZWQgdG8gcXVlcnkgdGhlIHNwZWxsaW5nIGNv bnRleHQgYXJvdW5kCisgICAgICAgIHRoZSBtaXNzcGVsbGVkIHdvcmQuCisKKyAgICAgICAgKiBw dWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKFdlYkZyYW1lKTogQWRkZWQgcGFyYWdyYXBoQXJv dW5kQ2FyZXQoKSBtZXRob2QuCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6cGFyYWdyYXBoQXJvdW5kQ2FyZXQpOiBBZGRlZCBw YXJhZ3JhcGhBcm91bmRDYXJldCgpIG1ldGhvZC4KKyAgICAgICAgKFdlYktpdCk6CisgICAgICAg ICogc3JjL1dlYkZyYW1lSW1wbC5oOgorICAgICAgICAoV2ViRnJhbWVJbXBsKTogQWRkZWQgcGFy YWdyYXBoQXJvdW5kQ2FyZXQoKSBtZXRob2QuCisKIDIwMTMtMDItMjIgIEFuZHJleSBLb3N5YWtv diAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21p dW1dIGFkZCBhIGJyb3dzZXIgdGVzdCBmb3IgZnJhbWVzIG9uIHRpbWVsaW5lCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAppbmRleCA4MTJhZDZlYTU2NjI2NTM4MmVhZjc3 YmFhMTE5YTE5N2ZmOGVlZGQxLi4wMWEyZTcwZDEwMjljNzI2Mzc2NWEwMTVjYTI3YjliNzNjMGEx NGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTQ1NCw2 ICs0NTQsMTAgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBXZWJSYW5nZSBzZWxlY3Rpb25SYW5n ZSgpIGNvbnN0ID0gMDsKIAorICAgIC8vIFJldHVybnMgdGhlIHBhcmFncmFwaCBhcm91bmQgdGhl IGNhcmV0IHdpdGhvdXQgYWx0ZXJpbmcgdGhlIGNhcmV0IHBvc2l0aW9uCisgICAgLy8gb3Igc2Vs ZWN0aW9uIHJhbmdlLgorICAgIHZpcnR1YWwgV2ViU3RyaW5nIHBhcmFncmFwaEFyb3VuZENhcmV0 KCkgY29uc3QgPSAwOworCiAgICAgdmlydHVhbCBXZWJTdHJpbmcgc2VsZWN0aW9uQXNUZXh0KCkg Y29uc3QgPSAwOwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIHNlbGVjdGlvbkFzTWFya3VwKCkgY29u c3QgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFt ZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApp bmRleCAzMmEyOWY4YTY3ZmI0ZDE4NDRjOGIyZjEwY2VkYTUzM2FjMmJmYzkxLi5iNWU1YzRkYzM0 MjI5ZTZiNTYzNWZhOWQ2Mjk3NGYwZjdmZDhjNTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTEzMjAsNiArMTMyMCwyMCBAQCBXZWJSYW5nZSBX ZWJGcmFtZUltcGw6OnNlbGVjdGlvblJhbmdlKCkgY29uc3QKICAgICByZXR1cm4gZnJhbWUoKS0+ c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCk7CiB9CiAKK1dlYlN0cmluZyBXZWJGcmFt ZUltcGw6OnBhcmFncmFwaEFyb3VuZENhcmV0KCkgY29uc3QKK3sKKyAgICBGcmFtZVNlbGVjdGlv biogc2VsZWN0aW9uID0gZnJhbWUoKS0+c2VsZWN0aW9uKCk7CisgICAgQVNTRVJUKCFzZWxlY3Rp b24tPmlzTm9uZSgpKTsKKyAgICBpZiAoc2VsZWN0aW9uLT5pc05vbmUoKSkKKyAgICAgICAgcmV0 dXJuIFdlYlN0cmluZygpOworICAgIEV4Y2VwdGlvbkNvZGUgZWM7CisgICAgUmVmUHRyPFJhbmdl PiBzZWxlY3Rpb25SYW5nZSA9IHNlbGVjdGlvbi0+dG9Ob3JtYWxpemVkUmFuZ2UoKTsKKyAgICBz ZWxlY3Rpb25SYW5nZS0+ZXhwYW5kKCJibG9jayIsIGVjKTsKKyAgICBpZiAoZWMpCisgICAgICAg IHJldHVybiBXZWJTdHJpbmcoKTsKKyAgICByZXR1cm4gc2VsZWN0aW9uUmFuZ2UtPnRleHQoKTsK K30KKwogV2ViU3RyaW5nIFdlYkZyYW1lSW1wbDo6c2VsZWN0aW9uQXNUZXh0KCkgY29uc3QKIHsK ICAgICBXZWJQbHVnaW5Db250YWluZXJJbXBsKiBwbHVnaW5Db250YWluZXIgPSBwbHVnaW5Db250 YWluZXJGcm9tRnJhbWUoZnJhbWUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5oCmluZGV4IDBjZTk4ZmI1YzBlYzA4YjMyYzBiY2M1NjVkMGQ2OWMyZGZhMmUyYTQu LjU1NjI1YjM1Y2ViOWY0ODM3YmIzNTU4ZDkwN2MwNDlkN2ZmY2JkMWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC0xODIsNiArMTgyLDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgdm9pZCByZXBsYWNlTWlzc3BlbGxlZFJhbmdlKGNvbnN0IFdlYlN0cmlu ZyYpOwogICAgIHZpcnR1YWwgYm9vbCBoYXNTZWxlY3Rpb24oKSBjb25zdDsKICAgICB2aXJ0dWFs IFdlYlJhbmdlIHNlbGVjdGlvblJhbmdlKCkgY29uc3Q7CisgICAgdmlydHVhbCBXZWJTdHJpbmcg cGFyYWdyYXBoQXJvdW5kQ2FyZXQoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBzZWxl Y3Rpb25Bc1RleHQoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBzZWxlY3Rpb25Bc01h cmt1cCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBzZWxlY3RXb3JkQXJvdW5kQ2FyZXQoKTsK 189859 2013-02-22 16:40:01 -0800 2013-02-25 09:13:16 -0800 Patch bug-110618-20130222163620.patch text/plain 2434 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGEyMjA1YjZjNDBhZTZmYjA0NGQ4ZWNmYTdiMDE0MTliMzkzZGQ3ZWQuLmQzYWRjMDk4M2MwYWIx M2Q1YTY2NThiZTZlMTRlZWEwM2VhYWYyMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTMtMDItMjIgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBleHBhbmRQYXJhZ3JhcGgoKSBtZXRob2QgdG8g V2ViUmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMDYxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhIG1ldGhvZCBleHBhbmRQYXJhZ3JhcGgoKSB0byBXZWJSYW5nZSB0byByZXR1cm4gYSBj b3B5IG9mIHRoZSByYW5nZQorICAgICAgICBleHBhbmRlZCB0byBwYXJhZ3JhcGggYm91bmRhcmll cy4gVGhpcyBtZXRob2QgaXMgdG8gYmUgdXNlZCB0byBxdWVyeSB0aGUKKyAgICAgICAgc3BlbGxp bmcgY29udGV4dCBhcm91bmQgdGhlIG1pc3NwZWxsZWQgd29yZCB1bmRlciBjdXJzb3IuCisKKyAg ICAgICAgKiBwdWJsaWMvV2ViUmFuZ2UuaDoKKyAgICAgICAgKFdlYlJhbmdlKTogQWRkZWQgZXhw YW5kUGFyYWdyYXBoKCkgbWV0aG9kIGRlY2xhcmF0aW9uLgorICAgICAgICAqIHNyYy9XZWJSYW5n ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlJhbmdlOjpleHBhbmRQYXJhZ3JhcGgpOiBBZGRl ZCBtZXRob2QgdG8gY29weSByYW5nZSwgZXhwYW5kIHRoZSBjb3BpZWQgcmFuZ2UgdG8gcGFyYWdy YXBoIGJvdW5kYXJpZXMsIGFuZCByZXR1cm4gdGhlIHJlc3VsdGluZyByYW5nZS4KKyAgICAgICAg KFdlYktpdCk6IEFkZGVkIGV4cGFuZFBhcmFncmFwaCgpIG1ldGhvZCBkZWZpbml0aW9uLgorCiAy MDEzLTAyLTIyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQzNzM0LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUmFuZ2UuaCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlJhbmdlLmgKaW5kZXggODQxNDkyODdlMDYyZDFmNDg3MDg1NTVkYjkw ZDVkNGY2MGE0M2JkNC4uNmY1MDdmMjNmMGY5OGIzNmMwNWYyMWUzODZmZDY4ZjI3NTQxN2U2ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUmFuZ2UuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSYW5nZS5oCkBAIC03Myw2ICs3Myw4 IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB0b0hUTUxUZXh0KCkgY29u c3Q7CiAgICAgV0VCS0lUX0VYUE9SVCBXZWJTdHJpbmcgdG9QbGFpblRleHQoKSBjb25zdDsKIAor ICAgIFdFQktJVF9FWFBPUlQgV2ViUmFuZ2UgZXhwYW5kUGFyYWdyYXBoKCkgY29uc3Q7CisKICAg ICBXRUJLSVRfRVhQT1JUIHN0YXRpYyBXZWJSYW5nZSBmcm9tRG9jdW1lbnRSYW5nZShXZWJGcmFt ZSosIGludCBzdGFydCwgaW50IGxlbmd0aCk7CiAKICAgICBXRUJLSVRfRVhQT1JUIFdlYlZlY3Rv cjxXZWJGbG9hdFF1YWQ+IHRleHRRdWFkcygpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViUmFuZ2UuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViUmFuZ2UuY3BwCmluZGV4IGJjMjkzMDU3MjM0NGNkNTkwZTZiZTU0MGVjOTdiMzJmYmI1 ODM3YzcuLjAzOWE1MjA1MzhjNWFkOGE5Y2RlODdmYmQ2OTA2NDE1OWMwNWMwNzcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJhbmdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJSYW5nZS5jcHAKQEAgLTk0LDYgKzk0LDE0IEBAIFdlYlN0 cmluZyBXZWJSYW5nZTo6dG9QbGFpblRleHQoKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGUt PnRleHQoKTsKIH0KIAorV2ViUmFuZ2UgV2ViUmFuZ2U6OmV4cGFuZFBhcmFncmFwaCgpIGNvbnN0 Cit7CisgICAgV2ViUmFuZ2UgY29weSgqdGhpcyk7CisgICAgRXhjZXB0aW9uQ29kZSBlYzsKKyAg ICBjb3B5Lm1fcHJpdmF0ZS0+ZXhwYW5kKCJibG9jayIsIGVjKTsKKyAgICByZXR1cm4gY29weTsK K30KKwogLy8gc3RhdGljCiBXZWJSYW5nZSBXZWJSYW5nZTo6ZnJvbURvY3VtZW50UmFuZ2UoV2Vi RnJhbWUqIGZyYW1lLCBpbnQgc3RhcnQsIGludCBsZW5ndGgpCiB7Cg== 190073 2013-02-25 09:13:21 -0800 2013-02-25 19:20:17 -0800 Patch for landing bug-110618-20130225090937.patch text/plain 2486 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFiOWViZWVmODcyZTMyOTI1ODQ2Y2IxZWIxZDExOTk5YzIwOGNlYjMuLjA1YzM0NDNlN2IxZGFm YWY3YTBkN2RmZGY5MDExZTFkNDliOGQyNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTMtMDItMjUgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBleHBhbmRlZFRvUGFyYWdyYXBoKCkgbWV0aG9k IHRvIFdlYlJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTA2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAg IEFkZCBhIG1ldGhvZCBleHBhbmRlZFRvUGFyYWdyYXBoKCkgdG8gV2ViUmFuZ2UgdG8gcmV0dXJu IGEgY29weSBvZiB0aGUKKyAgICAgICAgcmFuZ2UgZXhwYW5kZWQgdG8gcGFyYWdyYXBoIGJvdW5k YXJpZXMuIFRoaXMgbWV0aG9kIGlzIHRvIGJlIHVzZWQgdG8KKyAgICAgICAgcXVlcnkgdGhlIHNw ZWxsaW5nIGNvbnRleHQgYXJvdW5kIHRoZSBtaXNzcGVsbGVkIHdvcmQgdW5kZXIgY3Vyc29yLgor CisgICAgICAgICogcHVibGljL1dlYlJhbmdlLmg6CisgICAgICAgIChXZWJSYW5nZSk6IEFkZGVk IGV4cGFuZGVkVG9QYXJhZ3JhcGgoKSBtZXRob2QgZGVjbGFyYXRpb24uCisgICAgICAgICogc3Jj L1dlYlJhbmdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmFuZ2U6OmV4cGFuZGVkVG9QYXJh Z3JhcGgpOiBBZGRlZCBtZXRob2QgdG8gY29weSByYW5nZSwgZXhwYW5kIHRoZSBjb3BpZWQgcmFu Z2UgdG8gcGFyYWdyYXBoIGJvdW5kYXJpZXMsIGFuZCByZXR1cm4gdGhlIHJlc3VsdGluZyByYW5n ZS4KKyAgICAgICAgKFdlYktpdCk6IEFkZGVkIGV4cGFuZGVkVG9QYXJhZ3JhcGgoKSBtZXRob2Qg ZGVmaW5pdGlvbi4KKwogMjAxMy0wMi0yNSAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZm9sbG93LXVwIHRvIHIxNDM3MjUsIHJlZHVj ZSBjaGFuY2VzIHRlc3QgZmxha2VzIG9uIGEgc2xvdyBib3guCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSYW5nZS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUmFuZ2UuaAppbmRleCA4NDE0OTI4N2UwNjJkMWY0ODcwODU1NWRiOTBkNWQ0 ZjYwYTQzYmQ0Li5iMzQyODJlNTY3NjM3YjJmYzE4MzljN2Y5YmIzYzJhOTBkOGYzNDFmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSYW5nZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJhbmdlLmgKQEAgLTczLDYgKzczLDggQEAg cHVibGljOgogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIHRvSFRNTFRleHQoKSBjb25zdDsK ICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB0b1BsYWluVGV4dCgpIGNvbnN0OwogCisgICAg V0VCS0lUX0VYUE9SVCBXZWJSYW5nZSBleHBhbmRlZFRvUGFyYWdyYXBoKCkgY29uc3Q7CisKICAg ICBXRUJLSVRfRVhQT1JUIHN0YXRpYyBXZWJSYW5nZSBmcm9tRG9jdW1lbnRSYW5nZShXZWJGcmFt ZSosIGludCBzdGFydCwgaW50IGxlbmd0aCk7CiAKICAgICBXRUJLSVRfRVhQT1JUIFdlYlZlY3Rv cjxXZWJGbG9hdFF1YWQ+IHRleHRRdWFkcygpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViUmFuZ2UuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViUmFuZ2UuY3BwCmluZGV4IGJjMjkzMDU3MjM0NGNkNTkwZTZiZTU0MGVjOTdiMzJmYmI1 ODM3YzcuLjkzZGNlYzM5ZTI2ODVmNTI1NTYwNjMwYTYzMjhiM2NjOTBjZWViYjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJhbmdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJSYW5nZS5jcHAKQEAgLTk0LDYgKzk0LDEzIEBAIFdlYlN0 cmluZyBXZWJSYW5nZTo6dG9QbGFpblRleHQoKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGUt PnRleHQoKTsKIH0KIAorV2ViUmFuZ2UgV2ViUmFuZ2U6OmV4cGFuZGVkVG9QYXJhZ3JhcGgoKSBj b25zdAoreworICAgIFdlYlJhbmdlIGNvcHkoKnRoaXMpOworICAgIGNvcHkubV9wcml2YXRlLT5l eHBhbmQoImJsb2NrIiwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgcmV0dXJuIGNvcHk7Cit9CisK IC8vIHN0YXRpYwogV2ViUmFuZ2UgV2ViUmFuZ2U6OmZyb21Eb2N1bWVudFJhbmdlKFdlYkZyYW1l KiBmcmFtZSwgaW50IHN0YXJ0LCBpbnQgbGVuZ3RoKQogewo=