110602 2013-02-22 06:07:17 -0800 [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it. 2014-01-26 21:17:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra b.long b.long commit-queue zan oldest_to_newest 839533 0 csaavedra 2013-02-22 06:07:17 -0800 This is the only usage of WEBKIT_TOP_LEVEL I can see: if (!g_getenv("WEBKIT_TOP_LEVEL")) g_setenv("WEBKIT_TOP_LEVEL", TOP_LEVEL_DIR, FALSE); And later on: g_error("Could not locate test fonts at %s. Is WEBKIT_TOP_LEVEL set?", fontsPath.data()); Unless I am grossly overlooking something, this makes no sense. 937228 1 b.long 2013-10-07 15:07:01 -0700 TOP_LEVEL_DIR is used in getTopLevelPath: Tools/DumpRenderTree/gtk/DumpRenderTree.cpp-CString getTopLevelPath() Tools/DumpRenderTree/gtk/DumpRenderTree.cpp-{ Tools/DumpRenderTree/gtk/DumpRenderTree.cpp- if (!g_getenv("WEBKIT_TOP_LEVEL")) Tools/DumpRenderTree/gtk/DumpRenderTree.cpp: g_setenv("WEBKIT_TOP_LEVEL", TOP_LEVEL_DIR, FALSE); Tools/DumpRenderTree/gtk/DumpRenderTree.cpp- Tools/DumpRenderTree/gtk/DumpRenderTree.cpp: return TOP_LEVEL_DIR; Tools/DumpRenderTree/gtk/DumpRenderTree.cpp-} The error you're getting is probably because WebKitGTK expects this repo: https://github.com/mrobinson/webkitgtk-test-fonts To be checked out in webkit/WebKitBuild/Dependencies/Root 937432 2 zan 2013-10-08 00:33:31 -0700 WEBKIT_TOP_LEVEL is used in WebCore to load image resources from the trunk (rather than from the installation location) when running DRT: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp#L39 937444 3 csaavedra 2013-10-08 01:08:16 -0700 (In reply to comment #2) > WEBKIT_TOP_LEVEL is used in WebCore to load image resources from the trunk (rather than from the installation location) when running DRT: > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp#L39 Not used for fonts I guess. It's misleading. Retitling. 957827 4 218745 b.long 2013-12-09 03:12:45 -0800 Created attachment 218745 Patch 957829 5 b.long 2013-12-09 03:14:23 -0800 This makes WEBKIT_TOP_LEVEL work again, using the environment variable if available, and the build-time constant if not. I also removed the printing of the font path in the debug message, since it's guaranteed to be null (see the if statement right before). 957833 6 218746 b.long 2013-12-09 03:26:49 -0800 Created attachment 218746 Patch Actually, it's probably better to make this error message more useful, so now it prints a description of where the fonts should be installed and describes what WEBKIT_TOP_LEVEL is. 968069 7 b.long 2014-01-14 15:28:01 -0800 Anyone want to review this? 972325 8 218746 commit-queue 2014-01-26 21:17:16 -0800 Comment on attachment 218746 Patch Clearing flags on attachment: 218746 Committed r162823: <http://trac.webkit.org/changeset/162823> 972326 9 commit-queue 2014-01-26 21:17:19 -0800 All reviewed patches have been landed. Closing bug. 218745 2013-12-09 03:12:45 -0800 2013-12-09 03:26:43 -0800 Patch bug-110602-20131209121244.patch text/plain 1982 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODc0ZTk5MjU4ZDBmYTNmYTQxNGI1MTNmNGIyMzdhMzM1 YWE3ZTUwYi4uYTBlOWE4ZTQ0NTg5MmZlZGVhMjVhYTIzZDI5NTBlMTMxZWQ2MmZiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTEyLTA5ICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKwor ICAgICAgICBbR1RLXSBEdW1wUmVuZGVyVHJlZSBwcmludHMgb3V0IHN1Z2dlc3RpbmcgdG8gc2V0 IFdFQktJVF9UT1BfTEVWRUwgd2hlbiBmb250cyBhcmUgbWlzc2luZyBidXQgZG9lc24ndCB1c2Ug aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2 MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChnZXRUb3BMZXZl bFBhdGgpOiBVc2UgV0VCS0lUX1RPUF9MRVZFTCBlbnZpcm9ubWVudCB2YXJpYWJsZSBpZiBpdCBl eGlzdHMuCisgICAgICAgIChpbml0aWFsaXplRm9udHMpOiBEb24ndCBhdHRlbXB0IHRvIHByaW50 IG91dCBmb250UGF0aCwgc2luY2UgaXQncyBhbHdheXMgbnVsbCBoZXJlLgorCiAyMDEzLTEyLTA4 ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgMzItYml0IE1pbmlCcm93 c2VyIGRvZXNuJ3QgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwCmluZGV4IGExODg1MDk5ZGRhMDZkZDY0ZWMyZmI5MjEzNTNmYjY2MmIyNzg2MzYuLjg3 OGNhMTk1NDg0YTEzNzc1N2EyYzJhZjc0ODg5OWFiY2RmNjdmNDUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMTkwLDkgKzE5MCwxMCBAQCBzdGF0 aWMgdm9pZCBpbml0aWFsaXplR3RrRm9udFNldHRpbmdzKGNvbnN0IGNoYXIqIHRlc3RVUkwpCiAK IENTdHJpbmcgZ2V0VG9wTGV2ZWxQYXRoKCkKIHsKLSAgICBpZiAoIWdfZ2V0ZW52KCJXRUJLSVRf VE9QX0xFVkVMIikpCi0gICAgICAgIGdfc2V0ZW52KCJXRUJLSVRfVE9QX0xFVkVMIiwgVE9QX0xF VkVMX0RJUiwgRkFMU0UpOworICAgIGlmIChjb25zdCBnY2hhciogdG9wTGV2ZWwgPSBnX2dldGVu digiV0VCS0lUX1RPUF9MRVZFTCIpKQorICAgICAgICByZXR1cm4gdG9wTGV2ZWw7CiAKKyAgICBn X3NldGVudigiV0VCS0lUX1RPUF9MRVZFTCIsIFRPUF9MRVZFTF9ESVIsIEZBTFNFKTsKICAgICBy ZXR1cm4gVE9QX0xFVkVMX0RJUjsKIH0KIApAQCAtMjQ1LDcgKzI0Niw3IEBAIHN0YXRpYyB2b2lk IGluaXRpYWxpemVGb250cyhjb25zdCBjaGFyKiB0ZXN0VVJMID0gMCkKIAogICAgIENTdHJpbmcg Zm9udHNQYXRoID0gZ2V0Rm9udHNQYXRoKCk7CiAgICAgaWYgKGZvbnRzUGF0aC5pc051bGwoKSkK LSAgICAgICAgZ19lcnJvcigiQ291bGQgbm90IGxvY2F0ZSB0ZXN0IGZvbnRzIGF0ICVzLiBJcyBX RUJLSVRfVE9QX0xFVkVMIHNldD8iLCBmb250c1BhdGguZGF0YSgpKTsKKyAgICAgICAgZ19lcnJv cigiQ291bGQgbm90IGxvY2F0ZSB0ZXN0IGZvbnRzLiBJcyBXRUJLSVRfVE9QX0xFVkVMIHNldD8i KTsKIAogICAgIEdPd25QdHI8R0Rpcj4gZm9udHNEaXJlY3RvcnkoZ19kaXJfb3Blbihmb250c1Bh dGguZGF0YSgpLCAwLCAwKSk7CiAgICAgd2hpbGUgKGNvbnN0IGNoYXIqIGRpcmVjdG9yeUVudHJ5 ID0gZ19kaXJfcmVhZF9uYW1lKGZvbnRzRGlyZWN0b3J5LmdldCgpKSkgewo= 218746 2013-12-09 03:26:49 -0800 2014-01-26 21:17:16 -0800 Patch bug-110602-20131209122647.patch text/plain 2173 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODc0ZTk5MjU4ZDBmYTNmYTQxNGI1MTNmNGIyMzdhMzM1 YWE3ZTUwYi4uYjU4MjBmZGU2Njg4OTExNGJjODc4MGRjOWY1YjlhMWRkNGE2ODZiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTEyLTA5ICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKwor ICAgICAgICBbR1RLXSBEdW1wUmVuZGVyVHJlZSBwcmludHMgb3V0IHN1Z2dlc3RpbmcgdG8gc2V0 IFdFQktJVF9UT1BfTEVWRUwgd2hlbiBmb250cyBhcmUgbWlzc2luZyBidXQgZG9lc24ndCB1c2Ug aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA2 MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChnZXRUb3BMZXZl bFBhdGgpOiBVc2UgV0VCS0lUX1RPUF9MRVZFTCBlbnZpcm9ubWVudCB2YXJpYWJsZSBpZiBpdCBl eGlzdHMuCisgICAgICAgIChpbml0aWFsaXplRm9udHMpOiBGaXggcHJpbnRpbmcgb2YgZXhwZWN0 ZWQgZm9udCBwYXRoIChmb250UGF0aCBpcyBndWFyYW50ZWVkIHRvIGJlIG51bGwgaGVyZSkuCisK IDIwMTMtMTItMDggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICAzMi1i aXQgTWluaUJyb3dzZXIgZG9lc24ndCBidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggYTE4ODUwOTlkZGEwNmRkNjRlYzJmYjkyMTM1M2ZiNjYy YjI3ODYzNi4uNWVlMWRlYzQ1NTA2MzQxYjgxZTUxM2NmMTNhNWE5MTlkZDU2MjAxMCAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0xOTAsOSArMTkw LDEwIEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVHdGtGb250U2V0dGluZ3MoY29uc3QgY2hhciog dGVzdFVSTCkKIAogQ1N0cmluZyBnZXRUb3BMZXZlbFBhdGgoKQogewotICAgIGlmICghZ19nZXRl bnYoIldFQktJVF9UT1BfTEVWRUwiKSkKLSAgICAgICAgZ19zZXRlbnYoIldFQktJVF9UT1BfTEVW RUwiLCBUT1BfTEVWRUxfRElSLCBGQUxTRSk7CisgICAgaWYgKGNvbnN0IGdjaGFyKiB0b3BMZXZl bCA9IGdfZ2V0ZW52KCJXRUJLSVRfVE9QX0xFVkVMIikpCisgICAgICAgIHJldHVybiB0b3BMZXZl bDsKIAorICAgIGdfc2V0ZW52KCJXRUJLSVRfVE9QX0xFVkVMIiwgVE9QX0xFVkVMX0RJUiwgRkFM U0UpOwogICAgIHJldHVybiBUT1BfTEVWRUxfRElSOwogfQogCkBAIC0yNDUsNyArMjQ2LDggQEAg c3RhdGljIHZvaWQgaW5pdGlhbGl6ZUZvbnRzKGNvbnN0IGNoYXIqIHRlc3RVUkwgPSAwKQogCiAg ICAgQ1N0cmluZyBmb250c1BhdGggPSBnZXRGb250c1BhdGgoKTsKICAgICBpZiAoZm9udHNQYXRo LmlzTnVsbCgpKQotICAgICAgICBnX2Vycm9yKCJDb3VsZCBub3QgbG9jYXRlIHRlc3QgZm9udHMg YXQgJXMuIElzIFdFQktJVF9UT1BfTEVWRUwgc2V0PyIsIGZvbnRzUGF0aC5kYXRhKCkpOworICAg ICAgICBnX2Vycm9yKCJDb3VsZCBub3QgbG9jYXRlIHRlc3QgZm9udHMgYXQgJFdFQktJVF9UT1Bf TEVWRUwvV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1Jvb3Qvd2Via2l0Z3RrLXRlc3QtZm9udHMu ICIKKyAgICAgICAgICAgICJXRUJLSVRfVE9QX0xFVkVMIGlzIHlvdXIgV2ViS2l0IGNoZWNrb3V0 IGJ5IGRlZmF1bHQsIGFuZCBjYW4gYmUgb3ZlcnJpZGRlbiBieSBzZXR0aW5nIGl0IGFzIGFuIGVu dmlyb25tZW50IHZhcmlhYmxlLiIpOwogCiAgICAgR093blB0cjxHRGlyPiBmb250c0RpcmVjdG9y eShnX2Rpcl9vcGVuKGZvbnRzUGF0aC5kYXRhKCksIDAsIDApKTsKICAgICB3aGlsZSAoY29uc3Qg Y2hhciogZGlyZWN0b3J5RW50cnkgPSBnX2Rpcl9yZWFkX25hbWUoZm9udHNEaXJlY3RvcnkuZ2V0 KCkpKSB7Cg==