110598 2013-02-22 05:37:21 -0800 Attr: Simplify modification callbacks. 2013-03-28 12:38:54 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 113530 1 kling kling cmarcelo esprehn+autocc koivisto ojan.autocc webkit.review.bot oldest_to_newest 839495 0 kling 2013-02-22 05:37:21 -0800 Attr is a friend class of Element and does some pretty hairy stuff to invoke attribute modification callbacks. This could easily be cleaned up. 839497 1 189756 kling 2013-02-22 05:38:14 -0800 Created attachment 189756 Proposed patch 840285 2 189756 webkit.review.bot 2013-02-22 20:49:07 -0800 Comment on attachment 189756 Proposed patch Clearing flags on attachment: 189756 Committed r143834: <http://trac.webkit.org/changeset/143834> 840286 3 webkit.review.bot 2013-02-22 20:49:10 -0800 All reviewed patches have been landed. Closing bug. 865711 4 webkit.review.bot 2013-03-28 12:38:54 -0700 Re-opened since this is blocked by bug 113530 189756 2013-02-22 05:38:14 -0800 2013-02-22 20:49:06 -0800 Proposed patch bug-110598.diff text/plain 7592 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmI1NWI4Li44MmJjMGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzkg QEAKIDIwMTMtMDItMjIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIEF0dHI6IFNpbXBsaWZ5IG1vZGlmaWNhdGlvbiBjYWxsYmFja3MuCisgICAgICAgIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzExMDU5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIEF0dHIgYmVpbmcgYSBmcmllbmQgb2YgRWxlbWVu dCBhbmQgZ3JhYmJpbmcgYXQgdmFyaW91cyBpbnRlcm5hbCBzdG9yYWdlIGFuZCBjYWxsYmFja3Ms CisgICAgICAgIGxldCBBdHRyIHNpbXBseSBjYWxsIEVsZW1lbnQ6OnNldEF0dHJpYnV0ZSgpIHdo ZW4gaXRzIHZhbHVlIGlzIGNoYW5nZWQsIGFuZCBkbyBhbGwgdGhhdCBidXNpbmVzcworICAgICAg ICBmcm9tIEVsZW1lbnQuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAqIGRv bS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnNldEF0dHJpYnV0ZUlu dGVybmFsKToKKworICAgICAgICAgICAgQ2FsbCBBdHRyOjpyZWNyZWF0ZVRleHRDaGlsZEFmdGVy QXR0cmlidXRlVmFsdWVDaGFuZ2VkKCkgYWZ0ZXIgbW9kaWZ5aW5nIGFuIGF0dHJpYnV0ZSB2YWx1 ZSBpbnN0ZWFkCisgICAgICAgICAgICBvZiBkb2luZyB0aGUgbW9kaWZpY2F0aW9uIHRocm91Z2gg dGhlIEF0dHIgbm9kZS4KKworICAgICAgICAqIGRvbS9BdHRyLmg6CisgICAgICAgICogZG9tL0F0 dHIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXR0cjo6QXR0cik6CisgICAgICAgIChXZWJDb3Jl OjpBdHRyOjpjaGlsZHJlbkNoYW5nZWQpOgorCisgICAgICAgICAgICBBZGRlZCBhbiBtX2luQ2hp bGRyZW5DaGFuZ2VkIGZsYWcgc28gd2UgY2FuIHByZXZlbnQgaW5maW5pdGUgY2FsbGJhY2sgcmVj dXJzaW9uIGluIGNoaWxkcmVuQ2hhbmdlZCgpLgorCisgICAgICAgIChXZWJDb3JlOjpBdHRyOjpz ZXRWYWx1ZSk6CisKKyAgICAgICAgICAgIENhbGwgRWxlbWVudDo6c2V0QXR0cmlidXRlKCkgaW5z dGVhZCBvZiBtb2RpZnlpbmcgdGhlIGF0dHJpYnV0ZSBzdG9yYWdlIGRpcmVjdGx5LgorCisgICAg ICAgIChXZWJDb3JlOjpBdHRyOjpyZWNyZWF0ZVRleHRDaGlsZEFmdGVyQXR0cmlidXRlVmFsdWVD aGFuZ2VkKToKKworICAgICAgICAgICAgRmFjdG9yZWQgb3V0IHRoZSAicmVtb3ZlIGFsbCBjaGls ZHJlbiAvIGNyZWF0ZSBhIG5ldyB0ZXh0IGNoaWxkIHdpdGggYXR0cmlidXRlIHZhbHVlIiBsb2dp YyBpbnRvCisgICAgICAgICAgICBhIHNlcGFyYXRlIGZ1bmN0aW9uLgorCisyMDEzLTAyLTIyICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBHbHlwaFBhZ2U6IEFM V0FZU19JTkxJTkUgYWxsIHBlcmZvcm1hbmNlLXJlbGV2YW50IGdldHRlcnMuCiAKICAgICAgICAg UkVHUkVTU0lPTihyMTQzMTI1KTogfjUlIHBlcmZvcm1hbmNlIGhpdCBvbiBDaHJvbWl1bSdzIGlu dGwyIHBhZ2UgY3ljbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQXR0ci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vQXR0ci5jcHAKaW5kZXggNmUxYThhYy4uNzM0Njc2YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9BdHRyLmNwcApAQCAtMyw3ICszLDcgQEAKICAqICAgICAgICAgICAoQykgMTk5OSBBbnR0 aSBLb2l2aXN0byAoa29pdmlzdG9Aa2RlLm9yZykKICAqICAgICAgICAgICAoQykgMjAwMSBQZXRl ciBLZWxseSAocG1rQHBvc3QuY29tKQogICogICAgICAgICAgIChDKSAyMDAxIERpcmsgTXVlbGxl ciAobXVlbGxlckBrZGUub3JnKQotICogQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2LCAy MDA3LCAyMDA5LCAyMDEwLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAwNywgMjAwOSwgMjAxMCwgMjAxMiwg MjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5 IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9k aWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMK QEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJTdHlsZWRFbGVtZW50LmgiCiAjaW5jbHVkZSAi VGV4dC5oIgogI2luY2x1ZGUgIlhNTE5TTmFtZXMuaCIKKyNpbmNsdWRlIDx3dGYvVGVtcG9yYXJ5 Q2hhbmdlLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CiAjaW5jbHVkZSA8 d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogCkBAIC00MSw2ICs0Miw3IEBAIEF0dHI6OkF0dHIo RWxlbWVudCogZWxlbWVudCwgY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkKICAgICAsIG1fZWxl bWVudChlbGVtZW50KQogICAgICwgbV9uYW1lKG5hbWUpCiAgICAgLCBtX2lnbm9yZUNoaWxkcmVu Q2hhbmdlZCgwKQorICAgICwgbV9pbkNoaWxkcmVuQ2hhbmdlZChmYWxzZSkKICAgICAsIG1fc3Bl Y2lmaWVkKHRydWUpCiB7CiB9CkBAIC01MSw2ICs1Myw3IEBAIEF0dHI6OkF0dHIoRG9jdW1lbnQq IGRvY3VtZW50LCBjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpbmcm IHN0CiAgICAgLCBtX25hbWUobmFtZSkKICAgICAsIG1fc3RhbmRhbG9uZVZhbHVlKHN0YW5kYWxv bmVWYWx1ZSkKICAgICAsIG1faWdub3JlQ2hpbGRyZW5DaGFuZ2VkKDApCisgICAgLCBtX2luQ2hp bGRyZW5DaGFuZ2VkKGZhbHNlKQogICAgICwgbV9zcGVjaWZpZWQodHJ1ZSkKIHsKIH0KQEAgLTEw NywzMCArMTEwLDMyIEBAIHZvaWQgQXR0cjo6c2V0UHJlZml4KGNvbnN0IEF0b21pY1N0cmluZyYg cHJlZml4LCBFeGNlcHRpb25Db2RlJiBlYykKICAgICBtX25hbWUuc2V0UHJlZml4KG5ld1ByZWZp eCk7CiB9CiAKLXZvaWQgQXR0cjo6c2V0VmFsdWUoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkK K3ZvaWQgQXR0cjo6cmVjcmVhdGVUZXh0Q2hpbGRBZnRlckF0dHJpYnV0ZVZhbHVlQ2hhbmdlZCgp CiB7CisgICAgaWYgKG1faW5DaGlsZHJlbkNoYW5nZWQpCisgICAgICAgIHJldHVybjsKICAgICBF dmVudFF1ZXVlU2NvcGUgc2NvcGU7CiAgICAgbV9pZ25vcmVDaGlsZHJlbkNoYW5nZWQrKzsKICAg ICByZW1vdmVDaGlsZHJlbigpOwotICAgIGlmIChtX2VsZW1lbnQpCi0gICAgICAgIGVsZW1lbnRB dHRyaWJ1dGUoKS5zZXRWYWx1ZSh2YWx1ZSk7Ci0gICAgZWxzZQotICAgICAgICBtX3N0YW5kYWxv bmVWYWx1ZSA9IHZhbHVlOwogICAgIGNyZWF0ZVRleHRDaGlsZCgpOwogICAgIG1faWdub3JlQ2hp bGRyZW5DaGFuZ2VkLS07Cit9CiAKK3ZvaWQgQXR0cjo6c2V0VmFsdWUoY29uc3QgQXRvbWljU3Ry aW5nJiB2YWx1ZSkKK3sKICAgICBpbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNJbkFuY2VzdG9ycygm bV9uYW1lLCBtX2VsZW1lbnQpOworCisgICAgaWYgKG1fZWxlbWVudCkgeworICAgICAgICBtX2Vs ZW1lbnQtPnNldEF0dHJpYnV0ZShtX25hbWUsIHZhbHVlKTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKyAgICBtX3N0YW5kYWxvbmVWYWx1ZSA9IHZhbHVlOworICAgIHJlY3JlYXRlVGV4dENoaWxk QWZ0ZXJBdHRyaWJ1dGVWYWx1ZUNoYW5nZWQoKTsKIH0KIAogdm9pZCBBdHRyOjpzZXRWYWx1ZShj b25zdCBBdG9taWNTdHJpbmcmIHZhbHVlLCBFeGNlcHRpb25Db2RlJikKIHsKLSAgICBpZiAobV9l bGVtZW50KQotICAgICAgICBtX2VsZW1lbnQtPndpbGxNb2RpZnlBdHRyaWJ1dGUocXVhbGlmaWVk TmFtZSgpLCB0aGlzLT52YWx1ZSgpLCB2YWx1ZSk7Ci0KICAgICBzZXRWYWx1ZSh2YWx1ZSk7Ci0K LSAgICBpZiAobV9lbGVtZW50KQotICAgICAgICBtX2VsZW1lbnQtPmRpZE1vZGlmeUF0dHJpYnV0 ZShxdWFsaWZpZWROYW1lKCksIHZhbHVlKTsKIH0KIAogdm9pZCBBdHRyOjpzZXROb2RlVmFsdWUo Y29uc3QgU3RyaW5nJiB2LCBFeGNlcHRpb25Db2RlJiBlYykKQEAgLTE2Miw3ICsxNjcsNyBAQCB2 b2lkIEF0dHI6OmNoaWxkcmVuQ2hhbmdlZChib29sLCBOb2RlKiwgTm9kZSosIGludCkKICAgICBp ZiAobV9pZ25vcmVDaGlsZHJlbkNoYW5nZWQgPiAwKQogICAgICAgICByZXR1cm47CiAKLSAgICBp bnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNJbkFuY2VzdG9ycygmcXVhbGlmaWVkTmFtZSgpLCBtX2Vs ZW1lbnQpOworICAgIFRlbXBvcmFyeUNoYW5nZTxib29sPiBjaGFuZ2VJbkNoaWxkcmVuQ2hhbmdl ZChtX2luQ2hpbGRyZW5DaGFuZ2VkLCB0cnVlKTsKIAogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQg aW5jbHVkZSBlbnRpdHkgcmVmZXJlbmNlcyBpbiB0aGUgdmFsdWUKIApAQCAtMTcyLDE3ICsxNzcs NyBAQCB2b2lkIEF0dHI6OmNoaWxkcmVuQ2hhbmdlZChib29sLCBOb2RlKiwgTm9kZSosIGludCkK ICAgICAgICAgICAgIHZhbHVlQnVpbGRlci5hcHBlbmQodG9UZXh0KG4pLT5kYXRhKCkpOwogICAg IH0KIAotICAgIEF0b21pY1N0cmluZyBuZXdWYWx1ZSA9IHZhbHVlQnVpbGRlci50b0F0b21pY1N0 cmluZygpOwotICAgIGlmIChtX2VsZW1lbnQpCi0gICAgICAgIG1fZWxlbWVudC0+d2lsbE1vZGlm eUF0dHJpYnV0ZShxdWFsaWZpZWROYW1lKCksIHZhbHVlKCksIG5ld1ZhbHVlKTsKLQotICAgIGlm IChtX2VsZW1lbnQpCi0gICAgICAgIGVsZW1lbnRBdHRyaWJ1dGUoKS5zZXRWYWx1ZShuZXdWYWx1 ZSk7Ci0gICAgZWxzZQotICAgICAgICBtX3N0YW5kYWxvbmVWYWx1ZSA9IG5ld1ZhbHVlOwotCi0g ICAgaWYgKG1fZWxlbWVudCkKLSAgICAgICAgbV9lbGVtZW50LT5hdHRyaWJ1dGVDaGFuZ2VkKHF1 YWxpZmllZE5hbWUoKSwgbmV3VmFsdWUpOworICAgIHNldFZhbHVlKHZhbHVlQnVpbGRlci50b0F0 b21pY1N0cmluZygpKTsKIH0KIAogYm9vbCBBdHRyOjppc0lkKCkgY29uc3QKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9BdHRyLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vQXR0ci5oCmlu ZGV4IDhlNzYwYWEuLjRmOWJhNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9BdHRy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIuaApAQCAtNjQsNiArNjQsOCBAQCBwdWJs aWM6CiAgICAgdm9pZCBhdHRhY2hUb0VsZW1lbnQoRWxlbWVudCopOwogICAgIHZvaWQgZGV0YWNo RnJvbUVsZW1lbnRXaXRoVmFsdWUoY29uc3QgQXRvbWljU3RyaW5nJik7CiAKKyAgICB2b2lkIHJl Y3JlYXRlVGV4dENoaWxkQWZ0ZXJBdHRyaWJ1dGVWYWx1ZUNoYW5nZWQoKTsKKwogcHJpdmF0ZToK ICAgICBBdHRyKEVsZW1lbnQqLCBjb25zdCBRdWFsaWZpZWROYW1lJik7CiAgICAgQXR0cihEb2N1 bWVudCosIGNvbnN0IFF1YWxpZmllZE5hbWUmLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKTsK QEAgLTEwMSw4ICsxMDMsOSBAQCBwcml2YXRlOgogICAgIEF0b21pY1N0cmluZyBtX3N0YW5kYWxv bmVWYWx1ZTsKIAogICAgIFJlZlB0cjxTdHlsZVByb3BlcnR5U2V0PiBtX3N0eWxlOwotICAgIHVu c2lnbmVkIG1faWdub3JlQ2hpbGRyZW5DaGFuZ2VkIDogMzE7Ci0gICAgYm9vbCBtX3NwZWNpZmll ZCA6IDE7CisgICAgdW5zaWduZWQgc2hvcnQgbV9pZ25vcmVDaGlsZHJlbkNoYW5nZWQ7CisgICAg Ym9vbCBtX2luQ2hpbGRyZW5DaGFuZ2VkOworICAgIGJvb2wgbV9zcGVjaWZpZWQ7CiB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggMjkyZGU5Mi4u YTQ2YjFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtODA4LDEzICs4MDgsMTAgQEAgaW5s aW5lIHZvaWQgRWxlbWVudDo6c2V0QXR0cmlidXRlSW50ZXJuYWwoc2l6ZV90IGluZGV4LCBjb25z dCBRdWFsaWZpZWROYW1lJiBuYW0KICAgICAgICAgd2lsbE1vZGlmeUF0dHJpYnV0ZShuYW1lLCBh dHRyaWJ1dGVJdGVtKGluZGV4KS0+dmFsdWUoKSwgbmV3VmFsdWUpOwogCiAgICAgaWYgKG5ld1Zh bHVlICE9IGF0dHJpYnV0ZUl0ZW0oaW5kZXgpLT52YWx1ZSgpKSB7Ci0gICAgICAgIC8vIElmIHRo ZXJlIGlzIGFuIEF0dHIgbm9kZSBob29rZWQgdG8gdGhpcyBhdHRyaWJ1dGUsIHRoZSBBdHRyOjpz ZXRWYWx1ZSgpIGNhbGwgYmVsb3cKLSAgICAgICAgLy8gd2lsbCB3cml0ZSBpbnRvIHRoZSBFbGVt ZW50RGF0YS4KLSAgICAgICAgLy8gRklYTUU6IFJlZmFjdG9yIHRoaXMgc28gaXQgbWFrZXMgc29t ZSBzZW5zZS4KKyAgICAgICAgZW5zdXJlVW5pcXVlRWxlbWVudERhdGEoKS0+YXR0cmlidXRlSXRl bShpbmRleCktPnNldFZhbHVlKG5ld1ZhbHVlKTsKKwogICAgICAgICBpZiAoUmVmUHRyPEF0dHI+ IGF0dHJOb2RlID0gaW5TeW5jaHJvbml6YXRpb25PZkxhenlBdHRyaWJ1dGUgPyAwIDogYXR0cklm RXhpc3RzKG5hbWUpKQotICAgICAgICAgICAgYXR0ck5vZGUtPnNldFZhbHVlKG5ld1ZhbHVlKTsK LSAgICAgICAgZWxzZQotICAgICAgICAgICAgZW5zdXJlVW5pcXVlRWxlbWVudERhdGEoKS0+YXR0 cmlidXRlSXRlbShpbmRleCktPnNldFZhbHVlKG5ld1ZhbHVlKTsKKyAgICAgICAgICAgIGF0dHJO b2RlLT5yZWNyZWF0ZVRleHRDaGlsZEFmdGVyQXR0cmlidXRlVmFsdWVDaGFuZ2VkKCk7CiAgICAg fQogCiAgICAgaWYgKCFpblN5bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5oCmluZGV4IDg2OGIxZWQuLjc1ZDRhMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtNjM3 LDkgKzYzNyw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRpZEFkZFVzZXJBZ2VudFNo YWRvd1Jvb3QoU2hhZG93Um9vdCopIHsgfQogICAgIHZpcnR1YWwgYm9vbCBhbHdheXNDcmVhdGVV c2VyQWdlbnRTaGFkb3dSb290KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAotICAgIC8vIEZJ WE1FOiBSZW1vdmUgdGhlIG5lZWQgZm9yIEF0dHIgdG8gY2FsbCB3aWxsTW9kaWZ5QXR0cmlidXRl L2RpZE1vZGlmeUF0dHJpYnV0ZS4KLSAgICBmcmllbmQgY2xhc3MgQXR0cjsKLQogICAgIGVudW0g U3luY2hyb25pemF0aW9uT2ZMYXp5QXR0cmlidXRlIHsgTm90SW5TeW5jaHJvbml6YXRpb25PZkxh enlBdHRyaWJ1dGUgPSAwLCBJblN5bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSB9OwogCiAg ICAgdm9pZCBkaWRBZGRBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGNvbnN0IEF0b21p Y1N0cmluZyYpOwo=