110593 2013-02-22 05:18:31 -0800 Web Inspector: InspectorPageAgent::disable() should not update view metrics regardless of the override state 2013-02-22 05:43:18 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 839477 0 apavlov 2013-02-22 05:18:31 -0800 Patch to follow. 839479 1 189750 apavlov 2013-02-22 05:21:59 -0800 Created attachment 189750 Patch 839509 2 apavlov 2013-02-22 05:43:18 -0800 Committed r143721: <http://trac.webkit.org/changeset/143721> 189750 2013-02-22 05:21:59 -0800 2013-02-22 05:32:41 -0800 Patch bug-110593-20130222171818.patch text/plain 5309 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQyY2UwMTMwMGIwYTNi MWM4OTcyODE3YTFiNjIzZjI1NzJmMWJhZS4uNzNmMmJkMjg1MDMwNDIyYzI5NDlmY2Q0YTdjMjRj MWFjM2MyNGZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTIyICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW5zcGVjdG9yUGFnZUFnZW50OjpkaXNhYmxlKCkgc2hvdWxkIG5vdCB1cGRhdGUgdmll dyBtZXRyaWNzIHJlZ2FyZGxlc3Mgb2YgdGhlIG92ZXJyaWRlIHN0YXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1OTMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3JQYWdlQWdlbnQ6OmRp c2FibGUoKSBub3cgY2hlY2tzIGlmIHRoZSBkZXZpY2UgbWV0cmljcyBhcmUgb3ZlcnJpZGRlbiBi ZWZvcmUKKyAgICAgICAgdGVsbGluZyB0aGUgY2xpZW50IHRvIGRpc2FibGUgdGhlIG92ZXJyaWRl LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JQYWdlQWdlbnQ6OmRpc2FibGUpOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9yUGFnZUFnZW50OjpzZXREZXZpY2VNZXRyaWNzT3ZlcnJpZGUpOgorICAgICAg ICAoV2ViQ29yZTo6SW5zcGVjdG9yUGFnZUFnZW50OjpkZXZpY2VNZXRyaWNzQ2hhbmdlZCk6Cisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5oOgorICAgICAgICAoSW5zcGVj dG9yUGFnZUFnZW50KToKKwogMjAxMy0wMi0yMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhbGxvdyBvcHRpbmcgb3V0IGZy b20gdmVydGljYWwgc3BsaXQgaW4gdGhlIGRvY2stdG8tcmlnaHQgbW9kZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNwcAppbmRleCA3YTFlYjE0NDA5 MjlmZWNhNDY2YTM5MmRhNDM2MmQ0MDEzZDczYTI4Li43ZTljMzYwNTIzMzlmYTg4ZjIzYzA4Yjc1 MDdmNDc5M2E3ZDA5Nzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yUGFnZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yUGFnZUFnZW50LmNwcApAQCAtNDAyLDYgKzQwMiw3IEBAIHZvaWQgSW5zcGVjdG9yUGFnZUFn ZW50OjpkaXNhYmxlKEVycm9yU3RyaW5nKikKIHsKICAgICBtX2VuYWJsZWQgPSBmYWxzZTsKICAg ICBtX3N0YXRlLT5zZXRCb29sZWFuKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdlbnRFbmFibGVkLCBm YWxzZSk7CisgICAgbV9zdGF0ZS0+cmVtb3ZlKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdlbnRTY3Jp cHRzVG9FdmFsdWF0ZU9uTG9hZCk7CiAgICAgbV9pbnN0cnVtZW50aW5nQWdlbnRzLT5zZXRJbnNw ZWN0b3JQYWdlQWdlbnQoMCk7CiAKICAgICBzZXRTY3JpcHRFeGVjdXRpb25EaXNhYmxlZCgwLCBm YWxzZSk7CkBAIC00MTEsMTMgKzQxMiwxNSBAQCB2b2lkIEluc3BlY3RvclBhZ2VBZ2VudDo6ZGlz YWJsZShFcnJvclN0cmluZyopCiAgICAgc2V0RW11bGF0ZWRNZWRpYSgwLCAiIik7CiAgICAgc2V0 Q29udGludW91c1BhaW50aW5nRW5hYmxlZCgwLCBmYWxzZSk7CiAKLSAgICAvLyBXaGVuIGRpc2Fi bGluZyB0aGUgYWdlbnQsIHJlc2V0IHRoZSBvdmVycmlkZSB2YWx1ZXMuCisgICAgaWYgKCFkZXZp Y2VNZXRyaWNzQ2hhbmdlZCgwLCAwLCAxLCBmYWxzZSkpCisgICAgICAgIHJldHVybjsKKworICAg IC8vIFdoZW4gZGlzYWJsaW5nIHRoZSBhZ2VudCwgcmVzZXQgdGhlIG92ZXJyaWRlIHZhbHVlcyBp ZiBuZWNlc3NhcnkuCisgICAgdXBkYXRlVmlld01ldHJpY3MoMCwgMCwgMSwgZmFsc2UpOwogICAg IG1fc3RhdGUtPnNldExvbmcoUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudFNjcmVlbldpZHRoT3Zl cnJpZGUsIDApOwogICAgIG1fc3RhdGUtPnNldExvbmcoUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2Vu dFNjcmVlbkhlaWdodE92ZXJyaWRlLCAwKTsKICAgICBtX3N0YXRlLT5zZXREb3VibGUoUGFnZUFn ZW50U3RhdGU6OnBhZ2VBZ2VudEZvbnRTY2FsZUZhY3Rvck92ZXJyaWRlLCAxKTsKICAgICBtX3N0 YXRlLT5zZXRCb29sZWFuKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdlbnRGaXRXaW5kb3csIGZhbHNl KTsKLSAgICBtX3N0YXRlLT5yZW1vdmUoUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudFNjcmlwdHNU b0V2YWx1YXRlT25Mb2FkKTsKLSAgICB1cGRhdGVWaWV3TWV0cmljcygwLCAwLCAxLCBmYWxzZSk7 CiB9CiAKIHZvaWQgSW5zcGVjdG9yUGFnZUFnZW50OjphZGRTY3JpcHRUb0V2YWx1YXRlT25Mb2Fk KEVycm9yU3RyaW5nKiwgY29uc3QgU3RyaW5nJiBzb3VyY2UsIFN0cmluZyogaWRlbnRpZmllcikK QEAgLTcxNywxMyArNzIwLDcgQEAgdm9pZCBJbnNwZWN0b3JQYWdlQWdlbnQ6OnNldERldmljZU1l dHJpY3NPdmVycmlkZShFcnJvclN0cmluZyogZXJyb3JTdHJpbmcsIGludAogICAgICAgICByZXR1 cm47CiAgICAgfQogCi0gICAgLy8gVGhlc2UgdHdvIGFsd2F5cyBmaXQgYW4gaW50LgotICAgIGlu dCBjdXJyZW50V2lkdGggPSBzdGF0aWNfY2FzdDxpbnQ+KG1fc3RhdGUtPmdldExvbmcoUGFnZUFn ZW50U3RhdGU6OnBhZ2VBZ2VudFNjcmVlbldpZHRoT3ZlcnJpZGUpKTsKLSAgICBpbnQgY3VycmVu dEhlaWdodCA9IHN0YXRpY19jYXN0PGludD4obV9zdGF0ZS0+Z2V0TG9uZyhQYWdlQWdlbnRTdGF0 ZTo6cGFnZUFnZW50U2NyZWVuSGVpZ2h0T3ZlcnJpZGUpKTsKLSAgICBkb3VibGUgY3VycmVudEZv bnRTY2FsZUZhY3RvciA9IG1fc3RhdGUtPmdldERvdWJsZShQYWdlQWdlbnRTdGF0ZTo6cGFnZUFn ZW50Rm9udFNjYWxlRmFjdG9yT3ZlcnJpZGUpOwotICAgIGJvb2wgY3VycmVudEZpdFdpbmRvdyA9 IG1fc3RhdGUtPmdldEJvb2xlYW4oUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudEZpdFdpbmRvdyk7 Ci0KLSAgICBpZiAod2lkdGggPT0gY3VycmVudFdpZHRoICYmIGhlaWdodCA9PSBjdXJyZW50SGVp Z2h0ICYmIGZvbnRTY2FsZUZhY3RvciA9PSBjdXJyZW50Rm9udFNjYWxlRmFjdG9yICYmIGZpdFdp bmRvdyA9PSBjdXJyZW50Rml0V2luZG93KQorICAgIGlmICghZGV2aWNlTWV0cmljc0NoYW5nZWQo d2lkdGgsIGhlaWdodCwgZm9udFNjYWxlRmFjdG9yLCBmaXRXaW5kb3cpKQogICAgICAgICByZXR1 cm47CiAKICAgICBtX3N0YXRlLT5zZXRMb25nKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdlbnRTY3Jl ZW5XaWR0aE92ZXJyaWRlLCB3aWR0aCk7CkBAIC03MzQsNiArNzMxLDE3IEBAIHZvaWQgSW5zcGVj dG9yUGFnZUFnZW50OjpzZXREZXZpY2VNZXRyaWNzT3ZlcnJpZGUoRXJyb3JTdHJpbmcqIGVycm9y U3RyaW5nLCBpbnQKICAgICB1cGRhdGVWaWV3TWV0cmljcyh3aWR0aCwgaGVpZ2h0LCBmb250U2Nh bGVGYWN0b3IsIGZpdFdpbmRvdyk7CiB9CiAKK2Jvb2wgSW5zcGVjdG9yUGFnZUFnZW50OjpkZXZp Y2VNZXRyaWNzQ2hhbmdlZChpbnQgd2lkdGgsIGludCBoZWlnaHQsIGRvdWJsZSBmb250U2NhbGVG YWN0b3IsIGJvb2wgZml0V2luZG93KQoreworICAgIC8vIFRoZXNlIHR3byBhbHdheXMgZml0IGFu IGludC4KKyAgICBpbnQgY3VycmVudFdpZHRoID0gc3RhdGljX2Nhc3Q8aW50PihtX3N0YXRlLT5n ZXRMb25nKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdlbnRTY3JlZW5XaWR0aE92ZXJyaWRlKSk7Cisg ICAgaW50IGN1cnJlbnRIZWlnaHQgPSBzdGF0aWNfY2FzdDxpbnQ+KG1fc3RhdGUtPmdldExvbmco UGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudFNjcmVlbkhlaWdodE92ZXJyaWRlKSk7CisgICAgZG91 YmxlIGN1cnJlbnRGb250U2NhbGVGYWN0b3IgPSBtX3N0YXRlLT5nZXREb3VibGUoUGFnZUFnZW50 U3RhdGU6OnBhZ2VBZ2VudEZvbnRTY2FsZUZhY3Rvck92ZXJyaWRlKTsKKyAgICBib29sIGN1cnJl bnRGaXRXaW5kb3cgPSBtX3N0YXRlLT5nZXRCb29sZWFuKFBhZ2VBZ2VudFN0YXRlOjpwYWdlQWdl bnRGaXRXaW5kb3cpOworCisgICAgcmV0dXJuIHdpZHRoICE9IGN1cnJlbnRXaWR0aCB8fCBoZWln aHQgIT0gY3VycmVudEhlaWdodCB8fCBmb250U2NhbGVGYWN0b3IgIT0gY3VycmVudEZvbnRTY2Fs ZUZhY3RvciB8fCBmaXRXaW5kb3cgIT0gY3VycmVudEZpdFdpbmRvdzsKK30KKwogdm9pZCBJbnNw ZWN0b3JQYWdlQWdlbnQ6OnNldFNob3dQYWludFJlY3RzKEVycm9yU3RyaW5nKiwgYm9vbCBzaG93 KQogewogICAgIG1fc3RhdGUtPnNldEJvb2xlYW4oUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudFNo b3dQYWludFJlY3RzLCBzaG93KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JQYWdlQWdlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JQYWdlQWdlbnQuaAppbmRleCBkZTI0ZmM0N2IyZDM4MDViNzU3YTM5MGI4YWQ3OWY3ODA1ZjM2 Yzk1Li5kOTYwMzAzN2MwZjg0YmMzMmY1NGFhODQyODg0MzgxMDA2NDJlNzVmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5oCkBAIC0xODAsNiArMTgw LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIEluc3BlY3RvclBhZ2VBZ2VudChJbnN0cnVt ZW50aW5nQWdlbnRzKiwgUGFnZSosIEluc3BlY3RvckFnZW50KiwgSW5zcGVjdG9yQ29tcG9zaXRl U3RhdGUqLCBJbmplY3RlZFNjcmlwdE1hbmFnZXIqLCBJbnNwZWN0b3JDbGllbnQqLCBJbnNwZWN0 b3JPdmVybGF5Kik7CisgICAgYm9vbCBkZXZpY2VNZXRyaWNzQ2hhbmdlZChpbnQgd2lkdGgsIGlu dCBoZWlnaHQsIGRvdWJsZSBmb250U2NhbGVGYWN0b3IsIGJvb2wgZml0V2luZG93KTsKICAgICB2 b2lkIHVwZGF0ZVZpZXdNZXRyaWNzKGludCwgaW50LCBkb3VibGUsIGJvb2wpOwogI2lmIEVOQUJM RShUT1VDSF9FVkVOVFMpCiAgICAgdm9pZCB1cGRhdGVUb3VjaEV2ZW50RW11bGF0aW9uSW5QYWdl KGJvb2wpOwo=