110592 2013-02-22 05:08:18 -0800 Web Inspector: [Chromium] add a browser test for frames on timeline 2013-02-22 05:56:18 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 839472 0 caseq 2013-02-22 05:08:18 -0800 The existing layout tests emit artificial frame signals. We need some integration test to make sure real frame signals actually reach the inspector. 839476 1 189749 caseq 2013-02-22 05:17:03 -0800 Created attachment 189749 Patch 839500 2 189749 yurys 2013-02-22 05:39:25 -0800 Comment on attachment 189749 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189749&action=review > Source/WebKit/chromium/ChangeLog:7 > + Missing description. > Source/WebKit/chromium/src/js/Tests.js:602 > + test.assertTrue(frameCount >= 5, "Not enough frames"); Can you add a link to the test file? 839502 3 caseq 2013-02-22 05:39:33 -0800 Counterpart change in chromium land: https://codereview.chromium.org/12310063/ 839524 4 caseq 2013-02-22 05:56:18 -0800 Committed r143725: <http://trac.webkit.org/changeset/143725> 189749 2013-02-22 05:17:03 -0800 2013-02-22 05:39:25 -0800 Patch bug-110592-20130222171322.patch text/plain 6969 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBkYzEzZGJkMDc0ODU5NGFjMTcyMTIxMWZiMTA1NWZmNWExNDg1YTIuLjE5MjA5ZjUwNjA0YTBh ZTM0MTJmNzM0M2IyMzhmZTU1ODM3ZTA1ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTMtMDItMjIgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIGFkZCBhIGJyb3dz ZXIgdGVzdCBmb3IgZnJhbWVzIG9uIHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9qcy9UZXN0cy5qczoKKyAgICAgICAgKC5UZXN0 U3VpdGUucHJvdG90eXBlLmFzc2VydEhhc0tleSk6CisgICAgICAgICguVGVzdFN1aXRlLnByb3Rv dHlwZS50ZXN0VGltZWxpbmVGcmFtZXMuc3RlcDEpOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90 b3R5cGUudGVzdFRpbWVsaW5lRnJhbWVzLm9uVGltZWxpbmVSZWNvcmRlZCk6CisgICAgICAgICgu VGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0VGltZWxpbmVGcmFtZXMpOgorICAgICAgICAoLlRlc3RT dWl0ZS5wcm90b3R5cGUudGVzdFBhZ2VPdmVybGF5VXBkYXRlLnN0ZXA0KToKKyAgICAgICAgKC5U ZXN0U3VpdGUucHJvdG90eXBlLnRlc3RQYWdlT3ZlcmxheVVwZGF0ZS5vblRpbWVsaW5lUmVjb3Jk ZWQpOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUucmVjb3JkVGltZWxpbmUuYWRkUmVj b3JkKToKKyAgICAgICAgKC5UZXN0U3VpdGUucHJvdG90eXBlLnJlY29yZFRpbWVsaW5lLmlubmVy QWRkUmVjb3JkKToKKyAgICAgICAgKC5UZXN0U3VpdGUucHJvdG90eXBlLnJlY29yZFRpbWVsaW5l LmRvbmUpOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUucmVjb3JkVGltZWxpbmUpOgor ICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUuc3RvcFRpbWVsaW5lKToKKwogMjAxMy0wMi0y MSAgQWxlYyBGbGV0dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhl ZERCOiBJbXBsZW1lbnQgU2hhcmVkQnVmZmVyIHZlcnNpb24gb2YgcHV0KCkgLyBvblN1Y2Nlc3Mo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5qcwppbmRleCBiMTA0NjFjZGQyNzJh YTI2ODI0ZjRlY2JjNzBiZGQ0YTYzMjBkZDViLi4yOTA2MmNjNjdmZDMzNjZjMjBjMTM3MWRiNDY1 NjMwYzgyODhlYzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9U ZXN0cy5qcworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5qcwpAQCAt OTMsNiArOTMsMTggQEAgVGVzdFN1aXRlLnByb3RvdHlwZS5hc3NlcnRUcnVlID0gZnVuY3Rpb24o dmFsdWUsIG9wdF9tZXNzYWdlKQogCiAKIC8qKgorICogSGFzS2V5IGFzc2VydGlvbiB0ZXN0cyB0 aGF0IG9iamVjdCBoYXMgZ2l2ZW4ga2V5LgorICogQHBhcmFtIHtPYmplY3R9IG9iamVjdAorICog QHBhcmFtIHtzdHJpbmd9IGtleQorICovCitUZXN0U3VpdGUucHJvdG90eXBlLmFzc2VydEhhc0tl eSA9IGZ1bmN0aW9uKG9iamVjdCwga2V5KQoreworICAgIGlmICghb2JqZWN0Lmhhc093blByb3Bl cnR5KGtleSkpCisgICAgICAgIHRoaXMuZmFpbCgiRXhwZWN0ZWQgb2JqZWN0IHRvIGNvbnRhaW4g a2V5ICciICsga2V5ICsgIiciKTsKK307CisKKworLyoqCiAgKiBDb250YWlucyBhc3NlcnRpb24g dGVzdHMgdGhhdCBzdHJpbmcgY29udGFpbnMgc3Vic3RyaW5nLgogICogQHBhcmFtIHtzdHJpbmd9 IHN0cmluZyBPdXRlci4KICAqIEBwYXJhbSB7c3RyaW5nfSBzdWJzdHJpbmcgSW5uZXIuCkBAIC01 NTQsMjkgKzU2Niw1MiBAQCBUZXN0U3VpdGUucHJvdG90eXBlLnRlc3RQYXVzZUluU2hhcmVkV29y a2VySW5pdGlhbGl6YXRpb24gPSBmdW5jdGlvbigpCiAgICAgdGhpcy50YWtlQ29udHJvbCgpOwog fTsKIAotCi0vLyBSZWdyZXNzaW9uIHRlc3QgZm9yIGh0dHA6Ly93ZWJrLml0Lzk3NDY2Ci1UZXN0 U3VpdGUucHJvdG90eXBlLnRlc3RQYWdlT3ZlcmxheVVwZGF0ZSA9IGZ1bmN0aW9uKCkKKy8qKgor ICogVGVzdHMgdGhhdCB0aW1lbGluZSByZWNlaXZlcyBmcmFtZSBzaWduYWxzLgorICovCitUZXN0 U3VpdGUucHJvdG90eXBlLnRlc3RUaW1lbGluZUZyYW1lcyA9IGZ1bmN0aW9uKCkKIHsKICAgICB2 YXIgdGVzdCA9IHRoaXM7Ci0gICAgdmFyIHJlY29yZHMgPSBbXTsKLSAgICB2YXIgZGlzcGF0Y2hP blJlY29yZFR5cGUgPSB7fQogCi0gICAgZnVuY3Rpb24gYWRkUmVjb3JkKGV2ZW50KQorICAgIGZ1 bmN0aW9uIHN0ZXAxKCkKICAgICB7Ci0gICAgICAgIGlubmVyQWRkUmVjb3JkKGV2ZW50LmRhdGEp OworICAgICAgICB0ZXN0LnJlY29yZFRpbWVsaW5lKG9uVGltZWxpbmVSZWNvcmRlZCk7CisgICAg ICAgIHRlc3QuZXZhbHVhdGVJbkNvbnNvbGVfKCJydW5UZXN0KCkiLCBmdW5jdGlvbigpe30pOwog ICAgIH0KIAotICAgIGZ1bmN0aW9uIGlubmVyQWRkUmVjb3JkKHJlY29yZCkKKyAgICBmdW5jdGlv biBvblRpbWVsaW5lUmVjb3JkZWQocmVjb3JkcykKICAgICB7Ci0gICAgICAgIHJlY29yZHMucHVz aChyZWNvcmQpOwotICAgICAgICBpZiAodHlwZW9mIGRpc3BhdGNoT25SZWNvcmRUeXBlW3JlY29y ZC50eXBlXSA9PT0gImZ1bmN0aW9uIikKLSAgICAgICAgICAgIGRpc3BhdGNoT25SZWNvcmRUeXBl W3JlY29yZC50eXBlXShyZWNvcmQpOwotCi0gICAgICAgIGlmIChyZWNvcmQuY2hpbGRyZW4pCi0g ICAgICAgICAgICByZWNvcmQuY2hpbGRyZW4uZm9yRWFjaChpbm5lckFkZFJlY29yZCk7CisgICAg ICAgIHZhciBmcmFtZUNvdW50ID0gMDsKKyAgICAgICAgdmFyIHJlY29yZHNJbkZyYW1lID0ge307 CisKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByZWNvcmRzLmxlbmd0aDsgKytpKSB7Cisg ICAgICAgICAgICB2YXIgcmVjb3JkID0gcmVjb3Jkc1tpXTsKKyAgICAgICAgICAgIGlmIChyZWNv cmQudHlwZSAhPT0gIkJlZ2luRnJhbWUiKSB7CisgICAgICAgICAgICAgICAgcmVjb3Jkc0luRnJh bWVbcmVjb3JkLnR5cGVdID0gKHJlY29yZHNJbkZyYW1lW3JlY29yZC50eXBlXSB8fCAwKSArIDE7 CisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBp ZiAoIWZyYW1lQ291bnQrKykKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAg IAorICAgICAgICAgICAgdGVzdC5hc3NlcnRIYXNLZXkocmVjb3Jkc0luRnJhbWUsICJGaXJlQW5p bWF0aW9uRnJhbWUiKTsKKyAgICAgICAgICAgIHRlc3QuYXNzZXJ0SGFzS2V5KHJlY29yZHNJbkZy YW1lLCAiTGF5b3V0Iik7CisgICAgICAgICAgICB0ZXN0LmFzc2VydEhhc0tleShyZWNvcmRzSW5G cmFtZSwgIlJlY2FsY3VsYXRlU3R5bGVzIik7CisgICAgICAgICAgICB0ZXN0LmFzc2VydEhhc0tl eShyZWNvcmRzSW5GcmFtZSwgIlBhaW50Iik7CisgICAgICAgICAgICByZWNvcmRzSW5GcmFtZSA9 IHt9OworICAgICAgICB9CisgICAgICAgIHRlc3QuYXNzZXJ0VHJ1ZShmcmFtZUNvdW50ID49IDUs ICJOb3QgZW5vdWdoIGZyYW1lcyIpOworICAgICAgICB0ZXN0LnJlbGVhc2VDb250cm9sKCk7CiAg ICAgfQogCisgICAgc3RlcDEoKTsKKyAgICB0ZXN0LnRha2VDb250cm9sKCk7Cit9CisKKy8vIFJl Z3Jlc3Npb24gdGVzdCBmb3IgaHR0cDovL3dlYmsuaXQvOTc0NjYKK1Rlc3RTdWl0ZS5wcm90b3R5 cGUudGVzdFBhZ2VPdmVybGF5VXBkYXRlID0gZnVuY3Rpb24oKQoreworICAgIHZhciB0ZXN0ID0g dGhpczsKKwogICAgIGZ1bmN0aW9uIHBvcHVsYXRlUGFnZSgpCiAgICAgewogICAgICAgICB2YXIg ZGl2MSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwpAQCAtNTkxLDkgKzYyNiw3IEBA IFRlc3RTdWl0ZS5wcm90b3R5cGUudGVzdFBhZ2VPdmVybGF5VXBkYXRlID0gZnVuY3Rpb24oKQog CiAgICAgZnVuY3Rpb24gc3RlcDEoKQogICAgIHsKLSAgICAgICAgV2ViSW5zcGVjdG9yLnRpbWVs aW5lTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIu RXZlbnRUeXBlcy5UaW1lbGluZUV2ZW50UmVjb3JkZWQsIGFkZFJlY29yZCk7Ci0gICAgICAgIFdl Ykluc3BlY3Rvci50aW1lbGluZU1hbmFnZXIuc3RhcnQoKTsKLQorICAgICAgICB0ZXN0LnJlY29y ZFRpbWVsaW5lKG9uVGltZWxpbmVSZWNvcmRlZCk7CiAgICAgICAgIHRlc3QuZXZhbHVhdGVJbkNv bnNvbGVfKHBvcHVsYXRlUGFnZS50b1N0cmluZygpICsgIjsgcG9wdWxhdGVQYWdlKCk7IiArCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJpbnNwZWN0KGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdkaXYxJykpIiwgZnVuY3Rpb24oKSB7fSk7CiAgICAgICAgIFdlYkluc3BlY3Rvci5u b3RpZmljYXRpb25zLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91 dGxpbmUuRXZlbnRzLlNlbGVjdGVkTm9kZUNoYW5nZWQsIHN0ZXAyKTsKQEAgLTYxNCwxNSArNjQ3 LDEyIEBAIFRlc3RTdWl0ZS5wcm90b3R5cGUudGVzdFBhZ2VPdmVybGF5VXBkYXRlID0gZnVuY3Rp b24oKQogICAgIGZ1bmN0aW9uIHN0ZXA0KCkKICAgICB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5u b3RpZmljYXRpb25zLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJl ZU91dGxpbmUuRXZlbnRzLlNlbGVjdGVkTm9kZUNoYW5nZWQsIHN0ZXA0KTsKLSAgICAgICAgZGlz cGF0Y2hPblJlY29yZFR5cGUuVGltZVN0YW1wID0gc3RlcDU7Ci0gICAgICAgIHRlc3QuZXZhbHVh dGVJbkNvbnNvbGVfKCJjb25zb2xlLnRpbWVTdGFtcCgncmVhZHknKSIsIGZ1bmN0aW9uKCkge30p OworICAgICAgICB0ZXN0LnN0b3BUaW1lbGluZSgpOwogICAgIH0KIAotICAgIGZ1bmN0aW9uIHN0 ZXA1KCkKKyAgICBmdW5jdGlvbiBvblRpbWVsaW5lUmVjb3JkZWQocmVjb3JkcykKICAgICB7CiAg ICAgICAgIHZhciB0eXBlcyA9IHt9OwotICAgICAgICBXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5h Z2VyLnN0b3AoKTsKLSAgICAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5yZW1vdmVF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRXZlbnRUeXBlcy5UaW1l bGluZUV2ZW50UmVjb3JkZWQsIGFkZFJlY29yZCk7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBp IDwgcmVjb3Jkcy5sZW5ndGg7ICsraSkKICAgICAgICAgICAgIHR5cGVzW3JlY29yZHNbaV0udHlw ZV0gPSAodHlwZXNbcmVjb3Jkc1tpXS50eXBlXSB8fCAwKSArIDE7CiAKQEAgLTYzOSw2ICs2Njks NDggQEAgVGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0UGFnZU92ZXJsYXlVcGRhdGUgPSBmdW5jdGlv bigpCiAgICAgdGhpcy50YWtlQ29udHJvbCgpOwogfQogCisKKy8qKgorICogUmVjb3JkcyB0aW1l bGluZSB0aWxsIGNvbnNvbGUudGltZVN0YW1wKCJyZWFkeSIpLCBpbnZva2VzIGNhbGxiYWNrIHdp dGggcmVzdWx0aW5nIHJlY29yZHMuCisgKiBAcGFyYW0ge2Z1bmN0aW9uKEFycmF5LjxPYmplY3Q+ KX0gY2FsbGJhY2sKKyAqLworVGVzdFN1aXRlLnByb3RvdHlwZS5yZWNvcmRUaW1lbGluZSA9IGZ1 bmN0aW9uKGNhbGxiYWNrKQoreworICAgIHZhciByZWNvcmRzID0gW107CisgICAgdmFyIGRpc3Bh dGNoT25SZWNvcmRUeXBlID0ge30KKworICAgIFdlYkluc3BlY3Rvci50aW1lbGluZU1hbmFnZXIu YWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLkV2ZW50VHlwZXMu VGltZWxpbmVFdmVudFJlY29yZGVkLCBhZGRSZWNvcmQpOworICAgIFdlYkluc3BlY3Rvci50aW1l bGluZU1hbmFnZXIuc3RhcnQoKTsKKworICAgIGZ1bmN0aW9uIGFkZFJlY29yZChldmVudCkKKyAg ICB7CisgICAgICAgIGlubmVyQWRkUmVjb3JkKGV2ZW50LmRhdGEpOworICAgIH0KKworICAgIGZ1 bmN0aW9uIGlubmVyQWRkUmVjb3JkKHJlY29yZCkKKyAgICB7CisgICAgICAgIHJlY29yZHMucHVz aChyZWNvcmQpOworICAgICAgICBpZiAocmVjb3JkLnR5cGUgPT09ICJUaW1lU3RhbXAiICYmIHJl Y29yZC5kYXRhLm1lc3NhZ2UgPT09ICJyZWFkeSIpCisgICAgICAgICAgICBkb25lKCk7CisKKyAg ICAgICAgaWYgKHJlY29yZC5jaGlsZHJlbikKKyAgICAgICAgICAgIHJlY29yZC5jaGlsZHJlbi5m b3JFYWNoKGlubmVyQWRkUmVjb3JkKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBkb25lKCkKKyAg ICB7CisgICAgICAgIFdlYkluc3BlY3Rvci50aW1lbGluZU1hbmFnZXIuc3RvcCgpOworICAgICAg ICBXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5z cGVjdG9yLlRpbWVsaW5lTWFuYWdlci5FdmVudFR5cGVzLlRpbWVsaW5lRXZlbnRSZWNvcmRlZCwg YWRkUmVjb3JkKTsKKyAgICAgICAgY2FsbGJhY2socmVjb3Jkcyk7CisgICAgfQorfQorCisKK1Rl c3RTdWl0ZS5wcm90b3R5cGUuc3RvcFRpbWVsaW5lID0gZnVuY3Rpb24oKQoreworICAgIHRoaXMu ZXZhbHVhdGVJbkNvbnNvbGVfKCJjb25zb2xlLnRpbWVTdGFtcCgncmVhZHknKSIsIGZ1bmN0aW9u KCkge30pOworfQorCiBUZXN0U3VpdGUucHJvdG90eXBlLndhaXRGb3JUZXN0UmVzdWx0c0luQ29u c29sZSA9IGZ1bmN0aW9uKCkKIHsKICAgICB2YXIgbWVzc2FnZXMgPSBXZWJJbnNwZWN0b3IuY29u c29sZS5tZXNzYWdlczsK