110578 2013-02-22 02:14:34 -0800 [BlackBerry] DumpRenderTreeSupport: update the set position methods 2013-02-28 01:27:39 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 839404 0 berto 2013-02-22 02:14:34 -0800 TestRunner::setMockGeolocationPosition() changed in r130416: http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h DumpRenderTreeSupport::setMockGeolocationError() was renamed to setMockGeolocationPositionUnavailableError() in r129444: http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h 839406 1 189724 berto 2013-02-22 02:17:58 -0800 Created attachment 189724 Patch 839506 2 189724 rwlbuis 2013-02-22 05:40:53 -0800 Comment on attachment 189724 Patch LGTM. 843861 3 189724 webkit.review.bot 2013-02-28 01:27:36 -0800 Comment on attachment 189724 Patch Clearing flags on attachment: 189724 Committed r144274: <http://trac.webkit.org/changeset/144274> 843862 4 webkit.review.bot 2013-02-28 01:27:39 -0800 All reviewed patches have been landed. Closing bug. 189724 2013-02-22 02:17:58 -0800 2013-02-28 01:27:35 -0800 Patch 110578.diff text/plain 6591 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDQ1YzVhMGUuLmRmOWZmNjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAyLTIyICBY YW4gTG9wZXogIDx4bG9wZXpAcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gRHVtcFJl bmRlclRyZWVTdXBwb3J0OiB1cGRhdGUgdGhlIHNldCBwb3NpdGlvbiBtZXRob2RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1NzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0UnVubmVyOjpzZXRN b2NrR2VvbG9jYXRpb25Qb3NpdGlvbigpIGNoYW5nZWQgaW4gcjEzMDQxNjoKKyAgICAgICAgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTMwNDE2L3RydW5rL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL1Rlc3RSdW5uZXIuaAorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnQuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0OjpzZXRNb2Nr R2VvbG9jYXRpb25Qb3NpdGlvbik6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnQuaDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydCk6CisKKzIwMTMt MDItMjIgIFhhbiBMb3BleiAgPHhsb3BlekByaW0uY29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5 XSBEb21TdXBwb3J0OiB1c2UgTm9kZVRyYXZlcnNhbCBBUElzCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0NjcKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0LmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydC5jcHAKaW5kZXggZWViNzVmZC4uNDRiMzZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EdW1wUmVuZGVyVHJl ZVN1cHBvcnQuY3BwCkBAIC0xMTEsMTAgKzExMSwxMCBAQCB2b2lkIER1bXBSZW5kZXJUcmVlU3Vw cG9ydDo6c2V0TW9ja0dlb2xvY2F0aW9uUGVybWlzc2lvbihXZWJQYWdlKiB3ZWJQYWdlLCBib29s CiAgICAgbW9ja0NsaWVudC0+c2V0UGVybWlzc2lvbihhbGxvd2VkKTsKIH0KIAotdm9pZCBEdW1w UmVuZGVyVHJlZVN1cHBvcnQ6OnNldE1vY2tHZW9sb2NhdGlvblBvc2l0aW9uKFdlYlBhZ2UqIHdl YlBhZ2UsIGRvdWJsZSBsYXRpdHVkZSwgZG91YmxlIGxvbmdpdHVkZSwgZG91YmxlIGFjY3VyYWN5 KQordm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnQ6OnNldE1vY2tHZW9sb2NhdGlvblBvc2l0aW9u KFdlYlBhZ2UqIHdlYlBhZ2UsIGRvdWJsZSBsYXRpdHVkZSwgZG91YmxlIGxvbmdpdHVkZSwgZG91 YmxlIGFjY3VyYWN5LCBib29sIHByb3ZpZGVzQWx0aXR1ZGUsIGRvdWJsZSBhbHRpdHVkZSwgYm9v bCBwcm92aWRlc0FsdGl0dWRlQWNjdXJhY3ksIGRvdWJsZSBhbHRpdHVkZUFjY3VyYWN5LCBib29s IHByb3ZpZGVzSGVhZGluZywgZG91YmxlIGhlYWRpbmcsIGJvb2wgcHJvdmlkZXNTcGVlZCwgZG91 YmxlIHNwZWVkKQogewogICAgIEdlb2xvY2F0aW9uQ2xpZW50TW9jayogbW9ja0NsaWVudCA9IHRv R2VvbG9jYXRpb25DbGllbnRNb2NrKEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6ZnJvbShjb3JlUGFn ZSh3ZWJQYWdlKSktPmNsaWVudCgpKTsKLSAgICBtb2NrQ2xpZW50LT5zZXRQb3NpdGlvbihHZW9s b2NhdGlvblBvc2l0aW9uOjpjcmVhdGUoY3VycmVudFRpbWUoKSwgbGF0aXR1ZGUsIGxvbmdpdHVk ZSwgYWNjdXJhY3kpKTsKKyAgICBtb2NrQ2xpZW50LT5zZXRQb3NpdGlvbihHZW9sb2NhdGlvblBv c2l0aW9uOjpjcmVhdGUoY3VycmVudFRpbWUoKSwgbGF0aXR1ZGUsIGxvbmdpdHVkZSwgYWNjdXJh Y3ksIHByb3ZpZGVzQWx0aXR1ZGUsIGFsdGl0dWRlLCBwcm92aWRlc0FsdGl0dWRlQWNjdXJhY3ks IGFsdGl0dWRlQWNjdXJhY3ksIHByb3ZpZGVzSGVhZGluZywgaGVhZGluZywgcHJvdmlkZXNTcGVl ZCwgc3BlZWQpKTsKIH0KIAogdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnQ6OnNjYWxlUGFnZUJ5 KFdlYlBhZ2UqIHdlYlBhZ2UsIGZsb2F0IHNjYWxlRmFjdG9yLCBmbG9hdCB4LCBmbG9hdCB5KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRHVtcFJl bmRlclRyZWVTdXBwb3J0LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9EdW1wUmVuZGVyVHJlZVN1cHBvcnQuaAppbmRleCBiYmMwNDU1Li5hMzAwNjJmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EdW1wUmVuZGVyVHJl ZVN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnQuaApAQCAtNTUsNyArNTUsNyBAQCBwdWJsaWM6CiAgICAgc3Rh dGljIHZvaWQgcmVzZXRHZW9sb2NhdGlvbk1vY2soQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdl Kik7CiAgICAgc3RhdGljIHZvaWQgc2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb25VbmF2YWlsYWJs ZUVycm9yKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZSosIGNvbnN0IFdURjo6U3RyaW5nIG1l c3NhZ2UpOwogICAgIHN0YXRpYyB2b2lkIHNldE1vY2tHZW9sb2NhdGlvblBlcm1pc3Npb24oQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlKiwgYm9vbCBhbGxvd2VkKTsKLSAgICBzdGF0aWMgdm9p ZCBzZXRNb2NrR2VvbG9jYXRpb25Qb3NpdGlvbihCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2Uq LCBkb3VibGUgbGF0aXR1ZGUsIGRvdWJsZSBsb25naXR1ZGUsIGRvdWJsZSBhY2N1cmFjeSk7Cisg ICAgc3RhdGljIHZvaWQgc2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb24oQmxhY2tCZXJyeTo6V2Vi S2l0OjpXZWJQYWdlKiwgZG91YmxlIGxhdGl0dWRlLCBkb3VibGUgbG9uZ2l0dWRlLCBkb3VibGUg YWNjdXJhY3ksIGJvb2wgcHJvdmlkZXNBbHRpdHVkZSwgZG91YmxlIGFsdGl0dWRlLCBib29sIHBy b3ZpZGVzQWx0aXR1ZGVBY2N1cmFjeSwgZG91YmxlIGFsdGl0dWRlQWNjdXJhY3ksIGJvb2wgcHJv dmlkZXNIZWFkaW5nLCBkb3VibGUgaGVhZGluZywgYm9vbCBwcm92aWRlc1NwZWVkLCBkb3VibGUg c3BlZWQpOwogICAgIHN0YXRpYyB2b2lkIHNldE1vY2tEZXZpY2VPcmllbnRhdGlvbihCbGFja0Jl cnJ5OjpXZWJLaXQ6OldlYlBhZ2UqLCBib29sIGNhblByb3ZpZGVBbHBoYSwgZG91YmxlIGFscGhh LCBib29sIGNhblByb3ZpZGVCZXRhLCBkb3VibGUgYmV0YSwgYm9vbCBjYW5Qcm92aWRlR2FtbWEs IGRvdWJsZSBnYW1tYSk7CiAgICAgc3RhdGljIHZvaWQgc2NhbGVQYWdlQnkoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlKiwgZmxvYXQsIGZsb2F0LCBmbG9hdCk7CiAgICAgc3RhdGljIEpTVmFs dWVSZWYgY29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvKEpTQ29udGV4dFJlZiwgSlNW YWx1ZVJlZik7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggOTZhMWFjNC4uNDQ0MjA4YSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTIyICBYYW4gTG9wZXog IDx4bG9wZXpAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRHVtcFJlbmRlclRyZWVT dXBwb3J0OiB1cGRhdGUgdGhlIHNldCBwb3NpdGlvbiBtZXRob2RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1NzgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0UnVubmVyOjpzZXRNb2NrR2VvbG9j YXRpb25Qb3NpdGlvbigpIGNoYW5nZWQgaW4gcjEzMDQxNjoKKyAgICAgICAgaHR0cDovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTMwNDE2L3RydW5rL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3RSdW5uZXIuaAorCisgICAgICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydDo6c2V0TW9ja0dlb2xv Y2F0aW9uRXJyb3IoKSB3YXMgcmVuYW1lZCB0bworICAgICAgICBzZXRNb2NrR2VvbG9jYXRpb25Q b3NpdGlvblVuYXZhaWxhYmxlRXJyb3IoKSBpbiByMTI5NDQ0OgorICAgICAgICBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8xMjk0NDQvdHJ1bmsvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0LmgKKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvVGVzdFJ1bm5lckJsYWNrQmVycnkuY3BwOgorICAgICAg ICAoVGVzdFJ1bm5lcjo6c2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb24pOgorICAgICAgICAoVGVz dFJ1bm5lcjo6c2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb25VbmF2YWlsYWJsZUVycm9yKToKKwog MjAxMy0wMi0yMSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIHN1cHBvcnQgdGhlIGx1Y2lkIHZlcnNpb24gb2YgZnJlZXR5cGUgb24gcHJl Y2lzZSBpbiBEUlQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkv VGVzdFJ1bm5lckJsYWNrQmVycnkuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJy eS9UZXN0UnVubmVyQmxhY2tCZXJyeS5jcHAKaW5kZXggNGFkMzZlNi4uNDZkMmQ5YSAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9UZXN0UnVubmVyQmxhY2tCZXJy eS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9UZXN0UnVubmVyQmxh Y2tCZXJyeS5jcHAKQEAgLTM3NSwxNSArMzc1LDE1IEBAIHZvaWQgVGVzdFJ1bm5lcjo6c2V0QWx3 YXlzQWNjZXB0Q29va2llcyhib29sIGFsd2F5c0FjY2VwdENvb2tpZXMpCiAgICAgbm90SW1wbGVt ZW50ZWQoKTsKIH0KIAotdm9pZCBUZXN0UnVubmVyOjpzZXRNb2NrR2VvbG9jYXRpb25Qb3NpdGlv bihkb3VibGUgbGF0aXR1ZGUsIGRvdWJsZSBsb25naXR1ZGUsIGRvdWJsZSBhY2N1cmFjeSkKK3Zv aWQgVGVzdFJ1bm5lcjo6c2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb24oZG91YmxlIGxhdGl0dWRl LCBkb3VibGUgbG9uZ2l0dWRlLCBkb3VibGUgYWNjdXJhY3ksIGJvb2wgcHJvdmlkZXNBbHRpdHVk ZSwgZG91YmxlIGFsdGl0dWRlLCBib29sIHByb3ZpZGVzQWx0aXR1ZGVBY2N1cmFjeSwgZG91Ymxl IGFsdGl0dWRlQWNjdXJhY3ksIGJvb2wgcHJvdmlkZXNIZWFkaW5nLCBkb3VibGUgaGVhZGluZywg Ym9vbCBwcm92aWRlc1NwZWVkLCBkb3VibGUgc3BlZWQpCiB7Ci0gICAgRHVtcFJlbmRlclRyZWVT dXBwb3J0OjpzZXRNb2NrR2VvbG9jYXRpb25Qb3NpdGlvbihCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1 bXBSZW5kZXJUcmVlOjpjdXJyZW50SW5zdGFuY2UoKS0+cGFnZSgpLCBsYXRpdHVkZSwgbG9uZ2l0 dWRlLCBhY2N1cmFjeSk7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0OjpzZXRNb2NrR2VvbG9j YXRpb25Qb3NpdGlvbihCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpjdXJyZW50 SW5zdGFuY2UoKS0+cGFnZSgpLCBsYXRpdHVkZSwgbG9uZ2l0dWRlLCBhY2N1cmFjeSwgcHJvdmlk ZXNBbHRpdHVkZSwgYWx0aXR1ZGUsIHByb3ZpZGVzQWx0aXR1ZGVBY2N1cmFjeSwgYWx0aXR1ZGVB Y2N1cmFjeSwgcHJvdmlkZXNIZWFkaW5nLCBoZWFkaW5nLCBwcm92aWRlc1NwZWVkLCBzcGVlZCk7 CiB9CiAKLXZvaWQgVGVzdFJ1bm5lcjo6c2V0TW9ja0dlb2xvY2F0aW9uRXJyb3IoaW50IGNvZGUs IEpTU3RyaW5nUmVmIG1lc3NhZ2UpCit2b2lkIFRlc3RSdW5uZXI6OnNldE1vY2tHZW9sb2NhdGlv blBvc2l0aW9uVW5hdmFpbGFibGVFcnJvcihKU1N0cmluZ1JlZiBtZXNzYWdlKQogewogICAgIFN0 cmluZyBtZXNzYWdlU3RyID0ganNTdHJpbmdSZWZUb1dlYkNvcmVTdHJpbmcobWVzc2FnZSk7Ci0g ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0OjpzZXRNb2NrR2VvbG9jYXRpb25FcnJvcihCbGFja0Jl cnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpjdXJyZW50SW5zdGFuY2UoKS0+cGFnZSgpLCBj b2RlLCBtZXNzYWdlU3RyKTsKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnQ6OnNldE1vY2tHZW9s b2NhdGlvblBvc2l0aW9uVW5hdmFpbGFibGVFcnJvcihCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBS ZW5kZXJUcmVlOjpjdXJyZW50SW5zdGFuY2UoKS0+cGFnZSgpLCBtZXNzYWdlU3RyKTsKIH0KIAog dm9pZCBUZXN0UnVubmVyOjpzaG93V2ViSW5zcGVjdG9yKCkK