110567 2013-02-22 01:12:09 -0800 [BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry 2013-02-22 08:53:43 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 839355 0 cgarcia 2013-02-22 01:12:09 -0800 They were removed from ChromeClient in r122810 and are now implemented in NavigatorContentUtilsClientBlackBerry since r131056. 839356 1 189711 cgarcia 2013-02-22 01:13:39 -0800 Created attachment 189711 Patch 839588 2 189711 rwlbuis 2013-02-22 08:22:39 -0800 Comment on attachment 189711 Patch Ok. 839622 3 189711 webkit.review.bot 2013-02-22 08:53:39 -0800 Comment on attachment 189711 Patch Clearing flags on attachment: 189711 Committed r143736: <http://trac.webkit.org/changeset/143736> 839623 4 webkit.review.bot 2013-02-22 08:53:43 -0800 All reviewed patches have been landed. Closing bug. 189711 2013-02-22 01:13:39 -0800 2013-02-22 08:53:39 -0800 Patch protocol-handler.diff text/plain 3450 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDQ1YzVhMGUuLmEzNzI5NzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTIyICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNhcmdhcmNpYUByaW0uY29tPgorCisgICAgICAgIFtCbGFj a0JlcnJ5XSBSZW1vdmUgUHJvdG9jb2xIYW5kbGVyIG1ldGhvZHMgZnJvbSBDaHJvbWVDbGllbnRC bGFja0JlcnJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTA1NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGV5IHdlcmUgcmVtb3ZlZCBmcm9tIENocm9tZUNsaWVudCBpbiByMTIyODEwIGFuZCBhcmUg bm93CisgICAgICAgIGltcGxlbWVudGVkIGluIE5hdmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudEJs YWNrQmVycnkgc2luY2UgcjEzMTA1Ni4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEJsYWNrQmVycnkuaDoKKyAgICAgICAgKENocm9tZUNsaWVudEJsYWNrQmVycnkpOgorCiAy MDEzLTAyLTIyICBYYW4gTG9wZXogIDx4bG9wZXpAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gRG9tU3VwcG9ydDogdXNlIE5vZGVUcmF2ZXJzYWwgQVBJcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGQ0ODM3MzMuLmY1YWIwYWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTgyMywyNSArODIzLDYgQEAgUGFzc093blB0cjxD b2xvckNob29zZXI+IENocm9tZUNsaWVudEJsYWNrQmVycnk6OmNyZWF0ZUNvbG9yQ2hvb3NlcihD b2xvckNob29zZXIKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotI2lmIEVOQUJMRShOQVZJR0FU T1JfQ09OVEVOVF9VVElMUykKLXZvaWQgQ2hyb21lQ2xpZW50QmxhY2tCZXJyeTo6cmVnaXN0ZXJQ cm90b2NvbEhhbmRsZXIoY29uc3QgU3RyaW5nJiBzY2hlbWUsIGNvbnN0IFN0cmluZyYgYmFzZVVS TCwgY29uc3QgU3RyaW5nJiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGUpCi17Ci0gICAgbV93ZWJQ YWdlUHJpdmF0ZS0+bV9jbGllbnQtPnJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyKHNjaGVtZSwgYmFz ZVVSTCwgdXJsLCB0aXRsZSk7Ci19Ci0KLSNpZiBFTkFCTEUoQ1VTVE9NX1NDSEVNRV9IQU5ETEVS KQotQ2hyb21lQ2xpZW50OjpDdXN0b21IYW5kbGVyc1N0YXRlIENocm9tZUNsaWVudEJsYWNrQmVy cnk6OmlzUHJvdG9jb2xIYW5kbGVyUmVnaXN0ZXJlZChjb25zdCBTdHJpbmcmIHNjaGVtZSwgY29u c3QgU3RyaW5nJiBiYXNlVVJMLCBjb25zdCBTdHJpbmcmIHVybCkKLXsKLSAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8Q3VzdG9tSGFuZGxlcnNTdGF0ZT4obV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQt PmlzUHJvdG9jb2xIYW5kbGVyUmVnaXN0ZXJlZChzY2hlbWUsIGJhc2VVUkwsIHVybCkpOwotfQot Ci12b2lkIENocm9tZUNsaWVudEJsYWNrQmVycnk6OnVucmVnaXN0ZXJQcm90b2NvbEhhbmRsZXIo Y29uc3QgU3RyaW5nJiBzY2hlbWUsIGNvbnN0IFN0cmluZyYgYmFzZVVSTCwgY29uc3QgU3RyaW5n JiB1cmwpCi17Ci0gICAgbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPnVucmVnaXN0ZXJQcm90 b2NvbEhhbmRsZXIoc2NoZW1lLCBiYXNlVVJMLCB1cmwpOwotfQotI2VuZGlmCi0jZW5kaWYKLQog dm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjphZGRTZWFyY2hQcm92aWRlcihjb25zdCBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBvcmlnaW5VUkwsIGNvbnN0IEJsYWNrQmVycnk6OlBs YXRmb3JtOjpTdHJpbmcmIG5ld1VSTCkKIHsKICAgICAvLyBTZWUgaWYgdGhlIGlucHV0IFVSTCBo b3N0IG1hdGNoZXMgb2YgdGhlIG9yaWdpbiBob3N0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuaCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmgKaW5kZXggMTU1ZjI1Yi4uMTA4NzhjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuaAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tC ZXJyeS5oCkBAIC0xNTEsMTUgKzE1MSw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgYWxs b3dzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIGNvbnN0OwogI2VuZGlmCiAKLSNpZiBFTkFCTEUo TkFWSUdBVE9SX0NPTlRFTlRfVVRJTFMpCi0gICAgdmlydHVhbCB2b2lkIHJlZ2lzdGVyUHJvdG9j b2xIYW5kbGVyKGNvbnN0IFN0cmluZyYgLypzY2hlbWUqLywgY29uc3QgU3RyaW5nJiAvKmJhc2VV UkwqLywgY29uc3QgU3RyaW5nJiAvKnVybCovLCBjb25zdCBTdHJpbmcmIC8qdGl0bGUqLyk7Ci0K LSNpZiBFTkFCTEUoQ1VTVE9NX1NDSEVNRV9IQU5ETEVSKQotICAgIHZpcnR1YWwgQ3VzdG9tSGFu ZGxlcnNTdGF0ZSBpc1Byb3RvY29sSGFuZGxlclJlZ2lzdGVyZWQoY29uc3QgU3RyaW5nJiAvKnNj aGVtZSovLCBjb25zdCBTdHJpbmcmIC8qYmFzZVVSTCovLCBjb25zdCBTdHJpbmcmIC8qdXJsKi8p OwotICAgIHZpcnR1YWwgdm9pZCB1bnJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyKGNvbnN0IFN0cmlu ZyYgLypzY2hlbWUqLywgY29uc3QgU3RyaW5nJiAvKmJhc2VVUkwqLywgY29uc3QgU3RyaW5nJiAv KnVybCovKTsKLSNlbmRpZgotI2VuZGlmCi0KICAgICB2aXJ0dWFsIHZvaWQgYWRkU2VhcmNoUHJv dmlkZXIoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYsIGNvbnN0IEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpTdHJpbmcmKTsKICAgICB2aXJ0dWFsIGludCBpc1NlYXJjaFByb3ZpZGVy SW5zdGFsbGVkKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmLCBjb25zdCBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJik7CiAK