<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110562</bug_id>
          
          <creation_ts>2013-02-22 00:12:37 -0800</creation_ts>
          <short_desc>[BlackBerry] ChromeClientBlackBerry: fix variable names</short_desc>
          <delta_ts>2013-02-25 00:11:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Alberto Garcia">berto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>buildbot</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mifenton</cc>
    
    <cc>rniwa</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yong.li.webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>839316</commentid>
    <comment_count>0</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2013-02-22 00:12:37 -0800</bug_when>
    <thetext>manager was incorrectly renamed back to tracker in r138696:

http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839318</commentid>
    <comment_count>1</comment_count>
      <attachid>189704</attachid>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2013-02-22 00:14:31 -0800</bug_when>
    <thetext>Created attachment 189704
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839503</commentid>
    <comment_count>2</comment_count>
      <attachid>189704</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2013-02-22 05:39:38 -0800</bug_when>
    <thetext>Comment on attachment 189704
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839540</commentid>
    <comment_count>3</comment_count>
      <attachid>189704</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-22 06:25:34 -0800</bug_when>
    <thetext>Comment on attachment 189704
Patch

Rejecting attachment 189704 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=gce-cq-01&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 189704, &apos;--port=chromium-xvfb&apos;]&quot; exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run &quot;[&apos;Tools/Scripts/update-webkit&apos;, &apos;--chromium&apos;, &apos;--force-update&apos;]&quot; exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run &quot;[&apos;Tools/Scripts/update-webkit&apos;, &apos;--chromium&apos;, &apos;--force-update&apos;]&quot; exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://queues.webkit.org/results/16693903</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840288</commentid>
    <comment_count>4</comment_count>
      <attachid>189704</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-02-22 21:03:48 -0800</bug_when>
    <thetext>Comment on attachment 189704
Patch

Attachment 189704 did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16723317

New failing tests:
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840747</commentid>
    <comment_count>5</comment_count>
      <attachid>189704</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-25 00:11:07 -0800</bug_when>
    <thetext>Comment on attachment 189704
Patch

Clearing flags on attachment: 189704

Committed r143888: &lt;http://trac.webkit.org/changeset/143888&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840748</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-25 00:11:12 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>189704</attachid>
            <date>2013-02-22 00:14:31 -0800</date>
            <delta_ts>2013-02-25 00:11:07 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>110562.diff</filename>
            <type>text/plain</type>
            <size>1800</size>
            <attacher name="Alberto Garcia">berto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv
V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDkzM2Q0NTYuLjU2MTk1YmUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTIyICBB
bGJlcnRvIEdhcmNpYSAgPGFsYmdhcmNpYUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5
XSBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OiBmaXggdmFyaWFibGUgbmFtZXMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDU2MgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1hbmFnZXIgd2FzIGluY29ycmVj
dGx5IHJlbmFtZWQgYmFjayB0byB0cmFja2VyIGluIHIxMzg2OTY6CisgICAgICAgIGh0dHA6Ly90
cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzODY5Ni90cnVuay9Tb3VyY2UvV2ViS2l0L2JsYWNr
YmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKKworICAgICAg
ICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6Q2hyb21lQ2xpZW50QmxhY2tCZXJyeTo6ZXhjZWVkZWREYXRhYmFzZVF1b3RhKToK
KwogMjAxMy0wMi0yMSAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5n
LmNvbT4KIAogICAgICAgICBBbGxvdyB0byByZXRyaWV2ZSB0aGUgcmVxdWVzdCBkYXRhIGZyb20g
YWJzdHJhY3QgVGV4dENoZWNraW5nUmVxdWVzdCB0byBiZSBhY2Nlc3NpYmxlIGZvciBXSzIKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD
bGllbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw
cG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCBkNDgzNzMzLi45NzMxMGFhIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21l
Q2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv
cmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC01MDAsOCArNTAwLDggQEAg
dm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpleGNlZWRlZERhdGFiYXNlUXVvdGEoRnJhbWUq
IGZyYW1lLCBjb25zdCBTdHJpbmcmIG4KIAogICAgIERhdGFiYXNlTWFuYWdlciYgbWFuYWdlciA9
IERhdGFiYXNlTWFuYWdlcjo6bWFuYWdlcigpOwogCi0gICAgdW5zaWduZWQgbG9uZyBsb25nIG9y
aWdpblVzYWdlID0gdHJhY2tlci51c2FnZUZvck9yaWdpbihvcmlnaW4pOwotICAgIHVuc2lnbmVk
IGxvbmcgbG9uZyBjdXJyZW50UXVvdGEgPSB0cmFja2VyLnF1b3RhRm9yT3JpZ2luKG9yaWdpbik7
CisgICAgdW5zaWduZWQgbG9uZyBsb25nIG9yaWdpblVzYWdlID0gbWFuYWdlci51c2FnZUZvck9y
aWdpbihvcmlnaW4pOworICAgIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50UXVvdGEgPSBtYW5h
Z2VyLnF1b3RhRm9yT3JpZ2luKG9yaWdpbik7CiAKICAgICB1bnNpZ25lZCBsb25nIGxvbmcgZXN0
aW1hdGVkU2l6ZSA9IGRldGFpbHMuZXhwZWN0ZWRVc2FnZSgpOwogICAgIGNvbnN0IFN0cmluZyYg
bmFtZVN0ciA9IGRldGFpbHMuZGlzcGxheU5hbWUoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>