110554 2013-02-21 21:55:26 -0800 REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails 2013-02-22 10:52:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 rniwa eric abarth ap beidson eric japhet webkit.review.bot zan oldest_to_newest 839219 0 rniwa 2013-02-21 21:55:26 -0800 http://trac.webkit.org/changeset/143664 and http://trac.webkit.org/changeset/143681 made tests fail on Mac WK1 bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fsecurity%2Ffeed-urls-from-remote.html e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r143686%20(7135)/results.html --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/feed-urls-from-remote-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/feed-urls-from-remote-actual.txt @@ -1,6 +1,7 @@ Policy delegate: attempt to load feed://127.0.0.1:8000/security/resources/feed.xml with navigation type 'link clicked' originating from HTML > #document +FAIL: Timed out waiting for notifyDone to be called < rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing This test is to see if a feed URL can be followed from a link on a page. -Test Finished. +Test not completed. 839225 1 rniwa 2013-02-21 22:05:02 -0800 Added a failing test expectation in http://trac.webkit.org/changeset/143689. 839245 2 eric 2013-02-21 22:32:36 -0800 Yeah, we saw similar for Chromium, but I assumed it seemed specific to our DRT implementation. For now I'm just going to gate the offending code with ENABLE_THREADED_PARSER. That's slightly lame, and will potentially block enabling the threaded parser for other ports. This is a result of very very fragile code in the loader subsystem. The real solution is to re-write the loader, but that's out of scope for this change. :) It's also possible that we'll find a better solution than this one as we fix our last couple failures for the threaded parser. Thanks for filing. 839248 3 rniwa 2013-02-21 22:34:36 -0800 (In reply to comment #2) > > This is a result of very very fragile code in the loader subsystem. The real solution is to re-write the loader, but that's out of scope for this change. :) I don't think rewriting it really helps. The real problem with the loader is that we don't have a good strategy to test it. 839250 4 189688 eric 2013-02-21 22:36:44 -0800 Created attachment 189688 Patch 839252 5 189688 rniwa 2013-02-21 22:39:15 -0800 Comment on attachment 189688 Patch rs=me. 839258 6 eric 2013-02-21 22:49:13 -0800 (In reply to comment #3) > (In reply to comment #2) > > > > This is a result of very very fragile code in the loader subsystem. The real solution is to re-write the loader, but that's out of scope for this change. :) > > I don't think rewriting it really helps. The real problem with the loader is that we don't have a good strategy to test it. Perhaps. :) It's a state machine which is distributed between at least 5 classes, and about 20 bools. :) I suspect it would be a lot easier to understand as a single progressive state enum. 839283 7 189688 webkit.review.bot 2013-02-21 23:20:52 -0800 Comment on attachment 189688 Patch Rejecting attachment 189688 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189688, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: -conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 54>At revision 13692. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16701504 839287 8 eric 2013-02-21 23:23:31 -0800 Updating working directory Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Odd. 839309 9 189688 webkit.review.bot 2013-02-21 23:53:31 -0800 Comment on attachment 189688 Patch Clearing flags on attachment: 189688 Committed r143695: <http://trac.webkit.org/changeset/143695> 839310 10 webkit.review.bot 2013-02-21 23:53:35 -0800 All reviewed patches have been landed. Closing bug. 839492 11 zan 2013-02-22 05:36:21 -0800 Committed r143719: <http://trac.webkit.org/changeset/143719> 839508 12 zan 2013-02-22 05:43:18 -0800 (In reply to comment #11) > Committed r143719: <http://trac.webkit.org/changeset/143719> Manually rolled this out in r143719 due to crashes occurring on debug builds of AppleMac WK1, EFL and GTK. Would have done the rollout through sheriffbot, but it was failing to update the checkout. Examples: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r143709%20(6946)/results.html http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r143709%20(5750)/results.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r143713%20(9747)/results.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20WK1/r143709%20(307)/results.html Given that this only seemed to fix one test and introduced crashes in multiple tests I reckoned rolling out is best. 839618 13 abarth 2013-02-22 08:50:19 -0800 Yeah, Eric just missed the other half. Will fix shortly. 839645 14 189780 abarth 2013-02-22 09:14:07 -0800 Created attachment 189780 Patch for landing 839705 15 eric 2013-02-22 10:27:47 -0800 Sorry for the trouble. 839706 16 189780 eric 2013-02-22 10:28:06 -0800 Comment on attachment 189780 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=189780&action=review > Source/WebCore/dom/Document.cpp:5781 > + // FIXME: This should always be enabled, but it seems to cause > + // http/tests/security/feed-urls-from-remote.html to timeout on Mac WK1 > + // see http://webkit.org/b/110554 and http://webkit.org/b/110401 > +#if ENABLE(THREADED_HTML_PARSER) > loader()->checkLoadComplete(); > +#endif Didn't this part need a null check instead of an ENABLE? 839715 17 abarth 2013-02-22 10:35:47 -0800 > Didn't this part need a null check instead of an ENABLE? That might of worked, but I wanted to keep isLoading and checkLoadComplete in sync. 839733 18 189780 webkit.review.bot 2013-02-22 10:52:25 -0800 Comment on attachment 189780 Patch for landing Clearing flags on attachment: 189780 Committed r143753: <http://trac.webkit.org/changeset/143753> 839734 19 webkit.review.bot 2013-02-22 10:52:29 -0800 All reviewed patches have been landed. Closing bug. 189688 2013-02-21 22:36:44 -0800 2013-02-22 09:14:03 -0800 Patch bug-110554-20130221223304.patch text/plain 1728 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThkMDgyYTE5YzRiM2Iw Yzk5Zjg0YjJiYjgyODI5MDYyNzA5ZDdjOC4uODY3ZTI3MTk1ZmNiMjI1M2Q1NmY2NDRiMDZjMGRm ODVhN2QxYzI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTAyLTIxICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAgICBSRUdSRVNTSU9OKHIxNDM2NjQs IHIxNDM2ODEpOiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5odG1s IGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTA1NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aWxsIGZpeCBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5odG1sIGZv ciBNYWMgV0sxLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjppc0xvYWRpbmcpOgorCisyMDEzLTAyLTIxICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBMYXlvdXRUZXN0cy9mYXN0 L2VuY29kaW5nL3BhcnNlci10ZXN0cy0qLmh0bWwgdGltZW91dCB3aXRoIHRocmVhZGVkIEhUTUwg cGFyc2VyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDk5OTUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggMzc3 MzIzZTUzMDBiMDU3M2E5MDAyOWMxYzE2Njc2OTY4NzFiNmI5Yi4uYzRjNjZmOGNjNTA0ZTc4ZGIz OTZiMDIwMTUyY2U4NzIyMTYyYmRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwCkBAIC0yODAsOCArMjgwLDEzIEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmNvbW1p dElmUmVhZHkoKQogCiBib29sIERvY3VtZW50TG9hZGVyOjppc0xvYWRpbmcoKSBjb25zdAogewor ICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBhbHdheXMgYmUgZW5hYmxlZCwgYnV0IGl0IHNlZW1z IHRvIGNhdXNlCisgICAgLy8gaHR0cC90ZXN0cy9zZWN1cml0eS9mZWVkLXVybHMtZnJvbS1yZW1v dGUuaHRtbCB0byB0aW1lb3V0IG9uIE1hYyBXSzEKKyAgICAvLyBzZWUgaHR0cDovL3dlYmtpdC5v cmcvYi8xMTA1NTQgYW5kIGh0dHA6Ly93ZWJraXQub3JnL2IvMTEwNDAxCisjaWYgRU5BQkxFKFRI UkVBREVEX0hUTUxfUEFSU0VSKQogICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPmRvY3VtZW50 KCkgJiYgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+aGFzQWN0aXZlUGFyc2VyKCkpCiAgICAgICAgIHJl dHVybiB0cnVlOworI2VuZGlmCiAgICAgcmV0dXJuIGlzTG9hZGluZ01haW5SZXNvdXJjZSgpIHx8 ICFtX3N1YnJlc291cmNlTG9hZGVycy5pc0VtcHR5KCkgfHwgIW1fcGx1Z0luU3RyZWFtTG9hZGVy cy5pc0VtcHR5KCk7CiB9CiAK 189780 2013-02-22 09:14:07 -0800 2013-02-22 10:52:25 -0800 Patch for landing bug-110554-20130222091026.patch text/plain 2211 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzczOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTIyICBFcmljIFNl aWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNDM2NjQsIHIx NDM2ODEpOiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5odG1sIGZh aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1 NTQKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIFdpbGwgZml4 IGh0dHAvdGVzdHMvc2VjdXJpdHkvZmVlZC11cmxzLWZyb20tcmVtb3RlLmh0bWwgZm9yIE1hYyBX SzEuCisKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnRMb2FkZXI6OmlzTG9hZGluZyk6CisKIDIwMTMtMDItMjIgIEtlbnRhcm8g SGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gQWRkIGNvbW1lbnRz IHRvIGNoZWNrVHlwZU9yRGllVHJ5aW5nKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAko cmV2aXNpb24gMTQzNzM4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTc3Myw3ICs1NzczLDEyIEBAIHZvaWQgRG9jdW1lbnQ6OmRlY3JlbWVu dEFjdGl2ZVBhcnNlckNvdW4KICAgICAtLW1fYWN0aXZlUGFyc2VyQ291bnQ7CiAgICAgaWYgKCFm cmFtZSgpKQogICAgICAgICByZXR1cm47CisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGFsd2F5 cyBiZSBlbmFibGVkLCBidXQgaXQgc2VlbXMgdG8gY2F1c2UKKyAgICAvLyBodHRwL3Rlc3RzL3Nl Y3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5odG1sIHRvIHRpbWVvdXQgb24gTWFjIFdLMQor ICAgIC8vIHNlZSBodHRwOi8vd2Via2l0Lm9yZy9iLzExMDU1NCBhbmQgaHR0cDovL3dlYmtpdC5v cmcvYi8xMTA0MDEKKyNpZiBFTkFCTEUoVEhSRUFERURfSFRNTF9QQVJTRVIpCiAgICAgbG9hZGVy KCktPmNoZWNrTG9hZENvbXBsZXRlKCk7CisjZW5kaWYKICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+ Y2hlY2tMb2FkQ29tcGxldGUoKTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0Rv Y3VtZW50TG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRMb2FkZXIuY3BwCShyZXZpc2lvbiAxNDM3MzgpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODAsOCArMjgwLDEzIEBA IHZvaWQgRG9jdW1lbnRMb2FkZXI6OmNvbW1pdElmUmVhZHkoKQogCiBib29sIERvY3VtZW50TG9h ZGVyOjppc0xvYWRpbmcoKSBjb25zdAogeworICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBhbHdh eXMgYmUgZW5hYmxlZCwgYnV0IGl0IHNlZW1zIHRvIGNhdXNlCisgICAgLy8gaHR0cC90ZXN0cy9z ZWN1cml0eS9mZWVkLXVybHMtZnJvbS1yZW1vdGUuaHRtbCB0byB0aW1lb3V0IG9uIE1hYyBXSzEK KyAgICAvLyBzZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8xMTA1NTQgYW5kIGh0dHA6Ly93ZWJraXQu b3JnL2IvMTEwNDAxCisjaWYgRU5BQkxFKFRIUkVBREVEX0hUTUxfUEFSU0VSKQogICAgIGlmICht X2ZyYW1lICYmIG1fZnJhbWUtPmRvY3VtZW50KCkgJiYgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+aGFz QWN0aXZlUGFyc2VyKCkpCiAgICAgICAgIHJldHVybiB0cnVlOworI2VuZGlmCiAgICAgcmV0dXJu IGlzTG9hZGluZ01haW5SZXNvdXJjZSgpIHx8ICFtX3N1YnJlc291cmNlTG9hZGVycy5pc0VtcHR5 KCkgfHwgIW1fcGx1Z0luU3RyZWFtTG9hZGVycy5pc0VtcHR5KCk7CiB9CiAK