110549 2013-02-21 20:43:32 -0800 Remove deep-copy of ImageBuffer in drawing tiled SVG backgrounds 2013-02-21 22:41:29 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr d-r fmalita schenney webkit.review.bot zimmermann oldest_to_newest 839182 0 pdr 2013-02-21 20:43:32 -0800 We create a deep-copy of the temporary ImageBuffer used to stamp out tiled backgrounds. What a waste! http://trac.webkit.org/browser/trunk/Source/WebCore/svg/graphics/SVGImage.cpp?rev=143640#L161 Patch forthcoming. 839192 1 189672 pdr 2013-02-21 21:00:05 -0800 Created attachment 189672 Remove deep copy of ImageBuffer in tiled SVG backgrounds 839255 2 189672 webkit.review.bot 2013-02-21 22:41:26 -0800 Comment on attachment 189672 Remove deep copy of ImageBuffer in tiled SVG backgrounds Clearing flags on attachment: 189672 Committed r143692: <http://trac.webkit.org/changeset/143692> 839256 3 webkit.review.bot 2013-02-21 22:41:29 -0800 All reviewed patches have been landed. Closing bug. 189672 2013-02-21 21:00:05 -0800 2013-02-21 22:41:26 -0800 Remove deep copy of ImageBuffer in tiled SVG backgrounds 110549.1.patch text/plain 1852 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzY4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTIxICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGRlZXAgY29weSBvZiBJ bWFnZUJ1ZmZlciBpbiB0aWxlZCBTVkcgYmFja2dyb3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDU0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNWR0ltYWdlOjpkcmF3UGF0dGVybkZvckNvbnRh aW5lciBjcmVhdGVzIGEgdGVtcG9yYXJ5IEltYWdlQnVmZmVyIGZvciBzdGFtcGluZyBvdXQgdGls ZWQKKyAgICAgICAgYmFja2dyb3VuZHMuIFByZXZpb3VzbHkgdGhpcyBJbWFnZUJ1ZmZlciB3YXMg dW5uZWNlc3NhcmlseSBkZWVwLWNvcGllZCEgVGhpcyBwYXRjaCB1c2VzIGEKKyAgICAgICAgc2hh bGxvdyBjb3B5LCB0YWtpbmcgYWR2YW50YWdlIG9mIHRoZSBmYWN0IHRoYXQgdGhlIHRlbXBvcmFy eSBJbWFnZUJ1ZmZlciBpcyBuZXZlciBtb2RpZmllZC4KKworICAgICAgICBUaGlzIHBhdGNoIGlz IGNvdmVyZWQgd2l0aCBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9T VkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6ZHJhd1BhdHRlcm5Gb3JD b250YWluZXIpOgorCiAyMDEzLTAyLTIxICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgSW52YWxpZGF0ZSBvdXRzdGFuZGluZyBjaGVja3BvaW50cyBmb3Ig dGhlIGJhY2tncm91bmQgaW5wdXQgc3RyZWFtIGFuZCBwcmVsb2FkIHNjYW5uZXIKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcAkocmV2aXNpb24gMTQzNjg0KQor KysgU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTU4LDcgKzE1OCw3IEBAIHZvaWQgU1ZHSW1hZ2U6OmRyYXdQYXR0ZXJuRm9yQ29udGFp bmVyKEcKIAogICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gYnVmZmVyID0gSW1hZ2VCdWZmZXI6OmNy ZWF0ZShleHBhbmRlZEludFNpemUoaW1hZ2VCdWZmZXJTaXplLnNpemUoKSksIDEpOwogICAgIGRy YXdGb3JDb250YWluZXIoYnVmZmVyLT5jb250ZXh0KCksIGNvbnRhaW5lclNpemUsIHpvb20sIGlt YWdlQnVmZmVyU2l6ZSwgem9vbWVkQ29udGFpbmVyUmVjdCwgQ29sb3JTcGFjZURldmljZVJHQiwg Q29tcG9zaXRlU291cmNlT3ZlciwgQmxlbmRNb2RlTm9ybWFsKTsKLSAgICBSZWZQdHI8SW1hZ2U+ IGltYWdlID0gYnVmZmVyLT5jb3B5SW1hZ2UoQ29weUJhY2tpbmdTdG9yZSwgVW5zY2FsZWQpOwor ICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBidWZmZXItPmNvcHlJbWFnZShEb250Q29weUJhY2tp bmdTdG9yZSwgVW5zY2FsZWQpOwogCiAgICAgLy8gQWRqdXN0IHRoZSBzb3VyY2UgcmVjdCBhbmQg dHJhbnNmb3JtIGR1ZSB0byB0aGUgaW1hZ2UgYnVmZmVyJ3Mgc2NhbGluZy4KICAgICBGbG9hdFJl Y3Qgc2NhbGVkU3JjUmVjdCA9IHNyY1JlY3Q7Cg==