110546 2013-02-21 19:42:42 -0800 ASSERTION FAILED: m_tokenizer.isInDataState() in WebCore::HTMLDocumentParser::pumpTokenizer 2023-02-22 15:22:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 tonyg webkit-unassigned abarth ahmad.saleem792 dino eric kadam rhodovan.u-szeged simon.fraser oldest_to_newest 839153 0 189664 tonyg 2013-02-21 19:42:42 -0800 Created attachment 189664 Test case Write half of an entity and a beforeload handler and the other half in the script itself. See test case. 839724 1 eric 2013-02-22 10:41:07 -0800 I assume this affects both the main thread parser and the background parser? 839728 2 abarth 2013-02-22 10:48:07 -0800 Yeah. 847867 3 abarth 2013-03-05 11:41:59 -0800 *** Bug 111449 has been marked as a duplicate of this bug. *** 849409 4 dino 2013-03-06 16:07:01 -0800 From the dupe "The appropriate thing is to mark the test as expected to crash until we fix that bug." Really? This is causing a crash on four ports. It seems like we should rollout https://bugs.webkit.org/show_bug.cgi?id=111365 http://trac.webkit.org/changeset/144714 rather than wait for a fix. 849414 5 eric 2013-03-06 16:09:40 -0800 (In reply to comment #4) > From the dupe "The appropriate thing is to mark the test as expected to crash until we fix that bug." > > Really? This is causing a crash on four ports. It seems like we should rollout > https://bugs.webkit.org/show_bug.cgi?id=111365 > http://trac.webkit.org/changeset/144714 > > rather than wait for a fix. That change just added a test for this which was a known bug already. As noted in comment 2, this was an existing bug in the main-thread parser. We shouldn't have added a test w/o updating the Debug expectations to expect the ASSERT. :( 849422 6 dino 2013-03-06 16:16:02 -0800 (In reply to comment #5) > That change just added a test for this which was a known bug already. As noted in comment 2, this was an existing bug in the main-thread parser. We shouldn't have added a test w/o updating the Debug expectations to expect the ASSERT. :( Got it. I added it to the Mac expectations https://trac.webkit.org/r144996 (I should learn how to do it for all debug builds) 849439 7 eric 2013-03-06 16:30:32 -0800 webkit.org/b/110546 [ Debug ] fast/parser/document-write-fighting-eof.html [ Crash ] Is probably the line we should have added to LayoutTests/TestExpectations 849440 8 eric 2013-03-06 16:30:51 -0800 (In reply to comment #7) > webkit.org/b/110546 [ Debug ] fast/parser/document-write-fighting-eof.html [ Crash ] > > Is probably the line we should have added to LayoutTests/TestExpectations Again, apologies for the disruption. 853093 9 eric 2013-03-11 23:01:41 -0700 I happened to fix this for the threaded parser as part of bug 112069. 854066 10 ap 2013-03-12 22:52:52 -0700 *** Bug 112216 has been marked as a duplicate of this bug. *** 854423 11 simon.fraser 2013-03-13 11:18:20 -0700 This assertion is continually happening on the bots. For that reason, it should be fixed or removed. 854447 12 abarth 2013-03-13 11:55:15 -0700 (In reply to comment #11) > This assertion is continually happening on the bots. For that reason, it should be fixed or removed. My understanding is that this ASSERT is hit by one test. I would recommend marking the test as expected to crash in DEBUG. 854461 13 eric 2013-03-13 12:13:22 -0700 http://trac.webkit.org/browser/trunk/LayoutTests/fast/parser/document-write-fighting-eof.html Should be the only test to hit this ASSERT. There is a second test which will be added in bug 112069. 854497 14 simon.fraser 2013-03-13 12:48:50 -0700 Making the test an expected CRASH doesn't avoid the test bot slowdown associated with generating a crash log, which is what I'm trying to avoid. Perhaps I should just skip the test in debug. 854643 15 eric 2013-03-13 14:35:34 -0700 (In reply to comment #14) > Making the test an expected CRASH doesn't avoid the test bot slowdown associated with generating a crash log, which is what I'm trying to avoid. Perhaps I should just skip the test in debug. Sorry, I forgot about how slow CrashReporter can be. You're right, many platforms probably just want to Skip tests which are expected to Crash. We can just mark these as Skip in debug, that seems fine. 1173669 16 rhodovan.u-szeged 2016-03-11 02:08:16 -0800 *** Bug 135599 has been marked as a duplicate of this bug. *** 1935993 17 ahmad.saleem792 2023-02-22 15:22:45 -0800 I am not able to reproduce this assert failure in WebKit ToT build of 260689@main using MiniBrowser WK2 window. Do we need to track it further? 189664 2013-02-21 19:42:42 -0800 2013-02-21 19:42:42 -0800 Test case write-entity-before-load.html text/html 185 tonyg PHNjcmlwdD4KaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7Cjwvc2NyaXB0PgoKPHNjcmlwdAogICAgb25iZWZvcmVsb2FkPSJkb2N1bWVudC53cml0ZSgn JnF1JykiCiAgICBzcmM9ImRhdGE6dGV4dC9qYXZhc2NyaXB0LGRvY3VtZW50LndyaXRlKCdvdDsn KSI+Cjwvc2NyaXB0Pgo=