110545 2013-02-21 19:05:16 -0800 Increase the max preferred width of tables to 1000000 2013-02-22 14:40:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eae eric esprehn+autocc hyatt jchaffraix leviw ojan.autocc tony webkit.review.bot oldest_to_newest 839141 0 ojan 2013-02-21 19:05:16 -0800 Increase the max preferred width of tables to 1000000 839142 1 189661 ojan 2013-02-21 19:09:03 -0800 Created attachment 189661 Patch 839299 2 189661 eae 2013-02-21 23:37:05 -0800 Comment on attachment 189661 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189661&action=review > Source/WebCore/rendering/TableLayout.h:47 > + const static int tableMaxWidth = 1000000; Why did you pick 1,000,000? Still seems really small. > LayoutTests/fast/table/large-shrink-wrapped-width.html:24 > +<!-- The inner div should fill the container. It doesn't right now because we artificially limit the tables maxPreferredLogicalWidth to 1000000. I really don't think this test benefits from being done as a check-layout test. shouldBe("tableElement.offsetWidth", container.scrollWidth); (or clientWidth depending on the test) would be less code, a lot simpler and avoids the need for hard coded expectations. 839387 3 189661 benjamin 2013-02-22 01:52:28 -0800 Comment on attachment 189661 Patch > > LayoutTests/fast/table/large-shrink-wrapped-width.html:24 > > +<!-- The inner div should fill the container. It doesn't right now because we artificially limit the tables maxPreferredLogicalWidth to 1000000. > > I really don't think this test benefits from being done as a check-layout test. > > shouldBe("tableElement.offsetWidth", container.scrollWidth); (or clientWidth depending on the test) > > would be less code, a lot simpler and avoids the need for hard coded expectations. I completely agree, the test could be better IMHO. It is extremely opaque. 839595 4 eae 2013-02-22 08:30:31 -0800 (In reply to comment #2) Thinking of this some more I realize why you did it this way, hard-coded values might be unavoidable in this case. I think moving all of the width-styles to be inline would go a long way towards making the test easier to understand though. Another option might be to set the width of the table or a cell and then checking the offsetWidth of the table to see if it matches the set value. Still has to deal with border/padding/margins though... 839781 5 189661 ojan 2013-02-22 11:45:57 -0800 Comment on attachment 189661 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189661&action=review >> Source/WebCore/rendering/TableLayout.h:47 >> + const static int tableMaxWidth = 1000000; > > Why did you pick 1,000,000? Still seems really small. I figure it's still a lot larger than 15000 and really we'll just get rid of this once we enable SATURATED_LAYOUT_ARITHMETHIC everywhere, so I didn't think too much about it, especially since there are tests that actually do overflow if you pick a large enough value. 839791 6 ojan 2013-02-22 11:55:02 -0800 (In reply to comment #4) > (In reply to comment #2) > Thinking of this some more I realize why you did it this way, hard-coded values might be unavoidable in this case. Right. The parent's scrollWidth and the table's offsetWidth are both wrong (and match each other) at tip of tree. > I think moving all of the width-styles to be inline would go a long way towards making the test easier to understand though. I can do that if you really want, but I think it makes the test hard to make sense of because you can't easily tell what's different between each test case because there is now all the copy-pasted widths everywhere. > Another option might be to set the width of the table or a cell and then checking the offsetWidth of the table to see if it matches the set value. Still has to deal with border/padding/margins though... The tricky thing here is that the width of the table needs to be 100% to hit the bad codepath. This tableMaxWidth thing is a bit of a lie really. It only applies in really obscure edge cases it turns out. Most of the time there's no limit on how big your table can be. It was actually difficult to write a test case where this is exposed to web content. 839798 7 189806 ojan 2013-02-22 12:02:40 -0800 Created attachment 189806 inline some widths 839971 8 ojan 2013-02-22 14:22:14 -0800 I inlined all the widths except for the container width. Does that work? Also, I'm fine picking a number larger than 1000000, but I'd rather we just wait until we enable SATURATED_LAYOUT_ARITHMETHIC, so we can do the proper fix and get rid of this variable entirely. 839975 9 189806 eae 2013-02-22 14:25:35 -0800 Comment on attachment 189806 inline some widths Makes sense. Thanks for updating the test. 839998 10 ojan 2013-02-22 14:40:05 -0800 Committed r143801: <http://trac.webkit.org/changeset/143801> 189661 2013-02-21 19:09:03 -0800 2013-02-22 12:02:36 -0800 Patch bug-110545-20130221190523.patch text/plain 6563 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUzOGI5M2MzNTk3MDc5 YWM1NzBkYzg0OWIzOGQyYzFiMjI5NGFhNC4uMDMwZTU0N2FmY2RlNzhiY2E0ZWNhMzVjNDE4MTky ZDJkMWFjMDQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAyLTIxICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5jcmVhc2UgdGhlIG1heCBw cmVmZXJyZWQgd2lkdGggb2YgdGFibGVzIHRvIDEwMDAwMDAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDU0NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGFibGUvbGFyZ2Utc2hyaW5r LXdyYXBwZWQtd2lkdGguaHRtbAorCisgICAgICAgIFRoZSBvbGQgbGltaXQgb2YgMTUwMDAgd2Fz IHBpY2tlZCBhcmJpdHJhcmlseSB0byBhdm9pZCBvdmVyZmxvdy4KKyAgICAgICAgTm8gbmVlZCB0 byBwaWNrIHN1Y2ggYSBzbWFsbCBudW1iZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvQXV0b1Rh YmxlTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1dG9UYWJsZUxheW91dDo6Y29tcHV0 ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorICAgICAgICBBcyBiZXN0IEkgY2FuIHRlbGwsIHRo aXMgY29kZSBpcyBqdXN0IHdyb25nLiBSZW1vdmluZyB0aGlzIG1ha2VzIHRoZQorICAgICAgICBu ZXcgdGVzdCBwYXNzIGFuZCBkb2Vzbid0IGNhdXNlIGFueSB0ZXN0IGZhaWx1cmUuIFdoaWxlIHdl IGhhdmUgbWFueQorICAgICAgICB0ZXN0cyB0aGF0IGhpdCB0aGlzIGNvZGVwYXRoLCB0aGlzIGNv ZGUgd291bGQgb25seQorICAgICAgICBzaG93IGEgZGlmZmVyZW5jZSBpbiB0aGUgY2FzZXMgd2hl cmUgdGhlIGF2YWlsYWJsZSBjb250YWluZXIgd2lkdGggaXMKKyAgICAgICAgZ3JlYXRlciB0aGVu IDE1MDAwLCBhbmQgSSBkb24ndCB0aGluayB3ZSBoYXZlIGFueSB0ZXN0cyB0aGF0IGhpdCB0aGF0 IGNhc2UKKyAgICAgICAgb3RoZXIgdGhhbiB0aGlzIG5ldyBvbmUuCisgICAgICAgICogcmVuZGVy aW5nL1RhYmxlTGF5b3V0Lmg6CisKIDIwMTMtMDItMjEgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBh ZG9iZS5jb20+CiAKICAgICAgICAgLXdlYmtpdC1tYXJnaW4tY29sbGFwc2U6IHNlcGFyYXRlIGRv ZXNuJ3Qgd29yayBjb3JyZWN0bHkgZm9yIGJlZm9yZSBtYXJnaW5zCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwCmluZGV4IGJhY2YyYWIwNDEyYzliMmZiNjIx NDFlMjc3ODg2ZTRiYTRkNGQ4ODQuLmFjMGM5NjhlYjEzY2UwYTU5OTRkYmIyNjhmNjkwNmQ0OGQw NWRkNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlv dXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3Bw CkBAIC0yNTYsOSArMjU2LDYgQEAgdm9pZCBBdXRvVGFibGVMYXlvdXQ6OmNvbXB1dGVQcmVmZXJy ZWRMb2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXQKICAgICBpZiAodGFi bGVMb2dpY2FsV2lkdGguaXNGaXhlZCgpICYmIHRhYmxlTG9naWNhbFdpZHRoLmlzUG9zaXRpdmUo KSkgewogICAgICAgICBtaW5XaWR0aCA9IG1heDxpbnQ+KG1pbldpZHRoLCB0YWJsZUxvZ2ljYWxX aWR0aC52YWx1ZSgpKTsKICAgICAgICAgbWF4V2lkdGggPSBtaW5XaWR0aDsKLSAgICB9IGVsc2Ug aWYgKCFyZW1haW5pbmdQZXJjZW50ICYmIG1heE5vblBlcmNlbnQpIHsKLSAgICAgICAgLy8gaWYg dGhlcmUgd2FzIG5vIHJlbWFpbmluZyBwZXJjZW50LCBtYXhXaWR0aCBpcyBpbnZhbGlkCi0gICAg ICAgIG1heFdpZHRoID0gdGFibGVNYXhXaWR0aDsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UYWJsZUxheW91dC5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1RhYmxlTGF5b3V0LmgKaW5kZXggZWI5Mjc2ZGIxYTY0Njg5ZDk3OTE4NDIyZjZjMTUw Mzg1MDFmNmUzYi4uY2JiY2YxYWE4MGNmZjg5N2IyMzdiYWZjMGFiNjg4ZmNiZDQxMmQxYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RhYmxlTGF5b3V0LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RhYmxlTGF5b3V0LmgKQEAgLTQyLDcgKzQyLDkgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSA9IDA7CiAKIHByb3RlY3RlZDoKLSAgICBj b25zdCBzdGF0aWMgaW50IHRhYmxlTWF4V2lkdGggPSAxNTAwMDsKKyAgICAvLyBGSVhNRTogT25j ZSB3ZSBlbmFibGUgU0FUVVJBVEVEX0xBWU9VVF9BUklUSE1FVEhJQywgdGhpcyBzaG91bGQganVz dCBiZSBMYXlvdXRVbml0OjpuZWFybHlNYXgoKS4KKyAgICAvLyBVbnRpbCB0aGVuIHRob3VnaCwg dXNpbmcgbmVhcmx5TWF4IGNhdXNlcyBvdmVyZmxvdyBpbiBzb21lIHRlc3RzLCBzbyB3ZSBqdXN0 IHBpY2sgYSBsYXJnZSBudW1iZXIuCisgICAgY29uc3Qgc3RhdGljIGludCB0YWJsZU1heFdpZHRo ID0gMTAwMDAwMDsKIAogICAgIFJlbmRlclRhYmxlKiBtX3RhYmxlOwogfTsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1OWM1 MjVmMDMyMDhkYWQ1MTBmOGNiZWY3ZmQwNWZjY2E1ODBkYjlhLi40M2EyODAyMjc1Yzg1YjhkYmM3 MWQ1YTg1ZDc5OTRkYzI1YTk3MTU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDItMjEg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmNyZWFzZSB0aGUg bWF4IHByZWZlcnJlZCB3aWR0aCBvZiB0YWJsZXMgdG8gMTAwMDAwMAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTQ1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RhYmxlL2xhcmdlLXNocmlu ay13cmFwcGVkLXdpZHRoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC90YWJs ZS9sYXJnZS1zaHJpbmstd3JhcHBlZC13aWR0aC5odG1sOiBBZGRlZC4KKwogMjAxMy0wMi0yMSAg QW5kcmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICAtd2Via2l0LW1hcmdp bi1jb2xsYXBzZTogc2VwYXJhdGUgZG9lc24ndCB3b3JrIGNvcnJlY3RseSBmb3IgYmVmb3JlIG1h cmdpbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvbGFyZ2Utc2hyaW5rLXdy YXBwZWQtd2lkdGgtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9sYXJnZS1z aHJpbmstd3JhcHBlZC13aWR0aC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTNiMDg2MTU4NGYw N2U0NTkyOWZjYzIzNzY2NjlkOGY4MzgxYzI3YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvdGFibGUvbGFyZ2Utc2hyaW5rLXdyYXBwZWQtd2lkdGgtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsMTcgQEAKK0NvbnRlbnQgCitGQUlMOgorRXhwZWN0ZWQgMjAwMDAwMCBmb3Igd2lk dGgsIGJ1dCBnb3QgMTAwMDAxMC4gCisKKzxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CisgICAgPGRp diBzdHlsZT0iZGlzcGxheTppbmxpbmUtYmxvY2s7IGJvcmRlcjogNXB4IHNvbGlkIHNhbG1vbjsi IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjIwMDAwMDAiPgorICAgICAgICA8dGFibGUgc3R5bGU9Indp ZHRoOjEwMCU7IGJhY2tncm91bmQtY29sb3I6Z3JlZW47IHRhYmxlLWxheW91dDpmaXhlZCI+PHRi b2R5Pjx0cj48dGQ+Q29udGVudDwvdGQ+PC90cj48L3Rib2R5PjwvdGFibGU+CisgICAgPC9kaXY+ Cis8L2Rpdj4KK0NvbnRlbnQgCitQQVNTCisgCitQQVNTCisgCitQQVNTCisgCitQQVNTCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xhcmdlLXNocmluay13cmFwcGVkLXdpZHRo Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xhcmdlLXNocmluay13cmFwcGVkLXdpZHRo Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uYjBjZWY1Zjk3ZmU4ZmI2YTE0Y2U0N2ViYThiYWI4ZDkwYzcyZDdk MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvbGFyZ2Utc2hyaW5r LXdyYXBwZWQtd2lkdGguaHRtbApAQCAtMCwwICsxLDY5IEBACis8c3R5bGU+CisuY29udGFpbmVy IHsKKyAgICB3aWR0aDogMjAwMDAwMHB4OworfQorLmNoaWxkIHsKKyAgICBkaXNwbGF5OmlubGlu ZS1ibG9jazsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7CisgICAgd2lkdGg6IDEwMDAw cHg7CisgICAgaGVpZ2h0OiAxMHB4OworfQorLmxhcmdlIHsKKyAgICB3aWR0aDogNTAwMDAwcHg7 Cit9Cit0ZCB7CisgICAgcGFkZGluZzogMDsKK30KK3RhYmxlIHsKKyAgICBib3JkZXItc3BhY2lu ZzogMDsKKyAgICBkaXNwbGF5OiBpbmxpbmUtdGFibGU7CisgICAgb3V0bGluZTogNXB4IHNvbGlk IHNhbG1vbjsKK30KKzwvc3R5bGU+CisKKzwhLS0gVGhlIGlubmVyIGRpdiBzaG91bGQgZmlsbCB0 aGUgY29udGFpbmVyLiBJdCBkb2Vzbid0IHJpZ2h0IG5vdyBiZWNhdXNlIHdlIGFydGlmaWNpYWxs eSBsaW1pdCB0aGUgdGFibGVzIG1heFByZWZlcnJlZExvZ2ljYWxXaWR0aCB0byAxMDAwMDAwLgor ICAgIFNlZSB0aGUgcmVsYXRlZCBGSVhNRSBpbiBUYWJsZUxheW91dC5oLgorIC0tPgorPGRpdiBj bGFzcz0iY29udGFpbmVyIj4KKyAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5OmlubGluZS1ibG9jazsg Ym9yZGVyOiA1cHggc29saWQgc2FsbW9uOyIgZGF0YS1leHBlY3RlZC13aWR0aD0yMDAwMDAwPgor ICAgICAgICA8dGFibGUgc3R5bGU9IndpZHRoOjEwMCU7IGJhY2tncm91bmQtY29sb3I6Z3JlZW47 IHRhYmxlLWxheW91dDpmaXhlZCI+PHRyPjx0ZD5Db250ZW50PC90ZD48L3RyPjwvdGFibGU+Cisg ICAgPC9kaXY+Cis8L2Rpdj4KKzxkaXYgY2xhc3M9ImNvbnRhaW5lciIgc3R5bGU9ImRpc3BsYXk6 aW5saW5lLWJsb2NrOyBib3JkZXI6IDVweCBzb2xpZCBzYWxtb247IG1heC13aWR0aDogLXdlYmtp dC1tYXgtY29udGVudDsiID4KKyAgICA8dGFibGUgc3R5bGU9IndpZHRoOjEwMCU7IGJhY2tncm91 bmQtY29sb3I6Z3JlZW47IHRhYmxlLWxheW91dDpmaXhlZCI+PHRyPjx0ZD5Db250ZW50PC90ZD48 L3RyPjwvdGFibGU+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8IS0t IFRoZSAxIHB4IGV4dHJhIGlzIGZyb20gdGhlIGFsaWduPXJpZ2h0IHRkLiAtLT4KKyAgICA8dGFi bGUgZGF0YS1leHBlY3RlZC13aWR0aD0yMDAwMT4KKyAgICAgICAgPHRkIGFsaWduPXJpZ2h0Pjwv dGQ+CisgICAgICAgIDx0ZCB3aWR0aD0iMTAwJSI+CisgICAgICAgICAgICA8ZGl2IGNsYXNzPSJj aGlsZCI+PC9kaXY+PGRpdiBjbGFzcz0iY2hpbGQiPjwvZGl2PgorICAgICAgICA8L3RkPgorICAg IDwvdGFibGU+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8IS0tIFRo ZSAxIHB4IGV4dHJhIGlzIGZyb20gdGhlIGFsaWduPXJpZ2h0IHRkLiAtLT4KKyAgICA8dGFibGUg ZGF0YS1leHBlY3RlZC13aWR0aD0xMDAwMDAxPgorICAgICAgICA8dGQgYWxpZ249cmlnaHQ+PC90 ZD4KKyAgICAgICAgPHRkIHdpZHRoPSIxMDAlIj4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9Imxh cmdlIGNoaWxkIj48L2Rpdj48ZGl2IGNsYXNzPSJsYXJnZSBjaGlsZCI+PC9kaXY+CisgICAgICAg IDwvdGQ+CisgICAgPC90YWJsZT4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgor ICAgIDwhLS0gVGhlIDEgcHggZXh0cmEgaXMgZnJvbSB0aGUgYWxpZ249cmlnaHQgdGQuIC0tPgor ICAgIDx0YWJsZSBkYXRhLWV4cGVjdGVkLXdpZHRoPTE1MDAwMDE+CisgICAgICAgIDx0ZCBhbGln bj1yaWdodD48L3RkPgorICAgICAgICA8dGQgd2lkdGg9IjEwMCUiPgorICAgICAgICAgICAgPGRp diBjbGFzcz0ibGFyZ2UgY2hpbGQiPjwvZGl2PjxkaXYgY2xhc3M9ImxhcmdlIGNoaWxkIj48L2Rp dj48ZGl2IGNsYXNzPSJsYXJnZSBjaGlsZCI+PC9kaXY+CisgICAgICAgIDwvdGQ+CisgICAgPC90 YWJsZT4KKzwvZGl2PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91 dC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorY2hlY2tMYXlvdXQoJy5jb250YWluZXInKTsKKzwv c2NyaXB0Pgo= 189806 2013-02-22 12:02:40 -0800 2013-02-22 14:25:35 -0800 inline some widths bug-110545-20130222115859.patch text/plain 6437 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVkYmU5MzU2MGU5YjYy MmE5NGVlMGUzZWY1ODRkZDY3NDdiZWM2ZC4uMTBlZGVlZGQyYTc3OTZjNjRmZGIwYjNhNWI5NTEy MTBhN2FmODEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTAyLTIxICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgSW5jcmVhc2UgdGhlIG1heCBw cmVmZXJyZWQgd2lkdGggb2YgdGFibGVzIHRvIDEwMDAwMDAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDU0NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGFibGUvbGFyZ2Utc2hyaW5r LXdyYXBwZWQtd2lkdGguaHRtbAorCisgICAgICAgIFRoZSBvbGQgbGltaXQgb2YgMTUwMDAgd2Fz IHBpY2tlZCBhcmJpdHJhcmlseSB0byBhdm9pZCBvdmVyZmxvdy4KKyAgICAgICAgTm8gbmVlZCB0 byBwaWNrIHN1Y2ggYSBzbWFsbCBudW1iZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvQXV0b1Rh YmxlTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1dG9UYWJsZUxheW91dDo6Y29tcHV0 ZUluc3RyaW5zaWNMb2dpY2FsV2lkdGhzKToKKyAgICAgICAgQXMgYmVzdCBJIGNhbiB0ZWxsLCB0 aGlzIGNvZGUgaXMganVzdCB3cm9uZy4gUmVtb3ZpbmcgdGhpcyBtYWtlcyB0aGUKKyAgICAgICAg bmV3IHRlc3QgcGFzcyBhbmQgZG9lc24ndCBjYXVzZSBhbnkgdGVzdCBmYWlsdXJlLiBXaGlsZSB3 ZSBoYXZlIG1hbnkKKyAgICAgICAgdGVzdHMgdGhhdCBoaXQgdGhpcyBjb2RlcGF0aCwgdGhpcyBj b2RlIHdvdWxkIG9ubHkKKyAgICAgICAgc2hvdyBhIGRpZmZlcmVuY2UgaW4gdGhlIGNhc2VzIHdo ZXJlIHRoZSBhdmFpbGFibGUgY29udGFpbmVyIHdpZHRoIGlzCisgICAgICAgIGdyZWF0ZXIgdGhl biAxNTAwMCwgYW5kIEkgZG9uJ3QgdGhpbmsgd2UgaGF2ZSBhbnkgdGVzdHMgdGhhdCBoaXQgdGhh dCBjYXNlCisgICAgICAgIG90aGVyIHRoYW4gdGhpcyBuZXcgb25lLgorICAgICAgICAqIHJlbmRl cmluZy9UYWJsZUxheW91dC5oOgorCisyMDEzLTAyLTIxICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKICAgICAgICAgQWRkIGNvbXB1dGVJbnN0cmluc2ljTG9naWNhbFdpZHRocyBm dW5jdGlvbnMgdG8gVGFibGVMYXlvdXQgc3ViY2xhc3NlcwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTIwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKaW5kZXggOTZhNzA3YjAxY2FmYjk5YzIxYTYxMGY5 YzhkZDMzMzc0NzMxNDBjNS4uZDQwZGM1Yjk4Njc3ODAxYTIzNDdjOGFkYTEyZTk3OWEzYWM5NzA2 YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKQEAg LTI0NywxMCArMjQ3LDYgQEAgdm9pZCBBdXRvVGFibGVMYXlvdXQ6OmNvbXB1dGVJbnRyaW5zaWNM b2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXQKICAgICB9CiAKICAgICBt YXhXaWR0aCA9IG1heDxpbnQ+KG1heFdpZHRoLCBzcGFuTWF4TG9naWNhbFdpZHRoKTsKLQotICAg IC8vIElmIHRoZXJlIHdhcyBubyByZW1haW5pbmcgcGVyY2VudCwgbWF4V2lkdGggaXMgaW52YWxp ZAotICAgIGlmICghcmVtYWluaW5nUGVyY2VudCAmJiBtYXhOb25QZXJjZW50KQotICAgICAgICBt YXhXaWR0aCA9IHRhYmxlTWF4V2lkdGg7CiB9CiAKIHZvaWQgQXV0b1RhYmxlTGF5b3V0OjphcHBs eVByZWZlcnJlZExvZ2ljYWxXaWR0aFF1aXJrcyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0 VW5pdCYgbWF4V2lkdGgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvVGFibGVMYXlvdXQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UYWJsZUxheW91dC5o CmluZGV4IDI3MzkzZDQ5OWIwMzA0MWI5NDQ4MjVmNjkzMTc1ZTFmNmRiM2JhZDguLjY3NDcyYjk3 YzczNjM2YTA4OTMwMmJhYmViMGI3YjVlN2I1NjFlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9UYWJsZUxheW91dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9UYWJsZUxheW91dC5oCkBAIC00Myw3ICs0Myw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgbGF5b3V0KCkgPSAwOwogCiBwcm90ZWN0ZWQ6Ci0gICAgY29uc3Qgc3RhdGljIGludCB0YWJs ZU1heFdpZHRoID0gMTUwMDA7CisgICAgLy8gRklYTUU6IE9uY2Ugd2UgZW5hYmxlIFNBVFVSQVRF RF9MQVlPVVRfQVJJVEhNRVRISUMsIHRoaXMgc2hvdWxkIGp1c3QgYmUgTGF5b3V0VW5pdDo6bmVh cmx5TWF4KCkuCisgICAgLy8gVW50aWwgdGhlbiB0aG91Z2gsIHVzaW5nIG5lYXJseU1heCBjYXVz ZXMgb3ZlcmZsb3cgaW4gc29tZSB0ZXN0cywgc28gd2UganVzdCBwaWNrIGEgbGFyZ2UgbnVtYmVy LgorICAgIGNvbnN0IHN0YXRpYyBpbnQgdGFibGVNYXhXaWR0aCA9IDEwMDAwMDA7CiAKICAgICBS ZW5kZXJUYWJsZSogbV90YWJsZTsKIH07CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzIwYTk1MmMzMWU5YmIwYzMwMjZmZjA4 MzIxNjQ0NDIwOTFlNTdjYi4uNDY1NDg3YTI2ZTYwYjA1MDY3ZTUwMzhlODA1ZmJlMzFmNGRjMWNk ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTIxICBPamFuIFZhZmFpICA8b2phbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5jcmVhc2UgdGhlIG1heCBwcmVmZXJyZWQgd2lkdGgg b2YgdGFibGVzIHRvIDEwMDAwMDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC90YWJsZS9sYXJnZS1zaHJpbmstd3JhcHBlZC13aWR0aC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvbGFyZ2Utc2hyaW5rLXdyYXBw ZWQtd2lkdGguaHRtbDogQWRkZWQuCisKIDIwMTMtMDItMjIgIEJlbSBKb25lcy1CZXkgIDxiam9u ZXNiZUBhZG9iZS5jb20+CiAKICAgICAgICAgdGV4dC1vdmVyZmxvdzplbGxpcHNpcyBpcyBub3Qg YXBwbGllZCB3aGVuIHRoZSBibG9jayBjb250YWlucyBuZXN0ZWQgYmxvY2tzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xhcmdlLXNocmluay13cmFwcGVkLXdpZHRoLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvbGFyZ2Utc2hyaW5rLXdyYXBwZWQtd2lk dGgtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc0YzY0NzFiZWY0ZjY2ODdmYTExNzBhMDFhNDVm ZTQxMjI5NmJmMjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xh cmdlLXNocmluay13cmFwcGVkLXdpZHRoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE1IEBACitD b250ZW50IAorRkFJTDoKK0V4cGVjdGVkIDIwMDAwMDAgZm9yIHdpZHRoLCBidXQgZ290IDEwMDAw MTAuIAorCis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgc3R5bGU9ImRpc3BsYXk6 aW5saW5lLWJsb2NrOyBib3JkZXI6IDVweCBzb2xpZCBzYWxtb247IiBkYXRhLWV4cGVjdGVkLXdp ZHRoPSIyMDAwMDAwIj4KKyAgICAgICAgPHRhYmxlIHN0eWxlPSJ3aWR0aDoxMDAlOyBiYWNrZ3Jv dW5kLWNvbG9yOmdyZWVuOyB0YWJsZS1sYXlvdXQ6Zml4ZWQiPjx0Ym9keT48dHI+PHRkPkNvbnRl bnQ8L3RkPjwvdHI+PC90Ym9keT48L3RhYmxlPgorICAgIDwvZGl2PgorPC9kaXY+CisgCitQQVNT CisgCitQQVNTCisgCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xh cmdlLXNocmluay13cmFwcGVkLXdpZHRoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2xh cmdlLXNocmluay13cmFwcGVkLXdpZHRoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjE4ZWY5NTk2MDg1YmRi MmJjNTY4NDY0MDgzYWYwZWE5N2Y3NDBjYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvdGFibGUvbGFyZ2Utc2hyaW5rLXdyYXBwZWQtd2lkdGguaHRtbApAQCAtMCwwICsxLDYy IEBACis8c3R5bGU+CisuY29udGFpbmVyIHsKKyAgICB3aWR0aDogMjAwMDAwMHB4OworfQorLmNo aWxkIHsKKyAgICBkaXNwbGF5OmlubGluZS1ibG9jazsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBv cmFuZ2U7CisgICAgaGVpZ2h0OiAxMHB4OworfQordGQgeworICAgIHBhZGRpbmc6IDA7Cit9Cit0 YWJsZSB7CisgICAgYm9yZGVyLXNwYWNpbmc6IDA7CisgICAgZGlzcGxheTogaW5saW5lLXRhYmxl OworICAgIG91dGxpbmU6IDVweCBzb2xpZCBzYWxtb247Cit9Cis8L3N0eWxlPgorCis8IS0tIFRo ZSBpbm5lciBkaXYgc2hvdWxkIGZpbGwgdGhlIGNvbnRhaW5lci4gSXQgZG9lc24ndCByaWdodCBu b3cgYmVjYXVzZSB3ZSBhcnRpZmljaWFsbHkgbGltaXQgdGhlIHRhYmxlJ3MgbWF4UHJlZmVycmVk TG9naWNhbFdpZHRoIHRvIDEwMDAwMDAuCisgICAgU2VlIHRoZSByZWxhdGVkIEZJWE1FIGluIFRh YmxlTGF5b3V0LmguCisgLS0+Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgc3R5 bGU9ImRpc3BsYXk6aW5saW5lLWJsb2NrOyBib3JkZXI6IDVweCBzb2xpZCBzYWxtb247IiBkYXRh LWV4cGVjdGVkLXdpZHRoPTIwMDAwMDA+CisgICAgICAgIDx0YWJsZSBzdHlsZT0id2lkdGg6MTAw JTsgYmFja2dyb3VuZC1jb2xvcjpncmVlbjsgdGFibGUtbGF5b3V0OmZpeGVkIj48dHI+PHRkPkNv bnRlbnQ8L3RkPjwvdHI+PC90YWJsZT4KKyAgICA8L2Rpdj4KKzwvZGl2PgorCis8ZGl2IGNsYXNz PSJjb250YWluZXIiPgorICAgIDwhLS0gVGhlIDEgcHggZXh0cmEgaXMgZnJvbSB0aGUgYWxpZ249 cmlnaHQgdGQuIC0tPgorICAgIDx0YWJsZSBkYXRhLWV4cGVjdGVkLXdpZHRoPTIwMDAxPgorICAg ICAgICA8dGQgYWxpZ249cmlnaHQ+PC90ZD4KKyAgICAgICAgPHRkIHdpZHRoPSIxMDAlIj4KKyAg ICAgICAgICAgIDxkaXYgY2xhc3M9ImNoaWxkIiBzdHlsZT0id2lkdGg6IDEwMDAwcHgiPjwvZGl2 PjxkaXYgY2xhc3M9ImNoaWxkIiBzdHlsZT0id2lkdGg6IDEwMDAwcHgiPjwvZGl2PgorICAgICAg ICA8L3RkPgorICAgIDwvdGFibGU+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iY29udGFpbmVyIj4K KyAgICA8IS0tIFRoZSAxIHB4IGV4dHJhIGlzIGZyb20gdGhlIGFsaWduPXJpZ2h0IHRkLiAtLT4K KyAgICA8dGFibGUgZGF0YS1leHBlY3RlZC13aWR0aD0xMDAwMDAxPgorICAgICAgICA8dGQgYWxp Z249cmlnaHQ+PC90ZD4KKyAgICAgICAgPHRkIHdpZHRoPSIxMDAlIj4KKyAgICAgICAgICAgIDxk aXYgY2xhc3M9ImNoaWxkIiBzdHlsZT0id2lkdGg6IDUwMDAwMHB4Ij48L2Rpdj48ZGl2IGNsYXNz PSJjaGlsZCIgc3R5bGU9IndpZHRoOiA1MDAwMDBweCI+PC9kaXY+CisgICAgICAgIDwvdGQ+Cisg ICAgPC90YWJsZT4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDwhLS0g VGhlIDEgcHggZXh0cmEgaXMgZnJvbSB0aGUgYWxpZ249cmlnaHQgdGQuIC0tPgorICAgIDx0YWJs ZSBkYXRhLWV4cGVjdGVkLXdpZHRoPTE1MDAwMDE+CisgICAgICAgIDx0ZCBhbGlnbj1yaWdodD48 L3RkPgorICAgICAgICA8dGQgd2lkdGg9IjEwMCUiPgorICAgICAgICAgICAgPGRpdiBjbGFzcz0i Y2hpbGQiIHN0eWxlPSJ3aWR0aDogNTAwMDAwcHgiPjwvZGl2PjxkaXYgY2xhc3M9ImNoaWxkIiBz dHlsZT0id2lkdGg6IDUwMDAwMHB4Ij48L2Rpdj48ZGl2IGNsYXNzPSJjaGlsZCIgc3R5bGU9Indp ZHRoOiA1MDAwMDBweCI+PC9kaXY+CisgICAgICAgIDwvdGQ+CisgICAgPC90YWJsZT4KKzwvZGl2 PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0PgorY2hlY2tMYXlvdXQoJy5jb250YWluZXInKTsKKzwvc2NyaXB0Pgo=