110544 2013-02-21 19:01:41 -0800 Use CFNotificationCenter instead of NSNotificationCenter for SharedTimerIOS 2013-02-22 14:17:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin dbates ddkilzer oldest_to_newest 839138 0 benjamin 2013-02-21 19:01:41 -0800 Use CFNotificationCenter instead of NSNotificationCenter for SharedTimerIOS 839140 1 189660 benjamin 2013-02-21 19:04:48 -0800 Created attachment 189660 Patch 839786 2 189660 dbates 2013-02-22 11:52:23 -0800 Comment on attachment 189660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189660&action=review This patch looks straightforward to me. You may want to consider adding a remark that we never remove the observer for notification UIApplicationDidBecomeActiveNotification. (This behavior is consistent with the behavior we had when we used WebCoreResumeNotifierIOS). If you are looking for a more thorough review then feel free to have someone more familiar with {CF, NS}NotificationCenter review this patch. > Source/WebCore/ChangeLog:8 > + Previously, we were instanciating the Obj-C object WebCoreResumeNotifierIOS Nit: instanciating => instantiating > Source/WebCore/ChangeLog:12 > + without the itermediary object. Nit: itermediary => intermediary > Source/WebCore/platform/ios/SharedTimerIOS.mm:38 > +static void applicationDidBecomeActive(CFNotificationCenterRef, void*, CFStringRef, const void *, CFDictionaryRef) Nit: "void *" => "void*" Notice that lack of a space character between "void" and the '*'. 839958 3 benjamin 2013-02-22 14:17:20 -0800 Committed r143795: <http://trac.webkit.org/changeset/143795> 839960 4 benjamin 2013-02-22 14:17:49 -0800 Thank you for the review. 189660 2013-02-21 19:04:48 -0800 2013-02-22 11:52:22 -0800 Patch bug-110544-20130221190108.patch text/plain 3331 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ5Yjc0YmQwOTcyNTQy MDhlYWRmYzMzZmViOTA0ZjI0YmExMmExNi4uYWZlOTUzZTAzNjJkNDIzMDljMTE3ODA2MDJkNWE3 NGFlYTE0Njc4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTIxICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBDRk5vdGlm aWNhdGlvbkNlbnRlciBpbnN0ZWFkIG9mIE5TTm90aWZpY2F0aW9uQ2VudGVyIGZvciBTaGFyZWRU aW1lcklPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEwNTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UHJldmlvdXNseSwgd2Ugd2VyZSBpbnN0YW5jaWF0aW5nIHRoZSBPYmotQyBvYmplY3QgV2ViQ29y ZVJlc3VtZU5vdGlmaWVySU9TCisgICAgICAgIHdpdGggdGhlIG9ubHkgcHVycG9zZSBvZiBmb3J3 YXJkaW5nIG9uZSBub3RpZmljYXRpb24gdG8gYSBDIGZ1bmN0aW9uLgorCisgICAgICAgIFRoaXMg cGF0Y2ggdXBkYXRlcyB0aGUgY29kZSB0byB1c2UgQ0ZOb3RpZmljYXRpb25DZW50ZXIgdG8gZGlz cGF0Y2ggdGhlIG5vdGlmaWNhdGlvbgorICAgICAgICB3aXRob3V0IHRoZSBpdGVybWVkaWFyeSBv YmplY3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvU2hhcmVkVGltZXJJT1MubW06CisgICAg ICAgIChXZWJDb3JlOjphcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSk6CisgICAgICAgIChXZWJD b3JlOjpzZXRTaGFyZWRUaW1lckZpcmVJbnRlcnZhbCk6CisKIDIwMTMtMDItMjEgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIExheW91dFRlc3RzL2Zhc3QvZW5jb2Rp bmcvcGFyc2VyLXRlc3RzLSouaHRtbCB0aW1lb3V0IHdpdGggdGhyZWFkZWQgSFRNTCBwYXJzZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9TaGFyZWRUaW1lcklPUy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9TaGFyZWRUaW1lcklPUy5tbQppbmRleCA2 MDk4MmRhMzU4ZTYzOTY0ZWQyNDU0NmY4OGJiNmI5YjIzMjAyNDFmLi41NTE5MzgwZmViN2VlMTkz Nzk0NjlhYzI3OTNjOTBiNTdhMTQ0NDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvU2hhcmVkVGltZXJJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1NoYXJlZFRpbWVySU9TLm1tCkBAIC0zNCwzNCArMzQsOCBAQCB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHN0YXRpYyBDRlJ1bkxvb3BUaW1lclJlZiBz aGFyZWRUaW1lcjsKIHN0YXRpYyB2b2lkIHRpbWVyRmlyZWQoQ0ZSdW5Mb29wVGltZXJSZWYsIHZv aWQqKTsKLX0KLQotQGludGVyZmFjZSBXZWJDb3JlUmVzdW1lTm90aWZpZXJJT1MgOiBOU09iamVj dAotLSAodm9pZClkaWRXYWtlOwotQGVuZAotCi1AaW1wbGVtZW50YXRpb24gV2ViQ29yZVJlc3Vt ZU5vdGlmaWVySU9TCi0KLS0gKGlkKWluaXQKLXsKLSAgICBpZiAoIShzZWxmID0gW3N1cGVyIGlu aXRdKSkgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgcmV0dXJuIG5p bDsKLSAgICB9Ci0KLSAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIGFk ZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKGRpZFdha2UpIG5hbWU6QCJVSUFwcGxp Y2F0aW9uRGlkQmVjb21lQWN0aXZlTm90aWZpY2F0aW9uIiBvYmplY3Q6bmlsXTsKLQotICAgIHJl dHVybiBzZWxmOwotfQogCi0tICh2b2lkKWRlYWxsb2MKLXsKLSAgICBbW05TTm90aWZpY2F0aW9u Q2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGZdOwotCi0gICAgW3N1cGVy IGRlYWxsb2NdOwotfQotCi0tICh2b2lkKWRpZFdha2UKK3N0YXRpYyB2b2lkIGFwcGxpY2F0aW9u RGlkQmVjb21lQWN0aXZlKENGTm90aWZpY2F0aW9uQ2VudGVyUmVmLCB2b2lkKiwgQ0ZTdHJpbmdS ZWYsIGNvbnN0IHZvaWQgKiwgQ0ZEaWN0aW9uYXJ5UmVmKQogewogICAgIFdlYlRocmVhZFJ1bihe ewogICAgICAgICBpZiAoIXNoYXJlZFRpbWVyKQpAQCAtNzIsMTEgKzQ2LDYgQEAgc3RhdGljIHZv aWQgdGltZXJGaXJlZChDRlJ1bkxvb3BUaW1lclJlZiwgdm9pZCopOwogICAgIH0pOwogfQogCi1A ZW5kCi0KLW5hbWVzcGFjZSBXZWJDb3JlIHsKLQotc3RhdGljIFdlYkNvcmVSZXN1bWVOb3RpZmll cklPUyAqcmVzdW1lTm90aWZpZXI7CiB0eXBlZGVmIHZvaWQgKCpTaGFyZWRUaW1lckZpcmVkRnVu Y3Rpb24pKCk7CiBzdGF0aWMgU2hhcmVkVGltZXJGaXJlZEZ1bmN0aW9uIHNoYXJlZFRpbWVyRmly ZWRGdW5jdGlvbjsKIApAQCAtMTA4LDggKzc3LDEyIEBAIHZvaWQgc2V0U2hhcmVkVGltZXJGaXJl SW50ZXJ2YWwoZG91YmxlIGludGVydmFsKQogICAgIHNoYXJlZFRpbWVyID0gQ0ZSdW5Mb29wVGlt ZXJDcmVhdGUoMCwgZmlyZURhdGUsIDAsIDAsIDAsIHRpbWVyRmlyZWQsIDApOwogICAgIENGUnVu TG9vcEFkZFRpbWVyKFdlYlRocmVhZFJ1bkxvb3AoKSwgc2hhcmVkVGltZXIsIGtDRlJ1bkxvb3BD b21tb25Nb2Rlcyk7CiAKLSAgICBpZiAoIXJlc3VtZU5vdGlmaWVyKQotICAgICAgICByZXN1bWVO b3RpZmllciA9IFtbV2ViQ29yZVJlc3VtZU5vdGlmaWVySU9TIGFsbG9jXSBpbml0XTsKKyAgICBz dGF0aWMgYm9vbCByZWdpc3RlcmVkRm9yQXBwbGljYXRpb25Ob3RpZmljYXRpb24gPSBmYWxzZTsK KyAgICBpZiAoIXJlZ2lzdGVyZWRGb3JBcHBsaWNhdGlvbk5vdGlmaWNhdGlvbikgeworICAgICAg ICByZWdpc3RlcmVkRm9yQXBwbGljYXRpb25Ob3RpZmljYXRpb24gPSB0cnVlOworICAgICAgICBD Rk5vdGlmaWNhdGlvbkNlbnRlclJlZiBub3RpZmljYXRpb25DZW50ZXIgPSBDRk5vdGlmaWNhdGlv bkNlbnRlckdldExvY2FsQ2VudGVyKCk7CisgICAgICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRk T2JzZXJ2ZXIobm90aWZpY2F0aW9uQ2VudGVyLCAwLCBhcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2 ZSwgQ0ZTVFIoIlVJQXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmVOb3RpZmljYXRpb24iKSwgTlVM TCwgQ0ZOb3RpZmljYXRpb25TdXNwZW5zaW9uQmVoYXZpb3JDb2FsZXNjZSk7CisgICAgfQogfQog CiB2b2lkIHN0b3BTaGFyZWRUaW1lcigpCg==