110539 2013-02-21 18:03:39 -0800 25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled 2013-02-21 18:11:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 839101 0 msaboff 2013-02-21 18:03:39 -0800 A regression of 25-30% was found in iOS builds when running JavaScript with just the interpreter running V8 RayTrace. The problem has been tracked to a change made in r129713 <http://trac.webkit.org/changeset/129713> in llint/LowLevelInterpreter32_64.asm. When looking up a pointer in the JSGlobalObject::m_specialPointers array on 32 bit builds, we should use a scale of 4 instead of the 8 introduced in that patch. This is being tracked in <rdar://problem/13102630>. 839103 1 189655 msaboff 2013-02-21 18:07:14 -0800 Created attachment 189655 Patch This patch has already been reviewed in person. 839107 2 msaboff 2013-02-21 18:11:47 -0800 Committed r143677: <http://trac.webkit.org/changeset/143677> 189655 2013-02-21 18:07:14 -0800 2013-02-21 18:07:14 -0800 Patch 110539.patch text/plain 1462 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQzNjczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTAyLTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIDI1LTMwJSByZWdyZXNzaW9uIGluIFY4IFJheVRyYWNlIHRlc3QgaW4gMzIgYml0IGJ1aWxk cyB3aXRoIEpJVCBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEwNTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisK KyAgICAgICAgQ2hhbmdlIHRoZSBzY2FsZSB1c2VkIHRvIGxvb2t1cCBwb2ludGVycyBpbiBKU0ds b2JhbE9iamVjdDo6bV9zcGVjaWFsUG9pbnRlcnMgdG8gYmUgNCBieXRlcyBmb3IKKyAgICAgICAg dGhlIDMyIGJpdCB2ZXJzaW9uIG9mIHRoZSBpbnRlcnByZXRlci4KKworICAgICAgICAqIGxsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisKIDIwMTMtMDItMjEgIFJvZ2VyIEZvbmcg IDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGQgZXhlY3V0 YWJsZSBwcm9wZXJ0eSB0byBjbWQgZmlsZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCShyZXZpc2lv biAxNDM2NzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnBy ZXRlcjMyXzY0LmFzbQkod29ya2luZyBjb3B5KQpAQCAtMTQ4Niw3ICsxNDg2LDcgQEAgX2xsaW50 X29wX2puZXFfcHRyOgogICAgIGxvYWRwIENvZGVCbG9ja1tjZnJdLCB0MgogICAgIGxvYWRwIENv ZGVCbG9jazo6bV9nbG9iYWxPYmplY3RbdDJdLCB0MgogICAgIGJpbmVxIFRhZ09mZnNldFtjZnIs IHQwLCA4XSwgQ2VsbFRhZywgLm9wSm5lcVB0ckJyYW5jaAotICAgIGxvYWRwIEpTR2xvYmFsT2Jq ZWN0OjptX3NwZWNpYWxQb2ludGVyc1t0MiwgdDEsIDhdLCB0MQorICAgIGxvYWRwIEpTR2xvYmFs T2JqZWN0OjptX3NwZWNpYWxQb2ludGVyc1t0MiwgdDEsIDRdLCB0MQogICAgIGJwZXEgUGF5bG9h ZE9mZnNldFtjZnIsIHQwLCA4XSwgdDEsIC5vcEpuZXFQdHJGYWxsVGhyb3VnaAogLm9wSm5lcVB0 ckJyYW5jaDoKICAgICBkaXNwYXRjaEJyYW5jaCgxMltQQ10pCg==