110531 2013-02-21 16:37:58 -0800 Remove browser patching mechanism for handling javascript dialogs in chromium port 2013-02-25 16:52:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kkania kkania abarth apavlov dglazkov fishd jamesr keishi loislo pfeldman pmuellr tkent+wkapi vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 839002 0 kkania 2013-02-21 16:37:58 -0800 Page.handleJavaScriptDialog is now handled in the browser process for the chromium port. We can remove the old message patching technique. 839003 1 189636 kkania 2013-02-21 16:40:15 -0800 Created attachment 189636 Patch 839009 2 webkit.review.bot 2013-02-21 16:43:17 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 841004 3 189636 webkit.review.bot 2013-02-25 08:56:38 -0800 Comment on attachment 189636 Patch Rejecting attachment 189636 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189636, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16746387 841426 4 189636 webkit.review.bot 2013-02-25 16:52:33 -0800 Comment on attachment 189636 Patch Clearing flags on attachment: 189636 Committed r143987: <http://trac.webkit.org/changeset/143987> 841427 5 webkit.review.bot 2013-02-25 16:52:36 -0800 All reviewed patches have been landed. Closing bug. 189636 2013-02-21 16:40:15 -0800 2013-02-25 16:52:32 -0800 Patch bug-110531-20130221163636.patch text/plain 4297 kkania U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMWFkOTc1MmJkODk2ZjViMDFkYTIxZThjMjIwNDI4Y2EyYzIwNDcuLjg3NzVjNjIyMWEyYzYw ODY1YmFhMDMxMjljNGY4ZGUyMTNiOGUwZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMDItMjEgIEtlbiBLYW5pYSAgPGtrYW5pYUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmVtb3ZlIGJyb3dzZXIgcGF0Y2hpbmcgbWVjaGFuaXNtIGZvciBoYW5k bGluZyBqYXZhc2NyaXB0IGRpYWxvZ3MgaW4gY2hyb21pdW0gcG9ydAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTMxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRGV2VG9vbHNBZ2Vu dC5oOgorICAgICAgICAqIHNyYy9XZWJEZXZUb29sc0FnZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkRldlRvb2xzQWdlbnRJbXBsOjpoYW5kbGVKYXZhU2NyaXB0RGlhbG9nKToKKyAg ICAgICAgKFdlYktpdDo6YnJvd3NlckhpbnRUb1N0cmluZyk6CisgICAgICAgIChXZWJLaXQ6OmJy b3dzZXJIaW50RnJvbVN0cmluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYkRldlRvb2xzQWdlbnQ6 OnBhdGNoV2l0aEJyb3dzZXJEYXRhKToKKwogMjAxMy0wMi0yMSAgVnNldm9sb2QgVmxhc292ICA8 dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBHZXQgcmlkIG9m IHBhcnNlZFVSTCBpbiB1aVNvdXJjZUNvZGUsIHVzZSBuYW1lIGFuZCBwYXRoIGZvciBkaXNwbGF5 TmFtZSBpbnN0ZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRGV2VG9vbHNBZ2VudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2 VG9vbHNBZ2VudC5oCmluZGV4IDBkMGEwNzMyMjk0NWI4NTBjMjA4ZTY4OWQ3MTc4ODQ1ZDMxMjhj OTQuLjYwYWQ1NDA0MDkyOGNmMjlhY2I1ZTE4YzlkNDg3ODExMDM5ZDBhODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnQuaAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmgKQEAgLTUzLDgg KzUzLDYgQEAgcHVibGljOgogICAgIGVudW0gQnJvd3NlckRhdGFIaW50IHsKICAgICAgICAgQnJv d3NlckRhdGFIaW50Tm9uZSwKICAgICAgICAgQnJvd3NlckRhdGFIaW50U2NyZWVuc2hvdCwKLSAg ICAgICAgQnJvd3NlckRhdGFIaW50QWNjZXB0SmF2YVNjcmlwdERpYWxvZywKLSAgICAgICAgQnJv d3NlckRhdGFIaW50RGlzbWlzc0phdmFTY3JpcHREaWFsb2csCiAgICAgfTsKIAogICAgIHZpcnR1 YWwgfldlYkRldlRvb2xzQWdlbnQoKSB7fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuY3BwCmluZGV4IDkxYzczNjY1YzE5ODI3ZTYxMzE4 NjRkMThiZWQ4MWMxMjZlMTM1MjYuLjRiZDY2OGM4MTQyZGIyOWI3YjE5MWQyMjRmYzRmMmNmNTI2 MDc0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRldlRvb2xz QWdlbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEZXZUb29s c0FnZW50SW1wbC5jcHAKQEAgLTgzLDggKzgzLDYgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIG5h bWVzcGFjZSBCcm93c2VyRGF0YUhpbnRTdHJpbmdWYWx1ZXMgewogc3RhdGljIGNvbnN0IGNoYXIg c2NyZWVuc2hvdFtdID0gInNjcmVlbnNob3QiOwotc3RhdGljIGNvbnN0IGNoYXIgYWNjZXB0SmF2 YVNjcmlwdERpYWxvZ1tdID0gImFjY2VwdEphdmFTY3JpcHREaWFsb2ciOwotc3RhdGljIGNvbnN0 IGNoYXIgZGlzbWlzc0phdmFTY3JpcHREaWFsb2dbXSA9ICJkaXNtaXNzSmF2YVNjcmlwdERpYWxv ZyI7CiB9CiAKIGNsYXNzIENsaWVudE1lc3NhZ2VMb29wQWRhcHRlciA6IHB1YmxpYyBQYWdlU2Ny aXB0RGVidWdTZXJ2ZXI6OkNsaWVudE1lc3NhZ2VMb29wIHsKQEAgLTYxMCw4ICs2MDgsNyBAQCBi b29sIFdlYkRldlRvb2xzQWdlbnRJbXBsOjpjYXB0dXJlU2NyZWVuc2hvdChTdHJpbmcqIGRhdGEp CiAKIGJvb2wgV2ViRGV2VG9vbHNBZ2VudEltcGw6OmhhbmRsZUphdmFTY3JpcHREaWFsb2coYm9v bCBhY2NlcHQpCiB7Ci0gICAgLy8gT3BlcmF0aW9uIGlzIGdvaW5nIHRvIGJlIHBlcmZvcm1lZCBp biB0aGUgYnJvd3NlciBwcm9jZXNzLgotICAgIG1fc2VuZFdpdGhCcm93c2VyRGF0YUhpbnQgPSBh Y2NlcHQgPyBCcm93c2VyRGF0YUhpbnRBY2NlcHRKYXZhU2NyaXB0RGlhbG9nIDogQnJvd3NlckRh dGFIaW50RGlzbWlzc0phdmFTY3JpcHREaWFsb2c7CisgICAgLy8gT3BlcmF0aW9uIHdhcyBhbHJl YWR5IHBlcmZvcm1lZCBpbiB0aGUgYnJvd3NlciBwcm9jZXNzLgogICAgIHJldHVybiB0cnVlOwog fQogCkBAIC02OTQsMTAgKzY5MSw2IEBAIHN0YXRpYyBTdHJpbmcgYnJvd3NlckhpbnRUb1N0cmlu ZyhXZWJEZXZUb29sc0FnZW50OjpCcm93c2VyRGF0YUhpbnQgZGF0YUhpbnQpCiAgICAgc3dpdGNo IChkYXRhSGludCkgewogICAgIGNhc2UgV2ViRGV2VG9vbHNBZ2VudDo6QnJvd3NlckRhdGFIaW50 U2NyZWVuc2hvdDoKICAgICAgICAgcmV0dXJuIEJyb3dzZXJEYXRhSGludFN0cmluZ1ZhbHVlczo6 c2NyZWVuc2hvdDsKLSAgICBjYXNlIFdlYkRldlRvb2xzQWdlbnQ6OkJyb3dzZXJEYXRhSGludEFj Y2VwdEphdmFTY3JpcHREaWFsb2c6Ci0gICAgICAgIHJldHVybiBCcm93c2VyRGF0YUhpbnRTdHJp bmdWYWx1ZXM6OmFjY2VwdEphdmFTY3JpcHREaWFsb2c7Ci0gICAgY2FzZSBXZWJEZXZUb29sc0Fn ZW50OjpCcm93c2VyRGF0YUhpbnREaXNtaXNzSmF2YVNjcmlwdERpYWxvZzoKLSAgICAgICAgcmV0 dXJuIEJyb3dzZXJEYXRhSGludFN0cmluZ1ZhbHVlczo6ZGlzbWlzc0phdmFTY3JpcHREaWFsb2c7 CiAgICAgY2FzZSBXZWJEZXZUb29sc0FnZW50OjpCcm93c2VyRGF0YUhpbnROb25lOgogICAgIGRl ZmF1bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpAQCAtNzA5LDEwICs3MDIsNiBA QCBzdGF0aWMgV2ViRGV2VG9vbHNBZ2VudDo6QnJvd3NlckRhdGFIaW50IGJyb3dzZXJIaW50RnJv bVN0cmluZyhjb25zdCBTdHJpbmcmIHZhbAogewogICAgIGlmICh2YWx1ZSA9PSBCcm93c2VyRGF0 YUhpbnRTdHJpbmdWYWx1ZXM6OnNjcmVlbnNob3QpCiAgICAgICAgIHJldHVybiBXZWJEZXZUb29s c0FnZW50OjpCcm93c2VyRGF0YUhpbnRTY3JlZW5zaG90OwotICAgIGlmICh2YWx1ZSA9PSBCcm93 c2VyRGF0YUhpbnRTdHJpbmdWYWx1ZXM6OmFjY2VwdEphdmFTY3JpcHREaWFsb2cpCi0gICAgICAg IHJldHVybiBXZWJEZXZUb29sc0FnZW50OjpCcm93c2VyRGF0YUhpbnRBY2NlcHRKYXZhU2NyaXB0 RGlhbG9nOwotICAgIGlmICh2YWx1ZSA9PSBCcm93c2VyRGF0YUhpbnRTdHJpbmdWYWx1ZXM6OmRp c21pc3NKYXZhU2NyaXB0RGlhbG9nKQotICAgICAgICByZXR1cm4gV2ViRGV2VG9vbHNBZ2VudDo6 QnJvd3NlckRhdGFIaW50RGlzbWlzc0phdmFTY3JpcHREaWFsb2c7CiAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgcmV0dXJuIFdlYkRldlRvb2xzQWdlbnQ6OkJyb3dzZXJEYXRhSGludE5v bmU7CiB9CkBAIC04NjgsMTAgKzg1Nyw2IEBAIFdlYlN0cmluZyBXZWJEZXZUb29sc0FnZW50Ojpw YXRjaFdpdGhCcm93c2VyRGF0YShjb25zdCBXZWJTdHJpbmcmIG1lc3NhZ2UsIEJyb3dzCiAgICAg Y2FzZSBCcm93c2VyRGF0YUhpbnRTY3JlZW5zaG90OgogICAgICAgICByZXN1bHRPYmplY3QtPnNl dFN0cmluZygiZGF0YSIsIGhpbnREYXRhKTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBCcm93 c2VyRGF0YUhpbnRBY2NlcHRKYXZhU2NyaXB0RGlhbG9nOgotICAgICAgICBicmVhazsKLSAgICBj YXNlIEJyb3dzZXJEYXRhSGludERpc21pc3NKYXZhU2NyaXB0RGlhbG9nOgotICAgICAgICBicmVh azsKICAgICBjYXNlIEJyb3dzZXJEYXRhSGludE5vbmU6CiAgICAgZGVmYXVsdDoKICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==