<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110520</bug_id>
          
          <creation_ts>2013-02-21 15:12:24 -0800</creation_ts>
          <short_desc>Add computeInstrinsicLogicalWidths functions to TableLayout subclasses</short_desc>
          <delta_ts>2013-02-22 14:51:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>110515</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Ojan Vafai">ojan</assigned_to>
          <cc>eae</cc>
    
    <cc>eric</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>hyatt</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>leviw</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>838890</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-21 15:12:24 -0800</bug_when>
    <thetext>Add computeInstrinsicLogicalWidths functions to TableLayout subclasses</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>838896</commentid>
    <comment_count>1</comment_count>
      <attachid>189611</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-21 15:16:22 -0800</bug_when>
    <thetext>Created attachment 189611
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>838897</commentid>
    <comment_count>2</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-21 15:16:52 -0800</bug_when>
    <thetext>This patch depends on the cleanup in bug 110515.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839147</commentid>
    <comment_count>3</comment_count>
      <attachid>189662</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-21 19:22:50 -0800</bug_when>
    <thetext>Created attachment 189662
Sync to ToT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839712</commentid>
    <comment_count>4</comment_count>
      <attachid>189662</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2013-02-22 10:33:43 -0800</bug_when>
    <thetext>Comment on attachment 189662
Sync to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=189662&amp;action=review

&gt; Source/WebCore/rendering/AutoTableLayout.cpp:251
&gt; +    // if there was no remaining percent, maxWidth is invalid

Nit: Capitalize the first letter and end the sentence with a period.

&gt; Source/WebCore/rendering/FixedTableLayout.cpp:181
&gt; +    minWidth = maxWidth = calcWidthArray();

Julien is right that this style is rare.  I see it mostly when setting min and max preferred width to the same value.  I don&apos;t think it&apos;s actually against the style guide and this seems fine to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839773</commentid>
    <comment_count>5</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-22 11:37:44 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 189662 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=189662&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/rendering/FixedTableLayout.cpp:181
&gt; &gt; +    minWidth = maxWidth = calcWidthArray();
&gt; 
&gt; Julien is right that this style is rare.  I see it mostly when setting min and max preferred width to the same value.  I don&apos;t think it&apos;s actually against the style guide and this seems fine to me.

Yup. As to whether it&apos;s more readable, it just seems like a matter of taste. I find this more clear for these functions that all have the same pattern of setting the min and max widths.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839777</commentid>
    <comment_count>6</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-22 11:42:28 -0800</bug_when>
    <thetext>Committed r143762: &lt;http://trac.webkit.org/changeset/143762&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839805</commentid>
    <comment_count>7</comment_count>
      <attachid>189662</attachid>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2013-02-22 12:18:50 -0800</bug_when>
    <thetext>Comment on attachment 189662
Sync to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=189662&amp;action=review

&gt;&gt;&gt; Source/WebCore/rendering/FixedTableLayout.cpp:181
&gt;&gt;&gt; +    minWidth = maxWidth = calcWidthArray();
&gt;&gt; 
&gt;&gt; Julien is right that this style is rare.  I see it mostly when setting min and max preferred width to the same value.  I don&apos;t think it&apos;s actually against the style guide and this seems fine to me.
&gt; 
&gt; Yup. As to whether it&apos;s more readable, it just seems like a matter of taste. I find this more clear for these functions that all have the same pattern of setting the min and max widths.

The readability argument stems from not being consistent with the rest of the code (which is not something subjective). It&apos;s easy to browse over this code and miss that both logical widths are set up.

Also it *is* a style violation, I just couldn&apos;t find the relevant point in the coding style: see http://www.webkit.org/coding/coding-style.html, Line breaking, point 1. &quot;Each statement should get its own line.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>839910</commentid>
    <comment_count>8</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2013-02-22 13:55:16 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; The readability argument stems from not being consistent with the rest of the code (which is not something subjective). It&apos;s easy to browse over this code and miss that both logical widths are set up.

It *is* consistent with all the computePreferredLogicalWidth functions that do this. I feel like this pattern makes it much easier to browse this code and see that they&apos;re just being set to the same value.

&gt; Also it *is* a style violation, I just couldn&apos;t find the relevant point in the coding style: see http://www.webkit.org/coding/coding-style.html, Line breaking, point 1. &quot;Each statement should get its own line.&quot;

I think this case is not what this style rule is referring to, but I see how it&apos;s open to interpretation. If you want an official ruling on this, we should probably discuss this on webkit-dev.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>840019</commentid>
    <comment_count>9</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2013-02-22 14:51:41 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; The readability argument stems from not being consistent with the rest of the code (which is not something subjective). It&apos;s easy to browse over this code and miss that both logical widths are set up.
&gt; 
&gt; It *is* consistent with all the computePreferredLogicalWidth functions that do this. I feel like this pattern makes it much easier to browse this code and see that they&apos;re just being set to the same value.

I would expect computePreferredLogicalWidth&apos;s code to be old and thus don&apos;t match our current style very well.

&gt; &gt; Also it *is* a style violation, I just couldn&apos;t find the relevant point in the coding style: see http://www.webkit.org/coding/coding-style.html, Line breaking, point 1. &quot;Each statement should get its own line.&quot;
&gt; 
&gt; I think this case is not what this style rule is referring to, but I see how it&apos;s open to interpretation. If you want an official ruling on this, we should probably discuss this on webkit-dev.

I pointed it out on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2013-February/023947.html</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>189611</attachid>
            <date>2013-02-21 15:16:22 -0800</date>
            <delta_ts>2013-02-21 19:22:48 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-110520-20130221151242.patch</filename>
            <type>text/plain</type>
            <size>8093</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUzOGI5M2MzNTk3MDc5
YWM1NzBkYzg0OWIzOGQyYzFiMjI5NGFhNC4uZDgxOWYxNmYzMWI0NTVkZjJkM2VkZTE5ZmQwZjM5
ZjA0MGIzMDQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEzLTAyLTIxICBPamFu
IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIGNvbXB1dGVJbnN0cmlu
c2ljTG9naWNhbFdpZHRocyBmdW5jdGlvbnMgdG8gVGFibGVMYXlvdXQgc3ViY2xhc3NlcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTIwCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBqdXN0
IGEgcmVmYWN0b3IgaW4gcHJlcGFyYXRpb24gZm9yIGFkZGluZyBSZW5kZXJUYWJsZTo6Y29tcHV0
ZUludGluc2ljTG9naWNhbFdpZHRocy4KKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgor
CisgICAgICAgIFNwbGl0IHRoZSBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBmdW5jdGlv
bnMgaW50byBhIGNvbXB1dGVJbnRpbnNpY0xvZ2ljYWxXaWR0aHMKKyAgICAgICAgYW5kIGEgYXBw
bHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MuIEFsc28sIG1vdmUgdGhlIGFkZGl0aW9uIG9m
IGJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZworICAgICAgICBpbnRvIFJlbmRlclRhYmxlIHNpbmNl
IGJvdGggVGFibGVMYXlvdXQgc3ViY2xhc3NlcyBuZWVkIHRoaXMuCisKKyAgICAgICAgVGhpcyBo
YXMgdGhlIGFkZGVkIHJlYWRhYmlsaXR5IGJlbmVmaXQgb2YgYmV0dGVyIGlzb2xhdGluZyB0aGUg
cXVpcmtzIHRoYXQgZWFjaCB0YWJsZSBsYXlvdXQKKyAgICAgICAgbW9kZSByZXF1aXJlcy4KKwor
ICAgICAgICAqIHJlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6QXV0b1RhYmxlTGF5b3V0Ojpjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyk6CisgICAg
ICAgIChXZWJDb3JlOjpBdXRvVGFibGVMYXlvdXQ6OmFwcGx5UHJlZmVycmVkTG9naWNhbFdpZHRo
UXVpcmtzKToKKyAgICAgICAgKiByZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0Lmg6CisgICAgICAg
IChBdXRvVGFibGVMYXlvdXQpOgorICAgICAgICAqIHJlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpeGVkVGFibGVMYXlvdXQ6OmNvbXB1dGVJbnRyaW5z
aWNMb2dpY2FsV2lkdGhzKToKKyAgICAgICAgKFdlYkNvcmU6OkZpeGVkVGFibGVMYXlvdXQ6OmFw
cGx5UHJlZmVycmVkTG9naWNhbFdpZHRoUXVpcmtzKToKKyAgICAgICAgKiByZW5kZXJpbmcvRml4
ZWRUYWJsZUxheW91dC5oOgorICAgICAgICAoRml4ZWRUYWJsZUxheW91dCk6CisgICAgICAgICog
cmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxl
Ojpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyk6CisgICAgICAgICogcmVuZGVyaW5nL1Rh
YmxlTGF5b3V0Lmg6CisgICAgICAgIChUYWJsZUxheW91dCk6CisKIDIwMTMtMDItMjEgIEFuZHJl
aSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+CiAKICAgICAgICAgLXdlYmtpdC1tYXJnaW4tY29s
bGFwc2U6IHNlcGFyYXRlIGRvZXNuJ3Qgd29yayBjb3JyZWN0bHkgZm9yIGJlZm9yZSBtYXJnaW5z
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwCmluZGV4IGU4
ZWI5NGQ0N2FlOTFlNDZmZjllMDgwOTcxOGI5YzMyYmMyNjRkZTguLmUwYmE0OTVjYWMxNTg5ZmIx
ZDg0N2ZkMzM4ZjFkM2U3ZGNkMjVlMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl
cmluZy9BdXRvVGFibGVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9B
dXRvVGFibGVMYXlvdXQuY3BwCkBAIC0yMTAsNyArMjEwLDcgQEAgc3RhdGljIGJvb2wgc2hvdWxk
U2NhbGVDb2x1bW5zKFJlbmRlclRhYmxlKiB0YWJsZSkKICAgICByZXR1cm4gc2NhbGU7CiB9CiAK
LXZvaWQgQXV0b1RhYmxlTGF5b3V0Ojpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhMYXlv
dXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lkdGgpCit2b2lkIEF1dG9UYWJsZUxh
eW91dDo6Y29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWluV2lkdGgs
IExheW91dFVuaXQmIG1heFdpZHRoKQogewogICAgIGZ1bGxSZWNhbGMoKTsKIApAQCAtMjQ2LDE2
ICsyNDYsMTUgQEAgdm9pZCBBdXRvVGFibGVMYXlvdXQ6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2Fs
V2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXQKICAgICAgICAgbWF4V2lkdGggPSBt
YXg8aW50PihtYXhXaWR0aCwgc3RhdGljX2Nhc3Q8aW50PihtaW4obWF4UGVyY2VudCwgc3RhdGlj
X2Nhc3Q8ZmxvYXQ+KHRhYmxlTWF4V2lkdGgpKSkpOwogICAgIH0KIAotICAgIG1heFdpZHRoID0g
bWF4PGludD4obWF4V2lkdGgsIHNwYW5NYXhMb2dpY2FsV2lkdGgpOwotCi0gICAgaW50IGJvcmRl
cnNQYWRkaW5nQW5kU3BhY2luZyA9IG1fdGFibGUtPmJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZ0lu
Um93RGlyZWN0aW9uKCk7Ci0gICAgbWluV2lkdGggKz0gYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5n
OwotICAgIG1heFdpZHRoICs9IGJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZzsKKyAgICBtYXhXaWR0
aCA9IG1heDxpbnQ+KG1heFdpZHRoLCBzcGFuTWF4TG9naWNhbFdpZHRoKTsgICAgCiAKICAgICAv
LyBpZiB0aGVyZSB3YXMgbm8gcmVtYWluaW5nIHBlcmNlbnQsIG1heFdpZHRoIGlzIGludmFsaWQK
ICAgICBpZiAoIXJlbWFpbmluZ1BlcmNlbnQgJiYgbWF4Tm9uUGVyY2VudCkKICAgICAgICAgbWF4
V2lkdGggPSB0YWJsZU1heFdpZHRoOworfQogCit2b2lkIEF1dG9UYWJsZUxheW91dDo6YXBwbHlQ
cmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MoTGF5b3V0VW5pdCYgbWluV2lkdGgsIExheW91dFVu
aXQmIG1heFdpZHRoKSBjb25zdAorewogICAgIExlbmd0aCB0YWJsZUxvZ2ljYWxXaWR0aCA9IG1f
dGFibGUtPnN0eWxlKCktPmxvZ2ljYWxXaWR0aCgpOwogICAgIGlmICh0YWJsZUxvZ2ljYWxXaWR0
aC5pc0ZpeGVkKCkgJiYgdGFibGVMb2dpY2FsV2lkdGguaXNQb3NpdGl2ZSgpKQogICAgICAgICBt
aW5XaWR0aCA9IG1heFdpZHRoID0gbWF4PGludD4obWluV2lkdGgsIHRhYmxlTG9naWNhbFdpZHRo
LnZhbHVlKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJs
ZUxheW91dC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5oCmlu
ZGV4IDlkMGFkYzFjZDEzMDMzOGYxNDIzMDZiMjE0YTVkYWMzMTM3NGQ3YzkuLmExZmRhZDA0ODBk
NzJiMDBlZGY3YmFiNjZkZDUzMTY5OWI4NzJmNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp
bmcvQXV0b1RhYmxlTGF5b3V0LmgKQEAgLTM2LDcgKzM2LDggQEAgcHVibGljOgogICAgIEF1dG9U
YWJsZUxheW91dChSZW5kZXJUYWJsZSopOwogICAgIH5BdXRvVGFibGVMYXlvdXQoKTsKIAotICAg
IHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBt
aW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lkdGgpOworICAgIHZpcnR1YWwgdm9pZCBjb21wdXRl
SW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYg
bWF4V2lkdGgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBhcHBseVByZWZlcnJlZExvZ2lj
YWxXaWR0aFF1aXJrcyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lkdGgp
IGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKIAogcHJpdmF0ZToK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0LmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0LmNwcAppbmRleCBi
ZTkyZDMyMmI3Mzk2NjFmODlmODRkZGZlODcwNzFlN2U5MjIwNTc1Li4yYzNiNjg1Y2ExZWFkNWQ4
NTJkMjA4Zjg4OTBkOWM2YjExNDM2NWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k
ZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n
L0ZpeGVkVGFibGVMYXlvdXQuY3BwCkBAIC0xNzYsMTQgKzE3NiwxNiBAQCBpbnQgRml4ZWRUYWJs
ZUxheW91dDo6Y2FsY1dpZHRoQXJyYXkoKQogICAgIHJldHVybiB1c2VkV2lkdGg7CiB9CiAKLXZv
aWQgRml4ZWRUYWJsZUxheW91dDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoTGF5b3V0
VW5pdCYgbWluV2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKQordm9pZCBGaXhlZFRhYmxlTGF5
b3V0Ojpjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwg
TGF5b3V0VW5pdCYgbWF4V2lkdGgpCiB7Ci0gICAgaW50IGJvcmRlcnNQYWRkaW5nQW5kU3BhY2lu
ZyA9IG1fdGFibGUtPmJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZ0luUm93RGlyZWN0aW9uKCk7Ci0g
ICAgbWluV2lkdGggPSBtYXhXaWR0aCA9IGNhbGNXaWR0aEFycmF5KCkgKyBib3JkZXJzUGFkZGlu
Z0FuZFNwYWNpbmc7CisgICAgbWluV2lkdGggPSBtYXhXaWR0aCA9IGNhbGNXaWR0aEFycmF5KCk7
Cit9CiAKK3ZvaWQgRml4ZWRUYWJsZUxheW91dDo6YXBwbHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhR
dWlya3MoTGF5b3V0VW5pdCYgbWluV2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKSBjb25zdAor
ewogICAgIExlbmd0aCB0YWJsZUxvZ2ljYWxXaWR0aCA9IG1fdGFibGUtPnN0eWxlKCktPmxvZ2lj
YWxXaWR0aCgpOwogICAgIGlmICh0YWJsZUxvZ2ljYWxXaWR0aC5pc0ZpeGVkKCkgJiYgdGFibGVM
b2dpY2FsV2lkdGguaXNQb3NpdGl2ZSgpKQotICAgICAgICBtaW5XaWR0aCA9IG1heFdpZHRoID0g
bWF4PGludD4obWluV2lkdGgsIHRhYmxlTG9naWNhbFdpZHRoLnZhbHVlKCkgLSBib3JkZXJzUGFk
ZGluZ0FuZFNwYWNpbmcpOworICAgICAgICBtaW5XaWR0aCA9IG1heFdpZHRoID0gbWF4PGludD4o
bWluV2lkdGgsIHRhYmxlTG9naWNhbFdpZHRoLnZhbHVlKCkgLSBtX3RhYmxlLT5ib3JkZXJzUGFk
ZGluZ0FuZFNwYWNpbmdJblJvd0RpcmVjdGlvbigpKTsKIAogICAgIC8qCiAgICAgICAgIDx0YWJs
ZSBzdHlsZT0id2lkdGg6MTAwJTsgYmFja2dyb3VuZC1jb2xvcjpyZWQiPjx0cj48dGQ+CmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5oIGIvU291
cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpeGVkVGFibGVMYXlvdXQuaAppbmRleCA1NjA5ZThjN2I4
MGJlOGJjOTVmYmMyY2Q5OTg3OGQ2ZGY2NzU2Mjc0Li42OGJhMDg0NjgxOTU5NjUwNzdiZmFhYzkx
MmJiMzViODViODE0NTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4
ZWRUYWJsZUxheW91dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxl
TGF5b3V0LmgKQEAgLTM0LDcgKzM0LDggQEAgY2xhc3MgRml4ZWRUYWJsZUxheW91dCA6IHB1Ymxp
YyBUYWJsZUxheW91dCB7CiBwdWJsaWM6CiAgICAgRml4ZWRUYWJsZUxheW91dChSZW5kZXJUYWJs
ZSopOwogCi0gICAgdmlydHVhbCB2b2lkIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKExh
eW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXRVbml0JiBtYXhXaWR0aCk7CisgICAgdmlydHVhbCB2
b2lkIGNvbXB1dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBM
YXlvdXRVbml0JiBtYXhXaWR0aCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGFwcGx5UHJl
ZmVycmVkTG9naWNhbFdpZHRoUXVpcmtzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXRVbml0
JiBtYXhXaWR0aCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpOwog
CiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRh
YmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXgg
NDUxYjc0NWNhYTI3MTJiNmE5YTVlNjRhMTRiOTM0MDkzOTgyY2M4Ny4uZThjMWE5NzIzYWUyZTk5
MmMyMWE0MGFiNDNlOWE4MjdlMmVkZDEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu
ZGVyaW5nL1JlbmRlclRhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu
ZGVyVGFibGUuY3BwCkBAIC03MjAsNyArNzIwLDEzIEBAIHZvaWQgUmVuZGVyVGFibGU6OmNvbXB1
dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKCkKICAgICByZWNhbGNTZWN0aW9uc0lmTmVlZGVkKCk7
CiAgICAgcmVjYWxjQm9yZGVyc0luUm93RGlyZWN0aW9uKCk7CiAKLSAgICBtX3RhYmxlTGF5b3V0
LT5jb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhtX21pblByZWZlcnJlZExvZ2ljYWxXaWR0
aCwgbV9tYXhQcmVmZXJyZWRMb2dpY2FsV2lkdGgpOworICAgIG1fdGFibGVMYXlvdXQtPmNvbXB1
dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRoLCBtX21h
eFByZWZlcnJlZExvZ2ljYWxXaWR0aCk7CisKKyAgICBpbnQgYm9yZGVyc1BhZGRpbmdBbmRTcGFj
aW5nID0gYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nSW5Sb3dEaXJlY3Rpb24oKTsKKyAgICBtX21p
blByZWZlcnJlZExvZ2ljYWxXaWR0aCArPSBib3JkZXJzUGFkZGluZ0FuZFNwYWNpbmc7CisgICAg
bV9tYXhQcmVmZXJyZWRMb2dpY2FsV2lkdGggKz0gYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nOwor
CisgICAgbV90YWJsZUxheW91dC0+YXBwbHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MobV9t
aW5QcmVmZXJyZWRMb2dpY2FsV2lkdGgsIG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoKTsKIAog
ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2NhcHRpb25zLnNpemUoKTsgaSsrKQogICAg
ICAgICBtX21pblByZWZlcnJlZExvZ2ljYWxXaWR0aCA9IG1heChtX21pblByZWZlcnJlZExvZ2lj
YWxXaWR0aCwgbV9jYXB0aW9uc1tpXS0+bWluUHJlZmVycmVkTG9naWNhbFdpZHRoKCkpOwpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RhYmxlTGF5b3V0LmggYi9Tb3VyY2Uv
V2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQuaAppbmRleCBlYjkyNzZkYjFhNjQ2ODlkOTc5
MTg0MjJmNmMxNTAzODUwMWY2ZTNiLi4yNzM5M2Q0OTliMDMwNDFiOTQ0ODI1ZjY5MzE3NWUxZjZk
YjNiYWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQu
aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQuaApAQCAtMzgsNyAr
MzgsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5UYWJsZUxheW91dCgpIHsgfQogCi0gICAg
dmlydHVhbCB2b2lkIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1p
bldpZHRoLCBMYXlvdXRVbml0JiBtYXhXaWR0aCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBjb21w
dXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5p
dCYgbWF4V2lkdGgpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgYXBwbHlQcmVmZXJyZWRMb2dpY2Fs
V2lkdGhRdWlya3MoTGF5b3V0VW5pdCYgbWluV2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKSBj
b25zdCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpID0gMDsKIAogcHJvdGVjdGVkOgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>189662</attachid>
            <date>2013-02-21 19:22:50 -0800</date>
            <delta_ts>2013-02-22 12:18:50 -0800</delta_ts>
            <desc>Sync to ToT</desc>
            <filename>bug-110520-20130221191910.patch</filename>
            <type>text/plain</type>
            <size>8312</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJiMGRlNWQ5YzU2MGFl
Y2VjMDNiMTYyZDIzMjIwMjlkZDFlOTVjMi4uNTNkM2I1MTYwMzJmYzUxNzE3ODU3NmJkMDAxMzgy
NTUzNWQ0ZmQxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM3IEBACiAyMDEzLTAyLTIxICBPamFu
IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgQWRkIGNvbXB1dGVJbnN0cmlu
c2ljTG9naWNhbFdpZHRocyBmdW5jdGlvbnMgdG8gVGFibGVMYXlvdXQgc3ViY2xhc3NlcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTIwCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBqdXN0
IGEgcmVmYWN0b3IgaW4gcHJlcGFyYXRpb24gZm9yIGFkZGluZyBSZW5kZXJUYWJsZTo6Y29tcHV0
ZUludGluc2ljTG9naWNhbFdpZHRocy4KKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgor
CisgICAgICAgIFNwbGl0IHRoZSBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBmdW5jdGlv
bnMgaW50byBhIGNvbXB1dGVJbnRpbnNpY0xvZ2ljYWxXaWR0aHMKKyAgICAgICAgYW5kIGEgYXBw
bHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MuIEFsc28sIG1vdmUgdGhlIGFkZGl0aW9uIG9m
IGJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZworICAgICAgICBpbnRvIFJlbmRlclRhYmxlIHNpbmNl
IGJvdGggVGFibGVMYXlvdXQgc3ViY2xhc3NlcyBuZWVkIHRoaXMuCisKKyAgICAgICAgVGhpcyBo
YXMgdGhlIGFkZGVkIHJlYWRhYmlsaXR5IGJlbmVmaXQgb2YgYmV0dGVyIGlzb2xhdGluZyB0aGUg
cXVpcmtzIHRoYXQgZWFjaCB0YWJsZSBsYXlvdXQKKyAgICAgICAgbW9kZSByZXF1aXJlcy4KKwor
ICAgICAgICAqIHJlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6QXV0b1RhYmxlTGF5b3V0Ojpjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyk6CisgICAg
ICAgIChXZWJDb3JlOjpBdXRvVGFibGVMYXlvdXQ6OmFwcGx5UHJlZmVycmVkTG9naWNhbFdpZHRo
UXVpcmtzKToKKyAgICAgICAgKiByZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0Lmg6CisgICAgICAg
IChBdXRvVGFibGVMYXlvdXQpOgorICAgICAgICAqIHJlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpeGVkVGFibGVMYXlvdXQ6OmNvbXB1dGVJbnRyaW5z
aWNMb2dpY2FsV2lkdGhzKToKKyAgICAgICAgKFdlYkNvcmU6OkZpeGVkVGFibGVMYXlvdXQ6OmFw
cGx5UHJlZmVycmVkTG9naWNhbFdpZHRoUXVpcmtzKToKKyAgICAgICAgKiByZW5kZXJpbmcvRml4
ZWRUYWJsZUxheW91dC5oOgorICAgICAgICAoRml4ZWRUYWJsZUxheW91dCk6CisgICAgICAgICog
cmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxl
Ojpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyk6CisgICAgICAgICogcmVuZGVyaW5nL1Rh
YmxlTGF5b3V0Lmg6CisgICAgICAgIChUYWJsZUxheW91dCk6CisKKzIwMTMtMDItMjEgIE9qYW4g
VmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBDbGVhbiB1cCBjb21wdXRlUHJl
ZmVycmVkTG9naWNhbFdpZHRocyBmdW5jdGlvbnMgaW4gVGFibGVMYXlvdXQgc3ViY2xhc3Nlcwog
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTE1CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3Bw
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKaW5kZXggYmFj
ZjJhYjA0MTJjOWIyZmI2MjE0MWUyNzc4ODZlNGJhNGQ0ZDg4NC4uYWM0NGVkZDdlNjYzYmEzZGRm
YjEwOTVlYWUwZjkzYWJiOTA4ZmE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy
aW5nL0F1dG9UYWJsZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1
dG9UYWJsZUxheW91dC5jcHAKQEAgLTIxMCw3ICsyMTAsNyBAQCBzdGF0aWMgYm9vbCBzaG91bGRT
Y2FsZUNvbHVtbnMoUmVuZGVyVGFibGUqIHRhYmxlKQogICAgIHJldHVybiBzY2FsZTsKIH0KIAot
dm9pZCBBdXRvVGFibGVMYXlvdXQ6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKExheW91
dFVuaXQmIG1pbldpZHRoLCBMYXlvdXRVbml0JiBtYXhXaWR0aCkKK3ZvaWQgQXV0b1RhYmxlTGF5
b3V0Ojpjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwg
TGF5b3V0VW5pdCYgbWF4V2lkdGgpCiB7CiAgICAgZnVsbFJlY2FsYygpOwogCkBAIC0yNDgsMTgg
KzI0OCwxNiBAQCB2b2lkIEF1dG9UYWJsZUxheW91dDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxX
aWR0aHMoTGF5b3V0VW5pdCYgbWluV2lkdGgsIExheW91dAogCiAgICAgbWF4V2lkdGggPSBtYXg8
aW50PihtYXhXaWR0aCwgc3Bhbk1heExvZ2ljYWxXaWR0aCk7CiAKLSAgICBpbnQgYm9yZGVyc1Bh
ZGRpbmdBbmRTcGFjaW5nID0gbV90YWJsZS0+Ym9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nSW5Sb3dE
aXJlY3Rpb24oKTsKLSAgICBtaW5XaWR0aCArPSBib3JkZXJzUGFkZGluZ0FuZFNwYWNpbmc7Ci0g
ICAgbWF4V2lkdGggKz0gYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nOworICAgIC8vIGlmIHRoZXJl
IHdhcyBubyByZW1haW5pbmcgcGVyY2VudCwgbWF4V2lkdGggaXMgaW52YWxpZAorICAgIGlmICgh
cmVtYWluaW5nUGVyY2VudCAmJiBtYXhOb25QZXJjZW50KQorICAgICAgICBtYXhXaWR0aCA9IHRh
YmxlTWF4V2lkdGg7Cit9CiAKK3ZvaWQgQXV0b1RhYmxlTGF5b3V0OjphcHBseVByZWZlcnJlZExv
Z2ljYWxXaWR0aFF1aXJrcyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lk
dGgpIGNvbnN0Cit7CiAgICAgTGVuZ3RoIHRhYmxlTG9naWNhbFdpZHRoID0gbV90YWJsZS0+c3R5
bGUoKS0+bG9naWNhbFdpZHRoKCk7Ci0gICAgaWYgKHRhYmxlTG9naWNhbFdpZHRoLmlzRml4ZWQo
KSAmJiB0YWJsZUxvZ2ljYWxXaWR0aC5pc1Bvc2l0aXZlKCkpIHsKLSAgICAgICAgbWluV2lkdGgg
PSBtYXg8aW50PihtaW5XaWR0aCwgdGFibGVMb2dpY2FsV2lkdGgudmFsdWUoKSk7Ci0gICAgICAg
IG1heFdpZHRoID0gbWluV2lkdGg7Ci0gICAgfSBlbHNlIGlmICghcmVtYWluaW5nUGVyY2VudCAm
JiBtYXhOb25QZXJjZW50KSB7Ci0gICAgICAgIC8vIGlmIHRoZXJlIHdhcyBubyByZW1haW5pbmcg
cGVyY2VudCwgbWF4V2lkdGggaXMgaW52YWxpZAotICAgICAgICBtYXhXaWR0aCA9IHRhYmxlTWF4
V2lkdGg7Ci0gICAgfQorICAgIGlmICh0YWJsZUxvZ2ljYWxXaWR0aC5pc0ZpeGVkKCkgJiYgdGFi
bGVMb2dpY2FsV2lkdGguaXNQb3NpdGl2ZSgpKQorICAgICAgICBtaW5XaWR0aCA9IG1heFdpZHRo
ID0gbWF4PGludD4obWluV2lkdGgsIHRhYmxlTG9naWNhbFdpZHRoLnZhbHVlKCkpOwogfQogCiAv
KgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5o
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5oCmluZGV4IDlkMGFk
YzFjZDEzMDMzOGYxNDIzMDZiMjE0YTVkYWMzMTM3NGQ3YzkuLmExZmRhZDA0ODBkNzJiMDBlZGY3
YmFiNjZkZDUzMTY5OWI4NzJmNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu
Zy9BdXRvVGFibGVMYXlvdXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQXV0b1Rh
YmxlTGF5b3V0LmgKQEAgLTM2LDcgKzM2LDggQEAgcHVibGljOgogICAgIEF1dG9UYWJsZUxheW91
dChSZW5kZXJUYWJsZSopOwogICAgIH5BdXRvVGFibGVMYXlvdXQoKTsKIAotICAgIHZpcnR1YWwg
dm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwg
TGF5b3V0VW5pdCYgbWF4V2lkdGgpOworICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlSW50cmluc2lj
TG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lkdGgp
IE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBhcHBseVByZWZlcnJlZExvZ2ljYWxXaWR0aFF1
aXJrcyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lkdGgpIGNvbnN0IE9W
RVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKIAogcHJpdmF0ZToKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0LmNwcCBiL1NvdXJj
ZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0LmNwcAppbmRleCBiYzhmNTg2ZTRk
NjZlNTNhMmQ3MzlhYWFjOTEyOWI1Yzc0MDllZmFmLi5hNmI2NWU5MzRmZWEzMTE1YTJmZWQyM2Vm
NzI0NzQzZDgwZThkOTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4
ZWRUYWJsZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpeGVkVGFi
bGVMYXlvdXQuY3BwCkBAIC0xNzYsMTQgKzE3NiwxNiBAQCBpbnQgRml4ZWRUYWJsZUxheW91dDo6
Y2FsY1dpZHRoQXJyYXkoKQogICAgIHJldHVybiB1c2VkV2lkdGg7CiB9CiAKLXZvaWQgRml4ZWRU
YWJsZUxheW91dDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWlu
V2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKQordm9pZCBGaXhlZFRhYmxlTGF5b3V0Ojpjb21w
dXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5p
dCYgbWF4V2lkdGgpCiB7Ci0gICAgaW50IGJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZyA9IG1fdGFi
bGUtPmJvcmRlcnNQYWRkaW5nQW5kU3BhY2luZ0luUm93RGlyZWN0aW9uKCk7Ci0gICAgbWluV2lk
dGggPSBtYXhXaWR0aCA9IGNhbGNXaWR0aEFycmF5KCkgKyBib3JkZXJzUGFkZGluZ0FuZFNwYWNp
bmc7CisgICAgbWluV2lkdGggPSBtYXhXaWR0aCA9IGNhbGNXaWR0aEFycmF5KCk7Cit9CiAKK3Zv
aWQgRml4ZWRUYWJsZUxheW91dDo6YXBwbHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MoTGF5
b3V0VW5pdCYgbWluV2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKSBjb25zdAorewogICAgIExl
bmd0aCB0YWJsZUxvZ2ljYWxXaWR0aCA9IG1fdGFibGUtPnN0eWxlKCktPmxvZ2ljYWxXaWR0aCgp
OwogICAgIGlmICh0YWJsZUxvZ2ljYWxXaWR0aC5pc0ZpeGVkKCkgJiYgdGFibGVMb2dpY2FsV2lk
dGguaXNQb3NpdGl2ZSgpKQotICAgICAgICBtaW5XaWR0aCA9IG1heFdpZHRoID0gbWF4PGludD4o
bWluV2lkdGgsIHRhYmxlTG9naWNhbFdpZHRoLnZhbHVlKCkgLSBib3JkZXJzUGFkZGluZ0FuZFNw
YWNpbmcpOworICAgICAgICBtaW5XaWR0aCA9IG1heFdpZHRoID0gbWF4PGludD4obWluV2lkdGgs
IHRhYmxlTG9naWNhbFdpZHRoLnZhbHVlKCkgLSBtX3RhYmxlLT5ib3JkZXJzUGFkZGluZ0FuZFNw
YWNpbmdJblJvd0RpcmVjdGlvbigpKTsKIAogICAgIC8qCiAgICAgICAgIDx0YWJsZSBzdHlsZT0i
d2lkdGg6MTAwJTsgYmFja2dyb3VuZC1jb2xvcjpyZWQiPjx0cj48dGQ+CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5oIGIvU291cmNlL1dlYkNv
cmUvcmVuZGVyaW5nL0ZpeGVkVGFibGVMYXlvdXQuaAppbmRleCA1NjA5ZThjN2I4MGJlOGJjOTVm
YmMyY2Q5OTg3OGQ2ZGY2NzU2Mjc0Li42OGJhMDg0NjgxOTU5NjUwNzdiZmFhYzkxMmJiMzViODVi
ODE0NTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxh
eW91dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0LmgK
QEAgLTM0LDcgKzM0LDggQEAgY2xhc3MgRml4ZWRUYWJsZUxheW91dCA6IHB1YmxpYyBUYWJsZUxh
eW91dCB7CiBwdWJsaWM6CiAgICAgRml4ZWRUYWJsZUxheW91dChSZW5kZXJUYWJsZSopOwogCi0g
ICAgdmlydHVhbCB2b2lkIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKExheW91dFVuaXQm
IG1pbldpZHRoLCBMYXlvdXRVbml0JiBtYXhXaWR0aCk7CisgICAgdmlydHVhbCB2b2lkIGNvbXB1
dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXRVbml0
JiBtYXhXaWR0aCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGFwcGx5UHJlZmVycmVkTG9n
aWNhbFdpZHRoUXVpcmtzKExheW91dFVuaXQmIG1pbldpZHRoLCBMYXlvdXRVbml0JiBtYXhXaWR0
aCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpOwogCiBwcml2YXRl
OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXggMTRiM2E2ZDI3
N2Y2YmNlZjYwZjc2OGY5ODUxMDJkMjUzMmNiNWNkZS4uN2NjN2ViNjM5YTEzZTZhMWQ5NGRhNjVm
ODMwYzBkNWMzNmQwZDI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl
bmRlclRhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUu
Y3BwCkBAIC03MTksNyArNzE5LDEzIEBAIHZvaWQgUmVuZGVyVGFibGU6OmNvbXB1dGVQcmVmZXJy
ZWRMb2dpY2FsV2lkdGhzKCkKICAgICByZWNhbGNTZWN0aW9uc0lmTmVlZGVkKCk7CiAgICAgcmVj
YWxjQm9yZGVyc0luUm93RGlyZWN0aW9uKCk7CiAKLSAgICBtX3RhYmxlTGF5b3V0LT5jb21wdXRl
UHJlZmVycmVkTG9naWNhbFdpZHRocyhtX21pblByZWZlcnJlZExvZ2ljYWxXaWR0aCwgbV9tYXhQ
cmVmZXJyZWRMb2dpY2FsV2lkdGgpOworICAgIG1fdGFibGVMYXlvdXQtPmNvbXB1dGVJbnRyaW5z
aWNMb2dpY2FsV2lkdGhzKG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRoLCBtX21heFByZWZlcnJl
ZExvZ2ljYWxXaWR0aCk7CisKKyAgICBpbnQgYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nID0gYm9y
ZGVyc1BhZGRpbmdBbmRTcGFjaW5nSW5Sb3dEaXJlY3Rpb24oKTsKKyAgICBtX21pblByZWZlcnJl
ZExvZ2ljYWxXaWR0aCArPSBib3JkZXJzUGFkZGluZ0FuZFNwYWNpbmc7CisgICAgbV9tYXhQcmVm
ZXJyZWRMb2dpY2FsV2lkdGggKz0gYm9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nOworCisgICAgbV90
YWJsZUxheW91dC0+YXBwbHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWlya3MobV9taW5QcmVmZXJy
ZWRMb2dpY2FsV2lkdGgsIG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoKTsKIAogICAgIGZvciAo
dW5zaWduZWQgaSA9IDA7IGkgPCBtX2NhcHRpb25zLnNpemUoKTsgaSsrKQogICAgICAgICBtX21p
blByZWZlcnJlZExvZ2ljYWxXaWR0aCA9IG1heChtX21pblByZWZlcnJlZExvZ2ljYWxXaWR0aCwg
bV9jYXB0aW9uc1tpXS0+bWluUHJlZmVycmVkTG9naWNhbFdpZHRoKCkpOwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RhYmxlTGF5b3V0LmggYi9Tb3VyY2UvV2ViQ29yZS9y
ZW5kZXJpbmcvVGFibGVMYXlvdXQuaAppbmRleCBlYjkyNzZkYjFhNjQ2ODlkOTc5MTg0MjJmNmMx
NTAzODUwMWY2ZTNiLi4yNzM5M2Q0OTliMDMwNDFiOTQ0ODI1ZjY5MzE3NWUxZjZkYjNiYWQ4IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQuaApAQCAtMzgsNyArMzgsOCBAQCBw
dWJsaWM6CiAKICAgICB2aXJ0dWFsIH5UYWJsZUxheW91dCgpIHsgfQogCi0gICAgdmlydHVhbCB2
b2lkIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKExheW91dFVuaXQmIG1pbldpZHRoLCBM
YXlvdXRVbml0JiBtYXhXaWR0aCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlSW50cmlu
c2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5XaWR0aCwgTGF5b3V0VW5pdCYgbWF4V2lk
dGgpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgYXBwbHlQcmVmZXJyZWRMb2dpY2FsV2lkdGhRdWly
a3MoTGF5b3V0VW5pdCYgbWluV2lkdGgsIExheW91dFVuaXQmIG1heFdpZHRoKSBjb25zdCA9IDA7
CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpID0gMDsKIAogcHJvdGVjdGVkOgo=
</data>
<flag name="review"
          id="210154"
          type_id="1"
          status="+"
          setter="tony"
    />
    <flag name="commit-queue"
          id="210155"
          type_id="3"
          status="-"
          setter="tony"
    />
          </attachment>
      

    </bug>

</bugzilla>