110512 2013-02-21 14:16:01 -0800 Change default background color of a dragged image 2013-03-05 16:13:36 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh ap buildbot darin dcheng jamesr rniwa simon.fraser tony webkit.review.bot oldest_to_newest 838830 0 shawnsingh 2013-02-21 14:16:01 -0800 Most of the time, dragged images did not care what the background color of their nodeImage was. However, now in some cases, this background color actually matters because the drag image becomes a webkit composited layer and paints with that color. So, we should change this color to completely transparent. dcheng@ can you please make sure what I said above is correct =) Also, I did some archaeology and I think the original change was made in https://bugs.webkit.org/show_bug.cgi?id=43449 -- hopefully that may jog your memory if there really is an important reason why opaque white was chosen. There's no particular platform or other port that especially needs opaque white to paint the drag images correctly, is there? Patch coming in a moment. 838840 1 dcheng 2013-02-21 14:18:39 -0800 Yes, that's the right patch. I already looked at it yesterday, but I still don't really remember the exact reason for picking a white background. 838844 2 189601 shawnsingh 2013-02-21 14:22:39 -0800 Created attachment 189601 Patch 838847 3 189601 dcheng 2013-02-21 14:24:08 -0800 Comment on attachment 189601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189601&action=review > Source/WebCore/page/Frame.cpp:1082 > + m_view->setBaseBackgroundColor(colorWithOverrideAlpha(Color::black, 0.0)); Perhaps just use Color::transparent? 838849 4 189602 shawnsingh 2013-02-21 14:28:53 -0800 Created attachment 189602 Use Color::transparent 838877 5 189602 buildbot 2013-02-21 15:03:26 -0800 Comment on attachment 189602 Use Color::transparent Attachment 189602 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16692349 New failing tests: svg/custom/empty-className-baseVal-crash.html 838952 6 shawnsingh 2013-02-21 15:53:55 -0800 Still requesting review... before patch + after patch layout tests seem the same on my mac desktop. The ews bot failures are from the tree, very unlikely from this patch. 839066 7 simon.fraser 2013-02-21 17:37:17 -0800 Can you give specific examples of content that shows the problem you're trying to fix? 839289 8 shawnsingh 2013-02-21 23:25:10 -0800 (In reply to comment #7) > Can you give specific examples of content that shows the problem you're trying to fix? The original chromium-side bug report is https://code.google.com/p/chromium/issues/detail?id=177036 - you can see the screenshot on the first post there. For other reasons, the drag image is chosen to be larger than the image itself. As I understand the situation, there's no way to reproduce this in a reduced test / layout test, since it's a uniqueness of chrome os that recycles the draggable image back into another webview for the ui. At least, I think that's how it works. 841210 9 190108 shawnsingh 2013-02-25 12:50:32 -0800 Created attachment 190108 retrying ews bots 844550 10 shawnsingh 2013-02-28 15:34:28 -0800 Is there any update to review? tony@ I think you may have reviewed some dragging related patches in the past; could you please take a look? Thanks in advance. 846792 11 190108 tony 2013-03-04 13:30:08 -0800 Comment on attachment 190108 retrying ews bots View in context: https://bugs.webkit.org/attachment.cgi?id=190108&action=review Looks like this code originally came from Chromium's WebKit port and was refactored in r96339 to be used by Gtk+ as well. Can you describe how to manually see the difference here? Maybe you can upload a test case to the bug or add manual test to the ManualTests directory? > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). This goes below the bug line. See the other entries in the ChangeLog. > Source/WebCore/ChangeLog:13 > + This behavior is needed for chrome OS, the background color for > + nodeImage doesn't show up at all when dragging for other ports; so Please mention that this change does not impact Mac or Win due to the #if. 847814 12 190108 shawnsingh 2013-03-05 10:45:09 -0800 Comment on attachment 190108 retrying ews bots Thanks for review, removing r=? for now, I'll try to have a new patch soon. 847818 13 shawnsingh 2013-03-05 10:47:29 -0800 (In reply to comment #11) > (From update of attachment 190108 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190108&action=review > > Looks like this code originally came from Chromium's WebKit port and was refactored in r96339 to be used by Gtk+ as well. > > Can you describe how to manually see the difference here? hshi@ uploaded a nice manual test on the chromium side - https://code.google.com/p/chromium/issues/detail?id=177036 - I'll create a webkit manual test based off that for the next patch. Tony@ in the mean-time, did you have any further thoughts about comments #39 and #40, point (2) ? thanks 848088 14 191569 shawnsingh 2013-03-05 14:40:34 -0800 Created attachment 191569 Patch 848094 15 shawnsingh 2013-03-05 14:42:34 -0800 > > Source/WebCore/ChangeLog:13 > > + This behavior is needed for chrome OS, the background color for > > + nodeImage doesn't show up at all when dragging for other ports; so > > Please mention that this change does not impact Mac or Win due to the #if. Actually I did not understand what you mean here... does this comment still apply to the latest patch? Latest patch is complete this time, including a Manual test. 848123 16 tony 2013-03-05 15:05:01 -0800 (In reply to comment #15) > > > Source/WebCore/ChangeLog:13 > > > + This behavior is needed for chrome OS, the background color for > > > + nodeImage doesn't show up at all when dragging for other ports; so > > > > Please mention that this change does not impact Mac or Win due to the #if. > > Actually I did not understand what you mean here... does this comment still apply to the latest patch? Sorry, by Mac and Win I mean Apple Mac and Apple Win due to "#if !PLATFORM(MAC) && !PLATFORM(WIN)" a few lines up. 848126 17 191569 tony 2013-03-05 15:05:59 -0800 Comment on attachment 191569 Patch LGTM, please update the ChangeLog before landing. 848175 18 191587 shawnsingh 2013-03-05 15:45:12 -0800 Created attachment 191587 Patch for landing 848184 19 191587 webkit.review.bot 2013-03-05 15:53:46 -0800 Comment on attachment 191587 Patch for landing Rejecting attachment 191587 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 191587, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17048199 848189 20 191590 shawnsingh 2013-03-05 15:56:03 -0800 Created attachment 191590 Patch for landing 848203 21 191590 webkit.review.bot 2013-03-05 16:13:31 -0800 Comment on attachment 191590 Patch for landing Clearing flags on attachment: 191590 Committed r144841: <http://trac.webkit.org/changeset/144841> 848204 22 webkit.review.bot 2013-03-05 16:13:36 -0800 All reviewed patches have been landed. Closing bug. 189601 2013-02-21 14:22:39 -0800 2013-02-21 14:28:52 -0800 Patch bug-110512-20130221141859.patch text/plain 1818 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA1OTcwMDkxN2FmNzE2 Mjk5ZjNjZGY5OGZlMWRjZThkMGUxOWVjMC4uZGJiOGVmMTg3ODJiMTRiNTU3NmFkYzgwZjg2MTY5 NzcwMmMwNzg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTIxICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBkZWZh dWx0IGJhY2tncm91bmQgY29sb3Igb2YgYSBkcmFnZ2VkIGltYWdlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1MTIKKworICAgICAgICBVbnRpbCB2 ZXJ5IHJlY2VudGx5LCB0aGUgYmFja2dyb3VuZCBjb2xvciBvZiBhIGRyYWdnZWQgaW1hZ2UKKyAg ICAgICAgZGlkbid0IG1hdHRlci4gTm93LCB0aGUgYmFja2dyb3VuZCBjb2xvciBuZWVkcyB0byBi ZSBmdWxseQorICAgICAgICB0cmFuc3BhcmVudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJlaGF2aW9yIGlzIG5lZWRlZCBmb3IgY2hyb21l IE9TLCB0aGUgYmFja2dyb3VuZCBjb2xvciBmb3IKKyAgICAgICAgbm9kZUltYWdlIGRvZXNuJ3Qg c2hvdyB1cCBhdCBhbGwgd2hlbiBkcmFnZ2luZyBmb3Igb3RoZXIgcG9ydHM7IHNvCisgICAgICAg IHRoZXJlIGlzIG5vIHByYWN0aWNhbCB3YXkgdG8gdGVzdCB0aGlzIHdpdGggbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6 bm9kZUltYWdlKToKKwogMjAxMy0wMi0yMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgT3V0LW9mLXZpZXcgZml4ZWQgcG9zaXRpb24gY2hlY2sgc2hvdWxkIG5vdCBi ZSBhZmZlY3RlZCBieSBwYWdlIHNjYWxlIGF0IGFsbCBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAK aW5kZXggMTIzN2ZmOWU0MGY5MDk3ZjVjMTdjM2ZjMjc3ZmM5MGEwODM4M2Q5My4uNzNjYzIwZGU1 ZTIzZWI0ZDAzYTk4MmE5M2Y4MmFhYWU1YTMxYWZjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAg LTEwNzksNyArMTA3OSw3IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5v ZGUpCiAgICAgbV92aWV3LT5zZXRQYWludEJlaGF2aW9yKHN0YXRlLnBhaW50QmVoYXZpb3IgfCBQ YWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKTsKIAogICAgIC8vIFdoZW4gZ2Vu ZXJhdGluZyB0aGUgZHJhZyBpbWFnZSBmb3IgYW4gZWxlbWVudCwgaWdub3JlIHRoZSBkb2N1bWVu dCBiYWNrZ3JvdW5kLgotICAgIG1fdmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihjb2xvcldp dGhPdmVycmlkZUFscGhhKENvbG9yOjp3aGl0ZSwgMS4wKSk7CisgICAgbV92aWV3LT5zZXRCYXNl QmFja2dyb3VuZENvbG9yKGNvbG9yV2l0aE92ZXJyaWRlQWxwaGEoQ29sb3I6OmJsYWNrLCAwLjAp KTsKICAgICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7CiAgICAgbV92aWV3LT5zZXROb2RlVG9EcmF3 KG5vZGUpOyAvLyBFbmFibGUgc3BlY2lhbCBzdWItdHJlZSBkcmF3aW5nIG1vZGUuCiAK 189602 2013-02-21 14:28:53 -0800 2013-02-25 12:50:30 -0800 Use Color::transparent bug-110512-20130221142514.patch text/plain 1795 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA1OTcwMDkxN2FmNzE2 Mjk5ZjNjZGY5OGZlMWRjZThkMGUxOWVjMC4uZGJiOGVmMTg3ODJiMTRiNTU3NmFkYzgwZjg2MTY5 NzcwMmMwNzg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTIxICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBkZWZh dWx0IGJhY2tncm91bmQgY29sb3Igb2YgYSBkcmFnZ2VkIGltYWdlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1MTIKKworICAgICAgICBVbnRpbCB2 ZXJ5IHJlY2VudGx5LCB0aGUgYmFja2dyb3VuZCBjb2xvciBvZiBhIGRyYWdnZWQgaW1hZ2UKKyAg ICAgICAgZGlkbid0IG1hdHRlci4gTm93LCB0aGUgYmFja2dyb3VuZCBjb2xvciBuZWVkcyB0byBi ZSBmdWxseQorICAgICAgICB0cmFuc3BhcmVudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJlaGF2aW9yIGlzIG5lZWRlZCBmb3IgY2hyb21l IE9TLCB0aGUgYmFja2dyb3VuZCBjb2xvciBmb3IKKyAgICAgICAgbm9kZUltYWdlIGRvZXNuJ3Qg c2hvdyB1cCBhdCBhbGwgd2hlbiBkcmFnZ2luZyBmb3Igb3RoZXIgcG9ydHM7IHNvCisgICAgICAg IHRoZXJlIGlzIG5vIHByYWN0aWNhbCB3YXkgdG8gdGVzdCB0aGlzIHdpdGggbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6 bm9kZUltYWdlKToKKwogMjAxMy0wMi0yMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgT3V0LW9mLXZpZXcgZml4ZWQgcG9zaXRpb24gY2hlY2sgc2hvdWxkIG5vdCBi ZSBhZmZlY3RlZCBieSBwYWdlIHNjYWxlIGF0IGFsbCBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAK aW5kZXggMTIzN2ZmOWU0MGY5MDk3ZjVjMTdjM2ZjMjc3ZmM5MGEwODM4M2Q5My4uYjc1MzUwOWJl MjNjY2EwODNkOWI1ZDZlNTFlNmE1NDZlOWY4NWUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAg LTEwNzksNyArMTA3OSw3IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5v ZGUpCiAgICAgbV92aWV3LT5zZXRQYWludEJlaGF2aW9yKHN0YXRlLnBhaW50QmVoYXZpb3IgfCBQ YWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKTsKIAogICAgIC8vIFdoZW4gZ2Vu ZXJhdGluZyB0aGUgZHJhZyBpbWFnZSBmb3IgYW4gZWxlbWVudCwgaWdub3JlIHRoZSBkb2N1bWVu dCBiYWNrZ3JvdW5kLgotICAgIG1fdmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihjb2xvcldp dGhPdmVycmlkZUFscGhhKENvbG9yOjp3aGl0ZSwgMS4wKSk7CisgICAgbV92aWV3LT5zZXRCYXNl QmFja2dyb3VuZENvbG9yKENvbG9yOjp0cmFuc3BhcmVudCk7CiAgICAgbV9kb2MtPnVwZGF0ZUxh eW91dCgpOwogICAgIG1fdmlldy0+c2V0Tm9kZVRvRHJhdyhub2RlKTsgLy8gRW5hYmxlIHNwZWNp YWwgc3ViLXRyZWUgZHJhd2luZyBtb2RlLgogCg== 190108 2013-02-25 12:50:32 -0800 2013-03-05 14:40:29 -0800 retrying ews bots bug-110512-20130225124648.patch text/plain 1783 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMzMGQ0MTU5M2M1NTAw ODhmMTYwNDYyYzVjYmViYjc3ZTVjOWQwNS4uNmE0NWMxYzgzYTUyMDUwOTljZWI2OTBmM2VkNWNh NGE0M2M3MTZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTIxICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBkZWZh dWx0IGJhY2tncm91bmQgY29sb3Igb2YgYSBkcmFnZ2VkIGltYWdlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1MTIKKworICAgICAgICBVbnRpbCB2 ZXJ5IHJlY2VudGx5LCB0aGUgYmFja2dyb3VuZCBjb2xvciBvZiBhIGRyYWdnZWQgaW1hZ2UKKyAg ICAgICAgZGlkbid0IG1hdHRlci4gTm93LCB0aGUgYmFja2dyb3VuZCBjb2xvciBuZWVkcyB0byBi ZSBmdWxseQorICAgICAgICB0cmFuc3BhcmVudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJlaGF2aW9yIGlzIG5lZWRlZCBmb3IgY2hyb21l IE9TLCB0aGUgYmFja2dyb3VuZCBjb2xvciBmb3IKKyAgICAgICAgbm9kZUltYWdlIGRvZXNuJ3Qg c2hvdyB1cCBhdCBhbGwgd2hlbiBkcmFnZ2luZyBmb3Igb3RoZXIgcG9ydHM7IHNvCisgICAgICAg IHRoZXJlIGlzIG5vIHByYWN0aWNhbCB3YXkgdG8gdGVzdCB0aGlzIHdpdGggbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6 bm9kZUltYWdlKToKKwogMjAxMy0wMi0yNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgQ2hhbmdlZCBEYXRhYmFzZVRyYWNrZXI6OmdldE1heFNpemVGb3JEYXRhYmFz ZSgpIHRvIHJldHVybiB0aGUgcHJldmlvdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggMTIzN2Zm OWU0MGY5MDk3ZjVjMTdjM2ZjMjc3ZmM5MGEwODM4M2Q5My4uYjc1MzUwOWJlMjNjY2EwODNkOWI1 ZDZlNTFlNmE1NDZlOWY4NWUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAgLTEwNzksNyArMTA3 OSw3IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5vZGUpCiAgICAgbV92 aWV3LT5zZXRQYWludEJlaGF2aW9yKHN0YXRlLnBhaW50QmVoYXZpb3IgfCBQYWludEJlaGF2aW9y RmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKTsKIAogICAgIC8vIFdoZW4gZ2VuZXJhdGluZyB0aGUg ZHJhZyBpbWFnZSBmb3IgYW4gZWxlbWVudCwgaWdub3JlIHRoZSBkb2N1bWVudCBiYWNrZ3JvdW5k LgotICAgIG1fdmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihjb2xvcldpdGhPdmVycmlkZUFs cGhhKENvbG9yOjp3aGl0ZSwgMS4wKSk7CisgICAgbV92aWV3LT5zZXRCYXNlQmFja2dyb3VuZENv bG9yKENvbG9yOjp0cmFuc3BhcmVudCk7CiAgICAgbV9kb2MtPnVwZGF0ZUxheW91dCgpOwogICAg IG1fdmlldy0+c2V0Tm9kZVRvRHJhdyhub2RlKTsgLy8gRW5hYmxlIHNwZWNpYWwgc3ViLXRyZWUg ZHJhd2luZyBtb2RlLgogCg== 191569 2013-03-05 14:40:34 -0800 2013-03-05 15:45:08 -0800 Patch bug-110512-20130305143639.patch text/plain 4267 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI2NmQ4YTBjMDJkZTQx NjE2OTI5MzYwZmY4N2NkYTg1ZGIxN2YyMC4uNzkzNTFjOGEzZmQwYTYzMDY2NDkxNTA2MzZjM2U0 YjBkOTk1NjdlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTA1ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBkZWZhdWx0 IGJhY2tncm91bmQgb2YgYSBkcmFnZ2VkIGltYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVHJhbnNwYXJlbnQgYmFja2dyb3VuZCBjb2xvciAocGFy dGljdWxhcmx5IHZpc2libGUgaW4gdGhlIHBhZGRpbmcKKyAgICAgICAgb2YgYW4gZWxlbWVudCkg d2FzIG5vdCBiZWluZyByZXNwZWN0ZWQuIFRoZSBzb2x1dGlvbiBpcyB0bworICAgICAgICBpbml0 aWFsbHkgZmlsbCB0aGUgZHJhZyBpbWFnZSB3aXRoIHRyYW5zcGFyZW50IGluc3RlYWQgb2Ygd2hp dGUsCisgICAgICAgIHNvIHRoYXQgYW55IGNvbG9yIGJhY2tncm91bmQgd29ya3MgY29ycmVjdGx5 LgorCisgICAgICAgIE1hbnVhbCB0ZXN0IGFkZGVkOgorICAgICAgICAgIE1hbnVhbFRlc3RzL2Ry YWctYmFja2dyb3VuZC13aXRoLXBhZGRpbmcuaHRtbAorCisgICAgICAgIEluZnJhc3RydWN0dXJl IGZvciByZXRyaWV2aW5nIHRoZSBkcmFnIGltYWdlIGZvciBwaXhlbCB0ZXN0aW5nCisgICAgICAg IGRvZXMgbm90IHlldCBleGlzdC4KKworICAgICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWU6Om5vZGVJbWFnZSk6CisKIDIwMTMtMDMtMDUgIEJlbSBKb25lcy1C ZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25zXSBzaGFw ZS1vdXRzaWRlIG9uIGZsb2F0cyBmb3IgcG9seWdvbiBzaGFwZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAK aW5kZXggYTlmYmEyM2MzYmMxYTRmODcwYzM3ZjRiZTQxMDI5NzJjY2M0MzgxNy4uYzdlZDA3MmVh ZjViZjJlMTZjNjdjZjk3OGUyZWI0ZjZiODZmZGJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAg LTEwODUsNyArMTA4NSw3IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5v ZGUpCiAgICAgbV92aWV3LT5zZXRQYWludEJlaGF2aW9yKHN0YXRlLnBhaW50QmVoYXZpb3IgfCBQ YWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKTsKIAogICAgIC8vIFdoZW4gZ2Vu ZXJhdGluZyB0aGUgZHJhZyBpbWFnZSBmb3IgYW4gZWxlbWVudCwgaWdub3JlIHRoZSBkb2N1bWVu dCBiYWNrZ3JvdW5kLgotICAgIG1fdmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihjb2xvcldp dGhPdmVycmlkZUFscGhhKENvbG9yOjp3aGl0ZSwgMS4wKSk7CisgICAgbV92aWV3LT5zZXRCYXNl QmFja2dyb3VuZENvbG9yKENvbG9yOjp0cmFuc3BhcmVudCk7CiAgICAgbV9kb2MtPnVwZGF0ZUxh eW91dCgpOwogICAgIG1fdmlldy0+c2V0Tm9kZVRvRHJhdyhub2RlKTsgLy8gRW5hYmxlIHNwZWNp YWwgc3ViLXRyZWUgZHJhd2luZyBtb2RlLgogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggNzg4NmNiNjA1MjQ2ODI0YzkwY2YyZDk3YjhmZjNmZjdhOTAwNmU1Yy4uODJi Zjk0ZjJjMWM0ZWQ4NGYzYWE3MmNiOGMzOTY0YTFjODlhODM5YyAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTA1ICBTaGF3biBT aW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBkZWZhdWx0IGJh Y2tncm91bmQgb2YgYSBkcmFnZ2VkIGltYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNYW51YWxUZXN0cy9kcmFnLWJhY2tncm91bmQtd2l0aC1w YWRkaW5nLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAzLTA1ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEg IDxnbnNAZ25vbWUub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0t Z2l0IGEvTWFudWFsVGVzdHMvZHJhZy1iYWNrZ3JvdW5kLXdpdGgtcGFkZGluZy5odG1sIGIvTWFu dWFsVGVzdHMvZHJhZy1iYWNrZ3JvdW5kLXdpdGgtcGFkZGluZy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZk MmUxZjZiYTY1MWNkZjQ4ZDUxMmM1Yzk4YTE3YWFlMWI4NjA1YTMKLS0tIC9kZXYvbnVsbAorKysg Yi9NYW51YWxUZXN0cy9kcmFnLWJhY2tncm91bmQtd2l0aC1wYWRkaW5nLmh0bWwKQEAgLTAsMCAr MSwyNyBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKyAgPGJvZHkgc3R5bGU9ImJhY2tncm91 bmQtY29sb3I6IHNpbHZlcjsiPgorICAgIDxwPkZvciBhIGRyYWdnYWJsZSBlbGVtZW50IHRoYXQg aGFzIHBhZGRpbmcsIHRoZSBkcmFnIGltYWdlIHRoYXQgaXMgY3JlYXRlZAorICAgIHNob3VsZCBy ZXNwZWN0IHRoYXQgYmFja2dyb3VuZCBjb2xvci4gTm90ZSB0aGF0IG5vbmUgb2YgdGhlIGRyYWcg aW1hZ2VzCisgICAgdXNlIGFueSBvZiB0aGUgYm9keSBlbGVtZW50J3Mgc2lsdmVyIGJhY2tncm91 bmQuPC9wPgorCisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDEwMHB4 OyBwYWRkaW5nOiA1MHB4OyBib3JkZXI6IHNvbGlkIDJweCBibGFjazsiIGRyYWdnYWJsZT0idHJ1 ZSI+CisgICAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBncmV5OyB3aWR0aDogMTAw cHg7IGhlaWdodDogMTAwcHg7Ij5EcmFnIG1lISBEcmFnIGltYWdlIHBhZGRpbmcgc2hvdWxkIHJl bWFpbiB0cmFuc3BhcmVudC48L2Rpdj4KKyAgICA8L2Rpdj4KKworICAgIDxkaXYgc3R5bGU9InBv c2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAzNTBweDsgcGFkZGluZzogNTBweDsgYm9yZGVyOiBzb2xp ZCAycHggYmxhY2s7IGJhY2tncm91bmQtY29sb3I6IHJnYmEoMSwgMCwgMCwgMCk7IiBkcmFnZ2Fi bGU9InRydWUiPgorICAgICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogZ3JleTsgd2lk dGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyI+RHJhZyBtZSEgRHJhZyBpbWFnZSBwYWRkaW5nIHNo b3VsZCBiZSB0cmFuc3BhcmVudC48L2Rpdj4KKyAgICA8L2Rpdj4KKworICAgIDxkaXYgc3R5bGU9 InBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAzNTBweDsgbGVmdDogMjUwcHg7IHBhZGRpbmc6IDUw cHg7IGJvcmRlcjogc29saWQgMnB4IGJsYWNrOyBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsiIGRy YWdnYWJsZT0idHJ1ZSI+CisgICAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBncmV5 OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7Ij5EcmFnIG1lISBEcmFnIGltYWdlIHBhZGRp bmcgc2hvdWxkIGJlIHdoaXRlLjwvZGl2PgorICAgIDwvZGl2PgorCisgICAgPGRpdiBzdHlsZT0i cG9zaXRpb246IGFic29sdXRlOyB0b3A6IDM1MHB4OyBsZWZ0OiA1MDBweDsgcGFkZGluZzogNTBw eDsgYm9yZGVyOiBzb2xpZCAycHggYmxhY2s7IGJhY2tncm91bmQtY29sb3I6IGxpbWU7IiBkcmFn Z2FibGU9InRydWUiPgorICAgICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogZ3JleTsg d2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyI+RHJhZyBtZSEgRHJhZyBpbWFnZSBwYWRkaW5n IHNob3VsZCBiZSBsaW1lLjwvZGl2PgorICAgIDwvZGl2PgorCisgICAgPGRpdiBzdHlsZT0icG9z aXRpb246IGFic29sdXRlOyB0b3A6IDEwMHB4OyBsZWZ0OiAyNTBweDsgd2lkdGg6IDIwMHB4OyBo ZWlnaHQ6IDIwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBjeWFuOyI+IERyYWcgb24gdG9wIG9mIG1l IGp1c3QgZm9yIHJlZmVyZW5jZS48L2Rpdj4KKworICA8L2JvZHk+Cis8L2h0bWw+Cg== 191587 2013-03-05 15:45:12 -0800 2013-03-05 15:55:59 -0800 Patch for landing bug-110512-20130305154118.patch text/plain 4410 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI2NmQ4YTBjMDJkZTQx NjE2OTI5MzYwZmY4N2NkYTg1ZGIxN2YyMC4uODRiNTM3MmQ0NDA4ZTQyMGQ0YWZjMzlkOTAzYjIy ZWU2ZDJjZjZkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTA1ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBkZWZhdWx0 IGJhY2tncm91bmQgb2YgYSBkcmFnZ2VkIGltYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVHJhbnNwYXJlbnQgYmFja2dyb3VuZCBjb2xvciAocGFy dGljdWxhcmx5IHZpc2libGUgaW4gdGhlIHBhZGRpbmcKKyAgICAgICAgb2YgYW4gZWxlbWVudCkg d2FzIG5vdCBiZWluZyByZXNwZWN0ZWQuIFRoZSBzb2x1dGlvbiBpcyB0bworICAgICAgICBpbml0 aWFsbHkgZmlsbCB0aGUgZHJhZyBpbWFnZSB3aXRoIHRyYW5zcGFyZW50IGluc3RlYWQgb2Ygd2hp dGUsCisgICAgICAgIHNvIHRoYXQgYW55IGNvbG9yIGJhY2tncm91bmQgd29ya3MgY29ycmVjdGx5 LiBUaGlzIHBhdGNoIGRvZXMgbm90CisgICAgICAgIGFmZmVjdCBBcHBsZSBNYWMgb3IgV2luIHBs YXRmb3JtcywgZ2l2ZW4gdGhhdCB0aGlzIHBhcnQgb2YgdGhlCisgICAgICAgIGNvZGUgaXMgI2lm IGd1YXJkZWQgZnJvbSB0aG9zZSBwbGF0Zm9ybXMuCisKKyAgICAgICAgTWFudWFsIHRlc3QgYWRk ZWQ6CisgICAgICAgICAgTWFudWFsVGVzdHMvZHJhZy1iYWNrZ3JvdW5kLXdpdGgtcGFkZGluZy5o dG1sCisKKyAgICAgICAgSW5mcmFzdHJ1Y3R1cmUgZm9yIHJldHJpZXZpbmcgdGhlIGRyYWcgaW1h Z2UgZm9yIHBpeGVsIHRlc3RpbmcKKyAgICAgICAgZG9lcyBub3QgeWV0IGV4aXN0LgorCisgICAg ICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6bm9kZUltYWdl KToKKwogMjAxMy0wMy0wNSAgQmVtIEpvbmVzLUJleSAgPGJqb25lc2JlQGFkb2JlLmNvbT4KIAog ICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIHNoYXBlLW91dHNpZGUgb24gZmxvYXRzIGZvciBwb2x5 Z29uIHNoYXBlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCBhOWZiYTIzYzNiYzFhNGY4NzBjMzdm NGJlNDEwMjk3MmNjYzQzODE3Li5jN2VkMDcyZWFmNWJmMmUxNmM2N2NmOTc4ZTJlYjRmNmI4NmZk YmU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApAQCAtMTA4NSw3ICsxMDg1LDcgQEAgRHJhZ0ltYWdl UmVmIEZyYW1lOjpub2RlSW1hZ2UoTm9kZSogbm9kZSkKICAgICBtX3ZpZXctPnNldFBhaW50QmVo YXZpb3Ioc3RhdGUucGFpbnRCZWhhdmlvciB8IFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRp bmdMYXllcnMpOwogCiAgICAgLy8gV2hlbiBnZW5lcmF0aW5nIHRoZSBkcmFnIGltYWdlIGZvciBh biBlbGVtZW50LCBpZ25vcmUgdGhlIGRvY3VtZW50IGJhY2tncm91bmQuCi0gICAgbV92aWV3LT5z ZXRCYXNlQmFja2dyb3VuZENvbG9yKGNvbG9yV2l0aE92ZXJyaWRlQWxwaGEoQ29sb3I6OndoaXRl LCAxLjApKTsKKyAgICBtX3ZpZXctPnNldEJhc2VCYWNrZ3JvdW5kQ29sb3IoQ29sb3I6OnRyYW5z cGFyZW50KTsKICAgICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7CiAgICAgbV92aWV3LT5zZXROb2Rl VG9EcmF3KG5vZGUpOyAvLyBFbmFibGUgc3BlY2lhbCBzdWItdHJlZSBkcmF3aW5nIG1vZGUuCiAK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3ODg2Y2I2MDUyNDY4MjRj OTBjZjJkOTdiOGZmM2ZmN2E5MDA2ZTVjLi44MmJmOTRmMmMxYzRlZDg0ZjNhYTcyY2I4YzM5NjRh MWM4OWE4MzljIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTMtMDMtMDUgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgRml4IGRlZmF1bHQgYmFja2dyb3VuZCBvZiBhIGRyYWdnZWQgaW1hZ2Uu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA1MTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1hbnVh bFRlc3RzL2RyYWctYmFja2dyb3VuZC13aXRoLXBhZGRpbmcuaHRtbDogQWRkZWQuCisKIDIwMTMt MDMtMDUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9kcmFnLWJhY2tn cm91bmQtd2l0aC1wYWRkaW5nLmh0bWwgYi9NYW51YWxUZXN0cy9kcmFnLWJhY2tncm91bmQtd2l0 aC1wYWRkaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmQyZTFmNmJhNjUxY2RmNDhkNTEyYzVjOThhMTdh YWUxYjg2MDVhMwotLS0gL2Rldi9udWxsCisrKyBiL01hbnVhbFRlc3RzL2RyYWctYmFja2dyb3Vu ZC13aXRoLXBhZGRpbmcuaHRtbApAQCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgSFRNTD4KKzxo dG1sPgorICA8Ym9keSBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOyI+CisgICAgPHA+ Rm9yIGEgZHJhZ2dhYmxlIGVsZW1lbnQgdGhhdCBoYXMgcGFkZGluZywgdGhlIGRyYWcgaW1hZ2Ug dGhhdCBpcyBjcmVhdGVkCisgICAgc2hvdWxkIHJlc3BlY3QgdGhhdCBiYWNrZ3JvdW5kIGNvbG9y LiBOb3RlIHRoYXQgbm9uZSBvZiB0aGUgZHJhZyBpbWFnZXMKKyAgICB1c2UgYW55IG9mIHRoZSBi b2R5IGVsZW1lbnQncyBzaWx2ZXIgYmFja2dyb3VuZC48L3A+CisKKyAgICA8ZGl2IHN0eWxlPSJw b3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTAwcHg7IHBhZGRpbmc6IDUwcHg7IGJvcmRlcjogc29s aWQgMnB4IGJsYWNrOyIgZHJhZ2dhYmxlPSJ0cnVlIj4KKyAgICAgIDxkaXYgc3R5bGU9ImJhY2tn cm91bmQtY29sb3I6IGdyZXk7IHdpZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBweDsiPkRyYWcgbWUh IERyYWcgaW1hZ2UgcGFkZGluZyBzaG91bGQgcmVtYWluIHRyYW5zcGFyZW50LjwvZGl2PgorICAg IDwvZGl2PgorCisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDM1MHB4 OyBwYWRkaW5nOiA1MHB4OyBib3JkZXI6IHNvbGlkIDJweCBibGFjazsgYmFja2dyb3VuZC1jb2xv cjogcmdiYSgxLCAwLCAwLCAwKTsiIGRyYWdnYWJsZT0idHJ1ZSI+CisgICAgICA8ZGl2IHN0eWxl PSJiYWNrZ3JvdW5kLWNvbG9yOiBncmV5OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7Ij5E cmFnIG1lISBEcmFnIGltYWdlIHBhZGRpbmcgc2hvdWxkIGJlIHRyYW5zcGFyZW50LjwvZGl2Pgor ICAgIDwvZGl2PgorCisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDM1 MHB4OyBsZWZ0OiAyNTBweDsgcGFkZGluZzogNTBweDsgYm9yZGVyOiBzb2xpZCAycHggYmxhY2s7 IGJhY2tncm91bmQtY29sb3I6IHdoaXRlOyIgZHJhZ2dhYmxlPSJ0cnVlIj4KKyAgICAgIDxkaXYg c3R5bGU9ImJhY2tncm91bmQtY29sb3I6IGdyZXk7IHdpZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBw eDsiPkRyYWcgbWUhIERyYWcgaW1hZ2UgcGFkZGluZyBzaG91bGQgYmUgd2hpdGUuPC9kaXY+Cisg ICAgPC9kaXY+CisKKyAgICA8ZGl2IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMzUw cHg7IGxlZnQ6IDUwMHB4OyBwYWRkaW5nOiA1MHB4OyBib3JkZXI6IHNvbGlkIDJweCBibGFjazsg YmFja2dyb3VuZC1jb2xvcjogbGltZTsiIGRyYWdnYWJsZT0idHJ1ZSI+CisgICAgICA8ZGl2IHN0 eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBncmV5OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7 Ij5EcmFnIG1lISBEcmFnIGltYWdlIHBhZGRpbmcgc2hvdWxkIGJlIGxpbWUuPC9kaXY+CisgICAg PC9kaXY+CisKKyAgICA8ZGl2IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTAwcHg7 IGxlZnQ6IDI1MHB4OyB3aWR0aDogMjAwcHg7IGhlaWdodDogMjAwcHg7IGJhY2tncm91bmQtY29s b3I6IGN5YW47Ij4gRHJhZyBvbiB0b3Agb2YgbWUganVzdCBmb3IgcmVmZXJlbmNlLjwvZGl2Pgor CisgIDwvYm9keT4KKzwvaHRtbD4K 191590 2013-03-05 15:56:03 -0800 2013-03-05 16:13:31 -0800 Patch for landing bug-110512-20130305155209.patch text/plain 4402 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI2NmQ4YTBjMDJkZTQx NjE2OTI5MzYwZmY4N2NkYTg1ZGIxN2YyMC4uNThjMDM4YmZjZDhmYzgwYWE4Mjg3NWI0ZjY3OGE5 Zjc4ZDM3MTcwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTA1ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBkZWZhdWx0 IGJhY2tncm91bmQgb2YgYSBkcmFnZ2VkIGltYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9u eSBDaGFuZy4KKworICAgICAgICBUcmFuc3BhcmVudCBiYWNrZ3JvdW5kIGNvbG9yIChwYXJ0aWN1 bGFybHkgdmlzaWJsZSBpbiB0aGUgcGFkZGluZworICAgICAgICBvZiBhbiBlbGVtZW50KSB3YXMg bm90IGJlaW5nIHJlc3BlY3RlZC4gVGhlIHNvbHV0aW9uIGlzIHRvCisgICAgICAgIGluaXRpYWxs eSBmaWxsIHRoZSBkcmFnIGltYWdlIHdpdGggdHJhbnNwYXJlbnQgaW5zdGVhZCBvZiB3aGl0ZSwK KyAgICAgICAgc28gdGhhdCBhbnkgY29sb3IgYmFja2dyb3VuZCB3b3JrcyBjb3JyZWN0bHkuIFRo aXMgcGF0Y2ggZG9lcyBub3QKKyAgICAgICAgYWZmZWN0IEFwcGxlIE1hYyBvciBXaW4gcGxhdGZv cm1zLCBnaXZlbiB0aGF0IHRoaXMgcGFydCBvZiB0aGUKKyAgICAgICAgY29kZSBpcyAjaWYgZ3Vh cmRlZCBmcm9tIHRob3NlIHBsYXRmb3Jtcy4KKworICAgICAgICBNYW51YWwgdGVzdCBhZGRlZDoK KyAgICAgICAgICBNYW51YWxUZXN0cy9kcmFnLWJhY2tncm91bmQtd2l0aC1wYWRkaW5nLmh0bWwK KworICAgICAgICBJbmZyYXN0cnVjdHVyZSBmb3IgcmV0cmlldmluZyB0aGUgZHJhZyBpbWFnZSBm b3IgcGl4ZWwgdGVzdGluZworICAgICAgICBkb2VzIG5vdCB5ZXQgZXhpc3QuCisKKyAgICAgICAg KiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpub2RlSW1hZ2UpOgor CiAyMDEzLTAzLTA1ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgogCiAgICAg ICAgIFtDU1MgRXhjbHVzaW9uc10gc2hhcGUtb3V0c2lkZSBvbiBmbG9hdHMgZm9yIHBvbHlnb24g c2hhcGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCmluZGV4IGE5ZmJhMjNjM2JjMWE0Zjg3MGMzN2Y0YmU0 MTAyOTcyY2NjNDM4MTcuLmM3ZWQwNzJlYWY1YmYyZTE2YzY3Y2Y5NzhlMmViNGY2Yjg2ZmRiZTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCkBAIC0xMDg1LDcgKzEwODUsNyBAQCBEcmFnSW1hZ2VSZWYg RnJhbWU6Om5vZGVJbWFnZShOb2RlKiBub2RlKQogICAgIG1fdmlldy0+c2V0UGFpbnRCZWhhdmlv cihzdGF0ZS5wYWludEJlaGF2aW9yIHwgUGFpbnRCZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xh eWVycyk7CiAKICAgICAvLyBXaGVuIGdlbmVyYXRpbmcgdGhlIGRyYWcgaW1hZ2UgZm9yIGFuIGVs ZW1lbnQsIGlnbm9yZSB0aGUgZG9jdW1lbnQgYmFja2dyb3VuZC4KLSAgICBtX3ZpZXctPnNldEJh c2VCYWNrZ3JvdW5kQ29sb3IoY29sb3JXaXRoT3ZlcnJpZGVBbHBoYShDb2xvcjo6d2hpdGUsIDEu MCkpOworICAgIG1fdmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihDb2xvcjo6dHJhbnNwYXJl bnQpOwogICAgIG1fZG9jLT51cGRhdGVMYXlvdXQoKTsKICAgICBtX3ZpZXctPnNldE5vZGVUb0Ry YXcobm9kZSk7IC8vIEVuYWJsZSBzcGVjaWFsIHN1Yi10cmVlIGRyYXdpbmcgbW9kZS4KIApkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDc4ODZjYjYwNTI0NjgyNGM5MGNm MmQ5N2I4ZmYzZmY3YTkwMDZlNWMuLmJjODVjY2RhYWE2YmM1OTc4YzhiMjA2YzU1ZWQzM2VkYmJj MTRkOGEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MiBAQAorMjAxMy0wMy0wNSAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4K KworICAgICAgICBGaXggZGVmYXVsdCBiYWNrZ3JvdW5kIG9mIGEgZHJhZ2dlZCBpbWFnZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDUxMgorCisg ICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCisKKyAgICAgICAgKiBNYW51YWxUZXN0cy9k cmFnLWJhY2tncm91bmQtd2l0aC1wYWRkaW5nLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAzLTA1ICBH dXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvTWFudWFsVGVzdHMvZHJhZy1iYWNrZ3JvdW5kLXdp dGgtcGFkZGluZy5odG1sIGIvTWFudWFsVGVzdHMvZHJhZy1iYWNrZ3JvdW5kLXdpdGgtcGFkZGlu Zy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmZkMmUxZjZiYTY1MWNkZjQ4ZDUxMmM1Yzk4YTE3YWFlMWI4NjA1 YTMKLS0tIC9kZXYvbnVsbAorKysgYi9NYW51YWxUZXN0cy9kcmFnLWJhY2tncm91bmQtd2l0aC1w YWRkaW5nLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKyAg PGJvZHkgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsiPgorICAgIDxwPkZvciBhIGRy YWdnYWJsZSBlbGVtZW50IHRoYXQgaGFzIHBhZGRpbmcsIHRoZSBkcmFnIGltYWdlIHRoYXQgaXMg Y3JlYXRlZAorICAgIHNob3VsZCByZXNwZWN0IHRoYXQgYmFja2dyb3VuZCBjb2xvci4gTm90ZSB0 aGF0IG5vbmUgb2YgdGhlIGRyYWcgaW1hZ2VzCisgICAgdXNlIGFueSBvZiB0aGUgYm9keSBlbGVt ZW50J3Mgc2lsdmVyIGJhY2tncm91bmQuPC9wPgorCisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246 IGFic29sdXRlOyB0b3A6IDEwMHB4OyBwYWRkaW5nOiA1MHB4OyBib3JkZXI6IHNvbGlkIDJweCBi bGFjazsiIGRyYWdnYWJsZT0idHJ1ZSI+CisgICAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNv bG9yOiBncmV5OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7Ij5EcmFnIG1lISBEcmFnIGlt YWdlIHBhZGRpbmcgc2hvdWxkIHJlbWFpbiB0cmFuc3BhcmVudC48L2Rpdj4KKyAgICA8L2Rpdj4K KworICAgIDxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAzNTBweDsgcGFkZGlu ZzogNTBweDsgYm9yZGVyOiBzb2xpZCAycHggYmxhY2s7IGJhY2tncm91bmQtY29sb3I6IHJnYmEo MSwgMCwgMCwgMCk7IiBkcmFnZ2FibGU9InRydWUiPgorICAgICAgPGRpdiBzdHlsZT0iYmFja2dy b3VuZC1jb2xvcjogZ3JleTsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyI+RHJhZyBtZSEg RHJhZyBpbWFnZSBwYWRkaW5nIHNob3VsZCBiZSB0cmFuc3BhcmVudC48L2Rpdj4KKyAgICA8L2Rp dj4KKworICAgIDxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAzNTBweDsgbGVm dDogMjUwcHg7IHBhZGRpbmc6IDUwcHg7IGJvcmRlcjogc29saWQgMnB4IGJsYWNrOyBiYWNrZ3Jv dW5kLWNvbG9yOiB3aGl0ZTsiIGRyYWdnYWJsZT0idHJ1ZSI+CisgICAgICA8ZGl2IHN0eWxlPSJi YWNrZ3JvdW5kLWNvbG9yOiBncmV5OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7Ij5EcmFn IG1lISBEcmFnIGltYWdlIHBhZGRpbmcgc2hvdWxkIGJlIHdoaXRlLjwvZGl2PgorICAgIDwvZGl2 PgorCisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDM1MHB4OyBsZWZ0 OiA1MDBweDsgcGFkZGluZzogNTBweDsgYm9yZGVyOiBzb2xpZCAycHggYmxhY2s7IGJhY2tncm91 bmQtY29sb3I6IGxpbWU7IiBkcmFnZ2FibGU9InRydWUiPgorICAgICAgPGRpdiBzdHlsZT0iYmFj a2dyb3VuZC1jb2xvcjogZ3JleTsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyI+RHJhZyBt ZSEgRHJhZyBpbWFnZSBwYWRkaW5nIHNob3VsZCBiZSBsaW1lLjwvZGl2PgorICAgIDwvZGl2Pgor CisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDEwMHB4OyBsZWZ0OiAy NTBweDsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6IDIwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBjeWFu OyI+IERyYWcgb24gdG9wIG9mIG1lIGp1c3QgZm9yIHJlZmVyZW5jZS48L2Rpdj4KKworICA8L2Jv ZHk+Cis8L2h0bWw+Cg==