110494 2013-02-21 11:23:45 -0800 Disable MediaSource on Apple Windows port 2013-02-22 18:00:53 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell bfulgham roger_fong thorton webkit.review.bot oldest_to_newest 838625 0 acolwell 2013-02-21 11:23:45 -0800 While working on Bug 109857, I discovered that the MediaSource code was getting built for Apple's Windows port. I'm pretty sure this was an accident since there doesn't appear to be any other MediaSource specific code for this port. 838628 1 189563 acolwell 2013-02-21 11:25:35 -0800 Created attachment 189563 Patch 838693 2 189575 acolwell 2013-02-21 12:23:16 -0800 Created attachment 189575 Patch 838759 3 189588 acolwell 2013-02-21 13:18:01 -0800 Created attachment 189588 Removed newline at end of file. 840006 4 roger_fong 2013-02-22 14:42:02 -0800 Instead of getting rid of the whole ENABLE_MEDIA_SOURCE line can you just get rid of the contents in the tag? Also this is only for the VS2010 solution. We actually are running the VS2005 solution on all the bots. The FeaturesDefines in WebKitLibraries/win/tools/vsprops also needs to be modified appropriately. Thanks! 840045 5 189844 acolwell 2013-02-22 15:15:39 -0800 Created attachment 189844 VS 2005 & 2010 fixes 840063 6 roger_fong 2013-02-22 15:30:22 -0800 Looks good to me although I don't have review yet. CC'ing Brent who does. The vsprops files sometimes complain about not being able to commit when they should be able to. Feel free to force commit it if need be. 840180 7 acolwell 2013-02-22 17:44:11 -0800 Brent, Can I get a review on this please. This is preventing me from landing other changes. Thanks. 840183 8 189844 thorton 2013-02-22 17:48:42 -0800 Comment on attachment 189844 VS 2005 & 2010 fixes View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266 > - Value="ENABLE_MEDIA_SOURCE" > + Value="" Wut. 840185 9 thorton 2013-02-22 17:49:04 -0800 (In reply to comment #8) > (From update of attachment 189844 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review > > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266 > > - Value="ENABLE_MEDIA_SOURCE" > > + Value="" > > Wut. Oh, it looks fine here. It looked really weird in the review thing. 840189 10 acolwell 2013-02-22 17:53:13 -0800 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 189844 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=189844&action=review > > > > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:266 > > > - Value="ENABLE_MEDIA_SOURCE" > > > + Value="" > > > > Wut. > > Oh, it looks fine here. It looked really weird in the review thing. Thanks for the review. 840202 11 189844 webkit.review.bot 2013-02-22 18:00:48 -0800 Comment on attachment 189844 VS 2005 & 2010 fixes Clearing flags on attachment: 189844 Committed r143822: <http://trac.webkit.org/changeset/143822> 840203 12 webkit.review.bot 2013-02-22 18:00:53 -0800 All reviewed patches have been landed. Closing bug. 189563 2013-02-21 11:25:35 -0800 2013-02-21 12:23:14 -0800 Patch bug-110494-20130221112156.patch text/plain 1476 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5YzljYTg1M2NlYzVhODRh MjBiNmQ2ZjBkZDMzNTU5Yzg1NzA5ODYuLjNhNjBlZWU4MGY1YTlhYzIwMGFiNzdlZDcyYWRkYTAz MGE0YzU4NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMjEgIEFhcm9uIENv bHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWJsZSBNZWRpYVNv dXJjZSBvbiBBcHBsZSBXaW5kb3dzIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDQ5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHM6 CisKIDIwMTMtMDItMjAgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAg ICAgICBHZXQgVlMyMDEwIFNvbHV0aW9uIEImSSByZWFkeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHMgYi9Tb3VyY2UvV2ViS2l0 L1dlYktpdC52Y3hwcm9qL0ZlYXR1cmVEZWZpbmVzLnByb3BzCmluZGV4IGMwZmU3ZjBmZmJmNjc4 OWU4ZTZmYWZiZDBkMzhhZGY3ODdlM2MxOWQuLjJiNDVmMTg5ODcwYmMzMzhmYzAxYmQxNTcyZDE1 Y2EzOTJmNjgzYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVh dHVyZURlZmluZXMucHJvcHMKKysrIGIvU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9GZWF0 dXJlRGVmaW5lcy5wcm9wcwpAQCAtNTAsNyArNTAsNiBAQAogICAgIDxFTkFCTEVfTElOS19QUkVG RVRDSCAvPg0KICAgICA8RU5BQkxFX0xJTktfUFJFUkVOREVSIC8+DQogICAgIDxFTkFCTEVfTUFU SE1MPkVOQUJMRV9NQVRITUw8L0VOQUJMRV9NQVRITUw+DQotICAgIDxFTkFCTEVfTUVESUFfU09V UkNFPkVOQUJMRV9NRURJQV9TT1VSQ0U8L0VOQUJMRV9NRURJQV9TT1VSQ0U+DQogICAgIDxFTkFC TEVfTUVESUFfU1RBVElTVElDUz5FTkFCTEVfTUVESUFfU1RBVElTVElDUzwvRU5BQkxFX01FRElB X1NUQVRJU1RJQ1M+DQogICAgIDxFTkFCTEVfTUVURVJfRUxFTUVOVD5FTkFCTEVfTUVURVJfRUxF TUVOVDwvRU5BQkxFX01FVEVSX0VMRU1FTlQ+DQogICAgIDxFTkFCTEVfTUlDUk9EQVRBIC8+DQpA QCAtNDEyLDQgKzQxMSw0IEBACiAgICAgICA8RW52aXJvbm1lbnRWYXJpYWJsZT50cnVlPC9FbnZp cm9ubWVudFZhcmlhYmxlPg0KICAgICA8L0J1aWxkTWFjcm8+DQogICA8L0l0ZW1Hcm91cD4NCi08 L1Byb2plY3Q+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPC9Qcm9qZWN0Pg0K 189575 2013-02-21 12:23:16 -0800 2013-02-21 13:17:59 -0800 Patch bug-110494-20130221121936.patch text/plain 1476 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5YzljYTg1M2NlYzVhODRh MjBiNmQ2ZjBkZDMzNTU5Yzg1NzA5ODYuLjNhNjBlZWU4MGY1YTlhYzIwMGFiNzdlZDcyYWRkYTAz MGE0YzU4NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMjEgIEFhcm9uIENv bHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWJsZSBNZWRpYVNv dXJjZSBvbiBBcHBsZSBXaW5kb3dzIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDQ5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHM6 CisKIDIwMTMtMDItMjAgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAg ICAgICBHZXQgVlMyMDEwIFNvbHV0aW9uIEImSSByZWFkeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHMgYi9Tb3VyY2UvV2ViS2l0 L1dlYktpdC52Y3hwcm9qL0ZlYXR1cmVEZWZpbmVzLnByb3BzCmluZGV4IGMwZmU3ZjBmZmJmNjc4 OWU4ZTZmYWZiZDBkMzhhZGY3ODdlM2MxOWQuLjJiNDVmMTg5ODcwYmMzMzhmYzAxYmQxNTcyZDE1 Y2EzOTJmNjgzYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVh dHVyZURlZmluZXMucHJvcHMKKysrIGIvU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9GZWF0 dXJlRGVmaW5lcy5wcm9wcwpAQCAtNTAsNyArNTAsNiBAQAogICAgIDxFTkFCTEVfTElOS19QUkVG RVRDSCAvPg0KICAgICA8RU5BQkxFX0xJTktfUFJFUkVOREVSIC8+DQogICAgIDxFTkFCTEVfTUFU SE1MPkVOQUJMRV9NQVRITUw8L0VOQUJMRV9NQVRITUw+DQotICAgIDxFTkFCTEVfTUVESUFfU09V UkNFPkVOQUJMRV9NRURJQV9TT1VSQ0U8L0VOQUJMRV9NRURJQV9TT1VSQ0U+DQogICAgIDxFTkFC TEVfTUVESUFfU1RBVElTVElDUz5FTkFCTEVfTUVESUFfU1RBVElTVElDUzwvRU5BQkxFX01FRElB X1NUQVRJU1RJQ1M+DQogICAgIDxFTkFCTEVfTUVURVJfRUxFTUVOVD5FTkFCTEVfTUVURVJfRUxF TUVOVDwvRU5BQkxFX01FVEVSX0VMRU1FTlQ+DQogICAgIDxFTkFCTEVfTUlDUk9EQVRBIC8+DQpA QCAtNDEyLDQgKzQxMSw0IEBACiAgICAgICA8RW52aXJvbm1lbnRWYXJpYWJsZT50cnVlPC9FbnZp cm9ubWVudFZhcmlhYmxlPg0KICAgICA8L0J1aWxkTWFjcm8+DQogICA8L0l0ZW1Hcm91cD4NCi08 L1Byb2plY3Q+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPC9Qcm9qZWN0Pg0K 189588 2013-02-21 13:18:01 -0800 2013-02-22 15:16:10 -0800 Removed newline at end of file. bug-110494-20130221131421.patch text/plain 1310 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5YzljYTg1M2NlYzVhODRh MjBiNmQ2ZjBkZDMzNTU5Yzg1NzA5ODYuLjNhNjBlZWU4MGY1YTlhYzIwMGFiNzdlZDcyYWRkYTAz MGE0YzU4NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMjEgIEFhcm9uIENv bHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWJsZSBNZWRpYVNv dXJjZSBvbiBBcHBsZSBXaW5kb3dzIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDQ5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHM6 CisKIDIwMTMtMDItMjAgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAg ICAgICBHZXQgVlMyMDEwIFNvbHV0aW9uIEImSSByZWFkeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHMgYi9Tb3VyY2UvV2ViS2l0 L1dlYktpdC52Y3hwcm9qL0ZlYXR1cmVEZWZpbmVzLnByb3BzCmluZGV4IGMwZmU3ZjBmZmJmNjc4 OWU4ZTZmYWZiZDBkMzhhZGY3ODdlM2MxOWQuLmZhYzdmYjQ2MWZkZDBlNjE4NGI3MmVmZjgxYmZh N2ZjN2Y0ZGQ0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVh dHVyZURlZmluZXMucHJvcHMKKysrIGIvU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9GZWF0 dXJlRGVmaW5lcy5wcm9wcwpAQCAtNTAsNyArNTAsNiBAQAogICAgIDxFTkFCTEVfTElOS19QUkVG RVRDSCAvPg0KICAgICA8RU5BQkxFX0xJTktfUFJFUkVOREVSIC8+DQogICAgIDxFTkFCTEVfTUFU SE1MPkVOQUJMRV9NQVRITUw8L0VOQUJMRV9NQVRITUw+DQotICAgIDxFTkFCTEVfTUVESUFfU09V UkNFPkVOQUJMRV9NRURJQV9TT1VSQ0U8L0VOQUJMRV9NRURJQV9TT1VSQ0U+DQogICAgIDxFTkFC TEVfTUVESUFfU1RBVElTVElDUz5FTkFCTEVfTUVESUFfU1RBVElTVElDUzwvRU5BQkxFX01FRElB X1NUQVRJU1RJQ1M+DQogICAgIDxFTkFCTEVfTUVURVJfRUxFTUVOVD5FTkFCTEVfTUVURVJfRUxF TUVOVDwvRU5BQkxFX01FVEVSX0VMRU1FTlQ+DQogICAgIDxFTkFCTEVfTUlDUk9EQVRBIC8+DQo= 189844 2013-02-22 15:15:39 -0800 2013-02-22 18:00:48 -0800 VS 2005 & 2010 fixes b text/plain 2170 acolwell ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzljOWNhOC4uMjk4OGUwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxMy0wMi0yMiAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9yZz4KKworICAg ICAgICBEaXNhYmxlIE1lZGlhU291cmNlIG9uIEFwcGxlIFdpbmRvd3MgcG9ydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNDk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQudmN4cHJvai9G ZWF0dXJlRGVmaW5lcy5wcm9wczoKKwogMjAxMy0wMi0yMCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2Zv bmdAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCBWUzIwMTAgU29sdXRpb24gQiZJIHJlYWR5Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9GZWF0dXJlRGVmaW5lcy5w cm9wcyBiL1NvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovRmVhdHVyZURlZmluZXMucHJvcHMK aW5kZXggYzBmZTdmMC4uMTJiZDJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJLaXQu dmN4cHJvai9GZWF0dXJlRGVmaW5lcy5wcm9wcworKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC52 Y3hwcm9qL0ZlYXR1cmVEZWZpbmVzLnByb3BzCkBAIC01MCw3ICs1MCw3IEBACiAgICAgPEVOQUJM RV9MSU5LX1BSRUZFVENIIC8+DQogICAgIDxFTkFCTEVfTElOS19QUkVSRU5ERVIgLz4NCiAgICAg PEVOQUJMRV9NQVRITUw+RU5BQkxFX01BVEhNTDwvRU5BQkxFX01BVEhNTD4NCi0gICAgPEVOQUJM RV9NRURJQV9TT1VSQ0U+RU5BQkxFX01FRElBX1NPVVJDRTwvRU5BQkxFX01FRElBX1NPVVJDRT4N CisgICAgPEVOQUJMRV9NRURJQV9TT1VSQ0UgLz4NCiAgICAgPEVOQUJMRV9NRURJQV9TVEFUSVNU SUNTPkVOQUJMRV9NRURJQV9TVEFUSVNUSUNTPC9FTkFCTEVfTUVESUFfU1RBVElTVElDUz4NCiAg ICAgPEVOQUJMRV9NRVRFUl9FTEVNRU5UPkVOQUJMRV9NRVRFUl9FTEVNRU5UPC9FTkFCTEVfTUVU RVJfRUxFTUVOVD4NCiAgICAgPEVOQUJMRV9NSUNST0RBVEEgLz4NCmRpZmYgLS1naXQgYS9XZWJL aXRMaWJyYXJpZXMvQ2hhbmdlTG9nIGIvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwppbmRleCAz MWU3OTFiLi4xZjg2MmMzIDEwMDY0NAotLS0gYS9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCisr KyBiL1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMi0y MiAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9yZz4KKworICAgICAgICBEaXNh YmxlIE1lZGlhU291cmNlIG9uIEFwcGxlIFdpbmRvd3MgcG9ydAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNDk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJl RGVmaW5lcy52c3Byb3BzOgorCiAyMDEzLTAyLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdLQ29udGV4dElzUGx1Z0luVXBkYXRlQXZhaWxh YmxlCmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVy ZURlZmluZXMudnNwcm9wcyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0 dXJlRGVmaW5lcy52c3Byb3BzCmluZGV4IDQ2Y2JlYzIuLjI2OTNhODQgMTAwNjQ0Ci0tLSBhL1dl YktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy52c3Byb3BzCisr KyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy52c3By b3BzCkBAIC0yNjMsNyArMjYzLDcgQEAKIAkvPg0KICAgPFVzZXJNYWNybw0KIAkJTmFtZT0iRU5B QkxFX01FRElBX1NPVVJDRSINCi0JCVZhbHVlPSJFTkFCTEVfTUVESUFfU09VUkNFIg0KKwkJVmFs dWU9IiINCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSINCiAJLz4NCiAgIDxVc2VyTWFj cm8NCg==