110488 2013-02-21 09:58:28 -0800 Work around a MSVC 2012 Update 1 bug causing a crash on x86 2013-02-26 05:03:59 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Windows XP RESOLVED FIXED P2 Normal --- 1 jturcotte webkit-unassigned andersca ap hausmann jturcotte roger_fong oldest_to_newest 838529 0 jturcotte 2013-02-21 09:58:28 -0800 Work around a MSVC 2012 Update 1 bug causing a crash on x86 838534 1 189548 jturcotte 2013-02-21 10:00:26 -0800 Created attachment 189548 Patch 839746 2 189548 andersca 2013-02-22 11:02:57 -0800 Comment on attachment 189548 Patch This absolutely needs a comment. Also, I think it should be surrounded in an #ifdef so that we can remove it eventually. 840983 3 190063 jturcotte 2013-02-25 08:11:00 -0800 Created attachment 190063 Patch Added the ifdef as well since the comment alone would lack context. 841012 4 190063 andersca 2013-02-25 09:10:42 -0800 Comment on attachment 190063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190063&action=review > Source/WebCore/platform/text/TextEncodingRegistry.cpp:73 > + if (c1 != c2) I think you should put a return false inside the #ifdef. > Source/WebCore/platform/text/TextEncodingRegistry.cpp:78 > +#endif And then extend the ifdef below the return false; line. 841898 5 jturcotte 2013-02-26 05:03:59 -0800 Committed r144042: <http://trac.webkit.org/changeset/144042> 189548 2013-02-21 10:00:26 -0800 2013-02-25 08:11:00 -0800 Patch MSVC2012Crash.patch text/plain 1805 jturcotte ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MDc2MTFiLi5lNTM5NTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDItMjEgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lh LmNvbT4KKworICAgICAgICBXb3JrIGFyb3VuZCBhIE1TVkMgMjAxMiBVcGRhdGUgMSBidWcgY2F1 c2luZyBhIGNyYXNoIG9uIHg4NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEwNDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGNyYXNoIGhhcHBlbnMgd2hlbiBidWlsZGluZyB3aXRoIC9PMiwgd2hl cmUgVGV4dEVuY29kaW5nTmFtZUhhc2g6OmVxdWFsIGlzCisgICAgICAgIGluY29ycmVjdGx5IG9w dGltaXplZCB3aXRoIHRoZSBpbmxpbmVkIHRvQVNDSUlMb3dlciBhbmQgdXNlcyBhIHJlZ2lzdGVy IGFscmVhZHkgaW4gdXNlLgorCisgICAgICAgIFNsaWdodGx5IHJld29yZGluZyB0aGUgdXNlIG9m IHRoZSBpbmxpbmUgZnVuY3Rpb24gbGV0cyB0aGUgY29tcGlsZXIgcHJvZHVjZSBjb3JyZWN0IGNv ZGUuCisKKyAgICAgICAgVGhlIGJ1ZyBoYXMgYWxyZWFkeSBiZWVuIHJlcG9ydGVkIGFuZCBzaG91 bGQgYmUgZml4ZWQgaW4gdGhlIG5leHQgcmVsZWFzZSBvZiBNU1ZTIGxhdGVyIHRoaXMgeWVhci4K KyAgICAgICAgaHR0cHM6Ly9jb25uZWN0Lm1pY3Jvc29mdC5jb20vVmlzdWFsU3R1ZGlvL2ZlZWRi YWNrL2RldGFpbHMvNzc3NTMzL3ZzMjAxMi1jLW9wdGltaXppbmctYnVnLXdoZW4tdXNpbmctaW5s aW5lLWFuZC1jaGFyLXJldHVybi10eXBlLXg4Ni10YXJnZXQtb25seQorCisgICAgICAgICogcGxh dGZvcm0vdGV4dC9UZXh0RW5jb2RpbmdSZWdpc3RyeS5jcHA6CisKIDIwMTMtMDItMTkgIEFuZHJl aSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBBc3Nl cnRpb24gaW4gUmVuZGVyRmxvd1RocmVhZDo6cmVtb3ZlUmVuZGVyQm94UmVnaW9uSW5mbwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmdSZWdpc3Ry eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1JlZ2lzdHJ5 LmNwcAppbmRleCBhNTc4MmNmLi40YjVkYmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1JlZ2lzdHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1JlZ2lzdHJ5LmNwcApAQCAtNjUsOSArNjUsOSBA QCBzdHJ1Y3QgVGV4dEVuY29kaW5nTmFtZUhhc2ggewogICAgICAgICBjaGFyIGMxOwogICAgICAg ICBjaGFyIGMyOwogICAgICAgICBkbyB7Ci0gICAgICAgICAgICBjMSA9ICpzMSsrOwotICAgICAg ICAgICAgYzIgPSAqczIrKzsKLSAgICAgICAgICAgIGlmICh0b0FTQ0lJTG93ZXIoYzEpICE9IHRv QVNDSUlMb3dlcihjMikpCisgICAgICAgICAgICBjMSA9IHRvQVNDSUlMb3dlcigqczErKyk7Cisg ICAgICAgICAgICBjMiA9IHRvQVNDSUlMb3dlcigqczIrKyk7CisgICAgICAgICAgICBpZiAoYzEg IT0gYzIpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9IHdoaWxlIChj MSAmJiBjMik7CiAgICAgICAgIHJldHVybiAhYzEgJiYgIWMyOwo= 190063 2013-02-25 08:11:00 -0800 2013-02-25 09:10:42 -0800 Patch MSVC2012Crash.patch text/plain 2289 jturcotte ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MDc2MTFiLi40NmQ5MWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDItMjUgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lh LmNvbT4KKworICAgICAgICBXb3JrIGFyb3VuZCBhIE1TVkMgMjAxMiBVcGRhdGUgMSBidWcgY2F1 c2luZyBhIGNyYXNoIG9uIHg4NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEwNDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGNyYXNoIGhhcHBlbnMgd2hlbiBidWlsZGluZyB3aXRoIC9PMiwgd2hl cmUgVGV4dEVuY29kaW5nTmFtZUhhc2g6OmVxdWFsIGlzCisgICAgICAgIGluY29ycmVjdGx5IG9w dGltaXplZCB3aXRoIHRoZSBpbmxpbmVkIHRvQVNDSUlMb3dlciBhbmQgdXNlcyBhIHJlZ2lzdGVy IGFscmVhZHkgaW4gdXNlLgorICAgICAgICBUaGUgZnVuY3Rpb24gcmV0dXJucyBmYWxzZSBpbmNv cnJlY3RseSwgY2F1c2luZyBhIG1pc21hdGNoIG9mIHRleHQgZW5jb2RpbmcgbmFtZSB3aGljaAor ICAgICAgICB0aGVuIHJlc3VsdHMgaW4gYSBudWxsIHBvaW50ZXIgYWNjZXNzLgorCisgICAgICAg IFNsaWdodGx5IHJld29yZGluZyB0aGUgdXNlIG9mIHRoZSBpbmxpbmUgZnVuY3Rpb24gbGV0cyB0 aGUgY29tcGlsZXIgcHJvZHVjZSBjb3JyZWN0IGNvZGUuCisKKyAgICAgICAgVGhlIGJ1ZyBoYXMg YWxyZWFkeSBiZWVuIHJlcG9ydGVkIGFuZCBzaG91bGQgYmUgZml4ZWQgaW4gdGhlIG5leHQgcmVs ZWFzZSBvZiBNU1ZTIGxhdGVyIHRoaXMgeWVhci4KKyAgICAgICAgaHR0cHM6Ly9jb25uZWN0Lm1p Y3Jvc29mdC5jb20vVmlzdWFsU3R1ZGlvL2ZlZWRiYWNrL2RldGFpbHMvNzc3NTMzL3ZzMjAxMi1j LW9wdGltaXppbmctYnVnLXdoZW4tdXNpbmctaW5saW5lLWFuZC1jaGFyLXJldHVybi10eXBlLXg4 Ni10YXJnZXQtb25seQorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmdSZWdp c3RyeS5jcHA6CisKIDIwMTMtMDItMTkgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+ CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBBc3NlcnRpb24gaW4gUmVuZGVyRmxvd1RocmVhZDo6 cmVtb3ZlUmVuZGVyQm94UmVnaW9uSW5mbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9UZXh0RW5jb2RpbmdSZWdpc3RyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1JlZ2lzdHJ5LmNwcAppbmRleCBhNTc4MmNmLi42ZTlhOTM1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1Jl Z2lzdHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGlu Z1JlZ2lzdHJ5LmNwcApAQCAtNjUsOSArNjUsMTcgQEAgc3RydWN0IFRleHRFbmNvZGluZ05hbWVI YXNoIHsKICAgICAgICAgY2hhciBjMTsKICAgICAgICAgY2hhciBjMjsKICAgICAgICAgZG8gewor I2lmIGRlZmluZWQoX01TQ19GVUxMX1ZFUikgJiYgX01TQ19GVUxMX1ZFUiA9PSAxNzAwNTExMDYK KyAgICAgICAgICAgIC8vIFdvcmthcm91bmQgZm9yIGEgYnVnIGluIHRoZSBWUzIwMTIgVXBkYXRl IDEgb3B0aW1pemVyLCByZW1vdmUgb25jZSB0aGUgZml4IGlzIHJlbGVhc2VkLgorICAgICAgICAg ICAgLy8gaHR0cHM6Ly9jb25uZWN0Lm1pY3Jvc29mdC5jb20vVmlzdWFsU3R1ZGlvL2ZlZWRiYWNr L2RldGFpbHMvNzc3NTMzL3ZzMjAxMi1jLW9wdGltaXppbmctYnVnLXdoZW4tdXNpbmctaW5saW5l LWFuZC1jaGFyLXJldHVybi10eXBlLXg4Ni10YXJnZXQtb25seQorICAgICAgICAgICAgYzEgPSB0 b0FTQ0lJTG93ZXIoKnMxKyspOworICAgICAgICAgICAgYzIgPSB0b0FTQ0lJTG93ZXIoKnMyKysp OworICAgICAgICAgICAgaWYgKGMxICE9IGMyKQorI2Vsc2UKICAgICAgICAgICAgIGMxID0gKnMx Kys7CiAgICAgICAgICAgICBjMiA9ICpzMisrOwogICAgICAgICAgICAgaWYgKHRvQVNDSUlMb3dl cihjMSkgIT0gdG9BU0NJSUxvd2VyKGMyKSkKKyNlbmRpZgogICAgICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICAgICAgfSB3aGlsZSAoYzEgJiYgYzIpOwogICAgICAgICByZXR1cm4gIWMx ICYmICFjMjsK