110462 2013-02-21 06:03:47 -0800 Make SpellCheckRequest's constructor private 2013-02-21 06:21:36 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski laszlo.gombos mifenton morrita rniwa webkit.review.bot oldest_to_newest 838363 0 g.czajkowski 2013-02-21 06:03:47 -0800 It's no need to expose SpellCheckRequest's constructor. There is SpellCheckRequest::create() method which is responsible for creating SpellCheckRequest object. 838364 1 189515 g.czajkowski 2013-02-21 06:04:29 -0800 Created attachment 189515 proposed patch 838366 2 189515 tonikitoo 2013-02-21 06:06:16 -0800 Comment on attachment 189515 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=189515&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=XXXXXXXXXXXXXXXX Does the commit-queue fill it up for you? 838367 3 webkit.review.bot 2013-02-21 06:07:07 -0800 Attachment 189515 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/SpellChecker.h']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 838368 4 g.czajkowski 2013-02-21 06:08:19 -0800 (In reply to comment #2) > (From update of attachment 189515 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189515&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=XXXXXXXXXXXXXXXX > > Does the commit-queue fill it up for you? Sorry, it's my art :) I will fix it before landing. 838376 5 g.czajkowski 2013-02-21 06:21:36 -0800 Committed r143596: <http://trac.webkit.org/changeset/143596> 189515 2013-02-21 06:04:29 -0800 2013-02-21 06:06:16 -0800 proposed patch spelling-make-SpellCheckRequest-private.patch text/plain 2114 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NTY0MWE3Li4xZGJmMDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTMtMDItMjEgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CiAKKyAgICAgICAgTWFrZSBTcGVsbENoZWNrUmVxdWVzdCdzIGNvbnN0cnVjdG9yIHBy aXZhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD1Y WFhYWFhYWFhYWFhYWFhYCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQncyBubyBuZWVkIHRvIGV4cG9zZSBTcGVsbENoZWNrUmVxdWVzdCdzIGNvbnN0 cnVjdG9yLgorICAgICAgICBUaGVyZSBpcyBTcGVsbENoZWNrUmVxdWVzdDo6Y3JlYXRlKCkgbWV0 aG9kIHdoaWNoIGlzCisgICAgICAgIHJlc3BvbnNpYmxlIGZvciBjcmVhdGluZyBTcGVsbENoZWNr UmVxdWVzdCBvYmplY3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFu Z2UuCisKKyAgICAgICAgKiBlZGl0aW5nL1NwZWxsQ2hlY2tlci5oOgorICAgICAgICAoU3BlbGxD aGVja1JlcXVlc3QpOgorCisyMDEzLTAyLTIxICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFq a293c2tpQHNhbXN1bmcuY29tPgorCiAgICAgICAgIEFsbG93IHRvIHJldHJpZXZlIHRoZSByZXF1 ZXN0IGRhdGEgZnJvbSBhYnN0cmFjdCBUZXh0Q2hlY2tpbmdSZXF1ZXN0IHRvIGJlIGFjY2Vzc2li bGUgZm9yIFdLMgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTEwMjA4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU3BlbGxDaGVj a2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NwZWxsQ2hlY2tlci5oCmluZGV4IGY1YWFm YjQuLjQ2OTcwMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU3BlbGxDaGVj a2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9TcGVsbENoZWNrZXIuaApAQCAtNDYs MTAgKzQ2LDggQEAgY2xhc3MgU3BlbGxDaGVja2VyOwogCiBjbGFzcyBTcGVsbENoZWNrUmVxdWVz dCA6IHB1YmxpYyBUZXh0Q2hlY2tpbmdSZXF1ZXN0IHsKIHB1YmxpYzoKLSAgICBTcGVsbENoZWNr UmVxdWVzdChQYXNzUmVmUHRyPFJhbmdlPiBjaGVja2luZ1JhbmdlLCBQYXNzUmVmUHRyPFJhbmdl PiBwYXJhZ3JhcGhSYW5nZSwgY29uc3QgU3RyaW5nJiwgVGV4dENoZWNraW5nVHlwZU1hc2ssIFRl eHRDaGVja2luZ1Byb2Nlc3NUeXBlKTsKLSAgICB2aXJ0dWFsIH5TcGVsbENoZWNrUmVxdWVzdCgp OwotCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U3BlbGxDaGVja1JlcXVlc3Q+IGNyZWF0ZShUZXh0 Q2hlY2tpbmdUeXBlTWFzaywgVGV4dENoZWNraW5nUHJvY2Vzc1R5cGUsIFBhc3NSZWZQdHI8UmFu Z2U+IGNoZWNraW5nUmFuZ2UsIFBhc3NSZWZQdHI8UmFuZ2U+IHBhcmFncmFwaFJhbmdlKTsKKyAg ICB2aXJ0dWFsIH5TcGVsbENoZWNrUmVxdWVzdCgpOwogCiAgICAgUGFzc1JlZlB0cjxSYW5nZT4g Y2hlY2tpbmdSYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2hlY2tpbmdSYW5nZTsgfQogICAgIFBh c3NSZWZQdHI8UmFuZ2U+IHBhcmFncmFwaFJhbmdlKCkgY29uc3QgeyByZXR1cm4gbV9wYXJhZ3Jh cGhSYW5nZTsgfQpAQCAtNjQsNiArNjIsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRp ZENhbmNlbCgpIE9WRVJSSURFOwogCiBwcml2YXRlOgorICAgIFNwZWxsQ2hlY2tSZXF1ZXN0KFBh c3NSZWZQdHI8UmFuZ2U+IGNoZWNraW5nUmFuZ2UsIFBhc3NSZWZQdHI8UmFuZ2U+IHBhcmFncmFw aFJhbmdlLCBjb25zdCBTdHJpbmcmLCBUZXh0Q2hlY2tpbmdUeXBlTWFzaywgVGV4dENoZWNraW5n UHJvY2Vzc1R5cGUpOworCiAgICAgU3BlbGxDaGVja2VyKiBtX2NoZWNrZXI7CiAgICAgUmVmUHRy PFJhbmdlPiBtX2NoZWNraW5nUmFuZ2U7CiAgICAgUmVmUHRyPFJhbmdlPiBtX3BhcmFncmFwaFJh bmdlOwo=