110459 2013-02-21 05:12:14 -0800 [GTK] Control+Shift+Up/Down selection works backwards 2013-02-22 00:43:00 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra webkit-unassigned cgarcia mrobinson webkit.review.bot oldest_to_newest 838350 0 csaavedra 2013-02-21 05:12:14 -0800 [GTK] Control+Shift+Up/Down selection works backwards 838353 1 189513 csaavedra 2013-02-21 05:23:20 -0800 Created attachment 189513 Patch 838356 2 webkit.review.bot 2013-02-21 05:31:49 -0800 Attachment 189513 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/KeyBindingTranslator.cpp']" exit_code: 1 Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 838738 3 189513 mrobinson 2013-02-21 13:03:38 -0800 Comment on attachment 189513 Patch Okay. It would be nice to see a test, but this looks pretty straight-forward. 839331 4 csaavedra 2013-02-22 00:43:00 -0800 Committed r143696: <http://trac.webkit.org/changeset/143696> 189513 2013-02-21 05:23:20 -0800 2013-02-21 13:03:38 -0800 Patch bug-110459-20130221151940.patch text/plain 2199 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk2YmQwZTBhNjBhNDNm NjNmODBjNDYzNTI3Y2JmM2E3MmM2N2FmZi4uNzdmMDZlZWM4YjRiOTA1MWM2MTliZDMwM2FjM2Fl YjFhOWFhMTBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTIxICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQ29u dHJvbCtTaGlmdCtVcC9Eb3duIHNlbGVjdGlvbiB3b3JrcyBiYWNrd2FyZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDQ1OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0tleUJp bmRpbmdUcmFuc2xhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOiBUaGUgdHJhbnNsYXRpb24g dGFibGUgZm9yIHBhcmFncmFwaCBzZWxlY3Rpb24KKyAgICAgICAgY29tbWFuZHMgaXMgYmFja3dh cmRzLCBmaXggaXQuCisKIDIwMTMtMDItMTkgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vvay5vaEBj b2xsYWJvcmEuY29tPgogCiAgICAgICAgIFtHVEtdW0FDXSBJbXBsZW1lbnQga2V5ZnJhbWUgYW5p bWF0aW9ucyB3aXRoIGNsdXR0ZXIgYWMgYmFja2VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5jcHAKaW5kZXggNWJkMGZiOGNlOGMw YzE4YmViYThiYTYyNWNkNzAwZDEzNzA2YmIwOC4uZTM1YmJkNjI2M2ZmNTk1ODBjYWIwN2I1NmZj ZDM5NDRmZTAwOWEwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tl eUJpbmRpbmdUcmFuc2xhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv S2V5QmluZGluZ1RyYW5zbGF0b3IuY3BwCkBAIC0xMzQsOCArMTM0LDggQEAgc3RhdGljIGNvbnN0 IGNoYXIqIGNvbnN0IGd0a01vdmVDb21tYW5kc1tdWzRdID0gewogICAgICAgIk1vdmVVcEFuZE1v ZGlmeVNlbGVjdGlvbiIsICAgICAgICAgICAgICAgICAgICAgICAiTW92ZURvd25BbmRNb2RpZnlT ZWxlY3Rpb24iICAgICAgICAgICAgICAgIH0sIC8vIFVwL2Rvd24gbGluZQogICAgIHsgIk1vdmVU b0JlZ2lubmluZ09mTGluZSIsICAgICAgICAgICAgICAgICAgICAgICAgICAiTW92ZVRvRW5kT2ZM aW5lIiwKICAgICAgICJNb3ZlVG9CZWdpbm5pbmdPZkxpbmVBbmRNb2RpZnlTZWxlY3Rpb24iLCAg ICAgICAgIk1vdmVUb0VuZE9mTGluZUFuZE1vZGlmeVNlbGVjdGlvbiIgICAgICAgICB9LCAvLyBV cC9kb3duIGxpbmUgZW5kcwotICAgIHsgIk1vdmVQYXJhZ3JhcGhGb3J3YXJkIiwgICAgICAgICAg ICAgICAgICAgICAgICAgICAiTW92ZVBhcmFncmFwaEJhY2t3YXJkIiwKLSAgICAgICJNb3ZlUGFy YWdyYXBoRm9yd2FyZEFuZE1vZGlmeVNlbGVjdGlvbiIsICAgICAgICAgIk1vdmVQYXJhZ3JhcGhC YWNrd2FyZEFuZE1vZGlmeVNlbGVjdGlvbiIgICB9LCAvLyBVcC9kb3duIHBhcmFncmFwaHMKKyAg ICB7ICJNb3ZlUGFyYWdyYXBoQmFja3dhcmQiLCAgICAgICAgICAgICAgICAgICAgICAgICAgIk1v dmVQYXJhZ3JhcGhGb3J3YXJkIiwKKyAgICAgICJNb3ZlUGFyYWdyYXBoQmFja3dhcmRBbmRNb2Rp ZnlTZWxlY3Rpb24iLCAgICAgICAgIk1vdmVQYXJhZ3JhcGhGb3J3YXJkQW5kTW9kaWZ5U2VsZWN0 aW9uIiAgICB9LCAvLyBVcC9kb3duIHBhcmFncmFwaHMKICAgICB7ICJNb3ZlVG9CZWdpbm5pbmdP ZlBhcmFncmFwaCIsICAgICAgICAgICAgICAgICAgICAgIk1vdmVUb0VuZE9mUGFyYWdyYXBoIiwK ICAgICAgICJNb3ZlVG9CZWdpbm5pbmdPZlBhcmFncmFwaEFuZE1vZGlmeVNlbGVjdGlvbiIsICAg Ik1vdmVUb0VuZE9mUGFyYWdyYXBoQW5kTW9kaWZ5U2VsZWN0aW9uIiAgICB9LCAvLyBVcC9kb3du IHBhcmFncmFwaCBlbmRzLgogICAgIHsgIk1vdmVQYWdlVXAiLCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiTW92ZVBhZ2VEb3duIiwK