110456 2013-02-21 04:25:02 -0800 [chromium] Simplify computation of screenRect/windowRect. 2013-02-21 12:51:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P4 Trivial --- 1 johnme johnme abarth aelias eric esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 838321 0 johnme 2013-02-21 04:25:02 -0800 [chromium] Simplify computation of screenRect/windowRect. 838334 1 189509 johnme 2013-02-21 04:31:53 -0800 Created attachment 189509 Patch 838637 2 aelias 2013-02-21 11:38:20 -0800 LGTM 838676 3 189509 abarth 2013-02-21 12:12:00 -0800 Comment on attachment 189509 Patch This is great! I'm looking forward to removing applyDeviceScaleFactorInCompositor from more code. :) 838720 4 189509 webkit.review.bot 2013-02-21 12:51:03 -0800 Comment on attachment 189509 Patch Clearing flags on attachment: 189509 Committed r143642: <http://trac.webkit.org/changeset/143642> 838721 5 webkit.review.bot 2013-02-21 12:51:06 -0800 All reviewed patches have been landed. Closing bug. 189509 2013-02-21 04:31:53 -0800 2013-02-21 12:51:02 -0800 Patch bug-110456-20130221122814.patch text/plain 6692 johnme U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzhlMTE2ZGNlN2YxMzQ5 YjVkYzA1MzBjNzFiYjMxZGFlNWMzYTZkOS4uZTU5ZWE4ZjdlODI0NzQ2ODViZTE1ZWE2ZjdkNzE3 ZDg0ZTRmODEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTIxICBKb2hu IE1lbGxvciAgPGpvaG5tZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTaW1w bGlmeSBjb21wdXRhdGlvbiBvZiBzY3JlZW5SZWN0L3dpbmRvd1JlY3QuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0NTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgYXBw bHlEZXZpY2VTY2FsZUZhY3RvckluQ29tcG9zaXRvciBjaGVja3MKKyAgICAgICAgYWRkZWQgYnkg aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTM5MzU2IGJlY2F1c2UKKyAgICAgICAg Q2hyb21lIGZvciBBbmRyb2lkIG5vdyBzaXplcyBpdHMgc2NyZWVuIGFuZCB3aW5kb3cgaW4gRElQ CisgICAgICAgIHVuaXRzIChsaWtlIG90aGVyIHBsYXRmb3JtcyksIHNvIHRoZXkgYXJlIG5vIGxv bmdlciBuZWNlc3NhcnkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0aGlzIGlzIGp1 c3QgcmVtb3ZpbmcgYW4gdW51c2VkIGNvZGVwYXRoLgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vUGxhdGZvcm1TY3JlZW5DaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzY3Jl ZW5SZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OnNjcmVlbkF2YWlsYWJsZVJlY3QpOgorICAgICAg ICAqIHJlbmRlcmluZy9UZXh0QXV0b3NpemVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRB dXRvc2l6ZXI6OnByb2Nlc3NTdWJ0cmVlKToKKwogMjAxMy0wMi0yMCAgVGFrYXNoaSBTYWthbW90 byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1JlZmFjdG9yaW5nXSBNYWtlIG1fc3Rh dGUgYW4gb24tc3RhY2sgb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDA4Yzkz ZDMwMTllY2UyZGEzZjc1ZDU4NDkzMzU5MWFkZjU2ZTUyYTEuLmNlNzEzNDU2MTJmYzEyMzgwNWNh ZDE1NzQ3MmNjMDFkOTZiMWVkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTMtMDItMjEgIEpvaG4gTWVsbG9yICA8am9obm1lQGNocm9taXVtLm9yZz4K KworICAgICAgICBbY2hyb21pdW1dIFNpbXBsaWZ5IGNvbXB1dGF0aW9uIG9mIHNjcmVlblJlY3Qv d2luZG93UmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMDQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyBhcHBseURldmljZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9y IGNoZWNrcworICAgICAgICBhZGRlZCBieSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8xMzkzNTYgYmVjYXVzZQorICAgICAgICBDaHJvbWUgZm9yIEFuZHJvaWQgbm93IHNpemVzIGl0 cyBzY3JlZW4gYW5kIHdpbmRvdyBpbiBESVAKKyAgICAgICAgdW5pdHMgKGxpa2Ugb3RoZXIgcGxh dGZvcm1zKSwgc28gdGhleSBhcmUgbm8gbG9uZ2VyIG5lY2Vzc2FyeS4KKworICAgICAgICAqIHNy Yy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1w bDo6d2luZG93UmVjdCk6CisKIDIwMTMtMDItMjAgIFBhd2XFgiBIYWpkYW4sIEpyLiAgPHBoYWpk YW4uanJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBneXAgb3B0aW9uIHRvIHN3aXRjaCBF TkFCTEUoU1FMX0RBVEFCQVNFKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUGxhdGZvcm1TY3JlZW5DaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVtLmNwcAppbmRleCBhMjk4ZWM5M2U1 OWU5ZWViZTNjODMzZjBiMzIzNTMxZmVkNzQ2NDI5Li40ZmI2OTE1YTQ2OWE2ODc3ZGI2NWI2YmMx Njg5NTFjMDVhNmJmMGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVtLmNwcApAQCAtMzIsMTIgKzMyLDgg QEAKICNpbmNsdWRlICJQbGF0Zm9ybVNjcmVlbi5oIgogCiAjaW5jbHVkZSAiRmxvYXRSZWN0Lmgi Ci0jaW5jbHVkZSAiRnJhbWUuaCIKLSNpbmNsdWRlICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJI b3N0V2luZG93LmgiCi0jaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlNjcm9sbFZpZXcuaCIK LSNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIldpZGdldC5oIgogI2luY2x1ZGUgPHB1 YmxpYy9QbGF0Zm9ybS5oPgogI2luY2x1ZGUgPHB1YmxpYy9XZWJTY3JlZW5JbmZvLmg+CkBAIC04 MSwyNCArNzcsMTIgQEAgYm9vbCBzY3JlZW5Jc01vbm9jaHJvbWUoV2lkZ2V0KiB3aWRnZXQpCiAg ICAgcmV0dXJuIGNsaWVudC0+c2NyZWVuSW5mbygpLmlzTW9ub2Nocm9tZTsKIH0KIAotLy8gT24g Q2hyb21lIGZvciBBbmRyb2lkLCB0aGUgc2NyZWVuSW5mbyByZWN0cyBhcmUgaW4gcGh5c2ljYWwg c2NyZWVuIHBpeGVscwotLy8gaW5zdGVhZCBvZiBkZW5zaXR5IGluZGVwZW5kZW50IChVSSkgcGl4 ZWxzLCBhbmQgbXVzdCBiZSBzY2FsZWQgZG93bi4KLXN0YXRpYyBGbG9hdFJlY3QgdG9Vc2VyU3Bh Y2UoRmxvYXRSZWN0IHJlY3QsIFdpZGdldCogd2lkZ2V0KQotewotICAgIGlmICh3aWRnZXQtPmlz RnJhbWVWaWV3KCkpIHsKLSAgICAgICAgUGFnZSogcGFnZSA9IHN0YXRpY19jYXN0PEZyYW1lVmll dyo+KHdpZGdldCktPmZyYW1lKCktPnBhZ2UoKTsKLSAgICAgICAgaWYgKHBhZ2UgJiYgIXBhZ2Ut PnNldHRpbmdzKCktPmFwcGx5RGV2aWNlU2NhbGVGYWN0b3JJbkNvbXBvc2l0b3IoKSkKLSAgICAg ICAgICAgIHJlY3Quc2NhbGUoMSAvIHBhZ2UtPmRldmljZVNjYWxlRmFjdG9yKCkpOwotICAgIH0K LSAgICByZXR1cm4gcmVjdDsKLX0KLQogRmxvYXRSZWN0IHNjcmVlblJlY3QoV2lkZ2V0KiB3aWRn ZXQpCiB7CiAgICAgUGxhdGZvcm1QYWdlQ2xpZW50IGNsaWVudCA9IHRvUGxhdGZvcm1QYWdlQ2xp ZW50KHdpZGdldCk7CiAgICAgaWYgKCFjbGllbnQpCiAgICAgICAgIHJldHVybiBGbG9hdFJlY3Qo KTsKLSAgICByZXR1cm4gdG9Vc2VyU3BhY2UoSW50UmVjdChjbGllbnQtPnNjcmVlbkluZm8oKS5y ZWN0KSwgd2lkZ2V0KTsKKyAgICByZXR1cm4gSW50UmVjdChjbGllbnQtPnNjcmVlbkluZm8oKS5y ZWN0KTsKIH0KIAogRmxvYXRSZWN0IHNjcmVlbkF2YWlsYWJsZVJlY3QoV2lkZ2V0KiB3aWRnZXQp CkBAIC0xMDYsNyArOTAsNyBAQCBGbG9hdFJlY3Qgc2NyZWVuQXZhaWxhYmxlUmVjdChXaWRnZXQq IHdpZGdldCkKICAgICBQbGF0Zm9ybVBhZ2VDbGllbnQgY2xpZW50ID0gdG9QbGF0Zm9ybVBhZ2VD bGllbnQod2lkZ2V0KTsKICAgICBpZiAoIWNsaWVudCkKICAgICAgICAgcmV0dXJuIEZsb2F0UmVj dCgpOwotICAgIHJldHVybiB0b1VzZXJTcGFjZShJbnRSZWN0KGNsaWVudC0+c2NyZWVuSW5mbygp LmF2YWlsYWJsZVJlY3QpLCB3aWRnZXQpOworICAgIHJldHVybiBJbnRSZWN0KGNsaWVudC0+c2Ny ZWVuSW5mbygpLmF2YWlsYWJsZVJlY3QpOwogfQogCiB2b2lkIHNjcmVlbkNvbG9yUHJvZmlsZShD b2xvclByb2ZpbGUmIHRvUHJvZmlsZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9UZXh0QXV0b3NpemVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0QXV0 b3NpemVyLmNwcAppbmRleCA2YzkyNmI4MDRjZDBjZjE4OWQ0ZWFmYzBmODNkYTgxZjM2NTgzOGY4 Li43MGQwNzRmNzU4NDI5ZDEwYTYwMjY2Yzk5Y2ZlYTE2MWViZWRjOGJkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dEF1dG9zaXplci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1RleHRBdXRvc2l6ZXIuY3BwCkBAIC0xMTcsOCArMTE3LDYgQEAgYm9v bCBUZXh0QXV0b3NpemVyOjpwcm9jZXNzU3VidHJlZShSZW5kZXJPYmplY3QqIGxheW91dFJvb3Qp CiAgICAgaWYgKHdpbmRvd0luZm8ud2luZG93U2l6ZS5pc0VtcHR5KCkpIHsKICAgICAgICAgYm9v bCBpbmNsdWRlU2Nyb2xsYmFycyA9ICFJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OnNob3VsZEFw cGx5U2NyZWVuV2lkdGhPdmVycmlkZShtYWluRnJhbWUpOwogICAgICAgICB3aW5kb3dJbmZvLndp bmRvd1NpemUgPSBtYWluRnJhbWUtPnZpZXcoKS0+dW5zY2FsZWRWaXNpYmxlQ29udGVudFNpemUo aW5jbHVkZVNjcm9sbGJhcnMgPyBTY3JvbGxhYmxlQXJlYTo6SW5jbHVkZVNjcm9sbGJhcnMgOiBT Y3JvbGxhYmxlQXJlYTo6RXhjbHVkZVNjcm9sbGJhcnMpOwotICAgICAgICBpZiAoIW1fZG9jdW1l bnQtPnNldHRpbmdzKCktPmFwcGx5RGV2aWNlU2NhbGVGYWN0b3JJbkNvbXBvc2l0b3IoKSkKLSAg ICAgICAgICAgIHdpbmRvd0luZm8ud2luZG93U2l6ZS5zY2FsZSgxIC8gbV9kb2N1bWVudC0+cGFn ZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpKTsKICAgICB9CiAKICAgICAvLyBMYXJnZXN0IGFyZWEg b2YgYmxvY2sgdGhhdCBjYW4gYmUgdmlzaWJsZSBhdCBvbmNlIChhc3N1bWluZyB0aGUgbWFpbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAppbmRl eCBjYjY3Zjc5OWY4OTdmZTcwYmUwMjY3ZDdjMzRjOTMxODRmZDUxNjc0Li40OTU3NjhhMDU2ZDI3 MWNlNGIwYTA2NmM4YjUxNjIxMzNlMzRkYjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtMTg5LDE5ICsxODksMTcgQEAgdm9pZCBD aHJvbWVDbGllbnRJbXBsOjpzZXRXaW5kb3dSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcikKIAogRmxv YXRSZWN0IENocm9tZUNsaWVudEltcGw6OndpbmRvd1JlY3QoKQogewotICAgIGlmIChtX3dlYlZp ZXctPmNsaWVudCgpKSB7Ci0gICAgICAgIC8vIE9uIENocm9tZSBmb3IgQW5kcm9pZCwgcm9vdFdp bmRvd1JlY3QgaXMgaW4gcGh5c2ljYWwgc2NyZWVuIHBpeGVscwotICAgICAgICAvLyBpbnN0ZWFk IG9mIGRlbnNpdHkgaW5kZXBlbmRlbnQgKFVJKSBwaXhlbHMsIGFuZCBtdXN0IGJlIHNjYWxlZCBk b3duLgotICAgICAgICBGbG9hdFJlY3QgcmVjdCA9IEZsb2F0UmVjdChtX3dlYlZpZXctPmNsaWVu dCgpLT5yb290V2luZG93UmVjdCgpKTsKLSAgICAgICAgaWYgKCFtX3dlYlZpZXctPnBhZ2UoKS0+ c2V0dGluZ3MoKS0+YXBwbHlEZXZpY2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcigpKQotICAgICAg ICAgICAgcmVjdC5zY2FsZSgxIC8gbV93ZWJWaWV3LT5jbGllbnQoKS0+c2NyZWVuSW5mbygpLmRl dmljZVNjYWxlRmFjdG9yKTsKLSAgICAgICAgcmV0dXJuIHJlY3Q7CisgICAgV2ViUmVjdCByZWN0 OworICAgIGlmIChtX3dlYlZpZXctPmNsaWVudCgpKQorICAgICAgICByZWN0ID0gbV93ZWJWaWV3 LT5jbGllbnQoKS0+cm9vdFdpbmRvd1JlY3QoKTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gVGhl c2UgbnVtYmVycyB3aWxsIGJlIGZhaXJseSB3cm9uZy4gVGhlIHdpbmRvdydzIHgveSBjb29yZGlu YXRlcyB3aWxsCisgICAgICAgIC8vIGJlIHRoZSB0b3AgbGVmdCBjb3JuZXIgb2YgdGhlIHNjcmVl biBhbmQgdGhlIHNpemUgd2lsbCBiZSB0aGUgY29udGVudAorICAgICAgICAvLyBzaXplIGluc3Rl YWQgb2YgdGhlIHdpbmRvdyBzaXplLgorICAgICAgICByZWN0LndpZHRoID0gbV93ZWJWaWV3LT5z aXplKCkud2lkdGg7CisgICAgICAgIHJlY3QuaGVpZ2h0ID0gbV93ZWJWaWV3LT5zaXplKCkuaGVp Z2h0OwogICAgIH0KLQotICAgIC8vIFRoZXNlIG51bWJlcnMgd2lsbCBiZSBmYWlybHkgd3Jvbmcu IFRoZSB3aW5kb3cncyB4L3kgY29vcmRpbmF0ZXMgd2lsbAotICAgIC8vIGJlIHRoZSB0b3AgbGVm dCBjb3JuZXIgb2YgdGhlIHNjcmVlbiBhbmQgdGhlIHNpemUgd2lsbCBiZSB0aGUgY29udGVudAot ICAgIC8vIHNpemUgaW5zdGVhZCBvZiB0aGUgd2luZG93IHNpemUuCi0gICAgcmV0dXJuIEZsb2F0 UmVjdCgwLCAwLCBtX3dlYlZpZXctPnNpemUoKS53aWR0aCwgbV93ZWJWaWV3LT5zaXplKCkuaGVp Z2h0KTsKKyAgICByZXR1cm4gRmxvYXRSZWN0KHJlY3QpOwogfQogCiBGbG9hdFJlY3QgQ2hyb21l Q2xpZW50SW1wbDo6cGFnZVJlY3QoKQo=