110452 2013-02-21 03:27:13 -0800 Add LOG_DEBUG for printing messages without log channel 2013-02-21 20:30:46 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 90823 P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ap benjamin cmarcelo laszlo.gombos ojan.autocc webkit.review.bot oldest_to_newest 838288 0 gyuyoung.kim 2013-02-21 03:27:13 -0800 LOG_VERBOSE can't print log messages when we need to print debugging log without a log channel. Beside LOG_ERROR is also not proper for the debugging log. So, I'd like to suggest to use LOG_DEBUG. It will help to print debugging message without a log channel. 838302 1 189501 gyuyoung.kim 2013-02-21 03:48:53 -0800 Created attachment 189501 Patch 838524 2 ap 2013-02-21 09:53:15 -0800 Can you please give an example of where you'd like to use this? 838694 3 189501 benjamin 2013-02-21 12:24:56 -0800 Comment on attachment 189501 Patch Someone tries to add this every few months. :( Please define what is a "Debug Log". There was a thread on webkit-dev about debug logging facilities (thread: "Easing printf based debugging in WebKit with an helper"). There were some agreement on what it should do and how it should look like. 838698 4 benjamin 2013-02-21 12:28:29 -0800 *** This bug has been marked as a duplicate of bug 90823 *** 839123 5 gyuyoung.kim 2013-02-21 18:35:31 -0800 (In reply to comment #2) > Can you please give an example of where you'd like to use this? I was considering to replace EFL specific debug log with common WebKit log facilities. For example, EINA_LOG_DBG, EINA_LOG_CRIT and so on. But, we need to set additional an environment variable in order to use it. I and my co-worker thought this is not efficient for debugging. Because EFL port also uses WebKit LOG() as well. So, if LOG() macro supports debug log, I think we're able to replace all EFL specific logs with WebKit's thing. For example, as below, EINA_LOG_DBG("failed to load plugin, unload it without shutting it down."); => LOG_DEBUG("failed to load plugin, unload it without shutting it down."); EINA_LOG_ERR("failed to load plugin, unload it without shutting it down."); => LOG_ERROR("failed to load plugin, unload it without shutting it down."); Then, we can see this log as well as LOG_ERROR's message on debug build. Benjamin, thank you for noticing it, I will monitor Bug 90823. 839155 6 laszlo.gombos 2013-02-21 19:45:02 -0800 (In reply to comment #5) > (In reply to comment #2) > > Can you please give an example of where you'd like to use this? > > EINA_LOG_DBG("failed to load plugin, unload it without shutting it down."); > => LOG_DEBUG("failed to load plugin, unload it without shutting it down."); Would WTFLogAlways() work here ? 839158 7 gyuyoung.kim 2013-02-21 19:54:21 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > Can you please give an example of where you'd like to use this? > > > > > EINA_LOG_DBG("failed to load plugin, unload it without shutting it down."); > > => LOG_DEBUG("failed to load plugin, unload it without shutting it down."); > > Would WTFLogAlways() work here ? It works on release build as well. Beside it always shows messages regardless of build mode or env variable. It looks Apple folks wanted to use it. As you know, LOG() can only work on mostly ports's debug mode. So, I wasn't sure if we can make LOG wrapper for it, and replace EINA_LOG_XXX macro with it. 839169 8 gyuyoung.kim 2013-02-21 20:10:42 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #2) > > > > Can you please give an example of where you'd like to use this? > > > > > > > > EINA_LOG_DBG("failed to load plugin, unload it without shutting it down."); > > > => LOG_DEBUG("failed to load plugin, unload it without shutting it down."); > > > > Would WTFLogAlways() work here ? > > It works on release build as well. Beside it always shows messages regardless of build mode or env variable. It looks Apple folks wanted to use it. As you know, LOG() can only work on mostly ports's debug mode. So, I wasn't sure if we can make LOG wrapper for it, and replace EINA_LOG_XXX macro with it. BTW, is it possible to add EFL specific log macro based on WTFLogAlways() ? In GStreamerUtilities.h case, for example, it redefines LOG_VERBOSE as below, #define LOG_MEDIA_MESSAGE(...) do { \ GST_DEBUG(__VA_ARGS__); \ LOG_VERBOSE(Media, __VA_ARGS__); } while (0) For example, #if !LOG_DISABLED #define LOG_EFL_DEBUG() WTFLogAlways() #endif 839173 9 ap 2013-02-21 20:19:44 -0800 The issue with cross-platform LOG_DEBUG is that many people just don't want debug logging that they didn't enable. It tends to make real error messages less visible. I'm not sure why you want that in EFL code. In any case, it seems like you currently have a working solution with EINA_LOG_DBG. 839176 10 gyuyoung.kim 2013-02-21 20:30:46 -0800 (In reply to comment #9) > The issue with cross-platform LOG_DEBUG is that many people just don't want debug logging that they didn't enable. It tends to make real error messages less visible. > > I'm not sure why you want that in EFL code. In any case, it seems like you currently have a working solution with EINA_LOG_DBG. I agree with your comment. LOG_DEBUG may show blooming logs for someone. Thanks. 189501 2013-02-21 03:48:53 -0800 2013-02-21 12:24:55 -0800 Patch bug-110452-20130221204513.patch text/plain 2936 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc2M2Y3YWMxOWNhZjg5NWJiZjRjNTQ3 ODUzNjZmMDdjZjI0YzFkYzQuLjk2ODcwNTM0N2ZmNzc5ZWJmOTYzMmNhMmU1YmFlZjNmNzUxYzdm Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDItMjEgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBBZGQgTE9HX0RFQlVHIGZvciBwcmludGlu ZyBtZXNzYWdlcyB3aXRob3V0IGxvZyBjaGFubmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBMT0dfVkVSQk9TRSBjYW4ndCBwcmludCBsb2cgbWVzc2Fn ZXMgd2hlbiB3ZSBuZWVkIHRvIHByaW50IGRlYnVnZ2luZyBsb2cKKyAgICAgICAgd2l0aG91dCBh IGxvZyBjaGFubmVsLiBCZXNpZGUgTE9HX0VSUk9SIGlzIG5vdCBwcm9wZXIgZm9yIGRlYnVnZ2lu ZyBsb2cuCisgICAgICAgIExPR19ERUJVRyB3aWxsIGhlbHAgdG8gcHJpbnQgZGVidWdnaW5nIG1l c3NhZ2UuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5jcHA6CisgICAgICAgICogd3RmL0Fz c2VydGlvbnMuaDoKKwogMjAxMy0wMi0yMCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIEdldCBWUzIwMTAgU29sdXRpb24gQiZJIHJlYWR5LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmNwcAppbmRleCBhZDhjZTg2Yjg1ZDZiODQ5NGI2Y2UwYTgwZjU1OTRmMjQ2N2YwMDhlLi4y YmVhMzEyNWRjMDVkZGM4OWE2N2MwZGM1NGFkMWUzNzY5ODE3M2MyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25z LmNwcApAQCAtNDI2LDQgKzQyNiwxNCBAQCB2b2lkIFdURkxvZ0Fsd2F5cyhjb25zdCBjaGFyKiBm b3JtYXQsIC4uLikKICAgICB2YV9lbmQoYXJncyk7CiB9CiAKK3ZvaWQgV1RGTG9nRGVidWcoY29u c3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1bmN0aW9uLCBjb25zdCBjaGFy KiBmb3JtYXQsIC4uLikKK3sKKyAgICB2YV9saXN0IGFyZ3M7CisgICAgdmFfc3RhcnQoYXJncywg Zm9ybWF0KTsKKyAgICB2cHJpbnRmX3N0ZGVycl93aXRoX3ByZWZpeCgiREVCVUc6ICIsIGZvcm1h dCwgYXJncyk7CisgICAgdmFfZW5kKGFyZ3MpOworICAgIHByaW50Zl9zdGRlcnJfY29tbW9uKCJc biIpOworICAgIHByaW50Q2FsbFNpdGUoZmlsZSwgbGluZSwgZnVuY3Rpb24pOworfQorCiB9IC8v IGV4dGVybiAiQyIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCAwZDZjYzM2MjczMTk4ZGI5ZTg4YmQ4OTU1 ZTE3YjBmZGRlOWY0NjAzLi43YWNlZTVhOTIyMTAxNWNiOWM0NzcyZjBiMmEwOTFkYzg0MjM1Mjdk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dU Ri93dGYvQXNzZXJ0aW9ucy5oCkBAIC0xNDQsNiArMTQ0LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRF IHZvaWQgV1RGUmVwb3J0RXJyb3IoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNo YXIqIGYKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURkxvZyhXVEZMb2dDaGFubmVsKiwgY29u c3QgY2hhciogZm9ybWF0LCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDMpOwogV1RGX0VY UE9SVF9QUklWQVRFIHZvaWQgV1RGTG9nVmVyYm9zZShjb25zdCBjaGFyKiBmaWxlLCBpbnQgbGlu ZSwgY29uc3QgY2hhciogZnVuY3Rpb24sIFdURkxvZ0NoYW5uZWwqLCBjb25zdCBjaGFyKiBmb3Jt YXQsIC4uLikgV1RGX0FUVFJJQlVURV9QUklOVEYoNSwgNik7CiBXVEZfRVhQT1JUX1BSSVZBVEUg dm9pZCBXVEZMb2dBbHdheXMoY29uc3QgY2hhciogZm9ybWF0LCAuLi4pIFdURl9BVFRSSUJVVEVf UFJJTlRGKDEsIDIpOworV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGTG9nRGVidWcoY29uc3Qg Y2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1bmN0aW9uLCBjb25zdCBjaGFyKiBm b3JtYXQsIC4uLikgV1RGX0FUVFJJQlVURV9QUklOVEYoNCwgNSk7CiAKIFdURl9FWFBPUlRfUFJJ VkFURSB2b2lkIFdURkdldEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCogc2l6ZSk7CiBXVEZf RVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZSZXBvcnRCYWNrdHJhY2UoKTsKQEAgLTM5Niw2ICszOTcs MTYgQEAgd2hpbGUgKDApCiAjZGVmaW5lIExPR19WRVJCT1NFKGNoYW5uZWwsIC4uLikgV1RGTG9n VmVyYm9zZShfX0ZJTEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICZKT0lOX0xP R19DSEFOTkVMX1dJVEhfUFJFRklYKExPR19DSEFOTkVMX1BSRUZJWCwgY2hhbm5lbCksIF9fVkFf QVJHU19fKQogI2VuZGlmCiAKKy8qIExPR19ERUJVRyAqLworCisjaWYgQ09NUElMRVIoTVNWQzdf T1JfTE9XRVIpCisjZGVmaW5lIExPR19ERUJVRygpICgodm9pZCkwKQorI2VsaWYgTE9HX0RJU0FC TEVECisjZGVmaW5lIExPR19ERUJVRyguLi4pICgodm9pZCkwKQorI2Vsc2UKKyNkZWZpbmUgTE9H X0RFQlVHKC4uLikgV1RGTG9nRGVidWcoX19GSUxFX18sIF9fTElORV9fLCBXVEZfUFJFVFRZX0ZV TkNUSU9OLCBfX1ZBX0FSR1NfXykKKyNlbmRpZgorCiAvKiBVTlJFQUNIQUJMRV9GT1JfUExBVEZP Uk0gKi8KIAogI2lmIENPTVBJTEVSKENMQU5HKQo=