110451 2013-02-21 03:12:45 -0800 [BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload 2013-02-21 09:13:23 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 838280 0 cgarcia 2013-02-21 03:12:45 -0800 It seems it was added by mistake in r137845 when FrameLoaderClient::download was renamed to convertMainResourceLoadToDownload 838281 1 189495 cgarcia 2013-02-21 03:14:38 -0800 Created attachment 189495 Patch 838285 2 189498 cgarcia 2013-02-21 03:21:56 -0800 Created attachment 189498 Updated patch I forgot to remove the extra parameter from the header too. 838475 3 189498 rwlbuis 2013-02-21 08:55:15 -0800 Comment on attachment 189498 Updated patch Looks good. 838496 4 189498 webkit.review.bot 2013-02-21 09:13:19 -0800 Comment on attachment 189498 Updated patch Clearing flags on attachment: 189498 Committed r143614: <http://trac.webkit.org/changeset/143614> 838497 5 webkit.review.bot 2013-02-21 09:13:23 -0800 All reviewed patches have been landed. Closing bug. 189495 2013-02-21 03:14:38 -0800 2013-02-21 03:21:56 -0800 Patch extra-request-parameter.diff text/plain 2001 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGZmMTNkODkuLmVjMmUwOTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEzLTAyLTIxICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNhcmdhcmNpYUByaW0uY29tPgogCisgICAgICAgIFtCbGFj a0JlcnJ5XSBFeHRyYSBSZXNvdXJjZVJlcXVlc3QgcGFyYW1ldGVyIGluIEZyYW1lTG9hZGVyQ2xp ZW50QmxhY2tCZXJyeTo6Y29udmVydE1haW5SZXNvdXJjZUxvYWRUb0Rvd25sb2FkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0NTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNvbnZlcnRNYWluUmVzb3VyY2VMb2FkVG9Eb3dubG9h ZCk6CisgICAgICAgIFJlbW92ZSB0aGUgZXh0cmEgUmVzb3VyY2VSZXF1ZXN0IHBhcmFtZXRlci4K KworMjAxMy0wMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjYXJnYXJjaWFAcmltLmNvbT4K KwogICAgICAgICBbQmxhY2tCZXJyeV0gUmVuYW1lIExvY2FsaXplciB0byBMb2NhbGUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDQ0OQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGY0OTA4OWYuLjUz ODY1NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBA IC0xMjI0LDcgKzEyMjQsNyBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6c3Rh cnREb3dubG9hZChjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsCiAgICAgbV93ZWJQYWdl UHJpdmF0ZS0+bG9hZChyZXF1ZXN0LnVybCgpLnN0cmluZygpLCBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6U3RyaW5nOjplbXB0eVN0cmluZygpLCAiR0VUIiwgTmV0d29ya1JlcXVlc3Q6OlVzZVByb3Rv Y29sQ2FjaGVQb2xpY3ksIDAsIDAsIDAsIDAsIGZhbHNlLCBmYWxzZSwgdHJ1ZSwgIiIsIHN1Z2dl c3RlZE5hbWUpOwogfQogCi12b2lkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6Y29udmVy dE1haW5SZXNvdXJjZUxvYWRUb0Rvd25sb2FkKE1haW5SZXNvdXJjZUxvYWRlciogbWFpblJlc291 cmNlTG9hZGVyLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBSZXNvdXJjZVJlcXVlc3Qm LCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnk6OmNvbnZlcnRNYWluUmVzb3VyY2VMb2FkVG9Eb3dubG9hZChNYWluUmVzb3VyY2VMb2Fk ZXIqIG1haW5SZXNvdXJjZUxvYWRlciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVz b3VyY2VSZXNwb25zZSYgcikKIHsKICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6RmlsdGVyU3Ry ZWFtKiBzdHJlYW0gPSBOZXR3b3JrTWFuYWdlcjo6aW5zdGFuY2UoKS0+c3RyZWFtRm9ySGFuZGxl KG1haW5SZXNvdXJjZUxvYWRlci0+bG9hZGVyKCktPmhhbmRsZSgpKTsKICAgICBBU1NFUlQoc3Ry ZWFtKTsK 189498 2013-02-21 03:21:56 -0800 2013-02-21 09:13:19 -0800 Updated patch extra-request-parameter2.diff text/plain 3289 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGZmMTNkODkuLjkwMmIzYmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAyLTIxICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNhcmdhcmNpYUByaW0uY29tPgogCisgICAgICAgIFtCbGFj a0JlcnJ5XSBFeHRyYSBSZXNvdXJjZVJlcXVlc3QgcGFyYW1ldGVyIGluIEZyYW1lTG9hZGVyQ2xp ZW50QmxhY2tCZXJyeTo6Y29udmVydE1haW5SZXNvdXJjZUxvYWRUb0Rvd25sb2FkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0NTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGV4dHJh IFJlc291cmNlUmVxdWVzdCBwYXJhbWV0ZXIgZnJvbQorICAgICAgICBGcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnk6OmNvbnZlcnRNYWluUmVzb3VyY2VMb2FkVG9Eb3dubG9hZC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNvbnZlcnRNYWluUmVz b3VyY2VMb2FkVG9Eb3dubG9hZCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRCbGFja0JlcnJ5Lmg6CisgICAgICAgIChGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnkpOgorCisyMDEzLTAyLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNhcmdhcmNpYUByaW0u Y29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSBSZW5hbWUgTG9jYWxpemVyIHRvIExvY2FsZQog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNDQ5CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFt ZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggZjQ5MDg5 Zi4uNTM4NjU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHAKQEAgLTEyMjQsNyArMTIyNCw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5 OjpzdGFydERvd25sb2FkKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwKICAgICBtX3dl YlBhZ2VQcml2YXRlLT5sb2FkKHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpTdHJpbmc6OmVtcHR5U3RyaW5nKCksICJHRVQiLCBOZXR3b3JrUmVxdWVzdDo6VXNl UHJvdG9jb2xDYWNoZVBvbGljeSwgMCwgMCwgMCwgMCwgZmFsc2UsIGZhbHNlLCB0cnVlLCAiIiwg c3VnZ2VzdGVkTmFtZSk7CiB9CiAKLXZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Ojpj b252ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQoTWFpblJlc291cmNlTG9hZGVyKiBtYWlu UmVzb3VyY2VMb2FkZXIsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFJlc291cmNlUmVx dWVzdCYsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHIpCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeTo6Y29udmVydE1haW5SZXNvdXJjZUxvYWRUb0Rvd25sb2FkKE1haW5SZXNvdXJj ZUxvYWRlciogbWFpblJlc291cmNlTG9hZGVyLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBjb25z dCBSZXNvdXJjZVJlc3BvbnNlJiByKQogewogICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpGaWx0 ZXJTdHJlYW0qIHN0cmVhbSA9IE5ldHdvcmtNYW5hZ2VyOjppbnN0YW5jZSgpLT5zdHJlYW1Gb3JI YW5kbGUobWFpblJlc291cmNlTG9hZGVyLT5sb2FkZXIoKS0+aGFuZGxlKCkpOwogICAgIEFTU0VS VChzdHJlYW0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oCmluZGV4 IGVkOGYxMTguLmZhYWI3OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0Jl cnJ5LmgKQEAgLTE0NCw3ICsxNDQsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpZFNh dmVUb1BhZ2VDYWNoZSgpOwogICAgIHZpcnR1YWwgdm9pZCBkaWRSZXN0b3JlRnJvbVBhZ2VDYWNo ZSgpOwogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaERpZEJlY29tZUZyYW1lc2V0KGJvb2wpIHsg fQotICAgIHZpcnR1YWwgdm9pZCBjb252ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQoTWFp blJlc291cmNlTG9hZGVyKiwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VS ZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOworICAgIHZpcnR1YWwgdm9pZCBjb252 ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQoTWFpblJlc291cmNlTG9hZGVyKiwgY29uc3Qg UmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAgIHZpcnR1YWwg UGFzc1JlZlB0cjxGcmFtZT4gY3JlYXRlRnJhbWUoY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYs IEhUTUxGcmFtZU93bmVyRWxlbWVudCosIGNvbnN0IFN0cmluZyYsIGJvb2wsIGludCwgaW50KTsK ICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8V2lkZ2V0PiBjcmVhdGVQbHVnaW4oY29uc3QgSW50U2l6 ZSYsIEhUTUxQbHVnSW5FbGVtZW50KiwgY29uc3QgS1VSTCYsIGNvbnN0IFZlY3RvcjxTdHJpbmc+ JiwgY29uc3QgVmVjdG9yPFN0cmluZz4mLCBjb25zdCBTdHJpbmcmLCBib29sKTsKICAgICB2aXJ0 dWFsIHZvaWQgcmVkaXJlY3REYXRhVG9QbHVnaW4oV2lkZ2V0Kik7Cg==