110448 2013-02-21 02:43:23 -0800 [BlackBerry] Misc build fixes 2013-02-28 01:33:59 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 838259 0 berto 2013-02-21 02:43:23 -0800 WebString was replaced with BlackBerry::Platform::String in r131316. Some webdatabase APIs are encapuslated in DatabaseManager since r137520. Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844. Add closing brace that was missing in r142482. 838263 1 189489 berto 2013-02-21 02:45:37 -0800 Created attachment 189489 Patch 838330 2 189489 rwlbuis 2013-02-21 04:30:48 -0800 Comment on attachment 189489 Patch LGTM. 843874 3 189489 webkit.review.bot 2013-02-28 01:33:55 -0800 Comment on attachment 189489 Patch Clearing flags on attachment: 189489 Committed r144276: <http://trac.webkit.org/changeset/144276> 843875 4 webkit.review.bot 2013-02-28 01:33:59 -0800 All reviewed patches have been landed. Closing bug. 189489 2013-02-21 02:45:37 -0800 2013-02-28 01:33:55 -0800 Patch 110448.diff text/plain 4296 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGM2YmIzZDIuLmVl ZGVjMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMzgs OSArMzgsNyBAQAogI2luY2x1ZGUgIkNyZWRlbnRpYWxTdG9yYWdlLmgiCiAjaW5jbHVkZSAiQ3Jl ZGVudGlhbFRyYW5zZm9ybURhdGEuaCIKICNpbmNsdWRlICJET01TdXBwb3J0LmgiCi0jaW5jbHVk ZSAiRGF0YWJhc2UuaCIKICNpbmNsdWRlICJEYXRhYmFzZU1hbmFnZXIuaCIKLSNpbmNsdWRlICJE YXRhYmFzZVN5bmMuaCIKICNpbmNsdWRlICJEZWZhdWx0VGFwSGlnaGxpZ2h0LmgiCiAjaW5jbHVk ZSAiRGV2aWNlTW90aW9uQ2xpZW50QmxhY2tCZXJyeS5oIgogI2luY2x1ZGUgIkRldmljZU9yaWVu dGF0aW9uQ2xpZW50QmxhY2tCZXJyeS5oIgpAQCAtNzYxLDcgKzc1OSw3IEBAIHZvaWQgV2ViUGFn ZTo6bG9hZFN0cmluZyhjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBzdHJpbmcs IGNvbnN0IEJsYWNrCiAgICAgZC0+bG9hZFN0cmluZyhzdHJpbmcsIGJhc2VVUkwsIG1pbWVUeXBl LCBmYWlsaW5nVVJMKTsKIH0KIAotYm9vbCBXZWJQYWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3Jp cHQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgc2NyaXB0VVRGOCwgSmF2YVNj cmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQorYm9vbCBX ZWJQYWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZv cm06OlN0cmluZyYgc2NyaXB0VVRGOCwgSmF2YVNjcmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBC bGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiByZXR1cm5WYWx1ZSkKIHsKICAgICBCTEFDS0JF UlJZX0FTU0VSVChzY3JpcHRVVEY4LmlzVXRmOCgpKTsKICAgICBTdHJpbmcgc2NyaXB0ID0gc2Ny aXB0VVRGODsKQEAgLTU5NDIsNyArNTk0MCw3IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmRpZENo YW5nZVNldHRpbmdzKFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncykKICAgICBzdGF0aWMgYm9vbCBk YmluaXQgPSBmYWxzZTsKICAgICBpZiAoIWRiaW5pdCAmJiAhd2ViU2V0dGluZ3MtPmRhdGFiYXNl UGF0aCgpLmVtcHR5KCkpIHsKICAgICAgICAgZGJpbml0ID0gdHJ1ZTsKLSAgICAgICAgRGF0YWJh c2VNYW5hZ2VyOjppbml0aWFsaXplKHdlYlNldHRpbmdzLT5kYXRhYmFzZVBhdGgoKSk7CisgICAg ICAgIERhdGFiYXNlTWFuYWdlcjo6bWFuYWdlcigpLmluaXRpYWxpemUod2ViU2V0dGluZ3MtPmRh dGFiYXNlUGF0aCgpKTsKICAgICB9CiAKICAgICAvLyBUaGUgZGlyZWN0b3J5IG9mIGNhY2hlU3Rv cmFnZSBmb3Igb25lIHBhZ2UgZ3JvdXAgY2FuIG9ubHkgYmUgaW5pdGlhbGl6ZWQgb25jZS4KQEAg LTU5NTMsOCArNTk1MSw3IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmRpZENoYW5nZVNldHRpbmdz KFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncykKICAgICB9CiAKICAgICBjb3JlU2V0dGluZ3MtPnNl dExvY2FsU3RvcmFnZURhdGFiYXNlUGF0aCh3ZWJTZXR0aW5ncy0+bG9jYWxTdG9yYWdlUGF0aCgp KTsKLSAgICBEYXRhYmFzZTo6c2V0SXNBdmFpbGFibGUod2ViU2V0dGluZ3MtPmlzRGF0YWJhc2Vz RW5hYmxlZCgpKTsKLSAgICBEYXRhYmFzZVN5bmM6OnNldElzQXZhaWxhYmxlKHdlYlNldHRpbmdz LT5pc0RhdGFiYXNlc0VuYWJsZWQoKSk7CisgICAgRGF0YWJhc2VNYW5hZ2VyOjptYW5hZ2VyKCku c2V0SXNBdmFpbGFibGUod2ViU2V0dGluZ3MtPmlzRGF0YWJhc2VzRW5hYmxlZCgpKTsKIAogICAg IGNvcmVTZXR0aW5ncy0+c2V0TG9jYWxTdG9yYWdlRW5hYmxlZCh3ZWJTZXR0aW5ncy0+aXNMb2Nh bFN0b3JhZ2VFbmFibGVkKCkpOwogICAgIGNvcmVTZXR0aW5ncy0+c2V0T2ZmbGluZVdlYkFwcGxp Y2F0aW9uQ2FjaGVFbmFibGVkKHdlYlNldHRpbmdzLT5pc0FwcENhY2hlRW5hYmxlZCgpKTsKQEAg LTYyMjEsNyArNjIxOCw3IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnBvc3Rwb25lRG9jdW1lbnRT dHlsZVJlY2FsYygpCiAgICAgICAgIG1fZG9jdW1lbnRDaGlsZE5lZWRzU3R5bGVSZWNhbGMgPSBk b2N1bWVudC0+Y2hpbGROZWVkc1N0eWxlUmVjYWxjKCk7CiAgICAgICAgIGRvY3VtZW50LT5jbGVh ckNoaWxkTmVlZHNTdHlsZVJlY2FsYygpOwogCi0gICAgICAgIG1fZG9jdW1lbnRTdHlsZVJlY2Fs Y1Bvc3Rwb25lZCA9IGRvY3VtZW50LT5pc1BlbmRpbmdTdHlsZVJlY2FsYygpOworICAgICAgICBt X2RvY3VtZW50U3R5bGVSZWNhbGNQb3N0cG9uZWQgPSBkb2N1bWVudC0+aGFzUGVuZGluZ1N0eWxl UmVjYWxjKCk7CiAgICAgICAgIGRvY3VtZW50LT51bnNjaGVkdWxlU3R5bGVSZWNhbGMoKTsKICAg ICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA4NTU2YThkLi5iYWM2MzE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0w Mi0yMSAgQWxiZXJ0byBHYXJjaWEgIDxhbGJnYXJjaWFAcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gTWlzYyBidWlsZCBmaXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpleGVjdXRlSmF2YVNjcmlwdCk6CisgICAgICAgIFdl YlN0cmluZyB3YXMgcmVwbGFjZWQgd2l0aCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nIGlu IHIxMzEzMTYuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpk aWRDaGFuZ2VTZXR0aW5ncyk6CisgICAgICAgIFNvbWUgd2ViZGF0YWJhc2UgQVBJcyBhcmUgZW5j YXB1c2xhdGVkIGluIERhdGFiYXNlTWFuYWdlciBzaW5jZSByMTM3NTIwLgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6cG9zdHBvbmVEb2N1bWVudFN0eWxlUmVj YWxjKToKKyAgICAgICAgRG9jdW1lbnQ6OmlzUGVuZGluZ1N0eWxlUmVjYWxjKCkgd2FzIHJlbmFt ZWQgdG8gaGFzUGVuZGluZ1N0eWxlUmVjYWxjKCkgaW4gcjEyOTg0NC4KKyAgICAgICAgKiBXZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OklucHV0SGFuZGxlcjo6dXBkYXRlRm9ybVN0YXRlKToKKyAgICAgICAgQWRkIGNsb3NpbmcgYnJh Y2UgdGhhdCB3YXMgbWlzc2luZyBpbiByMTQyNDgyLgorCiAyMDEzLTAyLTIwICBOaW1hIEdoYW5h dmF0aWFuICA8bmdoYW5hdmF0aWFuQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIENo ZWNrIG9mZnNldCBmb3IgaW5pdGlhbGl6ZWQgdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDQ2N2Iw NGEuLjk2MjY2MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtOTYxLDYgKzk2MSw3IEBAIHZvaWQgSW5w dXRIYW5kbGVyOjp1cGRhdGVGb3JtU3RhdGUoKQogICAgIGlmICghbV9uZXh0Rm9jdXNhYmxlVGV4 dEVsZW1lbnQgJiYgIW1fcHJldmlvdXNGb2N1c2FibGVUZXh0RWxlbWVudCkgewogICAgICAgICBt X2hhc1N1Ym1pdEJ1dHRvbiA9IGZhbHNlOwogICAgICAgICBJbnB1dExvZyhQbGF0Zm9ybTo6TG9n TGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjp1cGRhdGVGb3JtU3RhdGUgbm8gdmFsaWQgZWxlbWVu dHMgZm91bmQsIGNsZWFyaW5nIHN0YXRlLiIpOworICAgIH0KIH0KIAogdm9pZCBJbnB1dEhhbmRs ZXI6OmZvY3VzTmV4dEZpZWxkKCkK