110437 2013-02-21 01:08:32 -0800 [BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp 2013-02-21 07:35:11 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 838204 0 cgarcia 2013-02-21 01:08:32 -0800 It receives two arguments, and only one is passed. 838240 1 189484 cgarcia 2013-02-21 02:07:59 -0800 Created attachment 189484 Patch 838410 2 189484 webkit.review.bot 2013-02-21 07:35:07 -0800 Comment on attachment 189484 Patch Clearing flags on attachment: 189484 Committed r143599: <http://trac.webkit.org/changeset/143599> 838411 3 webkit.review.bot 2013-02-21 07:35:11 -0800 All reviewed patches have been landed. Closing bug. 189484 2013-02-21 02:07:59 -0800 2013-02-21 07:35:07 -0800 Patch compile-assert.diff text/plain 4272 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViS2l0VGV4dENvZGVj LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViS2l0VGV4dENvZGVjLmNwcApp bmRleCA4MjY5YzkyLi40MzRiMzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYktpdFRleHRDb2RlYy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJLaXRUZXh0Q29kZWMuY3BwCkBAIC0zMyw2ICszMywxNyBAQCB1c2luZyBXZWJDb3Jl OjpUZXh0Q29kZWNJQ1U7CiBuYW1lc3BhY2UgQmxhY2tCZXJyeSB7CiBuYW1lc3BhY2UgV2ViS2l0 IHsKIAorI2RlZmluZSBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKHdlYmtpdE5hbWUsIHd0 Zk5hbWUpIFwKKyAgICBDT01QSUxFX0FTU0VSVChzdGF0aWNfY2FzdDxpbnQ+KHdlYmtpdE5hbWUp ID09IHN0YXRpY19jYXN0PGludD4oV1RGOjp3dGZOYW1lKSwgbWlzbWF0Y2hpbmdFbnVtcykKKwor Q09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVy LCBCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyKTsKK0NPTVBJTEVfQVNTRVJUX01BVENISU5H X0VOVU0oQmFzZTY0SWdub3JlV2hpdGVzcGFjZSwgQmFzZTY0SWdub3JlV2hpdGVzcGFjZSk7CitD T01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKEJhc2U2NElnbm9yZUludmFsaWRDaGFyYWN0ZXJz LCBCYXNlNjRJZ25vcmVJbnZhbGlkQ2hhcmFjdGVycyk7CisKKy8vIEZJWE1FOiBCYXNlNjRJbnNl cnRDUkxGIHNob3VsZCBiZSBCYXNlNjRJbnNlcnRMRnMuIFdURjo6ZW5jb2RlQmFzZTY0IGRvZXNu J3QgaW5zZXJ0IENSLgorQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShCYXNlNjREb05vdElu c2VydENSTEYsIEJhc2U2NERvTm90SW5zZXJ0TEZzKTsKK0NPTVBJTEVfQVNTRVJUX01BVENISU5H X0VOVU0oQmFzZTY0SW5zZXJ0Q1JMRiwgQmFzZTY0SW5zZXJ0TEZzKTsKKwogYm9vbCBpc1NhbWVF bmNvZGluZyhjb25zdCBjaGFyKiBlbmNvZGluZzEsIGNvbnN0IGNoYXIqIGVuY29kaW5nMikKIHsK ICAgICByZXR1cm4gVGV4dEVuY29kaW5nKGVuY29kaW5nMSkgPT0gVGV4dEVuY29kaW5nKGVuY29k aW5nMik7CkBAIC04NSw0MCArOTYsMjQgQEAgVHJhbnNjb2RlUmVzdWx0IHRyYW5zY29kZShjb25z dCBjaGFyKiBzb3VyY2VFbmNvZGluZywgY29uc3QgY2hhciogdGFyZ2V0RW5jb2RpbmcKICAgICBy ZXR1cm4gU3VjY2VzczsKIH0KIAotV1RGOjpCYXNlNjREZWNvZGVQb2xpY3kgYmFzZTY0RGVjb2Rl UG9saWN5Rm9yV1RGKEJhc2U2NERlY29kZVBvbGljeSBwb2xpY3kpCi17Ci0gICAgQ09NUElMRV9B U1NFUlQoV1RGOjpCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyID09IHN0YXRpY19jYXN0PFdU Rjo6QmFzZTY0RGVjb2RlUG9saWN5PihCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyKSk7Ci0g ICAgQ09NUElMRV9BU1NFUlQoV1RGOjpCYXNlNjRJZ25vcmVXaGl0ZXNwYWNlID09IHN0YXRpY19j YXN0PFdURjo6QmFzZTY0RGVjb2RlUG9saWN5PihCYXNlNjRJZ25vcmVXaGl0ZXNwYWNlKSk7Ci0g ICAgQ09NUElMRV9BU1NFUlQoV1RGOjpCYXNlNjRJZ25vcmVJbnZhbGlkQ2hhcmFjdGVycyA9PSBz dGF0aWNfY2FzdDxXVEY6OkJhc2U2NERlY29kZVBvbGljeT4oQmFzZTY0SWdub3JlSW52YWxpZENo YXJhY3RlcnMpKTsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8V1RGOjpCYXNlNjREZWNvZGVQb2xp Y3k+KHBvbGljeSk7Ci19Ci0KIGJvb2wgYmFzZTY0RGVjb2RlKGNvbnN0IEJsYWNrQmVycnk6OlBs YXRmb3JtOjpTdHJpbmcmIGJhc2U2NCwgc3RkOjp2ZWN0b3I8Y2hhcj4mIGJpbmFyeSwgQmFzZTY0 RGVjb2RlUG9saWN5IHBvbGljeSkKIHsKICAgICBWZWN0b3I8Y2hhcj4gcmVzdWx0OwotICAgIGlm ICghV1RGOjpiYXNlNjREZWNvZGUoYmFzZTY0LmNfc3RyKCksIGJhc2U2NC5sZW5ndGgoKSwgcmVz dWx0LCBiYXNlNjREZWNvZGVQb2xpY3lGb3JXVEYocG9saWN5KSkpCisgICAgaWYgKCFXVEY6OmJh c2U2NERlY29kZShiYXNlNjQuY19zdHIoKSwgYmFzZTY0Lmxlbmd0aCgpLCByZXN1bHQsIHN0YXRp Y19jYXN0PFdURjo6QmFzZTY0RGVjb2RlUG9saWN5Pihwb2xpY3kpKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgYmluYXJ5Lmluc2VydChiaW5hcnkuYmVnaW4oKSwgcmVzdWx0LmJlZ2lu KCksIHJlc3VsdC5lbmQoKSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLVdURjo6QmFzZTY0RGVj b2RlUG9saWN5IGJhc2U2NEVuY29kZVBvbGljeUZvcldURihCYXNlNjRFbmNvZGVQb2xpY3kgcG9s aWN5KQotewotICAgIC8vIEZJWE1FOiBCYXNlNjRJbnNlcnRDUkxGIHNob3VsZCBiZSBCYXNlNjRJ bnNlcnRMRnMuIFdURjo6ZW5jb2RlQmFzZTY0IGRvZXNuJ3QgaW5zZXJ0IENSLgotICAgIENPTVBJ TEVfQVNTRVJUKFdURjo6QmFzZTY0RG9Ob3RJbnNlcnRMRnMgPT0gc3RhdGljX2Nhc3Q8V1RGOjpC YXNlNjRFbmNvZGVQb2xpY3k+KEJhc2U2NERvTm90SW5zZXJ0Q1JMRikpOwotICAgIENPTVBJTEVf QVNTRVJUKFdURjo6QmFzZTY0SW5zZXJ0TEZzID09IHN0YXRpY19jYXN0PFdURjo6QmFzZTY0RW5j b2RlUG9saWN5PihCYXNlNjRJbnNlcnRDUkxGKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PFdU Rjo6QmFzZTY0RW5jb2RlUG9saWN5Pihwb2xpY3kpOwotfQotCiBib29sIGJhc2U2NEVuY29kZShj b25zdCBzdGQ6OnZlY3RvcjxjaGFyPiYgYmluYXJ5LCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3Ry aW5nJiBiYXNlNjQsIEJhc2U2NEVuY29kZVBvbGljeSBwb2xpY3kpCiB7CiAgICAgVmVjdG9yPGNo YXI+IHJlc3VsdDsKICAgICByZXN1bHQuYXBwZW5kKCZiaW5hcnlbMF0sIGJpbmFyeS5zaXplKCkp OwogCi0gICAgV1RGOjpiYXNlNjRFbmNvZGUoJmJpbmFyeVswXSwgYmluYXJ5LnNpemUoKSwgcmVz dWx0LCBiYXNlNjRFbmNvZGVQb2xpY3lGb3JXVEYocG9saWN5KSk7CisgICAgV1RGOjpiYXNlNjRF bmNvZGUoJmJpbmFyeVswXSwgYmluYXJ5LnNpemUoKSwgcmVzdWx0LCBzdGF0aWNfY2FzdDxXVEY6 OkJhc2U2NEVuY29kZVBvbGljeT4ocG9saWN5KSk7CiAKLSAgICBiYXNlNjQgPSBCbGFja2JlcnJ5 OjpQbGF0Zm9ybTo6U3RyaW5nKCZyZXN1bHRbMF0sIHJlc3VsdC5zaXplKCkpOworICAgIGJhc2U2 NCA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcoJnJlc3VsdFswXSwgcmVzdWx0LnNpemUo KSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmlu ZGV4IDg1NTZhOGQuLjJjMjBiYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDEzLTAyLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNhcmdhcmNp YUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBJbnZhbGlkIHVzZSBvZiBDT01QSUxF X0FTU0VSVCBtYWNybyBpbiBXZWJLaXRUZXh0Q29kZWMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0MzcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFwaS9XZWJLaXRUZXh0Q29kZWMuY3BwOgor ICAgICAgICAoV2ViS2l0KTogRGVmaW5lIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oKSBt YWNybyBhbmQgdXNlIGl0IHRvCisgICAgICAgIGNoZWNrIGVudW0gdmFsdWVzIG1hdGNoIGJldHdl ZW4gV2ViS2l0IGFuZCBXVEYuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OmJhc2U2NERl Y29kZSk6IFVzZSBhIHN0YXRpYyBjYXN0IGRpcmVjdGx5IHRvCisgICAgICAgIGNvbnZlcnQgZnJv bSBXZWJLaXQgQmFzZTY0RGVjb2RlUG9saWN5IHRvIFdURi4KKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6YmFzZTY0RW5jb2RlKTogVXNlIGEgc3RhdGljIGNhc3QgZGlyZWN0bHkgdG8KKyAg ICAgICAgY29udmVydCBmcm9tIFdlYktpdCBCYXNlNjRFbmNvZGVQb2xpY3kgdG8gV1RGLgorCiAy MDEzLTAyLTIwICBOaW1hIEdoYW5hdmF0aWFuICA8bmdoYW5hdmF0aWFuQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIENoZWNrIG9mZnNldCBmb3IgaW5pdGlhbGl6ZWQgdmFsdWUK