<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110424</bug_id>
          
          <creation_ts>2013-02-20 18:37:47 -0800</creation_ts>
          <short_desc>Web Inspector: Cannot deep expand an element that has previously been partially expanded</short_desc>
          <delta_ts>2013-02-26 08:00:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>apavlov</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>timothy</cc>
    
    <cc>vsevik</cc>
    
    <cc>web-inspector-bugs</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>838056</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-20 18:37:47 -0800</bug_when>
    <thetext>While we added support for true deep-expansion with https://bugs.webkit.org/show_bug.cgi?id=66868, there is (at least) one case where this fails.  In InspectorDOMAgent::pushChildNodesToFrontend(), if we find that we&apos;d already requested children for the given node, we return early:

    if (m_childrenRequested.contains(nodeId))
        return;

This could easily happen for the &lt;body&gt; or &lt;html&gt; elements, or basically any element that you inspect directly to open the inspector.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>838057</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2013-02-20 18:38:26 -0800</bug_when>
    <thetext>&lt;rdar://problem/13260224&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>838071</commentid>
    <comment_count>2</comment_count>
      <attachid>189445</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-20 18:56:44 -0800</bug_when>
    <thetext>Created attachment 189445
Work-in-progress patch, no tests yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>838157</commentid>
    <comment_count>3</comment_count>
      <attachid>189445</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2013-02-20 22:44:29 -0800</bug_when>
    <thetext>Comment on attachment 189445
Work-in-progress patch, no tests yet.

View in context: https://bugs.webkit.org/attachment.cgi?id=189445&amp;action=review

&gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:453
&gt; +        node = node-&gt;firstChild();

for (node = innerFirstChild(node); node; node = innerNextSibling(node)) {
...

&gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:455
&gt; +            nodeId = m_documentNodeToIdMap.get(node);

Dangling nodes (the ones printed with console.log(document)) will end up with nodes being a part of another NodeToIdMap instance. m_idToNodesMap knows which map to use.

Please do not reuse nodeId, this one is about child node. childNodeId

&gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:456
&gt; +            if (nodeId)

Should be an assertion. We know that m_childrenRequested.contains(nodeId). Hence we&apos;ve sent its children.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841640</commentid>
    <comment_count>4</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-25 22:22:31 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 189445 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=189445&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:455
&gt; &gt; +            nodeId = m_documentNodeToIdMap.get(node);
&gt; 
&gt; Dangling nodes (the ones printed with console.log(document)) will end up with nodes being a part of another NodeToIdMap instance. m_idToNodesMap knows which map to use.

Should I simply move the `NodeToIdMap* nodeMap = m_idToNodesMap.get(nodeId);` call to before I enter the `m_childrenRequested.contains(nodeId)` condition and used this nodeMap to get the childNodeId?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841671</commentid>
    <comment_count>5</comment_count>
      <attachid>190216</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-25 23:14:33 -0800</bug_when>
    <thetext>Created attachment 190216
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841712</commentid>
    <comment_count>6</comment_count>
      <attachid>190216</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2013-02-26 00:36:14 -0800</bug_when>
    <thetext>Comment on attachment 190216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190216&amp;action=review

&gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:457
&gt; +            childNodeId = nodeMap-&gt;get(node);

you never use childNodeId outside for scope - declare it inline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>842002</commentid>
    <comment_count>7</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-26 08:00:12 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 190216 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=190216&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:457
&gt; &gt; +            childNodeId = nodeMap-&gt;get(node);
&gt; 
&gt; you never use childNodeId outside for scope - declare it inline.

Made the change in commit. Thanks for the review Pavel.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>842003</commentid>
    <comment_count>8</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2013-02-26 08:00:34 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/144057.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>189445</attachid>
            <date>2013-02-20 18:56:44 -0800</date>
            <delta_ts>2013-02-25 23:14:25 -0800</delta_ts>
            <desc>Work-in-progress patch, no tests yet.</desc>
            <filename>110424.diff</filename>
            <type>text/plain</type>
            <size>1165</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4
IDY0OGY4ZDAuLjIxZGQ3ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J
bnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl
Y3RvckRPTUFnZW50LmNwcApAQCAtNDQ0LDggKzQ0NCwyMSBAQCB2b2lkIEluc3BlY3RvckRPTUFn
ZW50OjpwdXNoQ2hpbGROb2Rlc1RvRnJvbnRlbmQoaW50IG5vZGVJZCwgaW50IGRlcHRoKQogICAg
IE5vZGUqIG5vZGUgPSBub2RlRm9ySWQobm9kZUlkKTsKICAgICBpZiAoIW5vZGUgfHwgKG5vZGUt
Pm5vZGVUeXBlKCkgIT0gTm9kZTo6RUxFTUVOVF9OT0RFICYmIG5vZGUtPm5vZGVUeXBlKCkgIT0g
Tm9kZTo6RE9DVU1FTlRfTk9ERSAmJiBub2RlLT5ub2RlVHlwZSgpICE9IE5vZGU6OkRPQ1VNRU5U
X0ZSQUdNRU5UX05PREUpKQogICAgICAgICByZXR1cm47Ci0gICAgaWYgKG1fY2hpbGRyZW5SZXF1
ZXN0ZWQuY29udGFpbnMobm9kZUlkKSkKKyAgICBpZiAobV9jaGlsZHJlblJlcXVlc3RlZC5jb250
YWlucyhub2RlSWQpKSB7CisgICAgICAgIGlmIChkZXB0aCA8PSAxKQorICAgICAgICAgICAgcmV0
dXJuOworCisgICAgICAgIGRlcHRoLS07CisKKyAgICAgICAgbm9kZSA9IG5vZGUtPmZpcnN0Q2hp
bGQoKTsKKyAgICAgICAgd2hpbGUgKG5vZGUpIHsKKyAgICAgICAgICAgIG5vZGVJZCA9IG1fZG9j
dW1lbnROb2RlVG9JZE1hcC5nZXQobm9kZSk7CisgICAgICAgICAgICBpZiAobm9kZUlkKQorICAg
ICAgICAgICAgICAgIHB1c2hDaGlsZE5vZGVzVG9Gcm9udGVuZChub2RlSWQsIGRlcHRoKTsKKyAg
ICAgICAgICAgIG5vZGUgPSBub2RlLT5uZXh0U2libGluZygpOworICAgICAgICB9CiAgICAgICAg
IHJldHVybjsKKyAgICB9CiAKICAgICBOb2RlVG9JZE1hcCogbm9kZU1hcCA9IG1faWRUb05vZGVz
TWFwLmdldChub2RlSWQpOwogICAgIFJlZlB0cjxUeXBlQnVpbGRlcjo6QXJyYXk8VHlwZUJ1aWxk
ZXI6OkRPTTo6Tm9kZT4gPiBjaGlsZHJlbiA9IGJ1aWxkQXJyYXlGb3JDb250YWluZXJDaGlsZHJl
bihub2RlLCBkZXB0aCwgbm9kZU1hcCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190216</attachid>
            <date>2013-02-25 23:14:33 -0800</date>
            <delta_ts>2013-02-26 00:36:13 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-110424-20130225231051.patch</filename>
            <type>text/plain</type>
            <size>7507</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMzMGQ0MTU5M2M1NTAw
ODhmMTYwNDYyYzVjYmViYjc3ZTVjOWQwNS4uMTY1YzFkZjg2NjRmOTNjZmZhZWViN2U4YTNkOGU5
MDNhZGM3OTUxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI1ICBBbnRv
aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog
Q2Fubm90IGRlZXAgZXhwYW5kIGFuIGVsZW1lbnQgdGhhdCBoYXMgcHJldmlvdXNseSBiZWVuIHBh
cnRpYWxseSBleHBhbmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTEwNDI0CisKKyAgICAgICAgSW4gdGhlIGNhc2Ugd2hlcmUgdGhlIGNoaWxkcmVu
IGZyb20gdGhlIHByb3ZpZGVkIG5vZGUgaGF2ZSBhbHJlYWR5IGJlZW4gcHVzaGVkLCB0cmF2ZXJz
ZQorICAgICAgICBjaGlsZHJlbiBhdCB0aGUgZGVwdGggcHJvdmlkZWQgdW50aWwgd2UgZmluZCBj
aGlsZHJlbiB0aGF0IGhhdmUgbm90IGJlZW4gcHVzaGVkIHlldC4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01B
Z2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6cHVzaENoaWxk
Tm9kZXNUb0Zyb250ZW5kKToKKwogMjAxMy0wMi0yNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBs
ZS5jb20+CiAKICAgICAgICAgQ2hhbmdlZCBEYXRhYmFzZVRyYWNrZXI6OmdldE1heFNpemVGb3JE
YXRhYmFzZSgpIHRvIHJldHVybiB0aGUgcHJldmlvdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw
ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IGRmYTcwY2E4OWVkNDJjNzk2ZDI4MmRm
M2JmNmJjNDEzNzJkOTc3ZjUuLjc1MmM3YmRkYmZlODZhYjEzYjYxMmNjYzc3NDZiN2ViZmEzNWIy
OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2Vu
dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNw
cApAQCAtNDQzLDEwICs0NDMsMjUgQEAgdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6cHVzaENoaWxk
Tm9kZXNUb0Zyb250ZW5kKGludCBub2RlSWQsIGludCBkZXB0aCkKICAgICBOb2RlKiBub2RlID0g
bm9kZUZvcklkKG5vZGVJZCk7CiAgICAgaWYgKCFub2RlIHx8IChub2RlLT5ub2RlVHlwZSgpICE9
IE5vZGU6OkVMRU1FTlRfTk9ERSAmJiBub2RlLT5ub2RlVHlwZSgpICE9IE5vZGU6OkRPQ1VNRU5U
X05PREUgJiYgbm9kZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpET0NVTUVOVF9GUkFHTUVOVF9OT0RF
KSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmIChtX2NoaWxkcmVuUmVxdWVzdGVkLmNvbnRhaW5z
KG5vZGVJZCkpCi0gICAgICAgIHJldHVybjsKIAogICAgIE5vZGVUb0lkTWFwKiBub2RlTWFwID0g
bV9pZFRvTm9kZXNNYXAuZ2V0KG5vZGVJZCk7CisKKyAgICBpZiAobV9jaGlsZHJlblJlcXVlc3Rl
ZC5jb250YWlucyhub2RlSWQpKSB7CisgICAgICAgIGlmIChkZXB0aCA8PSAxKQorICAgICAgICAg
ICAgcmV0dXJuOworCisgICAgICAgIGRlcHRoLS07CisKKyAgICAgICAgaW50IGNoaWxkTm9kZUlk
OworICAgICAgICBmb3IgKG5vZGUgPSBpbm5lckZpcnN0Q2hpbGQobm9kZSk7IG5vZGU7IG5vZGUg
PSBpbm5lck5leHRTaWJsaW5nKG5vZGUpKSB7CisgICAgICAgICAgICBjaGlsZE5vZGVJZCA9IG5v
ZGVNYXAtPmdldChub2RlKTsKKyAgICAgICAgICAgIEFTU0VSVChjaGlsZE5vZGVJZCk7CisgICAg
ICAgICAgICBwdXNoQ2hpbGROb2Rlc1RvRnJvbnRlbmQoY2hpbGROb2RlSWQsIGRlcHRoKTsKKyAg
ICAgICAgfQorCisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBSZWZQdHI8VHlwZUJ1aWxk
ZXI6OkFycmF5PFR5cGVCdWlsZGVyOjpET006Ok5vZGU+ID4gY2hpbGRyZW4gPSBidWlsZEFycmF5
Rm9yQ29udGFpbmVyQ2hpbGRyZW4obm9kZSwgZGVwdGgsIG5vZGVNYXApOwogICAgIG1fZnJvbnRl
bmQtPnNldENoaWxkTm9kZXMobm9kZUlkLCBjaGlsZHJlbi5yZWxlYXNlKCkpOwogfQpkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4
IDY0ODY3NGEwYTRhYTFkMGE1NzJlNjZjNDVlNGE0ZTBmOTlhNDNkYTAuLjBkYzg3M2ExZmRjMTA4
MjUxZGZmMGRhMmM1MTQ4ZDQ3MWQ5NTUyYWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0w
Mi0yNSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJ
bnNwZWN0b3I6IENhbm5vdCBkZWVwIGV4cGFuZCBhbiBlbGVtZW50IHRoYXQgaGFzIHByZXZpb3Vz
bHkgYmVlbiBwYXJ0aWFsbHkgZXhwYW5kZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTExMDQyNAorCisgICAgICAgIFVwZGF0ZSBleGlzdGluZyB0ZXN0
IGZvciBJbnNwZWN0b3JET01BZ2VudDo6cmVxdWVzdENoaWxkTm9kZXMgdG8gY292ZXIgdGhlIGNh
c2UKKyAgICAgICAgd2hlcmUgd2Ugd2FudCB0byByZXF1ZXN0IGNoaWxkcmVuIGZvciBhIG5vZGUg
dGhhdCBhbHJlYWR5IGhhcyBoYWQgY2hpbGRyZW4gcHVzaGVkCisgICAgICAgIGJ1dCBtYXkgbm90
IGhhdmUgcHVzaGVkIGNoaWxkcmVuIGF0IHRoZSBkZXB0aCByZXF1ZXN0ZWQuCisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3ItcHJvdG9j
b2wvZG9tLXJlcXVlc3QtY2hpbGQtbm9kZXMtZGVwdGgtZXhwZWN0ZWQudHh0OgorICAgICAgICAq
IGluc3BlY3Rvci1wcm90b2NvbC9kb20tcmVxdWVzdC1jaGlsZC1ub2Rlcy1kZXB0aC5odG1sOgor
CiAyMDEzLTAyLTI1ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgdHJhbnNpdGlvbi1wcm9wZXJ0eSBwcm9wZXJ0eSBkb2Vzbid0IGFjY2VwdCAiYWxsLCA8SURF
TlQ+Ii4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20tcmVx
dWVzdC1jaGlsZC1ub2Rlcy1kZXB0aC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0
b3ItcHJvdG9jb2wvZG9tLXJlcXVlc3QtY2hpbGQtbm9kZXMtZGVwdGgtZXhwZWN0ZWQudHh0Cmlu
ZGV4IDE3NmY3NGU5ZmIzODBiMmY2ZTcxNjMzZDFhNTlhNGE4NzhjYjA3MDkuLjc5NDQ2MzBjYzBh
NWFlMDgyMzliY2Y3YTIzZmVjNTIzMjY5MDFkMDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lu
c3BlY3Rvci1wcm90b2NvbC9kb20tcmVxdWVzdC1jaGlsZC1ub2Rlcy1kZXB0aC1leHBlY3RlZC50
eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS1yZXF1ZXN0LWNoaWxk
LW5vZGVzLWRlcHRoLWV4cGVjdGVkLnR4dApAQCAtOSw3ICs5LDExIEBAIFBBU1M6IEZpcnN0IGNo
aWxkIGlzIGRpdiNkZXB0aC0xCiBQQVNTOiBGaXJzdCBjaGlsZCBoYXMgb25lIGNoaWxkCiBQQVNT
OiBGaXJzdCBjaGlsZCBoYXMgbm8gLmNoaWxkcmVuIHByb3BlcnR5CiAKLT09PSBHZXQgYWxsIGNo
aWxkcmVuIG9mIGRpdiNkZXB0aC0xID09PQorPT09IEdldCBjaGlsZHJlbiBvZiBkaXYjZGVwdGgt
MSB0aHJlZSBsZXZlbHMgZGVlcCA9PT0KKworUEFTUzogZGl2I2RlcHRoLTEgaGFzIG5vZGVzIDMg
bGV2ZWxzIGRlZXAKKworPT09IEdldCBhbGwgY2hpbGRyZW4gb2YgYm9keSA9PT0KIAogUEFTUzog
ZGl2I2RlcHRoLTEgaGFzIG5vZGVzIDkgbGV2ZWxzIGRlZXAKIApkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS1yZXF1ZXN0LWNoaWxkLW5vZGVzLWRlcHRoLmh0
bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZG9tLXJlcXVlc3QtY2hpbGQtbm9k
ZXMtZGVwdGguaHRtbAppbmRleCBkZmEzMzMxODY4ODQ1N2NmMTNlZTUyZTkyYTZhYzE4ODg0YzEx
MzY5Li43MmJjNWMxMzE4NGQzZTE3OGRiYzVhNDczYTllZDliMWNjY2IyZGEyIDEwMDY0NAotLS0g
YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZG9tLXJlcXVlc3QtY2hpbGQtbm9kZXMt
ZGVwdGguaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZG9tLXJlcXVl
c3QtY2hpbGQtbm9kZXMtZGVwdGguaHRtbApAQCAtNSw3ICs1LDcgQEAKIAogZnVuY3Rpb24gdGVz
dCgpCiB7Ci0KKyAgICB2YXIgZmlyc3REaXY7CiAgICAgdmFyIGV2ZW50c0NvdW50ID0gMDsKIAog
ICAgIGdldERvY3VtZW50KCk7CkBAIC0xNyw3ICsxNywxMSBAQCBmdW5jdGlvbiB0ZXN0KCkKICAg
ICAgICAgaWYgKGV2ZW50c0NvdW50ID09PSAxKQogICAgICAgICAgICAgZ290SW1tZWRpYXRlQ2hp
bGRyZW4obWVzc2FnZU9iamVjdCk7CiAgICAgICAgIGVsc2UgaWYgKGV2ZW50c0NvdW50ID09PSAy
KQorICAgICAgICAgICAgZ290QWRkaXRpb25hbENoaWxkcmVuKG1lc3NhZ2VPYmplY3QpOworICAg
ICAgICBlbHNlIGlmIChldmVudHNDb3VudCA9PT0gMykKICAgICAgICAgICAgIGdvdEFsbENoaWxk
cmVuKG1lc3NhZ2VPYmplY3QpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBJbnNwZWN0b3JU
ZXN0LmxvZyhKU09OLnN0cmluZ2lmeShtZXNzYWdlT2JqZWN0LCBudWxsLCAiICAgICIpKTsKICAg
ICB9OwogICAgIAogICAgIGZ1bmN0aW9uIGdldERvY3VtZW50KCkKQEAgLTQzLDE2ICs0NywzNSBA
QCBmdW5jdGlvbiB0ZXN0KCkKIAogICAgIGZ1bmN0aW9uIGdvdEltbWVkaWF0ZUNoaWxkcmVuKG1l
c3NhZ2VPYmplY3QpCiAgICAgeworICAgICAgICBmaXJzdERpdiA9IG1lc3NhZ2VPYmplY3QucGFy
YW1zLm5vZGVzWzBdOworICAgICAgICBhc3NlcnQoIkZpcnN0IGNoaWxkIGlzIGEgZGl2IiwgZmly
c3REaXYubG9jYWxOYW1lLCAiZGl2Iik7CisgICAgICAgIGFzc2VydCgiRmlyc3QgY2hpbGQgaXMg
ZGl2I2RlcHRoLTEiLCBmaXJzdERpdi5hdHRyaWJ1dGVzWzFdLCAiZGVwdGgtMSIpOworICAgICAg
ICBhc3NlcnQoIkZpcnN0IGNoaWxkIGhhcyBvbmUgY2hpbGQiLCBmaXJzdERpdi5jaGlsZE5vZGVD
b3VudCwgMSk7CisgICAgICAgIGFzc2VydCgiRmlyc3QgY2hpbGQgaGFzIG5vIC5jaGlsZHJlbiBw
cm9wZXJ0eSIsIGZpcnN0RGl2LmNoaWxkcmVuLCB1bmRlZmluZWQpOworCisgICAgICAgIHN0ZXAo
eworICAgICAgICAgICAgbmFtZTogIkdldCBjaGlsZHJlbiBvZiBkaXYjZGVwdGgtMSB0aHJlZSBs
ZXZlbHMgZGVlcCIsCisgICAgICAgICAgICBjb21tYW5kOiAiRE9NLnJlcXVlc3RDaGlsZE5vZGVz
IiwKKyAgICAgICAgICAgIHBhcmFtZXRlcnM6IHsibm9kZUlkIjogZmlyc3REaXYubm9kZUlkLCAi
ZGVwdGgiOiAzfQorICAgICAgICB9KTsKKyAgICB9OworCisgICAgZnVuY3Rpb24gZ290QWRkaXRp
b25hbENoaWxkcmVuKG1lc3NhZ2VPYmplY3QpCisgICAgeworICAgICAgICB2YXIgZGVwdGggPSAx
OwogICAgICAgICB2YXIgZmlyc3RDaGlsZCA9IG1lc3NhZ2VPYmplY3QucGFyYW1zLm5vZGVzWzBd
OwotICAgICAgICBhc3NlcnQoIkZpcnN0IGNoaWxkIGlzIGEgZGl2IiwgZmlyc3RDaGlsZC5sb2Nh
bE5hbWUsICJkaXYiKTsKLSAgICAgICAgYXNzZXJ0KCJGaXJzdCBjaGlsZCBpcyBkaXYjZGVwdGgt
MSIsIGZpcnN0Q2hpbGQuYXR0cmlidXRlc1sxXSwgImRlcHRoLTEiKTsKLSAgICAgICAgYXNzZXJ0
KCJGaXJzdCBjaGlsZCBoYXMgb25lIGNoaWxkIiwgZmlyc3RDaGlsZC5jaGlsZE5vZGVDb3VudCwg
MSk7Ci0gICAgICAgIGFzc2VydCgiRmlyc3QgY2hpbGQgaGFzIG5vIC5jaGlsZHJlbiBwcm9wZXJ0
eSIsIGZpcnN0Q2hpbGQuY2hpbGRyZW4sIHVuZGVmaW5lZCk7CisgICAgICAgIHZhciBub2RlID0g
Zmlyc3RDaGlsZDsKKyAgICAgICAgd2hpbGUgKG5vZGUgJiYgbm9kZS5jaGlsZHJlbikgeworICAg
ICAgICAgICAgZGVwdGgrKzsKKyAgICAgICAgICAgIG5vZGUgPSBub2RlLmNoaWxkcmVuWzBdOwor
ICAgICAgICB9CisKKyAgICAgICAgYXNzZXJ0KCJkaXYjZGVwdGgtMSBoYXMgbm9kZXMgMyBsZXZl
bHMgZGVlcCIsIGRlcHRoLCAzKTsKIAogICAgICAgICBzdGVwKHsKLSAgICAgICAgICAgIG5hbWU6
ICJHZXQgYWxsIGNoaWxkcmVuIG9mIGRpdiNkZXB0aC0xIiwKKyAgICAgICAgICAgIG5hbWU6ICJH
ZXQgYWxsIGNoaWxkcmVuIG9mIGJvZHkiLAogICAgICAgICAgICAgY29tbWFuZDogIkRPTS5yZXF1
ZXN0Q2hpbGROb2RlcyIsCi0gICAgICAgICAgICBwYXJhbWV0ZXJzOiB7Im5vZGVJZCI6IGZpcnN0
Q2hpbGQubm9kZUlkLCAiZGVwdGgiOiAtMX0KKyAgICAgICAgICAgIHBhcmFtZXRlcnM6IHsibm9k
ZUlkIjogZmlyc3REaXYubm9kZUlkLCAiZGVwdGgiOiAtMX0KICAgICAgICAgfSk7CiAgICAgfTsK
IApAQCAtNjYsMTkgKzg5LDIxIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgbm9kZSA9
IG5vZGUuY2hpbGRyZW5bMF07CiAgICAgICAgIH0KIAotICAgICAgICBhc3NlcnQoImRpdiNkZXB0
aC0xIGhhcyBub2RlcyA5IGxldmVscyBkZWVwIiwgZGVwdGgsIDkpOworICAgICAgICAvLyBXZSBo
YXZlIHJlcXVlc3RlZCBub2RlcyAzLWxldmVsIGRlZXAgc28gZmFyLCBzbworICAgICAgICAvLyB3
ZSBzaG91bGQgaGF2ZSBnb3R0ZW4gYW4gYWRkaXRpb25hbCA2IGxldmVscyBvZiBkZXB0aC4KKyAg
ICAgICAgYXNzZXJ0KCJkaXYjZGVwdGgtMSBoYXMgbm9kZXMgOSBsZXZlbHMgZGVlcCIsIGRlcHRo
LCA2KTsKIAogICAgICAgICBzdGVwKHsKICAgICAgICAgICAgIG5hbWU6ICJQYXNzIGFuIGludmFs
aWQgZGVwdGgiLAogICAgICAgICAgICAgY29tbWFuZDogIkRPTS5yZXF1ZXN0Q2hpbGROb2RlcyIs
Ci0gICAgICAgICAgICBwYXJhbWV0ZXJzOiB7Im5vZGVJZCI6IGZpcnN0Q2hpbGQubm9kZUlkLCAi
ZGVwdGgiOiAwfSwKKyAgICAgICAgICAgIHBhcmFtZXRlcnM6IHsibm9kZUlkIjogZmlyc3REaXYu
bm9kZUlkLCAiZGVwdGgiOiAwfSwKICAgICAgICAgICAgIGNhbGxiYWNrOiBmaW5pc2hUZXN0CiAg
ICAgICAgIH0pOwogICAgIH07CiAgICAgCiAgICAgZnVuY3Rpb24gZmluaXNoVGVzdCgpCiAgICAg
ewotICAgICAgICBhc3NlcnQoIkV4cGVjdGVkIG51bWJlciBvZiBzZXRDaGlsZE5vZGVzIGV2ZW50
cyIsIGV2ZW50c0NvdW50LCAyKTsKKyAgICAgICAgYXNzZXJ0KCJFeHBlY3RlZCBudW1iZXIgb2Yg
c2V0Q2hpbGROb2RlcyBldmVudHMiLCBldmVudHNDb3VudCwgMyk7CiAgICAgICAgIAogICAgICAg
ICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOwogICAgIH07Cg==
</data>
<flag name="review"
          id="210846"
          type_id="1"
          status="+"
          setter="pfeldman"
    />
          </attachment>
      

    </bug>

</bugzilla>