110421 2013-02-20 17:49:43 -0800 [WinCE] Link error - missing method createDragImageFromImage() 2013-05-10 11:51:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 mark.salisbury webkit-unassigned glenn mark.salisbury paroga oldest_to_newest 838009 0 mark.salisbury 2013-02-20 17:49:43 -0800 I see a link error compiling for WinCE. ClipboardWin.cpp expects to be able to call createDragImageFromImage() but it is not implemented for WinCE (today WinCE does not use Cairo or Core Graphics). 838027 1 189435 mark.salisbury 2013-02-20 18:04:16 -0800 Created attachment 189435 Proposed fix 842093 2 mark.salisbury 2013-02-26 09:31:03 -0800 Thoughts? 870263 3 paroga 2013-04-06 02:30:09 -0700 Committed r147835: <http://trac.webkit.org/changeset/147835> 875421 4 glenn 2013-04-14 17:03:52 -0700 (In reply to comment #3) > Committed r147835: <http://trac.webkit.org/changeset/147835> I notice that this patch was committed without any review. Or if there was a review, it isn't marked anywhere. That's a NO NO! 875422 5 glenn 2013-04-14 17:05:53 -0700 (In reply to comment #4) > (In reply to comment #3) > > Committed r147835: <http://trac.webkit.org/changeset/147835> > > I notice that this patch was committed without any review. Or if there was a review, it isn't marked anywhere. That's a NO NO! That is, either there should be a "Reviewed by" line or an "Unreviewed" line in the ChangeLog. 875846 6 mark.salisbury 2013-04-15 08:24:46 -0700 Glenn - thank you for providing feedback. I'll be sure to create patches that have "Unreviewed", "Reviewed by NOBODY (OOPS!)", or "Reviewed by <intended reviewer>" in the ChangeLog. 887468 7 189435 rwlbuis 2013-05-10 11:51:22 -0700 Comment on attachment 189435 Proposed fix Get out of review queue, patch has landed by now. 189435 2013-02-20 18:04:16 -0800 2013-05-10 11:51:21 -0700 Proposed fix 0005-WinCE-Link-error-missing-method-createDragImageFromI.patch text/plain 1781 mark.salisbury RnJvbSBiM2RhYTliZWY0YjRkODViYTgyNWU5ZWIzNGU2ZWU3ZTVkYWZmMWM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFNhbGlzYnVyeSA8bWFyay5zYWxpc2J1cnlAaHAuY29t PgpEYXRlOiBXZWQsIDIwIEZlYiAyMDEzIDE4OjQ3OjUwIC0wNzAwClN1YmplY3Q6IFtQQVRDSCA1 LzVdIFtXaW5DRV0gTGluayBlcnJvciAtIG1pc3NpbmcgbWV0aG9kCiBjcmVhdGVEcmFnSW1hZ2VG cm9tSW1hZ2UoKQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDQy MQoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8IDkg KysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNwcCB8 IDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDA3YWUzODEuLmZlNjNlNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxMy0wMi0y MCAgTWFyayBTYWxpc2J1cnkgIDxtYXJrLnNhbGlzYnVyeUBocC5jb20+CiAKKyAgICAgICAgW1dp bkNFXSBMaW5rIGVycm9yIC0gbWlzc2luZyBtZXRob2QgY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDQy MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHA6CisKKzIwMTMtMDItMjAgIE1hcmsgU2FsaXNidXJ5 ICA8bWFyay5zYWxpc2J1cnlAaHAuY29tPgorCiAgICAgICAgIFtXaW5DRV0gTGluayBlcnJvcnMg LSBtaXNzaW5nIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiBtZXRob2RzLgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNDE5CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAKaW5kZXggYzJmOTk2NC4uOWVjMDg4MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAKQEAgLTYw NSw4ICs2MDUsMTIgQEAgRHJhZ0ltYWdlUmVmIENsaXBib2FyZFdpbjo6Y3JlYXRlRHJhZ0ltYWdl KEludFBvaW50JiBsb2MpIGNvbnN0CiB7CiAgICAgSEJJVE1BUCByZXN1bHQgPSAwOwogICAgIGlm IChtX2RyYWdJbWFnZSkgeworI2lmIFVTRShDQUlSTykgfHwgVVNFKENHKQogICAgICAgICByZXN1 bHQgPSBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UobV9kcmFnSW1hZ2UtPmltYWdlKCkpOyAgICAg ICAgCiAgICAgICAgIGxvYyA9IG1fZHJhZ0xvYzsKKyNlbHNlCisgICAgICAgIG5vdEltcGxlbWVu dGVkKCk7CisjZW5kaWYKICAgICB9IGVsc2UgaWYgKG1fZHJhZ0ltYWdlRWxlbWVudCkgewogICAg ICAgICBOb2RlKiBub2RlID0gbV9kcmFnSW1hZ2VFbGVtZW50LmdldCgpOwogICAgICAgICByZXN1 bHQgPSBub2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpLT5ub2RlSW1hZ2Uobm9kZSk7Ci0tIAoxLjcu MTEubXN5c2dpdC4xCgo=