110414 2013-02-20 17:26:06 -0800 CMake should not require build target 2013-11-05 08:51:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED DUPLICATE 114243 P2 Normal --- 0 mark.salisbury webkit-unassigned laszlo.gombos mark.salisbury paroga oldest_to_newest 837983 0 mark.salisbury 2013-02-20 17:26:06 -0800 A bug was introduced recently (IMO) that requires a build target (Debug, Release, RelWithDebInfo, MinSizeRelease) to be specified when invoking CMake. If you don't specify a build target, you get an error from the top level CMakeLists.txt file on line 10 because it attempts to convert the build type "tolower". When I run CMake I have it to generate Visual Studio project files, then I open WebKit.sln and build from inside the VS IDE. The change I'd like to see guarded was introduced in http://trac.webkit.org/changeset/140990. 838019 1 189431 mark.salisbury 2013-02-20 17:59:03 -0800 Created attachment 189431 Proposed fix 842086 2 mark.salisbury 2013-02-26 09:29:14 -0800 Am I alone in seeing this issue as a problem? Maybe I wasn't clear in describing the issue? 870275 3 189431 paroga 2013-04-06 04:49:16 -0700 Comment on attachment 189431 Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=189431&action=review > CMakeLists.txt:12 > -string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE) > +if (CMAKE_BUILD_TYPE) > + string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE) > +endif () IMHO we should only remove the TOLOWER and replace "debug" with "Debug" in the other CMake files 889205 4 paroga 2013-05-15 02:11:08 -0700 Redolved with https://trac.webkit.org/changeset/147992 *** This bug has been marked as a duplicate of bug 114243 *** 947191 5 189431 ossy 2013-11-05 08:51:11 -0800 Comment on attachment 189431 Proposed fix Cleared review? from attachment 189431 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 189431 2013-02-20 17:59:03 -0800 2013-11-05 08:51:11 -0800 Proposed fix 0002-CMake-shouldn-t-need-build-target-to-be-specified-af.patch text/plain 1544 mark.salisbury RnJvbSAxMGI1MDIwNTIxN2ViODhkZmZlYjMzMmY0NjQzODBlM2ZlMDBhY2MxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFNhbGlzYnVyeSA8bWFyay5zYWxpc2J1cnlAaHAuY29t PgpEYXRlOiBXZWQsIDIwIEZlYiAyMDEzIDE4OjI0OjUwIC0wNzAwClN1YmplY3Q6IFtQQVRDSCAy LzVdIENNYWtlIHNob3VsZG4ndCBuZWVkIGJ1aWxkIHRhcmdldCB0byBiZSBzcGVjaWZpZWQgYWZ0 ZXIKIHIxNDA5OTAuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0 MTQKCi0tLQogQ01ha2VMaXN0cy50eHQgfCA0ICsrKy0KIENoYW5nZUxvZyAgICAgIHwgOSArKysr KysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggMGVjMDkx ZC4uNDJmOTQ5YiAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50 eHQKQEAgLTcsNyArNyw5IEBAIHByb2plY3QoV2ViS2l0KQogaWYgKE5PVCBDTUFLRV9CVUlMRF9U WVBFIEFORCBOT1QgQ01BS0VfQ19GTEFHUyBBTkQgTk9UIENNQUtFX0NYWF9GTEFHUykKICAgICBz ZXQoQ01BS0VfQlVJTERfVFlQRSBSZWxlYXNlKQogZW5kaWYgKCkKLXN0cmluZyhUT0xPV0VSICR7 Q01BS0VfQlVJTERfVFlQRX0gQ01BS0VfQlVJTERfVFlQRSkKK2lmIChDTUFLRV9CVUlMRF9UWVBF KQorICAgIHN0cmluZyhUT0xPV0VSICR7Q01BS0VfQlVJTERfVFlQRX0gQ01BS0VfQlVJTERfVFlQ RSkKK2VuZGlmICgpCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgRGVmYXVsdCBsaWJyYXJ5 IHR5cGUKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkYjZjZDlkLi44 ZGI3YmUwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTQgQEAKIDIwMTMtMDItMjAgIE1hcmsgU2FsaXNidXJ5ICA8bWFyay5zYWxpc2J1cnlAaHAuY29t PgogCisgICAgICAgIENNYWtlIHNob3VsZG4ndCBuZWVkIGJ1aWxkIHRhcmdldCB0byBiZSBzcGVj aWZpZWQgYWZ0ZXIgcjE0MDk5MC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKKzIwMTMtMDItMjAgIE1hcmsgU2FsaXNi dXJ5ICA8bWFyay5zYWxpc2J1cnlAaHAuY29tPgorCiAgICAgICAgIFtXaW5DRV0gRG9uJ3QgYWRk IGRlZmluaXRpb24gZm9yIFdURl9DUFVfQVJNX1RSQURJVElPTkFMIGlmIHdlIGFyZSBub3QKICAg ICAgICAgdGFyZ2V0aW5nIEFSTS4gIEZpeGVzIGJ1aWxkcyBmb3IgeDg2LiAgQWxzbywgV0lOQ0VC QVNJQyBkZWZpbmUgaXMgbm8KICAgICAgICAgbG9uZ2VyIHVzZWQuCi0tIAoxLjcuMTEubXN5c2dp dC4xCgo=