110403 2013-02-20 16:11:28 -0800 [BlackBerry] WebPagePrivate::load should not check new window policy 2013-02-21 11:10:57 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 837882 0 anlo 2013-02-20 16:11:28 -0800 Based on my understanding of http://trac.webkit.org/changeset/135952, we should not check the new window policy in WebPagePrivate::load. None of the other ports seem to do this, except for plugins. 837888 1 189402 anlo 2013-02-20 16:17:32 -0800 Created attachment 189402 Patch 838452 2 189402 cgarcia 2013-02-21 08:32:50 -0800 Comment on attachment 189402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189402&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:744 > FrameLoadRequest frameRequest(m_mainFrame, request); > - frameRequest.setFrameName(""); > - frameRequest.setShouldCheckNewWindowPolicy(true); > m_mainFrame->loader()->load(frameRequest); Now that we don't need the local variable maybe we could leave a single line m_mainFrame->loader()->load(FrameLoadRequest(m_mainFrame, request)); 838551 3 189552 anlo 2013-02-21 10:23:20 -0800 Created attachment 189552 Patch 838563 4 189552 rwlbuis 2013-02-21 10:32:19 -0800 Comment on attachment 189552 Patch Looks good. 838585 5 189552 webkit.review.bot 2013-02-21 10:55:34 -0800 Comment on attachment 189552 Patch Rejecting attachment 189552 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189552, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16699164 838603 6 189552 webkit.review.bot 2013-02-21 11:10:54 -0800 Comment on attachment 189552 Patch Clearing flags on attachment: 189552 Committed r143629: <http://trac.webkit.org/changeset/143629> 838604 7 webkit.review.bot 2013-02-21 11:10:57 -0800 All reviewed patches have been landed. Closing bug. 189402 2013-02-20 16:17:32 -0800 2013-02-21 10:23:16 -0800 Patch bug-110403-20130220191408.patch text/plain 1585 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjYmMxNDEzYmNmYTRiMTgxYTU2OTdjNzc1MDc1YzRkMWI1NTNlMmNhLi41ZWYyZTg1ZmU1 YzI3M2VjYmQ3NTY5NmVmNzgzZmRjNGY0ZTM3NzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMi0yMCAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJQYWdlUHJpdmF0ZTo6bG9hZCBzaG91bGQg bm90IGNoZWNrIG5ldyB3aW5kb3cgcG9saWN5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCYXNlZCBvbiBteSB1bmRlcnN0YW5kaW5nIG9mIGNoYW5nZXNl dCAxMzU5NTIsIHdlIHNob3VsZAorICAgICAgICBub3QgY2hlY2sgdGhlIG5ldyB3aW5kb3cgcG9s aWN5IGluIFdlYlBhZ2VQcml2YXRlOjpsb2FkLgorCisgICAgICAgIE5vbmUgb2YgdGhlIG90aGVy IHBvcnRzIHNlZW0gdG8gZG8gdGhpcywgZXhjZXB0IGZvciBwbHVnaW5zLgorCisgICAgICAgICog QXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJp dmF0ZTo6bG9hZCk6CisKIDIwMTMtMDItMTQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBkYXRlIGtleWJvYXJkIGV2ZW50IGRldGFpbHMg dG8gbWF0Y2ggcGxhdGZvcm0gZGV0YWlscy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwCmluZGV4IGNkYmQ2NzJjZGE4ZDk5OWM0YWJmNGZhYjBjODIzNWMyMDNjZTNmM2Eu LjY3NzVlNTlmYzg3Njk2YzAxMTNkYzdmN2NjZjJhZDdjNjRjOWY2MDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzQxLDggKzc0MSw2IEBAIHZvaWQgV2Vi UGFnZVByaXZhdGU6OmxvYWQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgdXJs LCBjb25zdCBCbGFja0JlCiAgICAgcmVxdWVzdC5zZXRTdWdnZXN0ZWRTYXZlTmFtZShzdWdnZXN0 ZWRTYXZlTmFtZSk7CiAKICAgICBGcmFtZUxvYWRSZXF1ZXN0IGZyYW1lUmVxdWVzdChtX21haW5G cmFtZSwgcmVxdWVzdCk7Ci0gICAgZnJhbWVSZXF1ZXN0LnNldEZyYW1lTmFtZSgiIik7Ci0gICAg ZnJhbWVSZXF1ZXN0LnNldFNob3VsZENoZWNrTmV3V2luZG93UG9saWN5KHRydWUpOwogICAgIG1f bWFpbkZyYW1lLT5sb2FkZXIoKS0+bG9hZChmcmFtZVJlcXVlc3QpOwogfQogCg== 189552 2013-02-21 10:23:20 -0800 2013-02-21 11:10:54 -0800 Patch bug-110403-20130221131941.patch text/plain 1789 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjYmMxNDEzYmNmYTRiMTgxYTU2OTdjNzc1MDc1YzRkMWI1NTNlMmNhLi41ZWYyZTg1ZmU1 YzI3M2VjYmQ3NTY5NmVmNzgzZmRjNGY0ZTM3NzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wMi0yMCAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJQYWdlUHJpdmF0ZTo6bG9hZCBzaG91bGQg bm90IGNoZWNrIG5ldyB3aW5kb3cgcG9saWN5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA0MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCYXNlZCBvbiBteSB1bmRlcnN0YW5kaW5nIG9mIGNoYW5nZXNl dCAxMzU5NTIsIHdlIHNob3VsZAorICAgICAgICBub3QgY2hlY2sgdGhlIG5ldyB3aW5kb3cgcG9s aWN5IGluIFdlYlBhZ2VQcml2YXRlOjpsb2FkLgorCisgICAgICAgIE5vbmUgb2YgdGhlIG90aGVy IHBvcnRzIHNlZW0gdG8gZG8gdGhpcywgZXhjZXB0IGZvciBwbHVnaW5zLgorCisgICAgICAgICog QXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJp dmF0ZTo6bG9hZCk6CisKIDIwMTMtMDItMTQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBkYXRlIGtleWJvYXJkIGV2ZW50IGRldGFpbHMg dG8gbWF0Y2ggcGxhdGZvcm0gZGV0YWlscy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwCmluZGV4IGNkYmQ2NzJjZGE4ZDk5OWM0YWJmNGZhYjBjODIzNWMyMDNjZTNmM2Eu LmQxYTk3OWU4YTBmMDZiOWZkYTM4ZWEyMjI4ZGNkZTYzNDI5ODViZmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzQwLDEwICs3NDAsNyBAQCB2b2lkIFdl YlBhZ2VQcml2YXRlOjpsb2FkKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIHVy bCwgY29uc3QgQmxhY2tCZQogCiAgICAgcmVxdWVzdC5zZXRTdWdnZXN0ZWRTYXZlTmFtZShzdWdn ZXN0ZWRTYXZlTmFtZSk7CiAKLSAgICBGcmFtZUxvYWRSZXF1ZXN0IGZyYW1lUmVxdWVzdChtX21h aW5GcmFtZSwgcmVxdWVzdCk7Ci0gICAgZnJhbWVSZXF1ZXN0LnNldEZyYW1lTmFtZSgiIik7Ci0g ICAgZnJhbWVSZXF1ZXN0LnNldFNob3VsZENoZWNrTmV3V2luZG93UG9saWN5KHRydWUpOwotICAg IG1fbWFpbkZyYW1lLT5sb2FkZXIoKS0+bG9hZChmcmFtZVJlcXVlc3QpOworICAgIG1fbWFpbkZy YW1lLT5sb2FkZXIoKS0+bG9hZChGcmFtZUxvYWRSZXF1ZXN0KG1fbWFpbkZyYW1lLCByZXF1ZXN0 KSk7CiB9CiAKIHZvaWQgV2ViUGFnZTo6bG9hZChjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 U3RyaW5nJiB1cmwsIGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIG5ldHdvcmtU b2tlbiwgYm9vbCBpc0luaXRpYWwpCg==