110399 2013-02-20 15:55:49 -0800 LevelDB: Remove excess vector copy 2013-02-20 16:51:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alecflett alecflett dgrogan jsbell tony webkit.review.bot oldest_to_newest 837864 0 alecflett 2013-02-20 15:55:49 -0800 LevelDB: Remove excess vector copy 837866 1 189398 alecflett 2013-02-20 15:56:51 -0800 Created attachment 189398 Patch 837867 2 alecflett 2013-02-20 15:59:01 -0800 tony@ - it looks like someone thought they were going to benefit from NRVO optimization, but that isn't possible because the return object is a reference that comes in via a parameter. Instead, we get an extra copy. I did a blame and looked back - this looks like it corresponds to the original checkin of LevelDBDatabase.cpp by hans@chromium.org so it doesn't look like this was any kind of purposefully optimization. 837940 3 189398 webkit.review.bot 2013-02-20 16:51:40 -0800 Comment on attachment 189398 Patch Clearing flags on attachment: 189398 Committed r143538: <http://trac.webkit.org/changeset/143538> 837942 4 webkit.review.bot 2013-02-20 16:51:43 -0800 All reviewed patches have been landed. Closing bug. 189398 2013-02-20 15:56:51 -0800 2013-02-20 16:51:40 -0800 Patch bug-110399-20130220155312.patch text/plain 1945 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNjZjZhNGVkYjkwMjBj MmUyMDE2OGFkNzQyOGE5MTAzNGNlZjcxNC4uOTk0YTVlNzQ5OWIzODg1MDk5YzQ5NTliZWM3MzAz NDhlMjIwZDE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTIwICBBbGVj IEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KKworICAgICAgICBMZXZlbERCOiBSZW1v dmUgZXhjZXNzIHZlY3RvciBjb3B5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTAzOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgYW4gZXh0cmEgY29weSBpbnRyb2R1Y2VkIGJ5IHRoZSBtYWtl VmVjdG9yIGZ1bmN0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBjb3ZlcmVk IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERC RGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGV2ZWxEQkRhdGFiYXNlOjpzYWZlR2V0 KToKKwogMjAxMy0wMi0yMCAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaGlnaGxpZ2h0IHVuZGVmaW5lZCB3b3JkIGlu IEphdmFTY3JpcHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xldmVsZGIv TGV2ZWxEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xldmVsZGIvTGV2 ZWxEQkRhdGFiYXNlLmNwcAppbmRleCAwYzM4OWNjZWQ1ZGRmMDI4M2Q3NTllYjgyNjhmNzE1ZDQ4 M2VkYmM3Li45YTcyZDI0ZGE4YjdhNGJiZmNhZjNmMjU4NmJlZjU4YWJjMGZhMzM1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9sZXZlbGRiL0xldmVsREJEYXRhYmFzZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3Bw CkBAIC03NSwxMyArNzUsNiBAQCBzdGF0aWMgTGV2ZWxEQlNsaWNlIG1ha2VMZXZlbERCU2xpY2Uo Y29uc3QgbGV2ZWxkYjo6U2xpY2UmIHMpCiAgICAgcmV0dXJuIExldmVsREJTbGljZShzLmRhdGEo KSwgcy5kYXRhKCkgKyBzLnNpemUoKSk7CiB9CiAKLXN0YXRpYyBWZWN0b3I8Y2hhcj4gbWFrZVZl Y3Rvcihjb25zdCBzdGQ6OnN0cmluZyYgcykKLXsKLSAgICBWZWN0b3I8Y2hhcj4gcmVzOwotICAg IHJlcy5hcHBlbmQocy5jX3N0cigpLCBzLmxlbmd0aCgpKTsKLSAgICByZXR1cm4gcmVzOwotfQot CiBjbGFzcyBDb21wYXJhdG9yQWRhcHRlciA6IHB1YmxpYyBsZXZlbGRiOjpDb21wYXJhdG9yIHsK IHB1YmxpYzoKICAgICBDb21wYXJhdG9yQWRhcHRlcihjb25zdCBMZXZlbERCQ29tcGFyYXRvciog Y29tcGFyYXRvcikKQEAgLTIyNSw3ICsyMTgsOCBAQCBib29sIExldmVsREJEYXRhYmFzZTo6c2Fm ZUdldChjb25zdCBMZXZlbERCU2xpY2UmIGtleSwgVmVjdG9yPGNoYXI+JiB2YWx1ZSwgYm9vbAog ICAgIGNvbnN0IGxldmVsZGI6OlN0YXR1cyBzID0gbV9kYi0+R2V0KHJlYWRPcHRpb25zLCBtYWtl U2xpY2Uoa2V5KSwgJnJlc3VsdCk7CiAgICAgaWYgKHMub2soKSkgewogICAgICAgICBmb3VuZCA9 IHRydWU7Ci0gICAgICAgIHZhbHVlID0gbWFrZVZlY3RvcihyZXN1bHQpOworICAgICAgICB2YWx1 ZS5jbGVhcigpOworICAgICAgICB2YWx1ZS5hcHBlbmQocmVzdWx0LmNfc3RyKCksIHJlc3VsdC5s ZW5ndGgoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KICAgICBpZiAocy5Jc05vdEZv dW5kKCkpCg==