110348 2013-02-20 07:30:00 -0800 Web Inspector: CSSProperty.status defaults to "style" not "active" 2013-02-20 08:10:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy apavlov apavlov graouts joepeck keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 837457 0 timothy 2013-02-20 07:30:00 -0800 The code and the json file description disagree on what an absent "status" means. Inspector.json: { "name": "status", "type": "string", "enum": ["active", "inactive", "disabled", "style"], "optional": true, "description": "The property status: \"active\" (implied if absent) if the property is effective in the style, \"inactive\" if the property is overridden by a same-named property in this style later on, \"disabled\" if the property is disabled by the user, \"style\" if the property is reported by the browser rather than by the CSS source parser." }, InspectorStyleSheet.cpp: // Default "status" == "style". if (status != TypeBuilder::CSS::CSSProperty::Status::Style) property->setStatus(status); Defaulting to "style" makes more sense to me, and the code agrees. 837462 1 189316 apavlov 2013-02-20 07:34:21 -0800 Created attachment 189316 Patch 837475 2 189316 webkit.review.bot 2013-02-20 08:10:05 -0800 Comment on attachment 189316 Patch Clearing flags on attachment: 189316 Committed r143465: <http://trac.webkit.org/changeset/143465> 837476 3 webkit.review.bot 2013-02-20 08:10:09 -0800 All reviewed patches have been landed. Closing bug. 189316 2013-02-20 07:34:21 -0800 2013-02-20 08:10:05 -0800 Patch bug-110348-20130220193042.patch text/plain 2891 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDdlMjc1OGNhYjJlNTM2 NzVlZTFhZDYyZWE0NGVkYThhMDcyZjI5Ni4uMGI4NmUyNDJmZGNjMDdmN2M2OWYzNDc0OTg2ZjQz MzQ4NjVmOTAxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTAyLTIwICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ1NTUHJvcGVydHkuc3RhdHVzIGRlZmF1bHRzIHRvICJzdHlsZSIgbm90ICJhY3RpdmUi CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAzNDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3IuanNvbjogRml4IHRoZSBkZWZhdWx0IHByb3BlcnR5IHN0YXR1cyB0byBi ZSAic3R5bGUiIGluIHRoZSBkZXNjcmlwdGlvbi4KKworMjAxMy0wMi0yMCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IElu dHJvZHVjZSBTZWN1cml0eU9yaWdpbkFkZGVkIGFuZCBTZWN1cml0eU9yaWdpblJlbW92ZWQgZXZl bnRzIGludG8gUmVzb3VyY2VUcmVlTW9kZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDIzMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yLmpzb24KaW5kZXggY2JhMWVkZWJkYmU4MWJmZTE1ZGM3M2E5MzhiMDg3ZWM3NjAzOGJiMC4u MzIwMGJhOWQxMGIzMWU0OTM3YTlkYjQzMjZiYjU3ZTkyYjc4NTczMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgpAQCAtMjMzMyw3ICsyMzMzLDcgQEAKICAgICAgICAg ICAgICAgICAgICAgeyAibmFtZSI6ICJpbXBsaWNpdCIsICJ0eXBlIjogImJvb2xlYW4iLCAib3B0 aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiV2hldGhlciB0aGUgcHJvcGVydHkgaXMgaW1w bGljaXQgKGltcGxpZXMgPGNvZGU+ZmFsc2U8L2NvZGU+IGlmIGFic2VudCkuIiB9LAogICAgICAg ICAgICAgICAgICAgICB7ICJuYW1lIjogInRleHQiLCAidHlwZSI6ICJzdHJpbmciLCAib3B0aW9u YWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiVGhlIGZ1bGwgcHJvcGVydHkgdGV4dCBhcyBzcGVj aWZpZWQgaW4gdGhlIHN0eWxlLiIgfSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJw YXJzZWRPayIsICJ0eXBlIjogImJvb2xlYW4iLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRp b24iOiAiV2hldGhlciB0aGUgcHJvcGVydHkgaXMgdW5kZXJzdG9vZCBieSB0aGUgYnJvd3NlciAo aW1wbGllcyA8Y29kZT50cnVlPC9jb2RlPiBpZiBhYnNlbnQpLiIgfSwKLSAgICAgICAgICAgICAg ICAgICAgeyAibmFtZSI6ICJzdGF0dXMiLCAidHlwZSI6ICJzdHJpbmciLCAiZW51bSI6IFsiYWN0 aXZlIiwgImluYWN0aXZlIiwgImRpc2FibGVkIiwgInN0eWxlIl0sICJvcHRpb25hbCI6IHRydWUs ICJkZXNjcmlwdGlvbiI6ICJUaGUgcHJvcGVydHkgc3RhdHVzOiBcImFjdGl2ZVwiIChpbXBsaWVk IGlmIGFic2VudCkgaWYgdGhlIHByb3BlcnR5IGlzIGVmZmVjdGl2ZSBpbiB0aGUgc3R5bGUsIFwi aW5hY3RpdmVcIiBpZiB0aGUgcHJvcGVydHkgaXMgb3ZlcnJpZGRlbiBieSBhIHNhbWUtbmFtZWQg cHJvcGVydHkgaW4gdGhpcyBzdHlsZSBsYXRlciBvbiwgXCJkaXNhYmxlZFwiIGlmIHRoZSBwcm9w ZXJ0eSBpcyBkaXNhYmxlZCBieSB0aGUgdXNlciwgXCJzdHlsZVwiIGlmIHRoZSBwcm9wZXJ0eSBp cyByZXBvcnRlZCBieSB0aGUgYnJvd3NlciByYXRoZXIgdGhhbiBieSB0aGUgQ1NTIHNvdXJjZSBw YXJzZXIuIiB9LAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInN0YXR1cyIsICJ0eXBl IjogInN0cmluZyIsICJlbnVtIjogWyJhY3RpdmUiLCAiaW5hY3RpdmUiLCAiZGlzYWJsZWQiLCAi c3R5bGUiXSwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlRoZSBwcm9wZXJ0eSBz dGF0dXM6IFwiYWN0aXZlXCIgaWYgdGhlIHByb3BlcnR5IGlzIGVmZmVjdGl2ZSBpbiB0aGUgc3R5 bGUsIFwiaW5hY3RpdmVcIiBpZiB0aGUgcHJvcGVydHkgaXMgb3ZlcnJpZGRlbiBieSBhIHNhbWUt bmFtZWQgcHJvcGVydHkgaW4gdGhpcyBzdHlsZSBsYXRlciBvbiwgXCJkaXNhYmxlZFwiIGlmIHRo ZSBwcm9wZXJ0eSBpcyBkaXNhYmxlZCBieSB0aGUgdXNlciwgXCJzdHlsZVwiIChpbXBsaWVkIGlm IGFic2VudCkgaWYgdGhlIHByb3BlcnR5IGlzIHJlcG9ydGVkIGJ5IHRoZSBicm93c2VyIHJhdGhl ciB0aGFuIGJ5IHRoZSBDU1Mgc291cmNlIHBhcnNlci4iIH0sCiAgICAgICAgICAgICAgICAgICAg IHsgIm5hbWUiOiAicmFuZ2UiLCAiJHJlZiI6ICJTb3VyY2VSYW5nZSIsICJvcHRpb25hbCI6IHRy dWUsICJkZXNjcmlwdGlvbiI6ICJUaGUgZW50aXJlIHByb3BlcnR5IHJhbmdlIGluIHRoZSBlbmNs b3Npbmcgc3R5bGUgZGVjbGFyYXRpb24gKGlmIGF2YWlsYWJsZSkuIiB9CiAgICAgICAgICAgICAg ICAgXSwKICAgICAgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiQ1NTIHN0eWxlIGVmZmVjdGl2 ZSB2aXN1YWwgZGltZW5zaW9ucyBhbmQgc291cmNlIG9mZnNldHMuIgo=