110327 2013-02-20 04:49:38 -0800 Web Inspector: [Canvas] UI: more intuitive control buttons 2013-02-21 06:28:06 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 837351 0 aandrey 2013-02-20 04:49:38 -0800 - NextDrawCall forward button (StepOver) should jump up to the last expanded node, otherwise a noop is not intuitive unless the last node is selected. - NextDrawCall/PrevDrawCall buttons should not skip draw call nodes themselves. Patch to follow. 837354 1 189287 aandrey 2013-02-20 04:51:37 -0800 Created attachment 189287 Patch 838378 2 189287 webkit.review.bot 2013-02-21 06:28:01 -0800 Comment on attachment 189287 Patch Clearing flags on attachment: 189287 Committed r143597: <http://trac.webkit.org/changeset/143597> 838379 3 webkit.review.bot 2013-02-21 06:28:06 -0800 All reviewed patches have been landed. Closing bug. 189287 2013-02-20 04:51:37 -0800 2013-02-21 06:28:01 -0800 Patch bug-110327-20130220164759.patch text/plain 6162 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NmMjdlOGYzZDY5M2Zj Zjk1N2MzMjdiZjAxZGQ1NDZiYWZjYWRhOC4uNDc4NjFiNmY2MGI2NDdmZWJmY2E2NjdmOWVhMTQz OTRlODM3MjIzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTIwICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtDYW52YXNdIFVJOiBtb3JlIGludHVpdGl2ZSBjb250cm9sIGJ1dHRvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDMyNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR3ZWFrcyB0byB0aGUgQ2Fu dmFzUHJvZmlsZXIgcmVwbGF5IGNvbnRyb2wgYnV0dG9ucy4KKyAgICAgICAgLSBOZXh0RHJhd0Nh bGwgZm9yd2FyZCBidXR0b24gKFN0ZXBPdmVyKSBzaG91bGQganVtcCB1cCB0byB0aGUgbGFzdCBl eHBhbmRlZCBub2RlLCBvdGhlcndpc2UgYSBub29wIGlzIG5vdCBpbnR1aXRpdmUgdW5sZXNzIHRo ZSBsYXN0IG5vZGUgaXMgc2VsZWN0ZWQuCisgICAgICAgIC0gTmV4dERyYXdDYWxsL1ByZXZEcmF3 Q2FsbCBidXR0b25zIHNob3VsZCBub3Qgc2tpcCBkcmF3IGNhbGwgbm9kZXMgdGhlbXNlbHZlcy4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ2FudmFzUHJvZmlsZVZpZXcuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ2FudmFzUHJvZmlsZVZpZXcucHJvdG90eXBlLl9vblJlcGxh eURyYXdpbmdDYWxsQ2xpY2spOgorCiAyMDEzLTAyLTE5ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZldyBtZXRob2RzIGluIFdlYkdMUmVuZGVyaW5n Q29udGV4dC5pZGwgaGF2ZSBpbmNvcnJlY3Qgc2lnbmF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ2FudmFzUHJvZmlsZVZpZXcuanMKaW5kZXgg OTQ3MzM0YWVlNjhlOGFiNzM5YmQ0MmQxZmY1M2RjYTg2YjM1OTA0OS4uYWEzZGUyYmUxODIyZGVi ZmQ3ZjlhM2RiNDliZmIyZjM5YzhlNGZkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3LmpzCkBAIC0yMDIsNyArMjAy LDcgQEAgV2ViSW5zcGVjdG9yLkNhbnZhc1Byb2ZpbGVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIHZhciBzaWJsaW5nID0gZm9yd2FyZCA/IG5leHROb2RlLm5leHRTaWJsaW5nIDogbmV4 dE5vZGUucHJldmlvdXNTaWJsaW5nOwogICAgICAgICAgICAgaWYgKHNpYmxpbmcpIHsKICAgICAg ICAgICAgICAgICBuZXh0Tm9kZSA9IHNpYmxpbmc7Ci0gICAgICAgICAgICAgICAgaWYgKG5leHRO b2RlLmhhc0NoaWxkcmVuKQorICAgICAgICAgICAgICAgIGlmIChuZXh0Tm9kZS5oYXNDaGlsZHJl biB8fCBuZXh0Tm9kZS5jYWxsLmlzRHJhd2luZ0NhbGwpCiAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBuZXh0Tm9kZSA9IG5l eHROb2RlLnBhcmVudDsKQEAgLTIxMCw3ICsyMTAsMTAgQEAgV2ViSW5zcGVjdG9yLkNhbnZhc1By b2ZpbGVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KLSAgICAgICAgKG5leHROb2RlIHx8IHNlbGVjdGVkTm9kZSku cmV2ZWFsQW5kU2VsZWN0KCk7CisgICAgICAgIGlmICghbmV4dE5vZGUgJiYgZm9yd2FyZCkKKyAg ICAgICAgICAgIHRoaXMuX29uUmVwbGF5TGFzdFN0ZXBDbGljaygpOworICAgICAgICBlbHNlCisg ICAgICAgICAgICAobmV4dE5vZGUgfHwgc2VsZWN0ZWROb2RlKS5yZXZlYWxBbmRTZWxlY3QoKTsK ICAgICB9LAogCiAgICAgX29uUmVwbGF5Rmlyc3RTdGVwQ2xpY2s6IGZ1bmN0aW9uKCkKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCAyYTQzNWFmMmI0YzM0OTgwMzZlNzljZTBlNDkzMGE4ZGRmZjBjZjQzLi5mZTlhNGJjYzYwMzhh MmU2MDMwMGJlYTZkNjc5MzNkZTA3NDY5MDgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMt MDItMjAgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogW0NhbnZhc10gVUk6IG1vcmUgaW50dWl0aXZlIGNvbnRyb2wgYnV0dG9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMzI3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvcHJvZmlsZXIvY2FudmFzMmQvY2FudmFzLXJlcGxheS1sb2ctZ3JpZC5odG1sOgorCiAy MDEzLTAyLTE5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQzMzkzLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2NhbnZhczJkL2NhbnZhcy1yZXBsYXktbG9nLWdy aWQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wcm9maWxlci9jYW52YXMyZC9jYW52YXMt cmVwbGF5LWxvZy1ncmlkLmh0bWwKaW5kZXggZmIxNjExZmY2OWM1OGU0NjQ5NWQ3MjhiM2MxOTM2 MjQ0MDNkZmM1ZC4uMjcwMmNhYWFhYjMyZTYyMzMyYjc1ZTBlZDNkYWQ0MzMxZWFiNjhhZCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2NhbnZhczJkL2NhbnZhcy1y ZXBsYXktbG9nLWdyaWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmlsZXIv Y2FudmFzMmQvY2FudmFzLXJlcGxheS1sb2ctZ3JpZC5odG1sCkBAIC0xMzgsOSArMTM4LDEyIEBA IGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgiVGVzdGlu ZyBSZXBsYXlOZXh0RHJhd2luZ0NhbGxDbGljayBzdGFydGluZyBvbiBhIGZyYW1lIG5vZGUiKTsK ICAgICAgICAgZm9yICh2YXIgaSA9IDE7IGkgPCBmcmFtZU5vZGVzLmxlbmd0aCArIDU7ICsraSkg ewogICAgICAgICAgICAgcHJvZmlsZVZpZXcuX29uUmVwbGF5RHJhd2luZ0NhbGxDbGljayh0cnVl KTsKLSAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0RXF1YWxzKGZyYW1lTm9kZXNbaV0g fHwgZnJhbWVOb2Rlcy5wZWVrTGFzdCgpLCBkYXRhR3JpZC5zZWxlY3RlZE5vZGUsICJlcnJvciBv biBpbmRleCAiICsgaSk7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydEVxdWFscyhm cmFtZU5vZGVzW2ldIHx8IGFsbE5vZGVzRmxhdC5wZWVrTGFzdCgpLCBkYXRhR3JpZC5zZWxlY3Rl ZE5vZGUsICJlcnJvciBvbiBpbmRleCAiICsgaSk7CiAgICAgICAgIH0KIAorICAgICAgICBmcmFt ZU5vZGVzLnBlZWtMYXN0KCkucmV2ZWFsQW5kU2VsZWN0KCk7CisgICAgICAgIEluc3BlY3RvclRl c3QuYXNzZXJ0RXF1YWxzKGZyYW1lTm9kZXMucGVla0xhc3QoKSwgZGF0YUdyaWQuc2VsZWN0ZWRO b2RlLCAiRXhwZWN0ZWQgdG8gc2VsZWN0IGxhc3QgZnJhbWUgbm9kZSIpOworCiAgICAgICAgIElu c3BlY3RvclRlc3QuYWRkUmVzdWx0KCJUZXN0aW5nIFJlcGxheVByZXZpb3VzRHJhd2luZ0NhbGxD bGljayBzdGFydGluZyBvbiBhIGZyYW1lIG5vZGUiKTsKICAgICAgICAgZm9yICh2YXIgaSA9IGZy YW1lTm9kZXMubGVuZ3RoIC0gMjsgaSA+PSAtNTsgLS1pKSB7CiAgICAgICAgICAgICBwcm9maWxl Vmlldy5fb25SZXBsYXlEcmF3aW5nQ2FsbENsaWNrKGZhbHNlKTsKQEAgLTE1MSw3ICsxNTQsNyBA QCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgSW5zcGVjdG9yVGVzdC5hc3NlcnRFcXVhbHMoZHJh d0NhbGxHcm91cHNbMF0sIGRhdGFHcmlkLnNlbGVjdGVkTm9kZSwgIkV4cGVjdGVkIHRvIG1vdmUg dG8gdGhlIGZpcnN0IGRyYXcgY2FsbCBncm91cCIpOwogCiAgICAgICAgIEluc3BlY3RvclRlc3Qu YWRkUmVzdWx0KCJUZXN0aW5nIFJlcGxheU5leHREcmF3aW5nQ2FsbENsaWNrIHN0YXJ0aW5nIG9u IGEgZHJhdyBjYWxsIGdyb3VwIik7Ci0gICAgICAgIHZhciBleHBlY3RlZCA9IFtkcmF3Q2FsbEdy b3Vwc1sxXSwgZnJhbWVOb2Rlc1sxXV07CisgICAgICAgIHZhciBleHBlY3RlZCA9IFtkcmF3Q2Fs bEdyb3Vwc1sxXSwgZnJhbWVOb2Rlc1sxXSwgYWxsTm9kZXNGbGF0LnBlZWtMYXN0KCldOwogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGV4cGVjdGVkLmxlbmd0aCArIDU7ICsraSkgewogICAg ICAgICAgICAgcHJvZmlsZVZpZXcuX29uUmVwbGF5RHJhd2luZ0NhbGxDbGljayh0cnVlKTsKICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0RXF1YWxzKGV4cGVjdGVkW2ldIHx8IGV4cGVj dGVkLnBlZWtMYXN0KCksIGRhdGFHcmlkLnNlbGVjdGVkTm9kZSwgImVycm9yIG9uIGluZGV4ICIg KyBpKTsKQEAgLTE2MSw3ICsxNjQsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgSW5zcGVj dG9yVGVzdC5hc3NlcnRFcXVhbHMoYWxsTm9kZXNGbGF0LnBlZWtMYXN0KCksIGRhdGFHcmlkLnNl bGVjdGVkTm9kZSwgIkV4cGVjdGVkIHRvIG1vdmUgdG8gdGhlIGxhc3QgY2FsbCIpOwogCiAgICAg ICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJUZXN0aW5nIFJlcGxheVByZXZpb3VzRHJhd2lu Z0NhbGxDbGljayBzdGFydGluZyBvbiBhIGNhbGwgbm9kZSIpOwotICAgICAgICB2YXIgZXhwZWN0 ZWQgPSBbZnJhbWVOb2Rlc1swXSwgZnJhbWVOb2Rlc1sxXSwgZHJhd0NhbGxHcm91cHNbMl0sIGRy YXdDYWxsR3JvdXBzWzNdLCBkcmF3Q2FsbEdyb3Vwc1s0XV07CisgICAgICAgIHZhciBleHBlY3Rl ZCA9IFtmcmFtZU5vZGVzWzBdLCBmcmFtZU5vZGVzWzFdLCBkcmF3Q2FsbEdyb3Vwc1syXSwgZHJh d0NhbGxHcm91cHNbM10sIGRyYXdDYWxsR3JvdXBzWzRdLCBub2Rlc1syOF1dOwogICAgICAgICBm b3IgKHZhciBpID0gZXhwZWN0ZWQubGVuZ3RoIC0gMTsgaSA+PSAtNTsgLS1pKSB7CiAgICAgICAg ICAgICBwcm9maWxlVmlldy5fb25SZXBsYXlEcmF3aW5nQ2FsbENsaWNrKGZhbHNlKTsKICAgICAg ICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0RXF1YWxzKGV4cGVjdGVkW2ldIHx8IGV4cGVjdGVk WzBdLCBkYXRhR3JpZC5zZWxlY3RlZE5vZGUsICJlcnJvciBvbiBpbmRleCAiICsgaSk7CkBAIC0x NzEsNyArMTc0LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIEluc3BlY3RvclRlc3QuYXNz ZXJ0RXF1YWxzKG5vZGVzWzE1XSwgZGF0YUdyaWQuc2VsZWN0ZWROb2RlLCAiRXhwZWN0ZWQgdG8g c2VsZWN0IG5vZGUgIzIwIik7CiAKICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIlRl c3RpbmcgUmVwbGF5TmV4dERyYXdpbmdDYWxsQ2xpY2sgc3RhcnRpbmcgb24gYSBjYWxsIG5vZGUi KTsKLSAgICAgICAgdmFyIGV4cGVjdGVkID0gW2RyYXdDYWxsR3JvdXBzWzNdLCBkcmF3Q2FsbEdy b3Vwc1s0XV07CisgICAgICAgIHZhciBleHBlY3RlZCA9IFtub2Rlc1sxNl0sIGRyYXdDYWxsR3Jv dXBzWzNdLCBkcmF3Q2FsbEdyb3Vwc1s0XSwgYWxsTm9kZXNGbGF0LnBlZWtMYXN0KCldOwogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGV4cGVjdGVkLmxlbmd0aCArIDU7ICsraSkgewogICAg ICAgICAgICAgcHJvZmlsZVZpZXcuX29uUmVwbGF5RHJhd2luZ0NhbGxDbGljayh0cnVlKTsKICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0RXF1YWxzKGV4cGVjdGVkW2ldIHx8IGV4cGVj dGVkLnBlZWtMYXN0KCksIGRhdGFHcmlkLnNlbGVjdGVkTm9kZSwgImVycm9yIG9uIGluZGV4ICIg KyBpKTsK