110309 2013-02-19 22:47:33 -0800 DFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant operands 2013-02-20 21:00:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 837188 0 fpizlo 2013-02-19 22:47:33 -0800 It used to be necessary, back when we didn't have constant folding. Now we have constant folding. 837190 1 189249 fpizlo 2013-02-19 22:49:18 -0800 Created attachment 189249 the patch 838126 2 fpizlo 2013-02-20 21:00:02 -0800 Landed in http://trac.webkit.org/changeset/143562 189249 2013-02-19 22:49:18 -0800 2013-02-19 22:55:04 -0800 the patch blah.patch text/plain 2197 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQzNDMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTAyLTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUludDMyVG9Eb3VibGUoKSBoYXMgYW4gdW5uZWNl c3NhcnkgY2FzZSBmb3IgY29uc3RhbnQgb3BlcmFuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSXQgdXNlZCB0byBiZSBuZWNlc3Nhcnks IGJhY2sgd2hlbiB3ZSBkaWRuJ3QgaGF2ZSBjb25zdGFudCBmb2xkaW5nLiBOb3cgd2UgaGF2ZQor ICAgICAgICBjb25zdGFudCBmb2xkaW5nLiBTbyB3ZSBkb24ndCBuZWVkIGl0LgorCisgICAgICAg ICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZUludDMyVG9Eb3VibGUpOgorCiAyMDEzLTAyLTE5ICBNYXJrIFJvd2Ug IDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdW5pbnRlcmVzdGluZyBj aGFuZ2UgdG8gdGVzdCBhIHRoZW9yeSBhYm91dCBiYWQgZGVwZW5kZW5jeSBoYW5kbGluZy4KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw CShyZXZpc2lvbiAxNDM0MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMxMCwyMCArMjMxMCw3IEBAIHZvaWQg U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVEb3VibGVBc0ludDMKIAogdm9pZCBTcGVjdWxhdGl2ZUpJ VDo6Y29tcGlsZUludDMyVG9Eb3VibGUoTm9kZSogbm9kZSkKIHsKLSNpZiBVU0UoSlNWQUxVRTY0 KQotICAgIC8vIE9uIEpTVkFMVUU2NCB3ZSBoYXZlIGEgd2F5IG9mIGxvYWRpbmcgZG91YmxlIGNv bnN0YW50cyBpbiBhIG1vcmUgZGlyZWN0IG1hbm5lcgotICAgIC8vIHRoYW4gYSBpbnQtPmRvdWJs ZSBjb252ZXJzaW9uLiBPbiAzMl82NCwgdW5mb3J0dW5hdGVseSwgd2UgY3VycmVudGx5IGRvbid0 IGhhdmUKLSAgICAvLyBhbnkgc3VjaCBtZWNoYW5pc20gLSB0aG91Z2ggd2UgY291bGQgaGF2ZSBp dCwgaWYgd2UganVzdCBwcm92aXNpb25lZCBzb21lIG1lbW9yeQotICAgIC8vIGluIENvZGVCbG9j ayBmb3IgdGhlIGRvdWJsZSBmb3JtIG9mIGludGVnZXIgY29uc3RhbnRzLgotICAgIGlmIChpc0lu dDMyQ29uc3RhbnQobm9kZS0+Y2hpbGQxKCkubm9kZSgpKSkgewotICAgICAgICBGUFJUZW1wb3Jh cnkgcmVzdWx0KHRoaXMpOwotICAgICAgICBHUFJUZW1wb3JhcnkgdGVtcCh0aGlzKTsKLSAgICAg ICAgbV9qaXQubW92ZShNYWNyb0Fzc2VtYmxlcjo6SW1tNjQocmVpbnRlcnByZXREb3VibGVUb0lu dDY0KHZhbHVlT2ZOdW1iZXJDb25zdGFudChub2RlLT5jaGlsZDEoKS5ub2RlKCkpKSksIHRlbXAu Z3ByKCkpOwotICAgICAgICBtX2ppdC5tb3ZlNjRUb0RvdWJsZSh0ZW1wLmdwcigpLCByZXN1bHQu ZnByKCkpOwotICAgICAgICBkb3VibGVSZXN1bHQocmVzdWx0LmZwcigpLCBub2RlKTsKLSAgICAg ICAgcmV0dXJuOwotICAgIH0KLSNlbmRpZgorICAgIEFTU0VSVCghaXNJbnQzMkNvbnN0YW50KG5v ZGUtPmNoaWxkMSgpLm5vZGUoKSkpOyAvLyBUaGlzIHNob3VsZCBoYXZlIGJlZW4gY29uc3RhbnQg Zm9sZGVkLgogICAgIAogICAgIGlmIChpc0ludDMyU3BlY3VsYXRpb24obV9zdGF0ZS5mb3JOb2Rl KG5vZGUtPmNoaWxkMSgpKS5tX3R5cGUpKSB7CiAgICAgICAgIFNwZWN1bGF0ZUludGVnZXJPcGVy YW5kIG9wMSh0aGlzLCBub2RlLT5jaGlsZDEoKSk7Cg==