110300 2013-02-19 21:45:19 -0800 Remove unnecessary includes for Platform.h from headers 2013-02-20 13:47:42 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned ap benjamin dino eric.carlson eric feature-media-reviews webkit.review.bot zherczeg oldest_to_newest 837123 0 laszlo.gombos 2013-02-19 21:45:19 -0800 In almost most cases config.h includes wtf/Platform.h and config.h gets included as the first header in almost all compilation unit, so in almost all cases there is no need to include wtf/Platform.h explicitly in header files. 837131 1 189237 laszlo.gombos 2013-02-19 21:51:45 -0800 Created attachment 189237 1st try 837661 2 189237 eric 2013-02-20 12:45:48 -0800 Comment on attachment 189237 1st try Yeah, I believe the style is that Platform.h is part of config.h which is required before any other includes in a cpp file. That said, it feels a bit odd to use PLATFORM(MAC) in a header w/o having Platform.h included. 837719 3 189237 webkit.review.bot 2013-02-20 13:47:39 -0800 Comment on attachment 189237 1st try Clearing flags on attachment: 189237 Committed r143499: <http://trac.webkit.org/changeset/143499> 837720 4 webkit.review.bot 2013-02-20 13:47:42 -0800 All reviewed patches have been landed. Closing bug. 189237 2013-02-19 21:51:45 -0800 2013-02-20 13:47:39 -0800 1st try 110300.patch text/plain 4915 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzQyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTE5ICBMYXN6bG8g R29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNz YXJ5IGluY2x1ZGVzIGZvciBQbGF0Zm9ybS5oIGZyb20gaGVhZGVycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMzAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd3RmL1BsYXRmb3JtLmggb25seSBuZWVk IHRvIGJlIGluY2x1ZGVkIGluIGEgZmV3IHBsYWNlcyBkaXJlY3RseQorICAgICAgICBhcyBpdCBp cyBpbmNsdWRlZCBpbiBjb25maWcuaC4gUmVtb3ZlIHRoZSB1bm5lY2Vzc2F5IGR1cGxpY2F0ZSBh cworICAgICAgICBpdCBjYW4gYmUgY29uZnVzaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TZWN1cmVU ZXh0SW5wdXQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9CaXF1YWQuaDoKKyAgICAgICAg KiBwbGF0Zm9ybS9hdWRpby9GRlRGcmFtZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NwdS9hcm0vZmlsdGVycy9GRUJsZW5kTkVPTi5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NwdS9hcm0vZmlsdGVycy9ORU9OSGVscGVycy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvRkVMaWdodGluZy5oOgorCiAyMDEzLTAyLTE5ICBFdWdlbmUgS2x5dWNo bmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENs ZWFudXAgYW5kIGFkZCBKU0RvY3MgdG8gU3VnZ2VzdEJveApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2VjdXJlVGV4dElucHV0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2VjdXJlVGV4dElucHV0LmgJKHJldmlzaW9uIDE0MzQyNikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1NlY3VyZVRleHRJbnB1dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw4 ICszMSw2IEBACiAjaWZuZGVmIFNlY3VyZVRleHRJbnB1dF9oCiAjZGVmaW5lIFNlY3VyZVRleHRJ bnB1dF9oCiAKLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KLQogbmFtZXNwYWNlIFdlYkNvcmUg ewogCiAvLyBPbmNlIGVuYWJsZVNlY3VyZVRleHRJbnB1dCBpcyBjYWxsZWQsIHNlY3VyZSB0ZXh0 IGlucHV0IG1vZGUgaXMgc2V0IHVudGlsCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9CaXF1YWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9CaXF1YWQuaAkocmV2aXNpb24gMTQzNDI2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vQmlxdWFkLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDYgQEAKICNpbmNsdWRl ICJBdWRpb0FycmF5LmgiCiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8d3RmL0Nv bXBsZXguaD4KLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KICAKICNpZiBVU0UoV0VCQVVESU9f SVBQKQogI2luY2x1ZGUgPGlwcHMuaD4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL0ZGVEZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vRkZURnJhbWUuaAkocmV2aXNpb24gMTQzNDI2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vRkZURnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtNjYsNyArNjYsNiBAQCBzdHJ1 Y3QgUkRGVENvbnRleHQ7CiAKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0 Zi9QYXNzT3duUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8d3Rm L1RocmVhZGluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvRkVCbGVuZE5FT04uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMv RkVCbGVuZE5FT04uaAkocmV2aXNpb24gMTQzNDI2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJzL0ZFQmxlbmRORU9OLmgJKHdvcmtpbmcgY29weSkK QEAgLTI3LDggKzI3LDYgQEAKICNpZm5kZWYgRkVCbGVuZE5FT05faAogI2RlZmluZSBGRUJsZW5k TkVPTl9oCiAKLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KLQogI2lmIEVOQUJMRShGSUxURVJT KSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCiAKICNpbmNsdWRlICJGRUJsZW5kLmgiCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvTkVP TkhlbHBlcnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jcHUvYXJtL2ZpbHRlcnMvTkVPTkhlbHBlcnMuaAkocmV2aXNpb24gMTQzNDI2KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJzL05FT05IZWxwZXJz LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3LDggKzI3LDYgQEAKICNpZm5kZWYgTkVPTkhlbHBlcnNf aAogI2RlZmluZSBORU9OSGVscGVyc19oCiAKLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KLQog I2lmIEVOQUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCiAKICNpbmNs dWRlIDxhcm1fbmVvbi5oPgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZmlsdGVycy9GRUxpZ2h0aW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUxpZ2h0aW5nLmgJKHJldmlzaW9uIDE0MzQyNikKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVMaWdodGluZy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNCw3ICszNCw2IEBACiAjaW5jbHVkZSAiTGlnaHRTb3VyY2UuaCIKICNp bmNsdWRlICJQb2ludExpZ2h0U291cmNlLmgiCiAjaW5jbHVkZSAiU3BvdExpZ2h0U291cmNlLmgi Ci0jaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8d3RmL1VpbnQ4Q2xhbXBlZEFy cmF5Lmg+CiAKIC8vIENvbW1vbiBiYXNlIGNsYXNzIGZvciBGRURpZmZ1c2VMaWdodGluZyBhbmQg RkVTcGVjdWxhckxpZ2h0aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDM0MjcpCisrKyBT b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAor MjAxMy0wMi0xOSAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBpbmNsdWRlcyBmb3IgUGxhdGZvcm0uaCBmcm9tIGhlYWRl cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDMw MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHd0Zi9Q bGF0Zm9ybS5oIG9ubHkgbmVlZCB0byBiZSBpbmNsdWRlZCBpbiBhIGZldyBwbGFjZXMgZGlyZWN0 bHkgICAgCisgICAgICAgIGFzIGl0IGlzIGluY2x1ZGVkIGluIGNvbmZpZy5oLiBSZW1vdmUgdGhl IHVubmVjZXNzYXkgZHVwbGljYXRlIGFzICAgIAorICAgICAgICBpdCBjYW4gYmUgY29uZnVzaW5n LgorCisgICAgICAgICogU2hhcmVkL1ByaW50SW5mby5oOgorCiAyMDEzLTAyLTE5ICBDb25yYWQg U2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgVUkgY2xp ZW50cyB0byBoYW5kbGUgdmVydGljYWwgd2hlZWwgZXZlbnRzLgpJbmRleDogU291cmNlL1dlYktp dDIvU2hhcmVkL1ByaW50SW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9QcmludEluZm8uaAkocmV2aXNpb24gMTQzNDI2KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVk L1ByaW50SW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw4ICsyNiw2IEBACiAjaWZuZGVmIFBy aW50SW5mb19oCiAjZGVmaW5lIFByaW50SW5mb19oCiAKLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0u aD4KLQogI2lmIFBMQVRGT1JNKE1BQykKIE9CSkNfQ0xBU1MgTlNQcmludEluZm87CiAjZWxpZiBQ TEFURk9STShHVEspCg==