110268 2013-02-19 15:08:45 -0800 StorageAreaProxy should know its quota 2013-02-19 15:33:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 836826 0 andersca 2013-02-19 15:08:45 -0800 StorageAreaProxy should know its quota 836835 1 189178 andersca 2013-02-19 15:13:19 -0800 Created attachment 189178 Patch 836837 2 189178 sam 2013-02-19 15:17:07 -0800 Comment on attachment 189178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189178&action=review > Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:97 > + exceptionCode = 0; I think we usually call this ec. > Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h:58 > + unsigned m_quota; What units is this in terms of. Please either add a comment or make the name more descriptive. 836865 3 andersca 2013-02-19 15:33:35 -0800 Committed r143396: <http://trac.webkit.org/changeset/143396> 189178 2013-02-19 15:13:19 -0800 2013-02-19 15:17:07 -0800 Patch bug-110268-20130219150941.patch text/plain 5738 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWEwOTcwNjRlNTYyZjky ZDZhNzgwMzBmMTFlNWYwOTQ2NDJhNGQyMC4uZDJhNGJiY2Q5YWU2Y2M5ZGY4MDYzNzBkYjEyNzg0 OWRkYzhhNjA4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcmFnZUFyZWFQ cm94eSBzaG91bGQga25vdyBpdHMgcXVvdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJlZ2luIHN0dWJiaW5nIG91dCBTdG9yYWdlQXJlYVByb3h5Ojpz ZXRJdGVtIGFuZCBhZGQgc29tZSBxdW90YSBtZW1iZXIgdmFyaWFibGVzLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VBcmVhUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpTdG9yYWdlQXJlYVByb3h5OjpTdG9yYWdlQXJlYVByb3h5KToKKyAgICAgICAgKFdlYktpdDo6 U3RvcmFnZUFyZWFQcm94eTo6c2V0SXRlbSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9TdG9yYWdl L1N0b3JhZ2VBcmVhUHJveHkuaDoKKyAgICAgICAgKFN0b3JhZ2VBcmVhUHJveHkpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpTdG9yYWdlTmFtZXNwYWNlUHJveHk6OmNyZWF0ZVNlc3Npb25TdG9yYWdlTmFt ZXNwYWNlKToKKyAgICAgICAgKFdlYktpdDo6U3RvcmFnZU5hbWVzcGFjZVByb3h5OjpTdG9yYWdl TmFtZXNwYWNlUHJveHkpOgorICAgICAgICAqIFdlYlByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTmFt ZXNwYWNlUHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6U3RvcmFnZU5hbWVzcGFjZVByb3h5Ojpx dW90YSk6CisgICAgICAgIChTdG9yYWdlTmFtZXNwYWNlUHJveHkpOgorCiAyMDEzLTAyLTE4ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIENhbm5v dCBsb2FkIGRvY3VtZW50cyB3aXRoIGJsb2IgdXJscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VBcmVhUHJveHkuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VBcmVhUHJveHkuY3BwCmluZGV4IDU3YTA2Y2Ex ZDRlZGRmYTM3YmQyOWI4YzA0YTVlMGU3ODRhZmYyYWYuLjBhOWMzZTg3Njg4ZmE0NjI1YTliZmEy NjAwZWE0NTM5NjVmMjhkYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv U3RvcmFnZS9TdG9yYWdlQXJlYVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1N0b3JhZ2UvU3RvcmFnZUFyZWFQcm94eS5jcHAKQEAgLTUyLDYgKzUyLDcgQEAgUGFzc1Jl ZlB0cjxTdG9yYWdlQXJlYVByb3h5PiBTdG9yYWdlQXJlYVByb3h5OjpjcmVhdGUoU3RvcmFnZU5h bWVzcGFjZVByb3h5KiBzdG8KIAogU3RvcmFnZUFyZWFQcm94eTo6U3RvcmFnZUFyZWFQcm94eShT dG9yYWdlTmFtZXNwYWNlUHJveHkqIHN0b3JhZ2VOYW1lc3BhY2VQcm94eSwgUGFzc1JlZlB0cjxT ZWN1cml0eU9yaWdpbj4gc2VjdXJpdHlPcmlnaW4pCiAgICAgOiBtX3N0b3JhZ2VUeXBlKHN0b3Jh Z2VOYW1lc3BhY2VQcm94eS0+c3RvcmFnZVR5cGUoKSkKKyAgICAsIG1fcXVvdGEoc3RvcmFnZU5h bWVzcGFjZVByb3h5LT5xdW90YSgpKQogICAgICwgbV9zdG9yYWdlQXJlYUlEKGdlbmVyYXRlU3Rv cmFnZUFyZWFJRCgpKQogewogICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLmNvbm5lY3Rpb24oKS0+ c2VuZChNZXNzYWdlczo6U3RvcmFnZU1hbmFnZXI6OkNyZWF0ZVN0b3JhZ2VBcmVhKG1fc3RvcmFn ZUFyZWFJRCwgc3RvcmFnZU5hbWVzcGFjZVByb3h5LT5zdG9yYWdlTmFtZXNwYWNlSUQoKSwgU2Vj dXJpdHlPcmlnaW5EYXRhOjpmcm9tU2VjdXJpdHlPcmlnaW4oc2VjdXJpdHlPcmlnaW4uZ2V0KCkp KSwgMCk7CkBAIC05MSw5ICs5MiwyNCBAQCBTdHJpbmcgU3RvcmFnZUFyZWFQcm94eTo6Z2V0SXRl bShjb25zdCBTdHJpbmcmIGtleSwgRXhjZXB0aW9uQ29kZSYsIEZyYW1lKiBzb3VyYwogICAgIHJl dHVybiBTdHJpbmcoKTsKIH0KIAotdm9pZCBTdG9yYWdlQXJlYVByb3h5OjpzZXRJdGVtKGNvbnN0 IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlLCBFeGNlcHRpb25Db2RlJiwgRnJhbWUq IHNvdXJjZUZyYW1lKQordm9pZCBTdG9yYWdlQXJlYVByb3h5OjpzZXRJdGVtKGNvbnN0IFN0cmlu ZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlLCBFeGNlcHRpb25Db2RlJiBleGNlcHRpb25Db2Rl LCBGcmFtZSogc291cmNlRnJhbWUpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzLgor ICAgIGV4Y2VwdGlvbkNvZGUgPSAwOworICAgIGlmICghY2FuQWNjZXNzU3RvcmFnZShzb3VyY2VG cmFtZSkpIHsKKyAgICAgICAgZXhjZXB0aW9uQ29kZSA9IFNFQ1VSSVRZX0VSUjsKKyAgICAgICAg cmV0dXJuOworICAgIH0KKworICAgIEFTU0VSVCghdmFsdWUuaXNOdWxsKCkpOworCisgICAgaWYg KGRpc2FibGVkQnlQcml2YXRlQnJvd3NpbmdJbkZyYW1lKHNvdXJjZUZyYW1lKSkgeworICAgICAg ICBleGNlcHRpb25Db2RlID0gUVVPVEFfRVhDRUVERURfRVJSOworICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgbG9hZFZhbHVlc0lmTmVlZGVkKCk7CisKKyAgICAvLyBGSVhNRTogQWN0dWFs bHkgc2V0IHRoZSB2YWx1ZS4KICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VBcmVhUHJveHku aCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlQXJlYVByb3h5LmgK aW5kZXggOTAxYzAzOGMzODhiMjcxZTRjZjE1MmI3MjYxZWY0YmYyYmI4NTAzYy4uMDI1MGEzNTA5 ZWIyMTA5YTJkZThjMjRmMDE3Y2FlNzhmNmE2YzA2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VBcmVhUHJveHkuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZUFyZWFQcm94eS5oCkBAIC02MCw2ICs2MCw3 IEBAIHByaXZhdGU6CiAgICAgdm9pZCBsb2FkVmFsdWVzSWZOZWVkZWQoKTsKIAogICAgIFdlYkNv cmU6OlN0b3JhZ2VUeXBlIG1fc3RvcmFnZVR5cGU7CisgICAgdW5zaWduZWQgbV9xdW90YTsKICAg ICB1aW50NjRfdCBtX3N0b3JhZ2VBcmVhSUQ7CiAgICAgT3duUHRyPEhhc2hNYXA8U3RyaW5nLCBT dHJpbmc+ID4gbV92YWx1ZXM7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9TdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3h5LmNwcAppbmRleCA3OGI1MzBh YWRiMmFmYTFiNzBjYzE4N2MxYWUzYTg5ZjMxZTNiZDI1Li5kOTZiYWYyMWQ0NDgzMjRkNmEzNzBj Y2NiNWE5OGY1OTJiNWUzNjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3h5LmNwcApAQCAtMjksNiArMjks NyBAQAogI2luY2x1ZGUgIlN0b3JhZ2VBcmVhUHJveHkuaCIKICNpbmNsdWRlICJXZWJQYWdlLmgi CiAjaW5jbHVkZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgorI2luY2x1ZGUgPFdlYkNvcmUv U2V0dGluZ3MuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTM2LDExICszNywx MiBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogUGFzc1JlZlB0cjxTdG9yYWdlTmFtZXNwYWNlUHJv eHk+IFN0b3JhZ2VOYW1lc3BhY2VQcm94eTo6Y3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2Uo V2ViUGFnZSogd2ViUGFnZSkKIHsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0b3JhZ2VOYW1l c3BhY2VQcm94eSh3ZWJQYWdlKSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTdG9yYWdlTmFt ZXNwYWNlUHJveHkod2ViUGFnZS0+cGFnZUlEKCksIHdlYlBhZ2UtPmNvcmVQYWdlKCktPnNldHRp bmdzKCktPnNlc3Npb25TdG9yYWdlUXVvdGEoKSkpOwogfQogCi1TdG9yYWdlTmFtZXNwYWNlUHJv eHk6OlN0b3JhZ2VOYW1lc3BhY2VQcm94eShXZWJQYWdlKiB3ZWJQYWdlKQotICAgIDogbV9zdG9y YWdlTmFtZXNwYWNlSUQod2ViUGFnZS0+cGFnZUlEKCkpCitTdG9yYWdlTmFtZXNwYWNlUHJveHk6 OlN0b3JhZ2VOYW1lc3BhY2VQcm94eSh1aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQsIHVuc2ln bmVkIHF1b3RhKQorICAgIDogbV9zdG9yYWdlTmFtZXNwYWNlSUQoc3RvcmFnZU5hbWVzcGFjZUlE KQorICAgICwgbV9xdW90YShxdW90YSkKIHsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VQcm94eS5oIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VQcm94eS5oCmluZGV4IDVm OGU3MTczNjcwMDFkOTc3MmRiYWY0MTk2NjBjYmRmNDc3YmU3Y2IuLmZhZmQ5MDI3MzJlZDg3OTM4 ZDk4NDBhZTQxNDZjZWQyMzJlNjFhMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvU3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3h5LmgKQEAgLTM5LDEwICsz OSwxMiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+U3RvcmFnZU5hbWVzcGFjZVByb3h5KCk7CiAK ICAgICB1aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQoKSBjb25zdCB7IHJldHVybiBtX3N0b3Jh Z2VOYW1lc3BhY2VJRDsgfQorICAgIHVuc2lnbmVkIHF1b3RhKCkgY29uc3QgeyByZXR1cm4gbV9x dW90YTsgfQorCiAgICAgV2ViQ29yZTo6U3RvcmFnZVR5cGUgc3RvcmFnZVR5cGUoKSBjb25zdDsK IAogcHJpdmF0ZToKLSAgICBleHBsaWNpdCBTdG9yYWdlTmFtZXNwYWNlUHJveHkoV2ViUGFnZSop OworICAgIGV4cGxpY2l0IFN0b3JhZ2VOYW1lc3BhY2VQcm94eSh1aW50NjRfdCBzdG9yYWdlTmFt ZXNwYWNlSUQsIHVuc2lnbmVkIHF1b3RhKTsKIAogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxXZWJD b3JlOjpTdG9yYWdlQXJlYT4gc3RvcmFnZUFyZWEoUGFzc1JlZlB0cjxXZWJDb3JlOjpTZWN1cml0 eU9yaWdpbj4pIE9WRVJSSURFOwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxXZWJDb3JlOjpTdG9y YWdlTmFtZXNwYWNlPiBjb3B5KCkgT1ZFUlJJREU7CkBAIC01Myw2ICs1NSw3IEBAIHByaXZhdGU6 CiAgICAgdmlydHVhbCB2b2lkIGNsb3NlSWRsZUxvY2FsU3RvcmFnZURhdGFiYXNlcygpIE9WRVJS SURFOwogCiAgICAgdWludDY0X3QgbV9zdG9yYWdlTmFtZXNwYWNlSUQ7CisgICAgdW5zaWduZWQg bV9xdW90YTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=