110262 2013-02-19 14:20:50 -0800 [Chromium] Move WebKitPlatformSupport declaration to Platform.h 2013-02-20 13:33:02 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106457 82948 1 pilgrim pilgrim abarth dglazkov enne fishd haraken jamesr tkent+wkapi webkit.review.bot oldest_to_newest 836771 0 pilgrim 2013-02-19 14:20:50 -0800 [Chromium] Move WebKitPlatformSupport declaration to Platform.h 836772 1 189160 pilgrim 2013-02-19 14:22:25 -0800 Created attachment 189160 Patch 836776 2 webkit.review.bot 2013-02-19 14:25:55 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 836784 3 189160 dglazkov 2013-02-19 14:28:44 -0800 Comment on attachment 189160 Patch whoa. 836786 4 189160 abarth 2013-02-19 14:30:24 -0800 Comment on attachment 189160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189160&action=review > Source/Platform/chromium/public/Platform.h:491 > +class WebKitPlatformSupport : public Platform { > +protected: > + ~WebKitPlatformSupport() { } > +}; We should change all consumers to use the name WebKit::Platform instead. :) 836792 5 pilgrim 2013-02-19 14:40:16 -0800 (In reply to comment #4) > We should change all consumers to use the name WebKit::Platform instead. :) It's on my list. I want this change first, then update all the #includes downstream ( https://codereview.chromium.org/11824036/ ), then we can remove the entire WK/chromium/public/platform directory. 836927 6 189160 webkit.review.bot 2013-02-19 16:16:07 -0800 Comment on attachment 189160 Patch Clearing flags on attachment: 189160 Committed r143401: <http://trac.webkit.org/changeset/143401> 836928 7 webkit.review.bot 2013-02-19 16:16:11 -0800 All reviewed patches have been landed. Closing bug. 836947 8 enne 2013-02-19 16:24:49 -0800 This was reverted along with r143382 for reason: Breaks Chromium win/mac canary compilation Committed r143403: <http://trac.webkit.org/changeset/143403> 837628 9 pilgrim 2013-02-20 12:00:14 -0800 Build breakage was fixed, rolled DEPS, let's give this another shot. 837702 10 189160 webkit.review.bot 2013-02-20 13:32:58 -0800 Comment on attachment 189160 Patch Clearing flags on attachment: 189160 Committed r143496: <http://trac.webkit.org/changeset/143496> 837703 11 webkit.review.bot 2013-02-20 13:33:02 -0800 All reviewed patches have been landed. Closing bug. 189160 2013-02-19 14:22:25 -0800 2013-02-20 13:32:58 -0800 Patch bug-110262-20130219171826.patch text/plain 2932 pilgrim SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTQzMzgzKQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE5ICBNYXJr IFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1v dmUgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IGRlY2xhcmF0aW9uIHRvIFBsYXRmb3JtLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHByZXBhcmF0aW9u IGZvciByZW1vdmluZyBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCBlbnRpcmVseSAob25jZQorICAg ICAgICBkb3duc3RyZWFtIHJlZmVyZW5jZXMgdG8gdGhhdCBmaWxlIGhhdmUgYmVlbiB1cGRhdGVk KS4gUGFydCBvZiBhCisgICAgICAgIGxhcmdlciByZWZhY3RvcmluZyBzZXJpZXM7IHNlZSB0cmFj a2luZyBidWcgODI5NDguCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaDoK KyAgICAgICAgKFdlYktpdFBsYXRmb3JtU3VwcG9ydCk6CisgICAgICAgIChXZWJLaXQ6OldlYktp dFBsYXRmb3JtU3VwcG9ydDo6fldlYktpdFBsYXRmb3JtU3VwcG9ydCk6CisgICAgICAgIChXZWJL aXQpOgorCiAyMDEzLTAyLTE5ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29t PgogCiAgICAgICAgIFdlYkF1ZGlvIEFQSTogQ2hhbmdlIHRoZSBQbGF0Zm9ybTo6Y3JlYXRlQXVk aW9EZXZpY2UgZnVuY3Rpb24gdG8gdGFrZSBhIERldmljZUlkIHBhcmFtZXRlcgpJbmRleDogU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaAkocmV2aXNpb24gMTQzMzgy KQorKysgU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCSh3b3JraW5n IGNvcHkpCkBAIC00ODUsNiArNDg1LDExIEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5QbGF0 Zm9ybSgpIHsgfQogfTsKIAorY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IDogcHVibGljIFBs YXRmb3JtIHsKK3Byb3RlY3RlZDoKKyAgICB+V2ViS2l0UGxhdGZvcm1TdXBwb3J0KCkgeyB9Cit9 OworCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwkocmV2aXNpb24gMTQzMzgzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMi0xOSAgTWFy ayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBN b3ZlIFdlYktpdFBsYXRmb3JtU3VwcG9ydCBkZWNsYXJhdGlvbiB0byBQbGF0Zm9ybS5oCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAyNjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBwcmVwYXJhdGlv biBmb3IgcmVtb3ZpbmcgV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmggZW50aXJlbHkgKG9uY2UKKyAg ICAgICAgZG93bnN0cmVhbSByZWZlcmVuY2VzIHRvIHRoYXQgZmlsZSBoYXZlIGJlZW4gdXBkYXRl ZCkuIFBhcnQgb2YgYQorICAgICAgICBsYXJnZXIgcmVmYWN0b3Jpbmcgc2VyaWVzOyBzZWUgdHJh Y2tpbmcgYnVnIDgyOTQ4LgorCisgICAgICAgICogcHVibGljL3BsYXRmb3JtL1dlYktpdFBsYXRm b3JtU3VwcG9ydC5oOgorCiAyMDEzLTAyLTE5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSBpZGJGYWN0b3J5IGZyb20gV2Vi S2l0UGxhdGZvcm1TdXBwb3J0CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9w bGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAkocmV2 aXNpb24gMTQzMzgyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0v V2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI4LDE4ICsyOCw0IEBA CiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNpZm5kZWYgV2ViS2l0UGxhdGZvcm1TdXBwb3J0X2gK LSNkZWZpbmUgV2ViS2l0UGxhdGZvcm1TdXBwb3J0X2gKLQogI2luY2x1ZGUgIi4uLy4uLy4uLy4u L1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oIgotCi1uYW1lc3BhY2UgV2ViS2l0 IHsKLQotY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IDogcHVibGljIFBsYXRmb3JtIHsKLXBy b3RlY3RlZDoKLSAgICB+V2ViS2l0UGxhdGZvcm1TdXBwb3J0KCkgeyB9Ci19OwotCi19IC8vIG5h bWVzcGFjZSBXZWJLaXQKLQotI2VuZGlmCg==